HBASE-27222 Purge FutureReturnValueIgnored warnings from error prone by Apache9 · Pull Request #4634 · apache/hbase

Apache9 · 2022-07-19T16:19:23Z

No description provided.

Apache9 · 2022-07-19T16:22:40Z

There are still 4 warnings left. For the two metrics one, I do not find a better way to fix, as the scheduleWithFixedRate will return a ScheduledFuture, seems the way is to store it somewhere and cancel it when stop?

And in AssignmentManager, the problem is moveAsync just returns a Future, not a CompletableFuture, so there is no way to register a listener to log the errors if any. We can fix this in the future to let it returns a CompletableFuture, but better in another issue.

Apache-HBase · 2022-07-19T17:11:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 25s	master passed
+1 💚	compile	5m 12s	master passed
+1 💚	checkstyle	1m 46s	master passed
+1 💚	spotless	0m 46s	branch has no errors when running spotless:check.
+1 💚	spotbugs	4m 16s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	5m 7s	the patch passed
+1 💚	javac	0m 32s	hbase-common in the patch passed.
-0 ⚠️	javac	0m 38s	hbase-client generated 3 new + 119 unchanged - 4 fixed = 122 total (was 123)
+1 💚	javac	0m 20s	hbase-zookeeper generated 0 new + 47 unchanged - 1 fixed = 47 total (was 48)
+1 💚	javac	0m 20s	hbase-asyncfs generated 0 new + 4 unchanged - 20 fixed = 4 total (was 24)
+1 💚	javac	2m 12s	hbase-server in the patch passed.
-0 ⚠️	javac	0m 27s	hbase-it generated 2 new + 101 unchanged - 2 fixed = 103 total (was 103)
+1 💚	javac	0m 24s	hbase-examples generated 0 new + 33 unchanged - 4 fixed = 33 total (was 37)
+1 💚	javac	0m 14s	hbase-external-blockcache generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2)
-0 ⚠️	checkstyle	0m 15s	hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	checkstyle	0m 15s	The patch passed checkstyle in hbase-client
+1 💚	checkstyle	0m 8s	The patch passed checkstyle in hbase-zookeeper
+1 💚	checkstyle	0m 9s	The patch passed checkstyle in hbase-asyncfs
+1 💚	checkstyle	0m 31s	The patch passed checkstyle in hbase-server
+1 💚	checkstyle	0m 10s	The patch passed checkstyle in hbase-it
-0 ⚠️	checkstyle	0m 10s	hbase-examples: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	checkstyle	0m 7s	hbase-external-blockcache: The patch generated 0 new + 0 unchanged - 14 fixed = 0 total (was 14)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 41s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 43s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 8s	the patch passed
		_ Other Tests _
+1 💚	asflicense	1m 14s	The patch does not generate ASF License warnings.
		50m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4634
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 4e9d756b359c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `075b305`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-it.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-examples.txt
Max. process+thread count	69 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-it hbase-examples hbase-external-blockcache U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-19T20:19:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 21s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 46s	master passed
+1 💚	compile	2m 46s	master passed
+1 💚	shadedjars	3m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 6s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 38s	the patch passed
+1 💚	compile	2m 47s	the patch passed
+1 💚	javac	2m 47s	the patch passed
+1 💚	shadedjars	3m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 4s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 45s	hbase-common in the patch passed.
+1 💚	unit	1m 21s	hbase-client in the patch passed.
+1 💚	unit	0m 39s	hbase-zookeeper in the patch passed.
+1 💚	unit	1m 2s	hbase-asyncfs in the patch passed.
+1 💚	unit	203m 19s	hbase-server in the patch passed.
+1 💚	unit	0m 51s	hbase-it in the patch passed.
+1 💚	unit	2m 15s	hbase-examples in the patch passed.
+1 💚	unit	0m 25s	hbase-external-blockcache in the patch passed.
		237m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4634
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 202e7dc77e2b 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `075b305`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/1/testReport/
Max. process+thread count	2590 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-it hbase-examples hbase-external-blockcache U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-19T20:32:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 34s	master passed
+1 💚	compile	2m 21s	master passed
+1 💚	shadedjars	3m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 41s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 25s	the patch passed
+1 💚	compile	2m 23s	the patch passed
+1 💚	javac	2m 23s	the patch passed
+1 💚	shadedjars	3m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 34s	hbase-common in the patch passed.
+1 💚	unit	1m 2s	hbase-client in the patch passed.
+1 💚	unit	0m 36s	hbase-zookeeper in the patch passed.
+1 💚	unit	1m 21s	hbase-asyncfs in the patch passed.
+1 💚	unit	219m 27s	hbase-server in the patch passed.
+1 💚	unit	0m 46s	hbase-it in the patch passed.
+1 💚	unit	1m 55s	hbase-examples in the patch passed.
+1 💚	unit	0m 16s	hbase-external-blockcache in the patch passed.
		251m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4634
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 70504eaab9db 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `075b305`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/1/testReport/
Max. process+thread count	2569 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-it hbase-examples hbase-external-blockcache U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-20T02:16:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 52s	master passed
+1 💚	compile	9m 5s	master passed
+1 💚	checkstyle	3m 32s	master passed
+1 💚	spotless	1m 15s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 36s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 35s	the patch passed
+1 💚	compile	9m 8s	the patch passed
+1 💚	javac	1m 0s	hbase-common in the patch passed.
-0 ⚠️	javac	1m 8s	hbase-client generated 3 new + 119 unchanged - 4 fixed = 122 total (was 123)
+1 💚	javac	0m 37s	hbase-zookeeper generated 0 new + 47 unchanged - 1 fixed = 47 total (was 48)
+1 💚	javac	0m 42s	hbase-asyncfs generated 0 new + 4 unchanged - 20 fixed = 4 total (was 24)
+1 💚	javac	3m 35s	hbase-server in the patch passed.
-0 ⚠️	javac	0m 51s	hbase-it generated 2 new + 101 unchanged - 2 fixed = 103 total (was 103)
+1 💚	javac	0m 47s	hbase-examples generated 0 new + 33 unchanged - 4 fixed = 33 total (was 37)
+1 💚	javac	0m 28s	hbase-external-blockcache generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2)
-0 ⚠️	checkstyle	0m 26s	hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	checkstyle	0m 30s	The patch passed checkstyle in hbase-client
+1 💚	checkstyle	0m 18s	The patch passed checkstyle in hbase-zookeeper
+1 💚	checkstyle	0m 19s	The patch passed checkstyle in hbase-asyncfs
+1 💚	checkstyle	0m 53s	The patch passed checkstyle in hbase-server
+1 💚	checkstyle	0m 21s	The patch passed checkstyle in hbase-it
+1 💚	checkstyle	0m 20s	The patch passed checkstyle in hbase-examples
+1 💚	checkstyle	0m 17s	hbase-external-blockcache: The patch generated 0 new + 0 unchanged - 14 fixed = 0 total (was 14)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 59s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	1m 16s	patch has no errors when running spotless:check.
+1 💚	spotbugs	9m 6s	the patch passed
		_ Other Tests _
+1 💚	asflicense	2m 33s	The patch does not generate ASF License warnings.
		85m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4634
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 09640feba55a 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `da27a67`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-it.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-it hbase-examples hbase-external-blockcache U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-20T11:40:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 26s	master passed
+1 💚	compile	5m 10s	master passed
+1 💚	checkstyle	1m 44s	master passed
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
+1 💚	spotbugs	4m 11s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 16s	the patch passed
+1 💚	compile	5m 5s	the patch passed
+1 💚	javac	0m 32s	hbase-common in the patch passed.
-0 ⚠️	javac	0m 38s	hbase-client generated 3 new + 119 unchanged - 4 fixed = 122 total (was 123)
+1 💚	javac	0m 19s	hbase-zookeeper generated 0 new + 47 unchanged - 1 fixed = 47 total (was 48)
+1 💚	javac	0m 20s	hbase-asyncfs generated 0 new + 4 unchanged - 20 fixed = 4 total (was 24)
+1 💚	javac	2m 11s	hbase-server in the patch passed.
-0 ⚠️	javac	0m 27s	hbase-it generated 2 new + 101 unchanged - 2 fixed = 103 total (was 103)
+1 💚	javac	0m 24s	hbase-examples generated 0 new + 33 unchanged - 4 fixed = 33 total (was 37)
+1 💚	javac	0m 14s	hbase-external-blockcache generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2)
+1 💚	checkstyle	0m 13s	The patch passed checkstyle in hbase-common
+1 💚	checkstyle	0m 16s	The patch passed checkstyle in hbase-client
+1 💚	checkstyle	0m 9s	The patch passed checkstyle in hbase-zookeeper
+1 💚	checkstyle	0m 8s	The patch passed checkstyle in hbase-asyncfs
+1 💚	checkstyle	0m 31s	The patch passed checkstyle in hbase-server
+1 💚	checkstyle	0m 10s	The patch passed checkstyle in hbase-it
+1 💚	checkstyle	0m 9s	The patch passed checkstyle in hbase-examples
+1 💚	checkstyle	0m 8s	hbase-external-blockcache: The patch generated 0 new + 0 unchanged - 14 fixed = 0 total (was 14)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 26s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 5s	the patch passed
		_ Other Tests _
+1 💚	asflicense	1m 12s	The patch does not generate ASF License warnings.
		49m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4634
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 3ad619b14df8 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `da27a67`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-it.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-it hbase-examples hbase-external-blockcache U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-21T01:52:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 24s	master passed
+1 💚	compile	4m 42s	master passed
+1 💚	checkstyle	1m 23s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	3m 44s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 9s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 11s	the patch passed
+1 💚	compile	4m 43s	the patch passed
+1 💚	javac	0m 28s	hbase-common in the patch passed.
-0 ⚠️	javac	0m 35s	hbase-client generated 3 new + 119 unchanged - 4 fixed = 122 total (was 123)
+1 💚	javac	0m 17s	hbase-zookeeper generated 0 new + 47 unchanged - 1 fixed = 47 total (was 48)
+1 💚	javac	0m 16s	hbase-asyncfs generated 0 new + 4 unchanged - 20 fixed = 4 total (was 24)
+1 💚	javac	2m 10s	hbase-server in the patch passed.
-0 ⚠️	javac	0m 25s	hbase-it generated 2 new + 101 unchanged - 2 fixed = 103 total (was 103)
+1 💚	javac	0m 20s	hbase-examples generated 0 new + 33 unchanged - 4 fixed = 33 total (was 37)
+1 💚	javac	0m 12s	hbase-external-blockcache generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2)
+1 💚	checkstyle	0m 10s	The patch passed checkstyle in hbase-common
+1 💚	checkstyle	0m 13s	The patch passed checkstyle in hbase-client
+1 💚	checkstyle	0m 6s	The patch passed checkstyle in hbase-zookeeper
+1 💚	checkstyle	0m 6s	The patch passed checkstyle in hbase-asyncfs
+1 💚	checkstyle	0m 27s	The patch passed checkstyle in hbase-server
+1 💚	checkstyle	0m 7s	The patch passed checkstyle in hbase-it
+1 💚	checkstyle	0m 7s	The patch passed checkstyle in hbase-examples
+1 💚	checkstyle	0m 6s	hbase-external-blockcache: The patch generated 0 new + 0 unchanged - 14 fixed = 0 total (was 14)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 44s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	4m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 54s	The patch does not generate ASF License warnings.
		46m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4634
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 1557903f629e 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `75a05b5`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-it.txt
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-it hbase-examples hbase-external-blockcache U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-21T05:29:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 38s	master passed
+1 💚	compile	3m 26s	master passed
+1 💚	shadedjars	5m 11s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 11s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 31s	the patch passed
+1 💚	compile	2m 48s	the patch passed
+1 💚	javac	2m 48s	the patch passed
+1 💚	shadedjars	4m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 58s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 2s	hbase-common in the patch passed.
+1 💚	unit	1m 44s	hbase-client in the patch passed.
+1 💚	unit	0m 43s	hbase-zookeeper in the patch passed.
+1 💚	unit	1m 15s	hbase-asyncfs in the patch passed.
+1 💚	unit	222m 5s	hbase-server in the patch passed.
+1 💚	unit	1m 26s	hbase-it in the patch passed.
+1 💚	unit	1m 46s	hbase-examples in the patch passed.
+1 💚	unit	0m 19s	hbase-external-blockcache in the patch passed.
		263m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4634
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6b00c1fc4d8a 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `75a05b5`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/4/testReport/
Max. process+thread count	2696 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-it hbase-examples hbase-external-blockcache U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-21T06:09:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 35s	master passed
+1 💚	compile	3m 27s	master passed
+1 💚	shadedjars	5m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 23s	the patch passed
+1 💚	compile	4m 6s	the patch passed
+1 💚	javac	4m 6s	the patch passed
+1 💚	shadedjars	4m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 1s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 50s	hbase-common in the patch passed.
+1 💚	unit	1m 21s	hbase-client in the patch passed.
+1 💚	unit	0m 44s	hbase-zookeeper in the patch passed.
+1 💚	unit	1m 42s	hbase-asyncfs in the patch passed.
-1 ❌	unit	260m 6s	hbase-server in the patch failed.
+1 💚	unit	0m 54s	hbase-it in the patch passed.
+1 💚	unit	2m 15s	hbase-examples in the patch passed.
+1 💚	unit	0m 21s	hbase-external-blockcache in the patch passed.
		303m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4634
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 769eb687eefd 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `75a05b5`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/4/testReport/
Max. process+thread count	2470 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-it hbase-examples hbase-external-blockcache U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-07-23T11:47:12Z

Ping @apurtell .

PTAL at this one?

Thanks.

apurtell · 2022-07-25T22:37:47Z

 Promise<Void> saslPromise = channel.eventLoop().newPromise();
 trySaslNegotiate(conf, channel, dnInfo, timeoutMs, client, accessToken, saslPromise);
-saslPromise.addListener(new FutureListener<Void>() {
+ addListener(saslPromise, new FutureListener<Void>() {


"Promoting" the listener makes sense.

apurtell · 2022-07-25T22:39:23Z

 state = State.BROKEN;
 failWaitingAckQueue(channel, errorSupplier);
- datanodeInfoMap.keySet().forEach(ChannelOutboundInvoker::close);
+ datanodeInfoMap.keySet().forEach(NettyFutureUtils::safeClose);


I like the approach here where new NettyFutureUtils encapsulates the await/cleanup details, (edit: and suppresses warnings in one place, mostly.)

apurtell · 2022-07-25T22:42:14Z

+ * thrown from the code that completes the future, and this method will catch all the exception
+ * thrown from the {@code listener} to catch possible code bugs.
+ * <p/>
+ * And the error phone check will always report FutureReturnValueIgnored because every method in


Sounds good.

apurtell · 2022-07-25T22:47:47Z

@Apache9 Apologies for the delay, lgtm with minor comments

Apache-HBase · 2022-07-26T03:57:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 12s	master passed
+1 💚	compile	4m 49s	master passed
+1 💚	checkstyle	1m 22s	master passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	3m 46s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 9s	the patch passed
+1 💚	compile	4m 49s	the patch passed
+1 💚	javac	0m 28s	hbase-common in the patch passed.
-0 ⚠️	javac	0m 35s	hbase-client generated 3 new + 119 unchanged - 4 fixed = 122 total (was 123)
+1 💚	javac	0m 16s	hbase-zookeeper generated 0 new + 47 unchanged - 1 fixed = 47 total (was 48)
+1 💚	javac	0m 17s	hbase-asyncfs generated 0 new + 4 unchanged - 20 fixed = 4 total (was 24)
+1 💚	javac	2m 15s	hbase-server in the patch passed.
-0 ⚠️	javac	0m 25s	hbase-it generated 2 new + 101 unchanged - 2 fixed = 103 total (was 103)
+1 💚	javac	0m 21s	hbase-examples generated 0 new + 33 unchanged - 4 fixed = 33 total (was 37)
+1 💚	javac	0m 12s	hbase-external-blockcache generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2)
+1 💚	checkstyle	0m 11s	The patch passed checkstyle in hbase-common
+1 💚	checkstyle	0m 12s	The patch passed checkstyle in hbase-client
+1 💚	checkstyle	0m 6s	The patch passed checkstyle in hbase-zookeeper
+1 💚	checkstyle	0m 6s	The patch passed checkstyle in hbase-asyncfs
+1 💚	checkstyle	0m 28s	The patch passed checkstyle in hbase-server
+1 💚	checkstyle	0m 7s	The patch passed checkstyle in hbase-it
+1 💚	checkstyle	0m 7s	The patch passed checkstyle in hbase-examples
+1 💚	checkstyle	0m 5s	hbase-external-blockcache: The patch generated 0 new + 0 unchanged - 14 fixed = 0 total (was 14)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 50s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	4m 37s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 53s	The patch does not generate ASF License warnings.
		47m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4634
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 480fdea410b0 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ebd1891`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-it.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-it hbase-examples hbase-external-blockcache U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-26T07:13:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 14s	master passed
+1 💚	compile	2m 30s	master passed
+1 💚	shadedjars	3m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 54s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 17s	the patch passed
+1 💚	compile	2m 29s	the patch passed
+1 💚	javac	2m 29s	the patch passed
+1 💚	shadedjars	3m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 31s	hbase-common in the patch passed.
+1 💚	unit	1m 1s	hbase-client in the patch passed.
+1 💚	unit	0m 38s	hbase-zookeeper in the patch passed.
+1 💚	unit	1m 20s	hbase-asyncfs in the patch passed.
+1 💚	unit	210m 16s	hbase-server in the patch passed.
+1 💚	unit	0m 53s	hbase-it in the patch passed.
+1 💚	unit	1m 55s	hbase-examples in the patch passed.
+1 💚	unit	0m 25s	hbase-external-blockcache in the patch passed.
		243m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4634
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d3ce882e78a2 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ebd1891`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/5/testReport/
Max. process+thread count	2601 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-it hbase-examples hbase-external-blockcache U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-26T07:23:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 8s	master passed
+1 💚	compile	3m 44s	master passed
+1 💚	shadedjars	5m 57s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 19s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 51s	the patch passed
+1 💚	compile	3m 38s	the patch passed
+1 💚	javac	3m 38s	the patch passed
+1 💚	shadedjars	5m 14s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 44s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 22s	hbase-common in the patch passed.
+1 💚	unit	2m 8s	hbase-client in the patch passed.
+1 💚	unit	0m 51s	hbase-zookeeper in the patch passed.
+1 💚	unit	1m 20s	hbase-asyncfs in the patch passed.
-1 ❌	unit	206m 10s	hbase-server in the patch failed.
+1 💚	unit	0m 50s	hbase-it in the patch passed.
+1 💚	unit	1m 39s	hbase-examples in the patch passed.
+1 💚	unit	0m 18s	hbase-external-blockcache in the patch passed.
		253m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4634
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b34808d895f9 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ebd1891`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/5/testReport/
Max. process+thread count	2631 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-it hbase-examples hbase-external-blockcache U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4634/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-07-26T15:42:28Z

The failed UT seems not related. Let me merge.

…4634) Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit 8b091c4)

…pache#4634) This change backports the changes from Jira: HBASE-27222. Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit 8b091c4) (cherry picked from commit 84e7cdb) Change-Id: Ibd7bbaab22dcec49a25ad61ec43c7eac3365e902

Apache9 requested a review from apurtell July 19, 2022 16:19

Apache9 self-assigned this Jul 19, 2022

Apache9 force-pushed the HBASE-27222 branch from 233037f to a348ce1Compare July 20, 2022 00:44

Apache9 force-pushed the HBASE-27222 branch from a348ce1 to 42f2e9bCompare July 20, 2022 02:33

apurtell approved these changes Jul 25, 2022
View reviewed changes

HBASE-27222 Purge FutureReturnValueIgnored warnings from error prone
a5fc7b0

Apache9 force-pushed the HBASE-27222 branch from 42f2e9b to a5fc7b0Compare July 26, 2022 03:06

Apache9 merged commit 8b091c4 into apache:masterJul 26, 2022

Apache9 added a commit that referenced this pull request Jul 26, 2022
HBASE-27222Purge FutureReturnValueIgnored warnings from error prone (#…
88f957b
…4634) Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit 8b091c4)

Apache9 added a commit that referenced this pull request Jul 26, 2022
HBASE-27222Purge FutureReturnValueIgnored warnings from error prone (#…
84e7cdb
…4634) Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit 8b091c4)

Uh oh!

Conversation

Apache9 commented Jul 19, 2022

Uh oh!

Apache9 commented Jul 19, 2022

Uh oh!

Apache-HBase commented Jul 19, 2022

Uh oh!

Apache-HBase commented Jul 19, 2022

Uh oh!

Apache-HBase commented Jul 19, 2022

Uh oh!

Apache-HBase commented Jul 20, 2022

Uh oh!

Apache-HBase commented Jul 20, 2022

Uh oh!

Apache-HBase commented Jul 21, 2022

Uh oh!

Apache-HBase commented Jul 21, 2022

Uh oh!

Apache-HBase commented Jul 21, 2022

Uh oh!

Apache9 commented Jul 23, 2022

Uh oh!

apurtellJul 25, 2022

Choose a reason for hiding this comment

Uh oh!

apurtellJul 25, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

apurtellJul 25, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

apurtell commented Jul 25, 2022

Uh oh!

Apache-HBase commented Jul 26, 2022

Uh oh!

Apache-HBase commented Jul 26, 2022

Uh oh!

Apache-HBase commented Jul 26, 2022

Uh oh!

Apache9 commented Jul 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

apurtellJul 25, 2022•
edited
Loading