Skip to content

HBASE-22808 HBCK Report showed the offline regions which belong to di… - #465

Merged
infraio merged 1 commit into
apache:masterfrom
infraio:HBASE-22808
Aug 8, 2019
Merged

HBASE-22808 HBCK Report showed the offline regions which belong to di…#465
infraio merged 1 commit into
apache:masterfrom
infraio:HBASE-22808

Conversation

@infraio

Copy link
Copy Markdown
Contributor

…sabled table

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit to fix on commit?

}
// skip the offline regions which belong to disabled table.
if (services.getTableStateManager()
.isTableState(location.getRegion().getTable(), TableState.State.DISABLED)) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. I see. I didn't see it in my reproduction of the issue.

Could be DISABLED or DISABLING. Thats what we check in other places IIRC.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There already a method which call isTableDisabled. Let me change to use that one.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec140Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1mvninstall487master passed
+1compile75master passed
+1checkstyle103master passed
+1shadedjars370branch has no errors when building our shaded downstream artifacts.
+1javadoc52master passed
0spotbugs301Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs298master passed
_ Patch Compile Tests _
+1mvninstall418the patch passed
+1compile82the patch passed
+1javac82the patch passed
+1checkstyle103the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars367patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1386Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc45the patch passed
+1findbugs342the patch passed
_ Other Tests _
-1unit14351hbase-server in the patch failed.
+1asflicense32The patch does not generate ASF License warnings.
19168
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/1/artifact/out/Dockerfile
GITHUB PR#465
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux f597cb0e13d3 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-465/out/precommit/personality/provided.sh
git revisionmaster / 547cec4
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/1/testReport/
Max. process+thread count4714 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@infraio
infraio merged commit 9250977 into apache:masterAug 8, 2019
@infraio
infraio deleted the HBASE-22808 branch August 8, 2019 08:57
asfgit pushed a commit that referenced this pull request Aug 8, 2019
…sabled table (#465)
Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Aug 8, 2019
…sabled table (#465)
Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Aug 8, 2019
…sabled table (#465)
Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Aug 8, 2019
…sabled table (#465)
Signed-off-by: Stack <stack@apache.org>
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec120Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1mvninstall379master passed
+1compile55master passed
+1checkstyle75master passed
+1shadedjars271branch has no errors when building our shaded downstream artifacts.
+1javadoc39master passed
0spotbugs258Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs250master passed
_ Patch Compile Tests _
+1mvninstall307the patch passed
+1compile57the patch passed
+1javac57the patch passed
+1checkstyle74the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars272patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck964Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc34the patch passed
+1findbugs267the patch passed
_ Other Tests _
-1unit17883hbase-server in the patch failed.
+1asflicense131The patch does not generate ASF License warnings.
21602
ReasonTests
Failed junit testshadoop.hbase.client.TestFromClientSide
hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.namespace.TestNamespaceAuditor
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/2/artifact/out/Dockerfile
GITHUB PR#465
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux b016921e2d3f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-465/out/precommit/personality/provided.sh
git revisionmaster / 547cec4
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/2/testReport/
Max. process+thread count4972 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

infraio added a commit to infraio/hbase that referenced this pull request Aug 17, 2020
…sabled table (apache#465)
Signed-off-by: Stack <stack@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
…sabled table (apache#465)
Signed-off-by: Stack <stack@apache.org>
(cherry picked from commit 1a59987)
Change-Id: I3ebdfc5d8ea5075d09a2cb462800b16341ff70b4
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@infraio@Apache-HBase@saintstack