Skip to content

HBASE-22822 : Un/Re-schedule balancer chore with balance_switch - #468

Closed
virajjasani wants to merge 4 commits into
apache:masterfrom
virajjasani:HBASE-22822-master
Closed

HBASE-22822 : Un/Re-schedule balancer chore with balance_switch#468
virajjasani wants to merge 4 commits into
apache:masterfrom
virajjasani:HBASE-22822-master

Conversation

@virajjasani

@virajjasanivirajjasani commented Aug 8, 2019

Copy link
Copy Markdown
Contributor

balance_switch turns on/off balancer. When it is turned off, we don't remove balancer chore from scheduled chores hence it keeps running only to eventually find out that it is not supposed to perform any action(if balancer was turned off). We can unschedule the chore to prevent the chore() execution and reschedule it when it is turned on by balance_switch.

This should also facilitate running balancer immediately after triggering balance_switch true(due to default initial delay: 0), and then chore would continue running as per duration provided in hbase.balancer.period.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author1The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall334master passed
+1compile53master passed
+1checkstyle77master passed
+1shadedjars271branch has no errors when building our shaded downstream artifacts.
+1javadoc36master passed
0spotbugs242Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs240master passed
_ Patch Compile Tests _
+1mvninstall297the patch passed
+1compile51the patch passed
+1javac51the patch passed
+1checkstyle72the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars260patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck911Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc32the patch passed
+1findbugs241the patch passed
_ Other Tests _
-1unit8605hbase-server in the patch failed.
+1asflicense31The patch does not generate ASF License warnings.
11931
ReasonTests
Failed junit testshadoop.hbase.client.TestAsyncRegionAdminApi
hadoop.hbase.regionserver.TestSplitTransactionOnCluster
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/1/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 2458f12033d8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 9250977
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/1/testReport/
Max. process+thread count4578 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec40Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall312master passed
+1compile51master passed
+1checkstyle73master passed
+1shadedjars260branch has no errors when building our shaded downstream artifacts.
+1javadoc37master passed
0spotbugs235Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs234master passed
_ Patch Compile Tests _
+1mvninstall281the patch passed
+1compile52the patch passed
+1javac52the patch passed
+1checkstyle71the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars255patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck894Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc33the patch passed
+1findbugs250the patch passed
_ Other Tests _
-1unit8435hbase-server in the patch failed.
+1asflicense32The patch does not generate ASF License warnings.
11663
ReasonTests
Failed junit testshadoop.hbase.client.TestAsyncRegionAdminApi
hadoop.hbase.regionserver.TestSplitTransactionOnCluster
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/2/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 04ddbc6ee3dc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / eb92b25
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/2/testReport/
Max. process+thread count4793 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec86Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall377master passed
+1compile53master passed
+1checkstyle76master passed
+1shadedjars293branch has no errors when building our shaded downstream artifacts.
+1javadoc35master passed
0spotbugs252Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs249master passed
_ Patch Compile Tests _
+1mvninstall333the patch passed
+1compile55the patch passed
+1javac55the patch passed
+1checkstyle75the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars261patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck949Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc30the patch passed
+1findbugs254the patch passed
_ Other Tests _
-1unit19085hbase-server in the patch failed.
+1asflicense47The patch does not generate ASF License warnings.
22619
ReasonTests
Failed junit testshadoop.hbase.client.TestFromClientSide
hadoop.hbase.client.TestCloneSnapshotFromClientNormal
hadoop.hbase.client.TestAsyncTableAdminApi
hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.client.TestAsyncRegionAdminApi
hadoop.hbase.regionserver.TestSplitTransactionOnCluster
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/3/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 029f356db98b 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / c05ee7c
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/3/testReport/
Max. process+thread count4946 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec48Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1mvninstall458master passed
+1compile75master passed
+1checkstyle113master passed
+1shadedjars359branch has no errors when building our shaded downstream artifacts.
+1javadoc55master passed
0spotbugs338Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs335master passed
_ Patch Compile Tests _
+1mvninstall393the patch passed
+1compile68the patch passed
+1javac68the patch passed
+1checkstyle107the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars355patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1194Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc46the patch passed
+1findbugs312the patch passed
_ Other Tests _
-1unit9513hbase-server in the patch failed.
+1asflicense25The patch does not generate ASF License warnings.
13945
ReasonTests
Failed junit testshadoop.hbase.client.TestAsyncRegionAdminApi
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/5/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 36502798b251 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 989e09a
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/5/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/5/testReport/
Max. process+thread count4869 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/5/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec146Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall499master passed
+1compile73master passed
+1checkstyle100master passed
+1shadedjars383branch has no errors when building our shaded downstream artifacts.
+1javadoc45master passed
0spotbugs319Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs317master passed
_ Patch Compile Tests _
+1mvninstall414the patch passed
+1compile99the patch passed
+1javac99the patch passed
+1checkstyle100the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars350patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1286Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc41the patch passed
+1findbugs316the patch passed
_ Other Tests _
-1unit18963hbase-server in the patch failed.
+1asflicense50The patch does not generate ASF License warnings.
23681
ReasonTests
Failed junit testshadoop.hbase.tool.TestSecureBulkLoadHFiles
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
hadoop.hbase.tool.TestBulkLoadHFiles
hadoop.hbase.replication.TestReplicationDisableInactivePeer
hadoop.hbase.regionserver.TestSplitTransactionOnCluster
hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.client.TestCloneSnapshotFromClientNormal
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/6/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 4361ab7bddcf 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 989e09a
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/6/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/6/testReport/
Max. process+thread count4895 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/6/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec37Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall370master passed
+1compile63master passed
+1checkstyle88master passed
+1shadedjars293branch has no errors when building our shaded downstream artifacts.
+1javadoc38master passed
0spotbugs278Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs276master passed
_ Patch Compile Tests _
+1mvninstall309the patch passed
+1compile58the patch passed
+1javac58the patch passed
+1checkstyle75the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars275patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck943Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc34the patch passed
+1findbugs253the patch passed
_ Other Tests _
-1unit8446hbase-server in the patch failed.
+1asflicense27The patch does not generate ASF License warnings.
11947
ReasonTests
Failed junit testshadoop.hbase.master.replication.TestRegisterPeerWorkerWhenRestarting
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/8/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 27ea32ed267c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / c8f57bf
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/8/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/8/testReport/
Max. process+thread count4832 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/8/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@virajjasani

Copy link
Copy Markdown
ContributorAuthor

Please review @apurtell@Reidddddd@anoopsjohn

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit in the below. Not important. LGTM.

*
* @param on boolean value indicates whether to turn the balancer on
*/
void turnBalancer(boolean on) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/turnBalancer/switchBalancer/ ?

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec210Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall337master passed
+1compile52master passed
+1checkstyle76master passed
+1shadedjars306branch has no errors when building our shaded downstream artifacts.
+1javadoc39master passed
0spotbugs247Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs244master passed
_ Patch Compile Tests _
+1mvninstall346the patch passed
+1compile60the patch passed
+1javac60the patch passed
+1checkstyle76the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars272patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck942Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc37the patch passed
+1findbugs252the patch passed
_ Other Tests _
-1unit16227hbase-server in the patch failed.
+1asflicense40The patch does not generate ASF License warnings.
19943
ReasonTests
Failed junit testshadoop.hbase.client.TestFromClientSide
hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.client.TestAdmin1
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/9/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 252369174a0e 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / c8f57bf
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/9/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/9/testReport/
Max. process+thread count5064 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/9/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec64Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall431master passed
+1compile70master passed
+1checkstyle98master passed
+1shadedjars373branch has no errors when building our shaded downstream artifacts.
+1javadoc47master passed
0spotbugs329Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs325master passed
_ Patch Compile Tests _
+1mvninstall397the patch passed
+1compile70the patch passed
+1javac70the patch passed
+1checkstyle89the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars343patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1229Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc43the patch passed
+1findbugs343the patch passed
_ Other Tests _
-1unit17703hbase-server in the patch failed.
+1asflicense33The patch does not generate ASF License warnings.
22161
ReasonTests
Failed junit testshadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
hadoop.hbase.replication.TestReplicationKillSlaveRS
hadoop.hbase.client.TestAdmin1
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/10/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux f93d590517b9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 15c903b
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/10/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/10/testReport/
Max. process+thread count4853 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/10/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec90Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall340master passed
+1compile55master passed
+1checkstyle78master passed
+1shadedjars274branch has no errors when building our shaded downstream artifacts.
+1javadoc37master passed
0spotbugs267Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs265master passed
_ Patch Compile Tests _
+1mvninstall296the patch passed
+1compile55the patch passed
+1javac55the patch passed
+1checkstyle75the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars271patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck931Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc39the patch passed
+1findbugs259the patch passed
_ Other Tests _
+1unit8990hbase-server in the patch passed.
+1asflicense23The patch does not generate ASF License warnings.
12452
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/11/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 72d2c3357bee 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / e938215
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/11/testReport/
Max. process+thread count4731 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/11/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Reidddddd

Reidddddd commented Aug 12, 2019

Copy link
Copy Markdown
Contributor

IIRC, gracefully_stop.sh will turn balancer off, move regions, stop/restart RS, then turn balancer on.

And there's one script rolling_restart.sh relying on gracefully_stop.sh, will repeat the mentioned process. If the RS number in rolling restart is large which is often the case in production env---hundreds at least, the master inside will cancel and remove task then construct a new task back and forth, at JVM level.

One step back, current impl brings no harm to master nor good, but the new impl looks like may bring a new uncertainty.

I incline to keep it still, and so, leave my -0.

@virajjasani

Copy link
Copy Markdown
ContributorAuthor

IIRC, gracefully_stop.sh will turn balancer off, move regions, stop/restart RS, then turn balancer on.

And there's one script rolling_restart.sh relying on gracefully_stop.sh, will repeat the mentioned process. If the RS number in rolling restart is large which is often the case in production env---hundreds at least, the master inside will cancel and remove task then construct a new task back and forth, at JVM level.

One step back, current impl brings no harm to master nor good, but the new impl looks like may bring a new uncertainty.

I incline to keep it still, and so, leave my -0.

graceful_stop.sh turns on balancer at the end conditionally. If -nob arg is provided, it won't: here
rolling_restart.sh provides that arg here
rolling_restart itself taking care of turning the balancer on/off makes sense rather than gracefu_stop taking care of it for rolling_restart. Even if it didn't, it could still run into the possibility of running balancer in between rolling restart of RegionServers, which should not happen provided we move regions back and forth anyways here.

@virajjasani

virajjasani commented Aug 12, 2019

Copy link
Copy Markdown
ContributorAuthor

@Reidddddd
Hence, balancer will be turned off before starting with rolling restart and turned on after all n servers are restarted (not in-between restarts of individual servers).
However, I am just wondering if there are any other such scenarios where we keep turning on/off balancer quite frequently as part of some workflow?

@Reidddddd

Copy link
Copy Markdown
Contributor

Hence, balancer will be turned off before starting with rolling restart and turned on after all n servers are restarted (not in-between restarts of individual servers).

Hmm, right. But it only works for master and branch-2.
But even it only targets to a single RS where balance off is only a temporary move, do you really think it is a good practice or worthy of destructing then constructing a task, just within few minutes?

However, I am just wondering if there are any other such scenarios where we keep turning on/off balancer quite frequently as part of some workflow?

Just rolling restart, maybe. One place I'm not sure is RSGroup's move_regions op.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec167Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall364master passed
+1compile58master passed
+1checkstyle79master passed
+1shadedjars264branch has no errors when building our shaded downstream artifacts.
+1javadoc37master passed
0spotbugs250Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs248master passed
_ Patch Compile Tests _
+1mvninstall334the patch passed
+1compile57the patch passed
+1javac57the patch passed
+1checkstyle76the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars298patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1018Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc31the patch passed
+1findbugs256the patch passed
_ Other Tests _
-1unit20948hbase-server in the patch failed.
+1asflicense50The patch does not generate ASF License warnings.
24654
ReasonTests
Failed junit testshadoop.hbase.client.TestTableSnapshotScanner
hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient
hadoop.hbase.master.assignment.TestSplitTableRegionProcedure
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.master.TestSplitRegionWhileRSCrash
hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed
hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation
hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay
hadoop.hbase.client.TestRestoreSnapshotFromClientClone
hadoop.hbase.client.TestAsyncTableAdminApi
hadoop.hbase.regionserver.wal.TestLogRolling
hadoop.hbase.client.TestAsyncSnapshotAdminApi
hadoop.hbase.tool.TestSecureBulkLoadHFilesSplitRecovery
hadoop.hbase.client.TestSeparateClientZKCluster
hadoop.hbase.replication.TestSerialReplication
hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions
hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller
hadoop.hbase.coprocessor.TestOpenTableInCoprocessor
hadoop.hbase.client.TestMetaWithReplicas
hadoop.hbase.client.TestAsyncNonMetaRegionLocator
hadoop.hbase.quotas.TestFileArchiverNotifierImpl
hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.client.TestAsyncTableBatch
hadoop.hbase.client.TestRestoreSnapshotFromClientAfterTruncate
hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
hadoop.hbase.client.TestAsyncMetaRegionLocator
hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange
hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
hadoop.hbase.client.TestAdmin2
hadoop.hbase.client.TestMvccConsistentScanner
hadoop.hbase.regionserver.TestEndToEndSplitTransaction
hadoop.hbase.client.TestAdmin
hadoop.hbase.regionserver.TestCompactSplitThread
hadoop.hbase.regionserver.wal.TestWALReplayCompressed
hadoop.hbase.regionserver.wal.TestWALReplay
hadoop.hbase.client.TestAsyncTableGetMultiThreaded
hadoop.hbase.client.TestAsyncTableLocateRegionForDeletedTable
hadoop.hbase.TestRegionRebalancing
hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash
hadoop.hbase.TestPartialResultsFromClientSide
hadoop.hbase.client.TestSizeFailures
hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
hadoop.hbase.regionserver.wal.TestAsyncWALReplay
hadoop.hbase.util.TestRegionMover
hadoop.hbase.tool.TestBulkLoadHFilesSplitRecovery
hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions
hadoop.hbase.client.TestRestoreSnapshotFromClientSimple
hadoop.hbase.client.TestMultiRespectsLimits
hadoop.hbase.regionserver.wal.TestAsyncLogRolling
hadoop.hbase.quotas.TestQuotaAdmin
hadoop.hbase.client.TestMultiParallel
hadoop.hbase.regionserver.TestHRegionOnCluster
hadoop.hbase.client.TestSmallReversedScanner
hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
hadoop.hbase.regionserver.wal.TestSecureWALReplay
hadoop.hbase.snapshot.TestFlushSnapshotFromClient
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/13/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 9f9870354bcf 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 009851d
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/13/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/13/testReport/
Max. process+thread count5172 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/13/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@xcangCRM

Copy link
Copy Markdown
Contributor

Notice there are lots tests failed. Have you already confirmed that they are all irrelevant to this change? thanks @virajjasani

@virajjasani

Copy link
Copy Markdown
ContributorAuthor

@xcangCRM yes, these test failures are irrelevant, second last build has +1 overall including unit tests.
However, I am just worried about the concern raised by @Reidddddd
Any recommendation/thought you would like to add?
Thanks

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec41Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall329master passed
+1compile55master passed
+1checkstyle81master passed
+1shadedjars274branch has no errors when building our shaded downstream artifacts.
+1javadoc37master passed
0spotbugs240Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs238master passed
_ Patch Compile Tests _
+1mvninstall298the patch passed
+1compile51the patch passed
+1javac51the patch passed
+1checkstyle76the patch passed
+1whitespace1The patch has no whitespace issues.
+1shadedjars259patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck920Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc33the patch passed
+1findbugs242the patch passed
_ Other Tests _
-1unit13238hbase-server in the patch failed.
+1asflicense25The patch does not generate ASF License warnings.
16733
ReasonTests
Failed junit testshadoop.hbase.client.TestMultiRespectsLimits
hadoop.hbase.regionserver.TestEndToEndSplitTransaction
hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions
hadoop.hbase.TestPartialResultsFromClientSide
hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
hadoop.hbase.client.TestSmallReversedScanner
hadoop.hbase.snapshot.TestFlushSnapshotFromClient
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
hadoop.hbase.regionserver.wal.TestAsyncWALReplay
hadoop.hbase.client.TestRestoreSnapshotFromClientAfterTruncate
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.client.TestAdmin
hadoop.hbase.util.TestRegionMover
hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation
hadoop.hbase.master.assignment.TestSplitTableRegionProcedure
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.TestRegionRebalancing
hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure
hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller
hadoop.hbase.client.TestAsyncTableGetMultiThreaded
hadoop.hbase.tool.TestSecureBulkLoadHFilesSplitRecovery
hadoop.hbase.regionserver.wal.TestLogRolling
hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange
hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed
hadoop.hbase.quotas.TestQuotaAdmin
hadoop.hbase.master.TestSplitRegionWhileRSCrash
hadoop.hbase.coprocessor.TestOpenTableInCoprocessor
hadoop.hbase.regionserver.TestHRegionOnCluster
hadoop.hbase.regionserver.wal.TestWALReplayCompressed
hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
hadoop.hbase.regionserver.TestCompactSplitThread
hadoop.hbase.regionserver.wal.TestWALReplay
hadoop.hbase.regionserver.wal.TestAsyncLogRolling
hadoop.hbase.client.TestRestoreSnapshotFromClientClone
hadoop.hbase.client.TestRestoreSnapshotFromClientSimple
hadoop.hbase.client.TestAsyncTableAdminApi
hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
hadoop.hbase.client.TestAsyncSnapshotAdminApi
hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash
hadoop.hbase.client.TestAsyncMetaRegionLocator
hadoop.hbase.client.TestSeparateClientZKCluster
hadoop.hbase.replication.TestAddToSerialReplicationPeer
hadoop.hbase.client.TestAsyncDecommissionAdminApi
hadoop.hbase.client.TestMultiParallel
hadoop.hbase.client.TestSizeFailures
hadoop.hbase.tool.TestBulkLoadHFilesSplitRecovery
hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange
hadoop.hbase.client.TestTableSnapshotScanner
hadoop.hbase.client.TestAsyncTableBatch
hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions
hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay
hadoop.hbase.regionserver.wal.TestSecureWALReplay
hadoop.hbase.client.TestAsyncTableLocateRegionForDeletedTable
hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient
hadoop.hbase.client.TestAsyncNonMetaRegionLocator
hadoop.hbase.quotas.TestFileArchiverNotifierImpl
hadoop.hbase.client.TestMvccConsistentScanner
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/14/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 9975d86e558d 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 9d6a653
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/14/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/14/testReport/
Max. process+thread count4700 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/14/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec245Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall379master passed
+1compile65master passed
+1checkstyle80master passed
+1shadedjars325branch has no errors when building our shaded downstream artifacts.
+1javadoc36master passed
0spotbugs261Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs260master passed
_ Patch Compile Tests _
+1mvninstall312the patch passed
+1compile60the patch passed
+1javac60the patch passed
+1checkstyle76the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars276patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1104Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc51the patch passed
+1findbugs241the patch passed
_ Other Tests _
-1unit14418hbase-server in the patch failed.
+1asflicense114The patch does not generate ASF License warnings.
18594
ReasonTests
Failed junit testshadoop.hbase.util.TestFromClientSide3WoUnsafe
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.replication.TestMasterReplication
hadoop.hbase.master.procedure.TestProcedurePriority
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/15/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux fa4d55f4a3ac 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 07ab9ed
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/15/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/15/testReport/
Max. process+thread count4836 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/15/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec218Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall416master passed
+1compile71master passed
+1checkstyle97master passed
+1shadedjars349branch has no errors when building our shaded downstream artifacts.
+1javadoc47master passed
0spotbugs328Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs325master passed
_ Patch Compile Tests _
+1mvninstall416the patch passed
+1compile74the patch passed
+1javac74the patch passed
+1checkstyle101the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars347patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1207Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc44the patch passed
+1findbugs330the patch passed
_ Other Tests _
-1unit14379hbase-server in the patch failed.
+1asflicense40The patch does not generate ASF License warnings.
18921
ReasonTests
Failed junit testshadoop.hbase.replication.TestReplicationEndpoint
hadoop.hbase.util.TestFromClientSide3WoUnsafe
hadoop.hbase.client.TestCloneSnapshotFromClientNormal
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleWAL
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/16/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 6ac26b840362 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 8c1edb3
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/16/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/16/testReport/
Max. process+thread count5058 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/16/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec99Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall464master passed
+1compile79master passed
+1checkstyle103master passed
+1shadedjars374branch has no errors when building our shaded downstream artifacts.
+1javadoc47master passed
0spotbugs328Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs323master passed
_ Patch Compile Tests _
+1mvninstall412the patch passed
+1compile71the patch passed
+1javac71the patch passed
+1checkstyle96the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars372patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1274Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc40the patch passed
+1findbugs288the patch passed
_ Other Tests _
-1unit13431hbase-server in the patch failed.
+1asflicense29The patch does not generate ASF License warnings.
17999
ReasonTests
Failed junit testshadoop.hbase.client.TestFromClientSide3
hadoop.hbase.util.TestFromClientSide3WoUnsafe
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/17/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux e62cc2fe9175 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / e69af5a
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/17/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/17/testReport/
Max. process+thread count5102 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/17/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec132Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall374master passed
+1compile62master passed
+1checkstyle97master passed
+1shadedjars301branch has no errors when building our shaded downstream artifacts.
+1javadoc37master passed
0spotbugs307Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs304master passed
_ Patch Compile Tests _
+1mvninstall353the patch passed
+1compile59the patch passed
+1javac59the patch passed
+1checkstyle91the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars308patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1037Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc37the patch passed
+1findbugs294the patch passed
_ Other Tests _
-1unit11894hbase-server in the patch failed.
+1asflicense32The patch does not generate ASF License warnings.
15819
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/18/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux c42c0f8312f5 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 27ed2ac
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/18/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/18/testReport/
Max. process+thread count5146 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/18/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec44Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall351master passed
+1compile57master passed
+1checkstyle75master passed
+1shadedjars264branch has no errors when building our shaded downstream artifacts.
+1javadoc35master passed
0spotbugs252Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs249master passed
_ Patch Compile Tests _
+1mvninstall295the patch passed
+1compile52the patch passed
+1javac52the patch passed
+1checkstyle71the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars264patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck910Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc32the patch passed
+1findbugs244the patch passed
_ Other Tests _
+1unit7281hbase-server in the patch passed.
+1asflicense23The patch does not generate ASF License warnings.
10614
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/19/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux bd2a9d4b1f7a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 53db390
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/19/testReport/
Max. process+thread count4679 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/19/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec36Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall326master passed
+1compile55master passed
+1checkstyle76master passed
+1shadedjars268branch has no errors when building our shaded downstream artifacts.
+1javadoc37master passed
0spotbugs254Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs253master passed
_ Patch Compile Tests _
+1mvninstall298the patch passed
+1compile58the patch passed
+1javac58the patch passed
+1checkstyle76the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars272patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck917Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc34the patch passed
+1findbugs244the patch passed
_ Other Tests _
+1unit9053hbase-server in the patch passed.
+1asflicense41The patch does not generate ASF License warnings.
12432
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/20/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 7121330dd884 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / d9d5f69
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/20/testReport/
Max. process+thread count4676 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/20/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec99Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall348master passed
+1compile62master passed
+1checkstyle91master passed
+1shadedjars288branch has no errors when building our shaded downstream artifacts.
+1javadoc37master passed
0spotbugs300Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs298master passed
_ Patch Compile Tests _
+1mvninstall330the patch passed
+1compile58the patch passed
+1javac58the patch passed
+1checkstyle84the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars290patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck965Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc36the patch passed
+1findbugs290the patch passed
_ Other Tests _
-1unit17933hbase-server in the patch failed.
+1asflicense30The patch does not generate ASF License warnings.
21627
ReasonTests
Failed junit testshadoop.hbase.client.TestFromClientSide3
hadoop.hbase.client.TestAsyncTableAdminApi3
hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.client.TestFromClientSide
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/22/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 5b8aa48532ab 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / edf6f68
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/22/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/22/testReport/
Max. process+thread count4692 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/22/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec99Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall381master passed
+1compile52master passed
+1checkstyle75master passed
+1shadedjars276branch has no errors when building our shaded downstream artifacts.
+1javadoc35master passed
0spotbugs245Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs243master passed
_ Patch Compile Tests _
+1mvninstall299the patch passed
+1compile54the patch passed
+1javac54the patch passed
+1checkstyle77the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars279patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck940Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc33the patch passed
+1findbugs257the patch passed
_ Other Tests _
+1unit8679hbase-server in the patch passed.
+1asflicense33The patch does not generate ASF License warnings.
12192
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/23/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 2b312e233019 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 60971be
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/23/testReport/
Max. process+thread count4693 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/23/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall363master passed
+1compile52master passed
+1checkstyle73master passed
+1shadedjars271branch has no errors when building our shaded downstream artifacts.
+1javadoc34master passed
0spotbugs258Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs257master passed
_ Patch Compile Tests _
+1mvninstall291the patch passed
+1compile54the patch passed
+1javac54the patch passed
+1checkstyle75the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars274patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck912Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc33the patch passed
+1findbugs252the patch passed
_ Other Tests _
-1unit8496hbase-server in the patch failed.
+1asflicense24The patch does not generate ASF License warnings.
11857
ReasonTests
Failed junit testshadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/24/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 7e9ca1ba72b2 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 78f5d8e
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/24/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/24/testReport/
Max. process+thread count4621 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/24/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec40Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall320master passed
+1compile51master passed
+1checkstyle72master passed
+1shadedjars262branch has no errors when building our shaded downstream artifacts.
+1javadoc34master passed
0spotbugs254Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs253master passed
_ Patch Compile Tests _
+1mvninstall355the patch passed
+1compile53the patch passed
+1javac53the patch passed
+1checkstyle74the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars316patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck896Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc32the patch passed
+1findbugs246the patch passed
_ Other Tests _
+1unit8989hbase-server in the patch passed.
+1asflicense24The patch does not generate ASF License warnings.
12370
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/25/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 3301e6471d94 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 94af651
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/25/testReport/
Max. process+thread count4786 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/25/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec71Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall332master passed
+1compile53master passed
+1checkstyle74master passed
+1shadedjars272branch has no errors when building our shaded downstream artifacts.
+1javadoc38master passed
0spotbugs276Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs275master passed
_ Patch Compile Tests _
+1mvninstall313the patch passed
+1compile58the patch passed
+1javac58the patch passed
+1checkstyle81the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars283patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck970Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc33the patch passed
+1findbugs278the patch passed
_ Other Tests _
-1unit20048hbase-server in the patch failed.
+1asflicense29The patch does not generate ASF License warnings.
23585
ReasonTests
Failed junit testshadoop.hbase.master.assignment.TestMergeTableRegionsProcedure
hadoop.hbase.replication.TestReplicationDisableInactivePeer
hadoop.hbase.tool.TestSecureBulkLoadHFiles
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.tool.TestBulkLoadHFiles
hadoop.hbase.client.TestAdmin2
hadoop.hbase.replication.TestReplicationSmallTests
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.replication.TestReplicationSmallTestsSync
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
hadoop.hbase.util.TestFromClientSide3WoUnsafe
hadoop.hbase.client.TestAsyncTableAdminApi
hadoop.hbase.client.TestCloneSnapshotFromClientNormal
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/26/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 350b882e9c6c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 3eb602c
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/26/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/26/testReport/
Max. process+thread count4973 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/26/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec64Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall458master passed
+1compile72master passed
+1checkstyle106master passed
+1shadedjars381branch has no errors when building our shaded downstream artifacts.
+1javadoc45master passed
0spotbugs339Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs335master passed
_ Patch Compile Tests _
+1mvninstall423the patch passed
+1compile72the patch passed
+1javac72the patch passed
+1checkstyle106the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars388patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1303Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc45the patch passed
+1findbugs347the patch passed
_ Other Tests _
-1unit17750hbase-server in the patch failed.
+1asflicense41The patch does not generate ASF License warnings.
22437
ReasonTests
Failed junit testshadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.master.TestMasterShutdown
hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleAsyncWAL
hadoop.hbase.client.TestFromClientSide
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/27/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 3f660bd444a7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 43a0ec8
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/27/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/27/testReport/
Max. process+thread count5037 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/27/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec71Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall459master passed
+1compile70master passed
+1checkstyle108master passed
+1shadedjars360branch has no errors when building our shaded downstream artifacts.
+1javadoc44master passed
0spotbugs308Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs305master passed
_ Patch Compile Tests _
+1mvninstall415the patch passed
+1compile74the patch passed
+1javac74the patch passed
+1checkstyle125the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars361patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1267Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc41the patch passed
+1findbugs325the patch passed
_ Other Tests _
-1unit17273hbase-server in the patch failed.
+1asflicense34The patch does not generate ASF License warnings.
21806
ReasonTests
Failed junit testshadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.replication.TestReplicationSmallTests
hadoop.hbase.util.TestFromClientSide3WoUnsafe
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.replication.TestReplicationSmallTestsSync
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/28/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux b3df9d8d9dad 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 7903f55
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/28/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/28/testReport/
Max. process+thread count5095 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/28/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec57Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall434master passed
+1compile77master passed
+1checkstyle107master passed
+1shadedjars381branch has no errors when building our shaded downstream artifacts.
+1javadoc45master passed
0spotbugs340Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs336master passed
_ Patch Compile Tests _
+1mvninstall415the patch passed
+1compile67the patch passed
+1javac67the patch passed
+1checkstyle97the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars353patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1190Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc42the patch passed
+1findbugs337the patch passed
_ Other Tests _
-1unit15149hbase-server in the patch failed.
+1asflicense33The patch does not generate ASF License warnings.
19578
ReasonTests
Failed junit testshadoop.hbase.client.TestAsyncTableAdminApi3
hadoop.hbase.client.TestMobSnapshotCloneIndependence
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/30/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 03170b6897ec 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 836f269
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/30/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/30/testReport/
Max. process+thread count4915 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/30/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec65Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall329master passed
+1compile53master passed
+1checkstyle79master passed
+1shadedjars304branch has no errors when building our shaded downstream artifacts.
+1javadoc37master passed
0spotbugs247Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs245master passed
_ Patch Compile Tests _
+1mvninstall352the patch passed
+1compile52the patch passed
+1javac52the patch passed
+1checkstyle75the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars268patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1003Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc34the patch passed
+1findbugs251the patch passed
_ Other Tests _
-1unit16854hbase-server in the patch failed.
+1asflicense32The patch does not generate ASF License warnings.
20441
ReasonTests
Failed junit testshadoop.hbase.client.TestFromClientSide
hadoop.hbase.client.TestCloneSnapshotFromClientNormal
hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.replication.TestReplicationDisableInactivePeer
hadoop.hbase.util.TestFromClientSide3WoUnsafe
hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure
hadoop.hbase.client.TestSnapshotCloneIndependence
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/31/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 73b74aeec0a6 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 7697d48
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/31/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/31/testReport/
Max. process+thread count4781 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/31/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@virajjasani

Copy link
Copy Markdown
ContributorAuthor

But even it only targets to a single RS where balance off is only a temporary move, do you really think it is a good practice or worthy of destructing then constructing a task, just within few minutes?

I agree that it should not keep doing this in shorter time.

@Reidddddd would you like me to close this PR?

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec61Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall407master passed
+1compile73master passed
+1checkstyle93master passed
+1shadedjars356branch has no errors when building our shaded downstream artifacts.
+1javadoc45master passed
0spotbugs317Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs313master passed
_ Patch Compile Tests _
+1mvninstall406the patch passed
+1compile77the patch passed
+1javac77the patch passed
+1checkstyle104the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars345patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1270Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc41the patch passed
+1findbugs312the patch passed
_ Other Tests _
-1unit18859hbase-server in the patch failed.
+1asflicense33The patch does not generate ASF License warnings.
23292
ReasonTests
Failed junit testshadoop.hbase.client.TestFromClientSide3
hadoop.hbase.tool.TestSecureBulkLoadHFiles
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.replication.TestReplicationDisableInactivePeer
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.tool.TestBulkLoadHFiles
hadoop.hbase.replication.TestReplicationSmallTestsSync
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/32/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 28b518d9d2e0 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 46abaef
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/32/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/32/testReport/
Max. process+thread count5018 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/32/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec93Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall373master passed
+1compile60master passed
+1checkstyle97master passed
+1shadedjars304branch has no errors when building our shaded downstream artifacts.
+1javadoc39master passed
0spotbugs273Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs270master passed
_ Patch Compile Tests _
+1mvninstall339the patch passed
+1compile60the patch passed
+1javac60the patch passed
+1checkstyle89the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars307patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1096Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc39the patch passed
+1findbugs290the patch passed
_ Other Tests _
-1unit13909hbase-server in the patch failed.
+1asflicense26The patch does not generate ASF License warnings.
17823
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestHRegionWithInMemoryFlush
hadoop.hbase.regionserver.TestHRegion
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/33/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux ccccda2e8b75 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 8e488ce
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/33/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/33/testReport/
Max. process+thread count4755 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/33/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Reidddddd

Copy link
Copy Markdown
Contributor

would you like me to close this PR?

Thanks!

@virajjasani

Copy link
Copy Markdown
ContributorAuthor

Closing the PR as per suggestion by @Reidddddd
If there is any change of thought, please let me know and I will reopen it.

Thanks for the review @Reidddddd@saintstack

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec103Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall419master passed
+1compile62master passed
+1checkstyle97master passed
+1shadedjars332branch has no errors when building our shaded downstream artifacts.
+1javadoc43master passed
0spotbugs258Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs255master passed
_ Patch Compile Tests _
+1mvninstall420the patch passed
+1compile66the patch passed
+1javac66the patch passed
+1checkstyle88the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars331patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1210Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc46the patch passed
+1findbugs312the patch passed
_ Other Tests _
-1unit19031hbase-server in the patch failed.
+1asflicense27The patch does not generate ASF License warnings.
23303
ReasonTests
Failed junit testshadoop.hbase.tool.TestSecureBulkLoadHFiles
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.regionserver.TestHRegion
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.client.TestAdmin1
hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
hadoop.hbase.tool.TestBulkLoadHFiles
hadoop.hbase.util.TestFromClientSide3WoUnsafe
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/34/artifact/out/Dockerfile
GITHUB PR#468
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux b1805f342f30 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revisionmaster / 6738280
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/34/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/34/testReport/
Max. process+thread count4969 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/34/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@virajjasani@Apache-HBase@Reidddddd@xcangCRM@saintstack