Uh oh!
There was an error while loading. Please reload this page.
HBASE-22822 : Un/Re-schedule balancer chore with balance_switch - #468
HBASE-22822 : Un/Re-schedule balancer chore with balance_switch#468virajjasani wants to merge 4 commits into
Conversation
Apache-HBase
commented
Aug 8, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 9, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 9, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 9, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 9, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 10, 2019
💔 -1 overall
This message was automatically generated. |
virajjasani
commented
Aug 11, 2019
Please review @apurtell@Reidddddd@anoopsjohn |
saintstack
left a comment
There was a problem hiding this comment.
Just a nit in the below. Not important. LGTM.
| * | ||
| * @param on boolean value indicates whether to turn the balancer on | ||
| */ | ||
| void turnBalancer(boolean on) { |
There was a problem hiding this comment.
s/turnBalancer/switchBalancer/ ?
Apache-HBase
commented
Aug 11, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 12, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 12, 2019
🎊 +1 overall
This message was automatically generated. |
IIRC, And there's one script One step back, current impl brings no harm to master nor good, but the new impl looks like may bring a new uncertainty. I incline to keep it still, and so, leave my -0. |
virajjasani
commented
Aug 12, 2019
graceful_stop.sh turns on balancer at the end conditionally. If -nob arg is provided, it won't: here |
@Reidddddd |
Reidddddd
commented
Aug 12, 2019
Hmm, right. But it only works for master and branch-2.
Just rolling restart, maybe. One place I'm not sure is RSGroup's move_regions op. |
Apache-HBase
commented
Aug 12, 2019
💔 -1 overall
This message was automatically generated. |
xcangCRM
commented
Aug 12, 2019
Notice there are lots tests failed. Have you already confirmed that they are all irrelevant to this change? thanks @virajjasani |
virajjasani
commented
Aug 13, 2019
@xcangCRM yes, these test failures are irrelevant, second last build has +1 overall including unit tests. |
Apache-HBase
commented
Aug 13, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 13, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 13, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 13, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 14, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 14, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 15, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 16, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 16, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 16, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 16, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 16, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 17, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 17, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 18, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 18, 2019
💔 -1 overall
This message was automatically generated. |
virajjasani
commented
Aug 19, 2019
I agree that it should not keep doing this in shorter time. @Reidddddd would you like me to close this PR? |
Apache-HBase
commented
Aug 19, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 20, 2019
💔 -1 overall
This message was automatically generated. |
Reidddddd
commented
Aug 20, 2019
Thanks! |
virajjasani
commented
Aug 20, 2019
Closing the PR as per suggestion by @Reidddddd Thanks for the review @Reidddddd@saintstack |
Apache-HBase
commented
Aug 20, 2019
💔 -1 overall
This message was automatically generated. |
balance_switch turns on/off balancer. When it is turned off, we don't remove balancer chore from scheduled chores hence it keeps running only to eventually find out that it is not supposed to perform any action(if balancer was turned off). We can unschedule the chore to prevent the chore() execution and reschedule it when it is turned on by balance_switch.
This should also facilitate running balancer immediately after triggering balance_switch true(due to default initial delay: 0), and then chore would continue running as per duration provided in hbase.balancer.period.