Uh oh!
There was an error while loading. Please reload this page.
HBASE-27152 Under compaction mark may leak - #4725
Conversation
Apache-HBase
commented
Aug 24, 2022
🎊 +1 overall
This message was automatically generated. |
| final String n = Thread.currentThread().getName(); | ||
| StealJobQueue<Runnable> stealJobQueue = new StealJobQueue<Runnable>(COMPARATOR); | ||
| // Since the StealJobQueue is unbounded, we need not to set the RejectedExecutionHandler for |
There was a problem hiding this comment.
This could be done as a separated issue? And what is the disadvantage to set the rejection handler, seems no harm?
There was a problem hiding this comment.
Actually the max size of StealJobQueue is bouded by the VM limit of an array, and the OOM exception occurs before the rejection handler. So StealJobQueue is equivalent to be unbounded. I think the RejectionHandler may bring some confusions and make the codes a little puzzle.
I will seperate the removing the rejection handler here in another issue. Thanks.
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
Aug 26, 2022
🎊 +1 overall
This message was automatically generated. |
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
No description provided.