HBASE-27352 - Quoted string argument with spaces passed from command line are propagated wrongly to the underlying java class by ujjawal4046 · Pull Request #4754 · apache/hbase

ujjawal4046 · 2022-08-31T17:48:01Z

It is due to the fact that read -r -a CMD_ARGS <<< "$@" in the hbase script would split command line args after expansion of $@ array (i.e. "$@") . Instead a straightforward array copy can be used.

ujjawal4046 · 2022-08-31T18:00:49Z

@ndimiduk Can you take a look whenever you get a chance, thanks

Apache-HBase · 2022-08-31T18:39:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 22s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4754/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4754
Optional Tests
uname	Linux e32c90d8a943 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `10d85f3`
Max. process+thread count	43 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4754/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-31T18:41:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		2m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4754/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4754
Optional Tests
uname	Linux 105f3147dc7c 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `10d85f3`
Max. process+thread count	29 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4754/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-31T18:42:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	spotless	0m 48s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	shellcheck	0m 1s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		4m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4754/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4754
Optional Tests	dupname asflicense spotless shellcheck shelldocs
uname	Linux b18668201c91 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `10d85f3`
Max. process+thread count	33 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4754/1/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2022-09-13T11:57:26Z

Looks alright to me @ujjawal4046 . I looked back through the history on the original PR and don't see a reason why I used read instead of a simpler construct... You did some testing after this change?

ujjawal4046 · 2022-09-13T12:10:29Z

I looked back through the history on the original PR and don't see a reason why I used read instead of a simpler construct... You did some testing after this change?

Yes, I had tested it manually after doing this change to ensure command line args are passed as it is from script to the underlying java class (for e.g. Import job). @ndimiduk Can you merge this if it looks okay ?

ndimiduk · 2022-09-13T12:17:34Z

I can, no problem. One small question before I do -- would you like to update the identity on your commit? Right now, it's u.kumar@ukumar-ltmit1s.internal.salesforce.com.

…line are propagated wrongly to the underlying java class

ujjawal4046 · 2022-09-13T12:27:07Z

@ndimiduk Sorry, looks like my work ID got attached. Have updated it.

Apache-HBase · 2022-09-13T12:31:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4754/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4754
Optional Tests
uname	Linux c52e4cabde9a 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f3f88ff`
Max. process+thread count	44 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4754/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-13T12:32:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4754/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4754
Optional Tests
uname	Linux 74027e703588 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f3f88ff`
Max. process+thread count	33 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4754/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-13T12:33:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	shellcheck	0m 1s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 35s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		3m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4754/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4754
Optional Tests	dupname asflicense spotless shellcheck shelldocs
uname	Linux 6980442e98d5 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f3f88ff`
Max. process+thread count	34 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4754/2/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…line are propagated wrongly to the underlying java class (apache#4754) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

…line are propagated wrongly to the underlying java class (#4754) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

ndimiduk approved these changes Sep 13, 2022
View reviewed changes

HBASE-27352 - Quoted string argument with spaces passed from command …
f2ef0ea
…line are propagated wrongly to the underlying java class

ujjawal4046 force-pushed the HBASE-27352 branch from 0dcb525 to f2ef0eaCompare September 13, 2022 12:23

ndimiduk merged commit b3a0489 into apache:masterSep 13, 2022

ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Sep 13, 2022
HBASE-27352 - Quoted string argument with spaces passed from command …
bd0c198
…line are propagated wrongly to the underlying java class (apache#4754) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Sep 13, 2022
HBASE-27352 - Quoted string argument with spaces passed from command …
59fcadf
…line are propagated wrongly to the underlying java class (apache#4754) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

This was referenced Sep 13, 2022
Backport "HBASE-27352 - Quoted string argument with spaces passed from command …" to branch-2 #4777
Merged
Backport "HBASE-27352 - Quoted string argument with spaces passed from command …" to branch-2.5 #4778
Merged

ndimiduk pushed a commit that referenced this pull request Sep 13, 2022
HBASE-27352- Quoted string argument with spaces passed from command …
74126ea
…line are propagated wrongly to the underlying java class (#4754) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

ndimiduk pushed a commit that referenced this pull request Sep 13, 2022
HBASE-27352- Quoted string argument with spaces passed from command …
606882e
…line are propagated wrongly to the underlying java class (#4754) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

Navigation Menu

Uh oh!

HBASE-27352 - Quoted string argument with spaces passed from command line are propagated wrongly to the underlying java class - #4754

HBASE-27352 - Quoted string argument with spaces passed from command line are propagated wrongly to the underlying java class#4754
ndimiduk merged 1 commit into
apache:masterfrom
ujjawal4046:HBASE-27352

ujjawal4046 commented Aug 31, 2022•
edited
Loading

Uh oh!

ujjawal4046 commented Aug 31, 2022

Uh oh!

Apache-HBase commented Aug 31, 2022

Uh oh!

Apache-HBase commented Aug 31, 2022

Uh oh!

Apache-HBase commented Aug 31, 2022

Uh oh!

ndimiduk commented Sep 13, 2022

Uh oh!

ujjawal4046 commented Sep 13, 2022

Uh oh!

ndimiduk commented Sep 13, 2022

Uh oh!

ujjawal4046 commented Sep 13, 2022

Uh oh!

Apache-HBase commented Sep 13, 2022

Uh oh!

Apache-HBase commented Sep 13, 2022

Uh oh!

Apache-HBase commented Sep 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ujjawal4046 commented Aug 31, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ujjawal4046 commented Aug 31, 2022

Uh oh!

Apache-HBase commented Aug 31, 2022

Uh oh!

Apache-HBase commented Aug 31, 2022

Uh oh!

Apache-HBase commented Aug 31, 2022

Uh oh!

ndimiduk commented Sep 13, 2022

Uh oh!

ujjawal4046 commented Sep 13, 2022

Uh oh!

ndimiduk commented Sep 13, 2022

Uh oh!

ujjawal4046 commented Sep 13, 2022

Uh oh!

Apache-HBase commented Sep 13, 2022

Uh oh!

Apache-HBase commented Sep 13, 2022

Uh oh!

Apache-HBase commented Sep 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ujjawal4046 commented Aug 31, 2022•
edited
Loading