Uh oh!
There was an error while loading. Please reload this page.
HBASE-27362 CompactSplit.requestCompactionInternal may bypass compact… - #4768
Merged
Conversation
Apache-HBase
commented
Sep 7, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 7, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 7, 2022
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Sep 8, 2022
| if (midKey == null) { | ||
| LOG.debug("Region " + r.getRegionInfo().getRegionNameAsString() | ||
| + " not splittable because midkey=null"); | ||
| if (LOG.isDebugEnabled()) { |
Contributor
There was a problem hiding this comment.
Are these logging changes related?
ContributorAuthor
There was a problem hiding this comment.
no, it is not related, just modified by the way.
| // re-create executor pool if compactions are disabled. | ||
| if (!isCompactionsEnabled()) { | ||
| LOG.info("Re-Initializing compactions because user switched on compactions"); | ||
| if (LOG.isInfoEnabled()) { |
Contributor
There was a problem hiding this comment.
I prefer we keep the old style.
ContributorAuthor
There was a problem hiding this comment.
Ok, I have reverted it.
Contributor
There was a problem hiding this comment.
If we want to align them, I prefer we open a new issue.
| protected void requestCompactionInternal(HRegion region, HStore store, String why, int priority, | ||
| boolean selectNow, CompactionLifeCycleTracker tracker, | ||
| CompactionCompleteTracker completeTracker, User user) throws IOException { | ||
| if (!this.isCompactionsEnabled()) { |
ContributorAuthor
There was a problem hiding this comment.
yes, it is the actual fix.
Apache-HBase
commented
Sep 8, 2022
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Sep 8, 2022
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
Sep 8, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 8, 2022
💔 -1 overall
This message was automatically generated. |
Apache9
approved these changes
Sep 8, 2022
Apache9 pushed a commit
to Apache9/hbase
that referenced
this pull request
Sep 8, 2022
…ionsEnabled check (apache#4768) Co-authored-by: comnetwork <comnetwork@163.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a26cbf1)
ndimiduk
commented
Sep 8, 2022
Member
Nice one 👍 |
vinayakphegde pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…ionsEnabled check (apache#4768) Co-authored-by: comnetwork <comnetwork@163.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a26cbf1) (cherry picked from commit b733485) Change-Id: Ie58f7748ff11422e1d76b405c1bf6c2989b8f649
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ionsEnabled check