HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7…

[Apache9]

….2 (#4787)

Signed-off-by: Wellington Chevreuil wchevreuil@apache.org

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 21s	branch-2.5 passed
+1 💚	compile	5m 59s	branch-2.5 passed
+1 💚	checkstyle	0m 59s	branch-2.5 passed
+1 💚	spotless	0m 37s	branch has no errors when running spotless:check.
-1 ❌	spotbugs	5m 47s	root in branch-2.5 has 48 extant spotbugs warnings.
-1 ❌	spotbugs	0m 38s	hbase-client in branch-2.5 has 11 extant spotbugs warnings.
-1 ❌	spotbugs	0m 24s	hbase-common in branch-2.5 has 6 extant spotbugs warnings.
-1 ❌	spotbugs	0m 14s	hbase-metrics in branch-2.5 has 1 extant spotbugs warnings.
-1 ❌	spotbugs	0m 48s	hbase-protocol in branch-2.5 has 1 extant spotbugs warnings.
-1 ❌	spotbugs	0m 22s	hbase-rest in branch-2.5 has 2 extant spotbugs warnings.
-1 ❌	spotbugs	1m 12s	hbase-server in branch-2.5 has 27 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 2s	the patch passed
+1 💚	compile	6m 2s	the patch passed
+1 💚	javac	6m 2s	the patch passed
+1 💚	checkstyle	0m 57s	root: The patch generated 0 new + 57 unchanged - 5 fixed = 57 total (was 62)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	12m 3s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚	spotless	0m 35s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 30s	hbase-common generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)
+1 💚	spotbugs	0m 20s	hbase-metrics generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	spotbugs	0m 54s	hbase-protocol generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	spotbugs	0m 46s	hbase-client generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11)
+1 💚	spotbugs	1m 19s	hbase-server generated 0 new + 0 unchanged - 27 fixed = 0 total (was 27)
+1 💚	spotbugs	0m 30s	hbase-rest generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚	spotbugs	5m 53s	root generated 0 new + 0 unchanged - 48 fixed = 0 total (was 48)
		_ Other Tests _
+1 💚	asflicense	0m 50s	The patch does not generate ASF License warnings.
		60m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4790/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4790
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml
uname	Linux 0884e9fd210f 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / df5c1ca
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4790/1/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4790/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-client-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4790/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-common-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4790/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-metrics-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4790/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-protocol-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4790/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-rest-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4790/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
Max. process+thread count	138 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics hbase-protocol hbase-client hbase-server hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4790/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 12s	branch-2.5 passed
+1 💚	compile	1m 51s	branch-2.5 passed
+1 💚	shadedjars	4m 3s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 39s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 38s	the patch passed
+1 💚	compile	1m 53s	the patch passed
+1 💚	javac	1m 53s	the patch passed
+1 💚	shadedjars	3m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	245m 13s	root in the patch passed.
		276m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4790/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4790
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7048ae13ce85 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / df5c1ca
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4790/1/testReport/
Max. process+thread count	4847 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics hbase-protocol hbase-client hbase-server hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4790/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 25s	branch-2.5 passed
+1 💚	compile	1m 22s	branch-2.5 passed
+1 💚	shadedjars	3m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 44s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 8s	the patch passed
+1 💚	compile	1m 24s	the patch passed
+1 💚	javac	1m 24s	the patch passed
+1 💚	shadedjars	3m 53s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 33s	the patch passed
		_ Other Tests _
+1 💚	unit	358m 7s	root in the patch passed.
		383m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4790/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4790
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a7ad3d13618b 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / df5c1ca
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4790/1/testReport/
Max. process+thread count	4846 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics hbase-protocol hbase-client hbase-server hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4790/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.