HBASE-22841 Add more factory functions to TimeRange by huonw · Pull Request #483 · apache/hbase

huonw · 2019-08-13T05:05:56Z

These functions make it easier to possible to use
org.apache.hadoop.hbase.client.Table.CheckAndMutateBuilder#timeRange
with more interesting ranges, without being forced to use the
deprecated constructors.

These functions make it easier to possible to use `org.apache.hadoop.hbase.client.Table.CheckAndMutateBuilder#timeRange` with more interesting ranges, without being forced to use the deprecated constructors.

Apache-HBase · 2019-08-13T13:37:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	146	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
0	mvndep	47	Maven dependency ordering for branch
+1	mvninstall	452	master passed
+1	compile	103	master passed
+1	checkstyle	125	master passed
+1	shadedjars	343	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	75	master passed
0	spotbugs	311	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	370	master passed
		_ Patch Compile Tests _
0	mvndep	21	Maven dependency ordering for patch
+1	mvninstall	425	the patch passed
+1	compile	100	the patch passed
+1	javac	100	the patch passed
+1	checkstyle	124	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	335	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1226	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	80	the patch passed
+1	findbugs	321	the patch passed
		_ Other Tests _
+1	unit	173	hbase-common in the patch passed.
-1	unit	19949	hbase-server in the patch failed.
+1	asflicense	73	The patch does not generate ASF License warnings.
		25032

Reason	Tests
Failed junit tests	hadoop.hbase.replication.TestAddToSerialReplicationPeer
	hadoop.hbase.client.TestAsyncMetaRegionLocator
	hadoop.hbase.client.TestSeparateClientZKCluster
	hadoop.hbase.master.TestSplitRegionWhileRSCrash
	hadoop.hbase.regionserver.wal.TestLogRolling
	hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions
	hadoop.hbase.client.TestAsyncTableBatch
	hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller
	hadoop.hbase.client.TestRestoreSnapshotFromClientSimple
	hadoop.hbase.regionserver.TestHRegionOnCluster
	hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
	hadoop.hbase.regionserver.wal.TestAsyncLogRolling
	hadoop.hbase.master.assignment.TestSplitTableRegionProcedure
	hadoop.hbase.tool.TestBulkLoadHFilesSplitRecovery
	hadoop.hbase.client.TestTableSnapshotScanner
	hadoop.hbase.regionserver.TestCompactSplitThread
	hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange
	hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed
	hadoop.hbase.client.TestAsyncTableAdminApi
	hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay
	hadoop.hbase.client.TestAsyncNonMetaRegionLocator
	hadoop.hbase.regionserver.wal.TestWALReplayCompressed
	hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
	hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation
	hadoop.hbase.TestPartialResultsFromClientSide
	hadoop.hbase.client.TestSizeFailures
	hadoop.hbase.client.TestMvccConsistentScanner
	hadoop.hbase.replication.TestSerialReplication
	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure
	hadoop.hbase.util.TestRegionMover
	hadoop.hbase.client.TestAsyncTableLocateRegionForDeletedTable
	hadoop.hbase.snapshot.TestFlushSnapshotFromClient
	hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange
	hadoop.hbase.client.TestRestoreSnapshotFromClientAfterTruncate
	hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
	hadoop.hbase.regionserver.wal.TestSecureWALReplay
	hadoop.hbase.client.TestMetaWithReplicas
	hadoop.hbase.client.TestAdmin
	hadoop.hbase.client.TestAsyncTableGetMultiThreaded
	hadoop.hbase.tool.TestSecureBulkLoadHFilesSplitRecovery
	hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
	hadoop.hbase.regionserver.TestEndToEndSplitTransaction
	hadoop.hbase.client.TestAsyncSnapshotAdminApi
	hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient
	hadoop.hbase.quotas.TestFileArchiverNotifierImpl
	hadoop.hbase.regionserver.wal.TestWALReplay
	hadoop.hbase.regionserver.wal.TestAsyncWALReplay
	hadoop.hbase.client.TestRestoreSnapshotFromClientClone
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
	hadoop.hbase.coprocessor.TestOpenTableInCoprocessor
	hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash
	hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/2/artifact/out/Dockerfile
GITHUB PR	#483
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 41b986b0da3e 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh
git revision	master / `9d6a653`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/2/testReport/
Max. process+thread count	4712 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-13T13:40:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	129	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
0	mvndep	34	Maven dependency ordering for branch
+1	mvninstall	367	master passed
+1	compile	88	master passed
+1	checkstyle	118	master passed
+1	shadedjars	300	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	61	master passed
0	spotbugs	270	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	323	master passed
		_ Patch Compile Tests _
0	mvndep	17	Maven dependency ordering for patch
+1	mvninstall	356	the patch passed
+1	compile	83	the patch passed
+1	javac	83	the patch passed
+1	checkstyle	115	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	305	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1048	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	56	the patch passed
+1	findbugs	380	the patch passed
		_ Other Tests _
+1	unit	187	hbase-common in the patch passed.
-1	unit	12360	hbase-server in the patch failed.
+1	asflicense	48	The patch does not generate ASF License warnings.
		16818

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide3

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/3/artifact/out/Dockerfile
GITHUB PR	#483
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 6211d86d45b1 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh
git revision	master / `07ab9ed`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/3/testReport/
Max. process+thread count	5187 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-13T15:05:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	313	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
0	mvndep	38	Maven dependency ordering for branch
+1	mvninstall	413	master passed
+1	compile	100	master passed
+1	checkstyle	137	master passed
+1	shadedjars	374	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	70	master passed
0	spotbugs	336	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	397	master passed
		_ Patch Compile Tests _
0	mvndep	20	Maven dependency ordering for patch
+1	mvninstall	394	the patch passed
+1	compile	93	the patch passed
+1	javac	93	the patch passed
+1	checkstyle	121	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	350	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1195	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	68	the patch passed
+1	findbugs	398	the patch passed
		_ Other Tests _
+1	unit	214	hbase-common in the patch passed.
-1	unit	12539	hbase-server in the patch failed.
+1	asflicense	53	The patch does not generate ASF License warnings.
		17765

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide3

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/4/artifact/out/Dockerfile
GITHUB PR	#483
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 01da04563c55 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh
git revision	master / `8c1edb3`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/4/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/4/testReport/
Max. process+thread count	4695 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/4/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet · 2019-08-13T17:18:24Z

 * Evaluated according to minStamp &lt;= timestamp &lt; maxStamp
 * or [minStamp,maxStamp) in interval notation.
- * <p>
- * Can be returned and read by clients. Should not be directly created by clients.


I think that this comment is still valid until the deprecated constructors are removed.

I've added this in the committed patch.

HorizonNet · 2019-08-13T17:20:19Z

 .thenPut(put);
 assertFalse(ok);

+ ok = table.checkAndMutate(ROW, FAMILY).qualifier(QUALIFIER)


Could you please add a short comment for every test what the purpose is (or move them into separate, small test cases)?

Apache-HBase · 2019-08-13T21:22:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	38	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
0	mvndep	35	Maven dependency ordering for branch
+1	mvninstall	303	master passed
+1	compile	73	master passed
+1	checkstyle	95	master passed
+1	shadedjars	263	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	51	master passed
0	spotbugs	239	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	283	master passed
		_ Patch Compile Tests _
0	mvndep	15	Maven dependency ordering for patch
+1	mvninstall	285	the patch passed
+1	compile	72	the patch passed
+1	javac	72	the patch passed
+1	checkstyle	93	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	259	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	934	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	56	the patch passed
+1	findbugs	304	the patch passed
		_ Other Tests _
+1	unit	180	hbase-common in the patch passed.
+1	unit	6550	hbase-server in the patch passed.
+1	asflicense	59	The patch does not generate ASF License warnings.
		10329

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/5/artifact/out/Dockerfile
GITHUB PR	#483
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 40cdad9d856b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh
git revision	master / `e69af5a`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/5/testReport/
Max. process+thread count	4829 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/5/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-14T03:11:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	302	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
0	mvndep	43	Maven dependency ordering for branch
+1	mvninstall	416	master passed
+1	compile	98	master passed
+1	checkstyle	127	master passed
+1	shadedjars	330	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	65	master passed
0	spotbugs	295	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	357	master passed
		_ Patch Compile Tests _
0	mvndep	17	Maven dependency ordering for patch
+1	mvninstall	391	the patch passed
+1	compile	98	the patch passed
+1	javac	98	the patch passed
+1	checkstyle	126	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	332	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1114	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	60	the patch passed
+1	findbugs	335	the patch passed
		_ Other Tests _
+1	unit	175	hbase-common in the patch passed.
-1	unit	10799	hbase-server in the patch failed.
+1	asflicense	46	The patch does not generate ASF License warnings.
		15648

Reason	Tests
Failed junit tests	hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/6/artifact/out/Dockerfile
GITHUB PR	#483
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux e8f5fa6a7636 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh
git revision	master / `27ed2ac`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/6/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/6/testReport/
Max. process+thread count	4758 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

openinx

The patch looks good to me overall. +1, please address HorizonNet's comment if necessary.. Thanks.

Apache-HBase · 2019-08-14T22:01:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	76	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
0	mvndep	38	Maven dependency ordering for branch
+1	mvninstall	369	master passed
+1	compile	81	master passed
+1	checkstyle	100	master passed
+1	shadedjars	267	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	55	master passed
0	spotbugs	263	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	312	master passed
		_ Patch Compile Tests _
0	mvndep	15	Maven dependency ordering for patch
+1	mvninstall	338	the patch passed
+1	compile	81	the patch passed
+1	javac	81	the patch passed
+1	checkstyle	105	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	312	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1040	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	54	the patch passed
+1	findbugs	317	the patch passed
		_ Other Tests _
+1	unit	175	hbase-common in the patch passed.
-1	unit	13314	hbase-server in the patch failed.
+1	asflicense	49	The patch does not generate ASF License warnings.
		17501

Reason	Tests
Failed junit tests	hadoop.hbase.util.TestFromClientSide3WoUnsafe
	hadoop.hbase.client.TestFromClientSide3

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/7/artifact/out/Dockerfile
GITHUB PR	#483
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 7b1a9a115455 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh
git revision	master / `53db390`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/7/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/7/testReport/
Max. process+thread count	4729 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/7/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-15T07:22:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	76	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
0	mvndep	35	Maven dependency ordering for branch
+1	mvninstall	326	master passed
+1	compile	81	master passed
+1	checkstyle	111	master passed
+1	shadedjars	290	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	55	master passed
0	spotbugs	222	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	270	master passed
		_ Patch Compile Tests _
0	mvndep	16	Maven dependency ordering for patch
+1	mvninstall	303	the patch passed
+1	compile	76	the patch passed
+1	javac	76	the patch passed
+1	checkstyle	106	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	276	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	964	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	59	the patch passed
+1	findbugs	345	the patch passed
		_ Other Tests _
+1	unit	171	hbase-common in the patch passed.
-1	unit	14059	hbase-server in the patch failed.
+1	asflicense	78	The patch does not generate ASF License warnings.
		18131

Reason	Tests
Failed junit tests	hadoop.hbase.master.TestMasterOperationsForRegionReplicas
	hadoop.hbase.client.TestFromClientSide

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/8/artifact/out/Dockerfile
GITHUB PR	#483
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 9a4fd6aaf454 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh
git revision	master / `d9d5f69`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/8/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/8/testReport/
Max. process+thread count	4811 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/8/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-15T09:58:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	68	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
0	mvndep	39	Maven dependency ordering for branch
+1	mvninstall	315	master passed
+1	compile	74	master passed
+1	checkstyle	97	master passed
+1	shadedjars	266	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	52	master passed
0	spotbugs	238	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	288	master passed
		_ Patch Compile Tests _
0	mvndep	15	Maven dependency ordering for patch
+1	mvninstall	288	the patch passed
+1	compile	72	the patch passed
+1	javac	72	the patch passed
+1	checkstyle	96	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	260	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	936	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	66	the patch passed
+1	findbugs	327	the patch passed
		_ Other Tests _
+1	unit	182	hbase-common in the patch passed.
-1	unit	20117	hbase-server in the patch failed.
+1	asflicense	61	The patch does not generate ASF License warnings.
		24025

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.client.TestAsyncTableAdminApi
	hadoop.hbase.util.TestFromClientSide3WoUnsafe
	hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
	hadoop.hbase.replication.TestReplicationSmallTests
	hadoop.hbase.tool.TestBulkLoadHFiles
	hadoop.hbase.master.assignment.TestOpenRegionProcedureHang
	hadoop.hbase.master.TestAssignmentManagerMetrics
	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.replication.TestReplicationSmallTestsSync
	hadoop.hbase.client.TestFromClientSide3
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
	hadoop.hbase.tool.TestSecureBulkLoadHFiles
	hadoop.hbase.snapshot.TestFlushSnapshotFromClient

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/9/artifact/out/Dockerfile
GITHUB PR	#483
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux d2cd50ba05d4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh
git revision	master / `8ffc45a`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/9/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/9/testReport/
Max. process+thread count	5034 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/9/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-16T03:16:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	104	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
0	mvndep	34	Maven dependency ordering for branch
+1	mvninstall	327	master passed
+1	compile	83	master passed
+1	checkstyle	111	master passed
+1	shadedjars	284	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	63	master passed
0	spotbugs	306	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	362	master passed
		_ Patch Compile Tests _
0	mvndep	16	Maven dependency ordering for patch
+1	mvninstall	309	the patch passed
+1	compile	83	the patch passed
+1	javac	83	the patch passed
+1	checkstyle	110	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	286	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	988	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	68	the patch passed
+1	findbugs	346	the patch passed
		_ Other Tests _
+1	unit	175	hbase-common in the patch passed.
-1	unit	17779	hbase-server in the patch failed.
+1	asflicense	47	The patch does not generate ASF License warnings.
		21982

Reason	Tests
Failed junit tests	hadoop.hbase.replication.TestReplicationDisableInactivePeer
	hadoop.hbase.client.TestFromClientSide3

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/10/artifact/out/Dockerfile
GITHUB PR	#483
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux cd96b381c3ed 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh
git revision	master / `edf6f68`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/10/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/10/testReport/
Max. process+thread count	4725 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/10/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-16T08:21:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	53	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
0	mvndep	34	Maven dependency ordering for branch
+1	mvninstall	311	master passed
+1	compile	73	master passed
+1	checkstyle	102	master passed
+1	shadedjars	271	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	55	master passed
0	spotbugs	247	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	299	master passed
		_ Patch Compile Tests _
0	mvndep	17	Maven dependency ordering for patch
+1	mvninstall	332	the patch passed
+1	compile	78	the patch passed
+1	javac	78	the patch passed
+1	checkstyle	98	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	271	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	925	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	55	the patch passed
+1	findbugs	305	the patch passed
		_ Other Tests _
+1	unit	182	hbase-common in the patch passed.
-1	unit	18185	hbase-server in the patch failed.
+1	asflicense	47	The patch does not generate ASF License warnings.
		22114

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
	hadoop.hbase.master.procedure.TestProcedurePriority
	hadoop.hbase.master.procedure.TestSCPWithReplicas

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/12/artifact/out/Dockerfile
GITHUB PR	#483
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux edf6a89180a6 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh
git revision	master / `78f5d8e`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/12/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/12/testReport/
Max. process+thread count	4987 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/12/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-16T10:08:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	42	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
0	mvndep	34	Maven dependency ordering for branch
+1	mvninstall	304	master passed
+1	compile	73	master passed
+1	checkstyle	97	master passed
+1	shadedjars	266	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	52	master passed
0	spotbugs	241	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	287	master passed
		_ Patch Compile Tests _
0	mvndep	16	Maven dependency ordering for patch
+1	mvninstall	286	the patch passed
+1	compile	134	the patch passed
+1	javac	134	the patch passed
+1	checkstyle	209	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	262	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	904	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	51	the patch passed
+1	findbugs	293	the patch passed
		_ Other Tests _
+1	unit	181	hbase-common in the patch passed.
+1	unit	8311	hbase-server in the patch passed.
+1	asflicense	42	The patch does not generate ASF License warnings.
		12223

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/13/artifact/out/Dockerfile
GITHUB PR	#483
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux af866be93e4f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh
git revision	master / `94af651`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/13/testReport/
Max. process+thread count	4795 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/13/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-16T15:35:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	207	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
0	mvndep	34	Maven dependency ordering for branch
+1	mvninstall	482	master passed
+1	compile	98	master passed
+1	checkstyle	107	master passed
+1	shadedjars	327	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	58	master passed
0	spotbugs	264	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	316	master passed
		_ Patch Compile Tests _
0	mvndep	19	Maven dependency ordering for patch
+1	mvninstall	351	the patch passed
+1	compile	79	the patch passed
+1	javac	79	the patch passed
+1	checkstyle	97	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	276	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	990	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	55	the patch passed
+1	findbugs	308	the patch passed
		_ Other Tests _
+1	unit	171	hbase-common in the patch passed.
+1	unit	15563	hbase-server in the patch passed.
+1	asflicense	68	The patch does not generate ASF License warnings.
		20053

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/14/artifact/out/Dockerfile
GITHUB PR	#483
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b26c1d90b9d7 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-483/out/precommit/personality/provided.sh
git revision	master / `3eb602c`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/14/testReport/
Max. process+thread count	5079 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-483/14/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

openinx · 2019-08-17T01:25:51Z

I think the patch is good enough now, plan to commit this patch to avoid the daily nosiy from hadoopQA :-)

huonw · 2019-08-18T22:29:36Z

Oh, thanks. I was going to get to the feedback today. Should I open a follow-up pull request that addresses @HorizonNet's comment about the tests?

openinx · 2019-08-19T01:47:11Z

@huonw no need. I've addressed that in the committed patch. Thanks for your contribution.

huonw · 2019-08-19T01:48:21Z

Thank you for doing so!

HBASE-22841 Add more factory functions to TimeRange
b7025bd
These functions make it easier to possible to use `org.apache.hadoop.hbase.client.Table.CheckAndMutateBuilder#timeRange` with more interesting ranges, without being forced to use the deprecated constructors.

HorizonNet reviewed Aug 13, 2019
View reviewed changes

openinx reviewed Aug 14, 2019
View reviewed changes

openinx closed this Aug 17, 2019

huonw deleted the timerange-constructors branch August 18, 2019 22:29

Uh oh!

Conversation

huonw commented Aug 13, 2019

Uh oh!

Apache-HBase commented Aug 13, 2019

Uh oh!

Apache-HBase commented Aug 13, 2019

Uh oh!

Apache-HBase commented Aug 13, 2019

Uh oh!

HorizonNetAug 13, 2019

Choose a reason for hiding this comment

Uh oh!

openinxAug 17, 2019

Choose a reason for hiding this comment

Uh oh!

HorizonNetAug 13, 2019

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Aug 13, 2019

Uh oh!

Apache-HBase commented Aug 14, 2019

Uh oh!

openinx left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Aug 14, 2019

Uh oh!

Apache-HBase commented Aug 15, 2019

Uh oh!

Apache-HBase commented Aug 15, 2019

Uh oh!

Apache-HBase commented Aug 16, 2019

Uh oh!

Apache-HBase commented Aug 16, 2019

Uh oh!

Apache-HBase commented Aug 16, 2019

Uh oh!

Apache-HBase commented Aug 16, 2019

Uh oh!

openinx commented Aug 17, 2019

Uh oh!

huonw commented Aug 18, 2019

Uh oh!

openinx commented Aug 19, 2019

Uh oh!

huonw commented Aug 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants