Skip to content

HBASE-27159 Emit source metrics for BlockCacheExpressHitPercent - #4830

Merged
apurtell merged 2 commits into
apache:masterfrom
d-c-manning:HBASE-27159-blockcache-metrics
Oct 17, 2022
Merged

HBASE-27159 Emit source metrics for BlockCacheExpressHitPercent#4830
apurtell merged 2 commits into
apache:masterfrom
d-c-manning:HBASE-27159-blockcache-metrics

Conversation

@d-c-manning

@d-c-manningd-c-manning commented Oct 15, 2022

Copy link
Copy Markdown
Contributor

@Apache-HBase

Apache-HBase commented Oct 15, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 33smaster passed
+1 💚compile2m 30smaster passed
+1 💚checkstyle0m 35smaster passed
+1 💚spotless0m 39sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 31smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 7sthe patch passed
+1 💚compile2m 31sthe patch passed
-0 ⚠️javac2m 14shbase-server generated 3 new + 190 unchanged - 3 fixed = 193 total (was 193)
-0 ⚠️checkstyle0m 7shbase-hadoop-compat: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck8m 3sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
-1 ❌spotless0m 12spatch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 💚spotbugs1m 42sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
29m 39s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4830
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux abdd3899af53 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0d260f5
Default JavaTemurin-1.8.0_345-b01
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-hadoop-compat.txt
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 16, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 38smaster passed
+1 💚compile0m 53smaster passed
+1 💚shadedjars3m 55sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 41smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 26sthe patch passed
+1 💚compile0m 52sthe patch passed
+1 💚javac0m 52sthe patch passed
+1 💚shadedjars3m 53spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 33sthe patch passed
_ Other Tests _
+1 💚unit0m 33shbase-hadoop-compat in the patch passed.
+1 💚unit195m 17shbase-server in the patch passed.
214m 25s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4830
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f7dda34601e6 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0d260f5
Default JavaEclipse Adoptium-11.0.16.1+1
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/1/testReport/
Max. process+thread count2679 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 16, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 24sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 23smaster passed
+1 💚compile0m 53smaster passed
+1 💚shadedjars3m 47sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 10sthe patch passed
+1 💚compile0m 53sthe patch passed
+1 💚javac0m 53sthe patch passed
+1 💚shadedjars3m 47spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36sthe patch passed
_ Other Tests _
+1 💚unit0m 35shbase-hadoop-compat in the patch passed.
+1 💚unit208m 51shbase-server in the patch passed.
227m 30s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4830
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1f74a9a51ec8 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0d260f5
Default JavaTemurin-1.8.0_345-b01
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/1/testReport/
Max. process+thread count2509 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 16, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 20smaster passed
+1 💚compile2m 31smaster passed
+1 💚checkstyle0m 36smaster passed
+1 💚spotless0m 38sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 31smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 2sthe patch passed
+1 💚compile2m 28sthe patch passed
-0 ⚠️javac2m 12shbase-server generated 3 new + 190 unchanged - 3 fixed = 193 total (was 193)
+1 💚checkstyle0m 34sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck8m 6sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 36spatch has no errors when running spotless:check.
+1 💚spotbugs1m 49sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
29m 42s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4830
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 53c99aa08961 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0d260f5
Default JavaTemurin-1.8.0_345-b01
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 16, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 38smaster passed
+1 💚compile0m 51smaster passed
+1 💚shadedjars3m 58sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 24sthe patch passed
+1 💚compile0m 52sthe patch passed
+1 💚javac0m 52sthe patch passed
+1 💚shadedjars3m 53spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 33sthe patch passed
_ Other Tests _
+1 💚unit0m 33shbase-hadoop-compat in the patch passed.
+1 💚unit196m 3shbase-server in the patch passed.
214m 43s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4830
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8d7b1794fb12 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0d260f5
Default JavaEclipse Adoptium-11.0.16.1+1
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/2/testReport/
Max. process+thread count2679 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 16, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 22sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 7smaster passed
+1 💚compile0m 53smaster passed
+1 💚shadedjars3m 46sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 11sthe patch passed
+1 💚compile0m 54sthe patch passed
+1 💚javac0m 54sthe patch passed
+1 💚shadedjars3m 46spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36sthe patch passed
_ Other Tests _
+1 💚unit0m 34shbase-hadoop-compat in the patch passed.
+1 💚unit209m 3shbase-server in the patch passed.
226m 52s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4830
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b5dda838e304 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0d260f5
Default JavaTemurin-1.8.0_345-b01
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/2/testReport/
Max. process+thread count2533 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4830/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtellapurtell changed the title HBASE-27159 add BlockCache Caching CountsHBASE-27159 Emit source metrics for BlockCacheExpressHitPercentOct 17, 2022
@apurtell
apurtell merged commit 5cacece into apache:masterOct 17, 2022
asfgit pushed a commit that referenced this pull request Oct 17, 2022
@d-c-manning@apurtell
HBASE-27159Emit source metrics for BlockCacheExpressHitPercent (#4830)
fc4191a
Signed-off-by: Andrew Purtell <apurtell@apache.org>
asfgit pushed a commit that referenced this pull request Oct 17, 2022
@d-c-manning@apurtell
HBASE-27159Emit source metrics for BlockCacheExpressHitPercent (#4830)
cbad5f5
Signed-off-by: Andrew Purtell <apurtell@apache.org>
asfgit pushed a commit that referenced this pull request Oct 17, 2022
@d-c-manning@apurtell
HBASE-27159Emit source metrics for BlockCacheExpressHitPercent (#4830)
b9ec644
Signed-off-by: Andrew Purtell <apurtell@apache.org>
@d-c-manning
d-c-manning deleted the HBASE-27159-blockcache-metrics branch October 17, 2022 22:23
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@d-c-manning@apurtell
HBASE-27159 Emit source metrics for BlockCacheExpressHitPercent (apac…
2d641aa
…he#4830)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit cbad5f5)
Change-Id: Ibc524e72ebaa8f9c67dbbf1f13d67c7d36b765e2
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apurtellapurtellapurtell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@d-c-manning@Apache-HBase@apurtell