Skip to content

HBASE-27440 fix table HistogramMetrics leak in table metrics map - #4838

Merged
Apache9 merged 4 commits into
apache:masterfrom
tianliuliu:fixMetricsMapLeak
Oct 24, 2022
Merged

HBASE-27440 fix table HistogramMetrics leak in table metrics map#4838
Apache9 merged 4 commits into
apache:masterfrom
tianliuliu:fixMetricsMapLeak

Conversation

@tianliuliu

Copy link
Copy Markdown
Contributor

image

the method removeHistogramMetrics will cause the metricsMap leak!
because the put op in the map is the baseName but the remove is not , the origin code add the histogramSuffixe follow the baseName when remove.

image

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 41sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 21smaster passed
+1 💚compile0m 46smaster passed
+1 💚shadedjars4m 2sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 33smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
-1 ❌mvninstall0m 36sroot in the patch failed.
-1 ❌compile0m 7shbase-hadoop-compat in the patch failed.
-1 ❌compile0m 36shbase-server in the patch failed.
-0 ⚠️javac0m 7shbase-hadoop-compat in the patch failed.
-0 ⚠️javac0m 36shbase-server in the patch failed.
-1 ❌shadedjars1m 7spatch has 10 errors when building our shaded downstream artifacts.
+1 💚javadoc0m 33sthe patch passed
_ Other Tests _
-1 ❌unit0m 8shbase-hadoop-compat in the patch failed.
-1 ❌unit0m 35shbase-server in the patch failed.
13m 46s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4838
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 07f09a701f02 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5cacece
Default JavaTemurin-1.8.0_345-b01
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjarshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-hadoop-compat.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/testReport/
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 27sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 20smaster passed
+1 💚compile2m 33smaster passed
+1 💚checkstyle0m 35smaster passed
+1 💚spotless0m 39sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 33smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
-1 ❌mvninstall0m 36sroot in the patch failed.
-1 ❌compile0m 6shbase-hadoop-compat in the patch failed.
-1 ❌compile1m 14shbase-server in the patch failed.
-0 ⚠️javac0m 6shbase-hadoop-compat in the patch failed.
-0 ⚠️javac1m 14shbase-server in the patch failed.
-0 ⚠️checkstyle0m 6shbase-hadoop-compat: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
-0 ⚠️checkstyle0m 25shbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌hadoopcheck0m 37sThe patch causes 10 errors with Hadoop v3.2.4.
-1 ❌hadoopcheck1m 15sThe patch causes 10 errors with Hadoop v3.3.4.
-1 ❌spotless0m 10spatch has 24 errors when running spotless:check, run spotless:apply to fix.
-1 ❌spotbugs0m 6shbase-hadoop-compat in the patch failed.
-1 ❌spotbugs0m 27shbase-server in the patch failed.
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
15m 42s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4838
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux f791aa66d8d4 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5cacece
Default JavaTemurin-1.8.0_345-b01
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-compile-hbase-hadoop-compat.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-compile-hbase-hadoop-compat.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-hadoop-compat.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-javac-3.2.4.txt
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-javac-3.3.4.txt
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-spotless.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-hadoop-compat.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 29sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 48smaster passed
+1 💚compile0m 56smaster passed
+1 💚shadedjars4m 13sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
-1 ❌mvninstall0m 46sroot in the patch failed.
-1 ❌compile0m 8shbase-hadoop-compat in the patch failed.
-1 ❌compile0m 42shbase-server in the patch failed.
-0 ⚠️javac0m 8shbase-hadoop-compat in the patch failed.
-0 ⚠️javac0m 42shbase-server in the patch failed.
-1 ❌shadedjars1m 12spatch has 10 errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35sthe patch passed
_ Other Tests _
-1 ❌unit0m 8shbase-hadoop-compat in the patch failed.
-1 ❌unit0m 43shbase-server in the patch failed.
18m 0s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4838
Optional Testsjavac javadoc unit shadedjars compile
unameLinux eb433a063af7 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5cacece
Default JavaEclipse Adoptium-11.0.16.1+1
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjarshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-hadoop-compat.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/testReport/
Max. process+thread count77 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall2m 35smaster passed
+1 💚compile0m 56smaster passed
+1 💚shadedjars4m 6sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
-1 ❌mvninstall0m 45sroot in the patch failed.
-1 ❌compile0m 8shbase-hadoop-compat in the patch failed.
-1 ❌compile0m 41shbase-server in the patch failed.
-0 ⚠️javac0m 8shbase-hadoop-compat in the patch failed.
-0 ⚠️javac0m 41shbase-server in the patch failed.
-1 ❌shadedjars1m 13spatch has 10 errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35sthe patch passed
_ Other Tests _
-1 ❌unit0m 8shbase-hadoop-compat in the patch failed.
-1 ❌unit0m 42shbase-server in the patch failed.
14m 40s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4838
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2e86cd05783f 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dffc8e0
Default JavaEclipse Adoptium-11.0.16.1+1
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjarshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-hadoop-compat.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/testReport/
Max. process+thread count77 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 48sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall2m 4smaster passed
+1 💚compile0m 47smaster passed
+1 💚shadedjars4m 2sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 31smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
-1 ❌mvninstall0m 37sroot in the patch failed.
-1 ❌compile0m 8shbase-hadoop-compat in the patch failed.
-1 ❌compile0m 34shbase-server in the patch failed.
-0 ⚠️javac0m 8shbase-hadoop-compat in the patch failed.
-0 ⚠️javac0m 34shbase-server in the patch failed.
-1 ❌shadedjars1m 7spatch has 10 errors when building our shaded downstream artifacts.
+1 💚javadoc0m 33sthe patch passed
_ Other Tests _
-1 ❌unit0m 7shbase-hadoop-compat in the patch failed.
-1 ❌unit0m 35shbase-server in the patch failed.
16m 29s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4838
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6346cbfbfc72 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dffc8e0
Default JavaTemurin-1.8.0_345-b01
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjarshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-hadoop-compat.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/testReport/
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 1sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 20smaster passed
+1 💚compile2m 34smaster passed
+1 💚checkstyle0m 41smaster passed
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 42smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
-1 ❌mvninstall0m 39sroot in the patch failed.
-1 ❌compile0m 7shbase-hadoop-compat in the patch failed.
-1 ❌compile1m 16shbase-server in the patch failed.
-0 ⚠️javac0m 7shbase-hadoop-compat in the patch failed.
-0 ⚠️javac1m 16shbase-server in the patch failed.
-0 ⚠️checkstyle0m 7shbase-hadoop-compat: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
-0 ⚠️checkstyle0m 28shbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌hadoopcheck0m 42sThe patch causes 10 errors with Hadoop v3.2.4.
-1 ❌hadoopcheck1m 25sThe patch causes 10 errors with Hadoop v3.3.4.
-1 ❌spotless0m 12spatch has 24 errors when running spotless:check, run spotless:apply to fix.
-1 ❌spotbugs0m 8shbase-hadoop-compat in the patch failed.
-1 ❌spotbugs0m 30shbase-server in the patch failed.
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
21m 8s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4838
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 4e6287f2be66 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dffc8e0
Default JavaTemurin-1.8.0_345-b01
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-compile-hbase-hadoop-compat.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-compile-hbase-hadoop-compat.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-hadoop-compat.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-javac-3.2.4.txt
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-javac-3.3.4.txt
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-spotless.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-hadoop-compat.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
Max. process+thread count60 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tianliuliutianliuliu changed the title fix table HistogramMetrics leak in table metrics mapHBASE-27439 fix table HistogramMetrics leak in table metrics mapOct 21, 2022
@tianliuliutianliuliu changed the title HBASE-27439 fix table HistogramMetrics leak in table metrics mapHBASE-27440 fix table HistogramMetrics leak in table metrics mapOct 21, 2022
metricsMap.clear();
}

@VisibleForTesting

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not allow VisibleForTesting annotation now.

Please use RestrictedApi to restrict the usage.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thx

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Apache9 I've already changed it, pls help me review, thx a lot!

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 32sMaven dependency ordering for branch
+1 💚mvninstall2m 34smaster passed
+1 💚compile2m 30smaster passed
+1 💚checkstyle0m 34smaster passed
+1 💚spotless0m 37sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 30smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 14sthe patch passed
+1 💚compile2m 31sthe patch passed
+1 💚javac2m 31sthe patch passed
-0 ⚠️checkstyle0m 7shbase-hadoop-compat: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️checkstyle0m 27shbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck8m 11sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
-1 ❌spotless0m 12spatch has 33 errors when running spotless:check, run spotless:apply to fix.
+1 💚spotbugs1m 44sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
30m 15s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4838
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 72d0fd44d05a 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dad9a7d
Default JavaTemurin-1.8.0_345-b01
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-hadoop-compat.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/3/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count60 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
Contributor

Please run mvn spotless:apply to fix the style error.

@tianliuliu

Copy link
Copy Markdown
ContributorAuthor

Please run mvn spotless:apply to fix the style error.

done, thx very mush

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 31sMaven dependency ordering for branch
+1 💚mvninstall2m 33smaster passed
+1 💚compile0m 56smaster passed
+1 💚shadedjars4m 5sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 29sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚shadedjars4m 8spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37sthe patch passed
_ Other Tests _
+1 💚unit0m 34shbase-hadoop-compat in the patch passed.
+1 💚unit200m 45shbase-server in the patch passed.
220m 36s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4838
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 783dd7edad1c 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dad9a7d
Default JavaEclipse Adoptium-11.0.16.1+1
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/3/testReport/
Max. process+thread count2730 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 41sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 23smaster passed
+1 💚compile0m 47smaster passed
+1 💚shadedjars4m 8sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 33smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 7sthe patch passed
+1 💚compile0m 47sthe patch passed
+1 💚javac0m 47sthe patch passed
+1 💚shadedjars4m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 33sthe patch passed
_ Other Tests _
+1 💚unit0m 30shbase-hadoop-compat in the patch passed.
+1 💚unit209m 49shbase-server in the patch passed.
228m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4838
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 11559ba788f2 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dad9a7d
Default JavaTemurin-1.8.0_345-b01
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/3/testReport/
Max. process+thread count2888 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 2sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall2m 8smaster passed
+1 💚compile2m 32smaster passed
+1 💚checkstyle0m 40smaster passed
+1 💚spotless0m 39sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 37smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 9sthe patch passed
+1 💚compile2m 34sthe patch passed
+1 💚javac2m 34sthe patch passed
+1 💚checkstyle0m 39sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck7m 51sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 40spatch has no errors when running spotless:check.
+1 💚spotbugs1m 52sthe patch passed
_ Other Tests _
+1 💚asflicense0m 19sThe patch does not generate ASF License warnings.
30m 39s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4838
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 7c24cc426363 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2fc879e
Default JavaTemurin-1.8.0_345-b01
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall2m 7smaster passed
+1 💚compile0m 47smaster passed
+1 💚shadedjars4m 5sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 32smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 11sthe patch passed
+1 💚compile0m 46sthe patch passed
+1 💚javac0m 46sthe patch passed
+1 💚shadedjars4m 8spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 32sthe patch passed
_ Other Tests _
+1 💚unit0m 30shbase-hadoop-compat in the patch passed.
+1 💚unit210m 13shbase-server in the patch passed.
228m 34s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4838
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 28b222c72a44 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2fc879e
Default JavaTemurin-1.8.0_345-b01
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/testReport/
Max. process+thread count2703 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 52smaster passed
+1 💚compile0m 57smaster passed
+1 💚shadedjars4m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 44sthe patch passed
+1 💚compile0m 56sthe patch passed
+1 💚javac0m 56sthe patch passed
+1 💚shadedjars4m 8spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35sthe patch passed
_ Other Tests _
+1 💚unit0m 34shbase-hadoop-compat in the patch passed.
+1 💚unit217m 17shbase-server in the patch passed.
237m 35s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4838
Optional Testsjavac javadoc unit shadedjars compile
unameLinux fd5d2c65a68c 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2fc879e
Default JavaEclipse Adoptium-11.0.16.1+1
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/testReport/
Max. process+thread count3111 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit d187f69 into apache:masterOct 24, 2022
Apache9 pushed a commit that referenced this pull request Oct 24, 2022
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit d187f69)
Apache9 pushed a commit that referenced this pull request Oct 24, 2022
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit d187f69)
Apache9 pushed a commit that referenced this pull request Oct 24, 2022
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit d187f69)
bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Nov 18, 2022
…e metrics map (apache#4838)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit d187f69)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
…che#4838)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit d187f69)
(cherry picked from commit 098e598)
Change-Id: I059d2e9d479f72a2d9c1eade95a492142d69d321
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tianliuliu@Apache-HBase@Apache9