Skip to content

HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… - #484

Merged
Reidddddd merged 4 commits into
apache:branch-1.3from
eomiks:branch-1.3
Aug 23, 2019
Merged

HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…#484
Reidddddd merged 4 commits into
apache:branch-1.3from
eomiks:branch-1.3

Conversation

@eomiks

@eomikseomiks commented Aug 13, 2019

Copy link
Copy Markdown
Contributor

HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)

Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError of scan order check.

which is resolved by HBASE-19863 for 1.4, 2.x, or later version.

A same bug exists in branch 1.3 and older, and also my cluster suffered from the same problem.

When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
actual hfs offset can be behind, in this case heap.next() is not enough. it requires reseek to find right next cell.

java.lang.AssertionError: Key key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969) at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551) at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081) at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755) at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957) at org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168) 

I created a backport patch of HBASE-19863and a part of HBASE-17958.

Exact same testcase included. And changed StoreScanner due to the difference of codes.

…ilter could throw AssertionError (backport of HBASE-19863)
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec86Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1mvninstall433branch-1.3 passed
+1compile41branch-1.3 passed
+1checkstyle112branch-1.3 passed
-1shadedjars12branch has 10 errors when building our shaded downstream artifacts.
+1javadoc39branch-1.3 passed
0spotbugs147Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs144branch-1.3 passed
_ Patch Compile Tests _
+1mvninstall108the patch passed
+1compile43the patch passed
+1javac43the patch passed
-1checkstyle104hbase-server: The patch generated 4 new + 371 unchanged - 24 fixed = 375 total (was 395)
+1whitespace0The patch has no whitespace issues.
-1shadedjars10patch has 10 errors when building our shaded downstream artifacts.
+1hadoopcheck655Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1javadoc38the patch passed
+1findbugs160the patch passed
_ Other Tests _
-1unit8170hbase-server in the patch failed.
+1asflicense25The patch does not generate ASF License warnings.
10278
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestScannerHeartbeatMessages
hadoop.hbase.regionserver.TestCompactSplitThread
hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL
hadoop.hbase.client.TestAdmin2
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/1/artifact/out/Dockerfile
GITHUB PR#484
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 0b9b50f3ca6e 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revisionbranch-1.3 / 8e5e868
Default Java1.8.0_222
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/1/artifact/out/branch-shadedjars.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/1/artifact/out/diff-checkstyle-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/1/artifact/out/patch-shadedjars.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/1/testReport/
Max. process+thread count4339 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/1/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…ilter could throw AssertionError (backport of HBASE-19863)
+ checkstyle adapted.
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec47Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1mvninstall435branch-1.3 passed
+1compile36branch-1.3 passed with JDK v1.8.0_222
+1compile39branch-1.3 passed with JDK v1.7.0_232
+1checkstyle98branch-1.3 passed
+1shadedjars150branch has no errors when building our shaded downstream artifacts.
+1javadoc35branch-1.3 passed with JDK v1.8.0_222
+1javadoc36branch-1.3 passed with JDK v1.7.0_232
0spotbugs168Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs165branch-1.3 passed
_ Patch Compile Tests _
+1mvninstall99the patch passed
+1compile38the patch passed with JDK v1.8.0_222
+1javac38the patch passed
+1compile40the patch passed with JDK v1.7.0_232
+1javac40the patch passed
-1checkstyle86hbase-server: The patch generated 4 new + 371 unchanged - 24 fixed = 375 total (was 395)
+1whitespace0The patch has no whitespace issues.
+1shadedjars144patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck537Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1javadoc28the patch passed with JDK v1.8.0_222
+1javadoc36the patch passed with JDK v1.7.0_232
+1findbugs161the patch passed
_ Other Tests _
+1unit5647hbase-server in the patch passed.
+1asflicense25The patch does not generate ASF License warnings.
7970
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/2/artifact/out/Dockerfile
GITHUB PR#484
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 9837e6ce7dd8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revisionbranch-1.3 / 18c5abe
Default Java1.7.0_232
Multi-JDK versions/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/2/artifact/out/diff-checkstyle-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/2/testReport/
Max. process+thread count3820 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/2/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec953Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1mvninstall443branch-1.3 passed
+1compile38branch-1.3 passed with JDK v1.8.0_222
+1compile43branch-1.3 passed with JDK v1.7.0_232
+1checkstyle105branch-1.3 passed
+1shadedjars169branch has no errors when building our shaded downstream artifacts.
+1javadoc37branch-1.3 passed with JDK v1.8.0_222
+1javadoc42branch-1.3 passed with JDK v1.7.0_232
0spotbugs178Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs175branch-1.3 passed
_ Patch Compile Tests _
+1mvninstall114the patch passed
+1compile42the patch passed with JDK v1.8.0_222
+1javac42the patch passed
+1compile44the patch passed with JDK v1.7.0_232
+1javac44the patch passed
-1checkstyle97hbase-server: The patch generated 1 new + 372 unchanged - 23 fixed = 373 total (was 395)
+1whitespace0The patch has no whitespace issues.
+1shadedjars158patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck580Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1javadoc30the patch passed with JDK v1.8.0_222
+1javadoc44the patch passed with JDK v1.7.0_232
+1findbugs179the patch passed
_ Other Tests _
-1unit5856hbase-server in the patch failed.
+1asflicense21The patch does not generate ASF License warnings.
9270
ReasonTests
Failed junit testshadoop.hbase.util.TestHBaseFsck
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/3/artifact/out/Dockerfile
GITHUB PR#484
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 487830f1ae51 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revisionbranch-1.3 / 18c5abe
Default Java1.7.0_232
Multi-JDK versions/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/3/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/3/testReport/
Max. process+thread count3996 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/3/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…ilter could throw AssertionError (backport of HBASE-19863)
+ checkstyle adapted.
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec1556Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1mvninstall437branch-1.3 passed
+1compile42branch-1.3 passed
+1checkstyle116branch-1.3 passed
-1shadedjars13branch has 10 errors when building our shaded downstream artifacts.
+1javadoc40branch-1.3 passed
0spotbugs156Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs153branch-1.3 passed
_ Patch Compile Tests _
+1mvninstall110the patch passed
+1compile43the patch passed
+1javac43the patch passed
-1checkstyle111hbase-server: The patch generated 1 new + 372 unchanged - 23 fixed = 373 total (was 395)
+1whitespace0The patch has no whitespace issues.
-1shadedjars11patch has 10 errors when building our shaded downstream artifacts.
+1hadoopcheck585Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1javadoc30the patch passed
+1findbugs262the patch passed
_ Other Tests _
-1unit9089hbase-server in the patch failed.
+1asflicense133The patch does not generate ASF License warnings.
12912
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestEncryptionKeyRotation
hadoop.hbase.regionserver.TestRegionReplicas
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/artifact/out/Dockerfile
GITHUB PR#484
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux a112393a1bb9 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revisionbranch-1.3 / d2b310b
Default Java1.8.0_222
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/artifact/out/branch-shadedjars.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/artifact/out/diff-checkstyle-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/artifact/out/patch-shadedjars.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/testReport/
Max. process+thread count3809 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec55Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1mvninstall438branch-1.3 passed
+1compile37branch-1.3 passed with JDK v1.8.0_222
+1compile39branch-1.3 passed with JDK v1.7.0_232
+1checkstyle94branch-1.3 passed
+1shadedjars151branch has no errors when building our shaded downstream artifacts.
+1javadoc36branch-1.3 passed with JDK v1.8.0_222
+1javadoc39branch-1.3 passed with JDK v1.7.0_232
0spotbugs161Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs158branch-1.3 passed
_ Patch Compile Tests _
+1mvninstall98the patch passed
+1compile36the patch passed with JDK v1.8.0_222
+1javac36the patch passed
+1compile37the patch passed with JDK v1.7.0_232
+1javac37the patch passed
+1checkstyle86hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1whitespace0The patch has no whitespace issues.
+1shadedjars144patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck534Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1javadoc32the patch passed with JDK v1.8.0_222
+1javadoc38the patch passed with JDK v1.7.0_232
+1findbugs156the patch passed
_ Other Tests _
+1unit5580hbase-server in the patch passed.
+1asflicense29The patch does not generate ASF License warnings.
7920
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/5/artifact/out/Dockerfile
GITHUB PR#484
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux ea2a6c88e389 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revisionbranch-1.3 / d2b310b
Default Java1.7.0_232
Multi-JDK versions/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/5/testReport/
Max. process+thread count4223 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/5/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec159Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1mvninstall485branch-1.3 passed
+1compile55branch-1.3 passed
+1checkstyle126branch-1.3 passed
-1shadedjars15branch has 10 errors when building our shaded downstream artifacts.
+1javadoc57branch-1.3 passed
0spotbugs183Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs179branch-1.3 passed
_ Patch Compile Tests _
+1mvninstall151the patch passed
+1compile54the patch passed
+1javac54the patch passed
+1checkstyle122hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1whitespace0The patch has no whitespace issues.
-1shadedjars12patch has 10 errors when building our shaded downstream artifacts.
+1hadoopcheck676Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1javadoc39the patch passed
+1findbugs176the patch passed
_ Other Tests _
-1unit9407hbase-server in the patch failed.
+1asflicense22The patch does not generate ASF License warnings.
11838
ReasonTests
Failed junit testshadoop.hbase.snapshot.TestFlushSnapshotFromClient
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/artifact/out/Dockerfile
GITHUB PR#484
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux c2b8c7ef6615 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revisionbranch-1.3 / b97621b
Default Java1.8.0_222
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/artifact/out/branch-shadedjars.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/artifact/out/patch-shadedjars.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/testReport/
Max. process+thread count4499 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec3163Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1mvninstall465branch-1.3 passed
+1compile52branch-1.3 passed with JDK v1.8.0_222
+1compile52branch-1.3 passed with JDK v1.7.0_232
+1checkstyle127branch-1.3 passed
+1shadedjars206branch has no errors when building our shaded downstream artifacts.
+1javadoc41branch-1.3 passed with JDK v1.8.0_222
+1javadoc49branch-1.3 passed with JDK v1.7.0_232
0spotbugs213Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs209branch-1.3 passed
_ Patch Compile Tests _
+1mvninstall131the patch passed
+1compile46the patch passed with JDK v1.8.0_222
+1javac46the patch passed
+1compile50the patch passed with JDK v1.7.0_232
+1javac50the patch passed
+1checkstyle119hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1whitespace0The patch has no whitespace issues.
+1shadedjars199patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck666Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1javadoc33the patch passed with JDK v1.8.0_222
+1javadoc50the patch passed with JDK v1.7.0_232
+1findbugs212the patch passed
_ Other Tests _
-1unit14119hbase-server in the patch failed.
+1asflicense168The patch does not generate ASF License warnings.
20347
ReasonTests
Failed junit testshadoop.hbase.master.handler.TestEnableTableHandler
hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS
hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster
hadoop.hbase.regionserver.TestRegionReplicaFailover
hadoop.hbase.snapshot.TestFlushSnapshotFromClient
hadoop.hbase.client.TestAdmin2
hadoop.hbase.regionserver.TestEncryptionKeyRotation
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/6/artifact/out/Dockerfile
GITHUB PR#484
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux ddcf2e148861 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revisionbranch-1.3 / b97621b
Default Java1.7.0_232
Multi-JDK versions/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/6/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/6/testReport/
Max. process+thread count3815 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/6/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec111Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1mvninstall528branch-1.3 passed
+1compile95branch-1.3 passed
+1checkstyle186branch-1.3 passed
-1shadedjars50branch has 10 errors when building our shaded downstream artifacts.
+1javadoc58branch-1.3 passed
0spotbugs155Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs153branch-1.3 passed
_ Patch Compile Tests _
+1mvninstall102the patch passed
+1compile47the patch passed
+1javac47the patch passed
+1checkstyle115hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1whitespace0The patch has no whitespace issues.
-1shadedjars10patch has 10 errors when building our shaded downstream artifacts.
+1hadoopcheck692Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1javadoc78the patch passed
+1findbugs303the patch passed
_ Other Tests _
-1unit3425hbase-server in the patch failed.
+1asflicense14The patch does not generate ASF License warnings.
6090
ReasonTests
Failed junit testshadoop.hbase.ipc.TestSimpleRpcScheduler
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/8/artifact/out/Dockerfile
GITHUB PR#484
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 3f84772d5107 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revisionbranch-1.3 / f8695bb
Default Java1.8.0_222
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/8/artifact/out/branch-shadedjars.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/8/artifact/out/patch-shadedjars.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/8/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/8/testReport/
Max. process+thread count708 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/8/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Reidddddd

Reidddddd commented Aug 16, 2019

Copy link
Copy Markdown
Contributor

Backport HBASE-19863?

First skimmed(not in detailed), looks like they are quite different?

@eomiks

eomiks commented Aug 16, 2019

Copy link
Copy Markdown
ContributorAuthor

@Reidddddd
at first, I thought backporting HBASE-19863 would make all the problem go away so I wrote that description. But through some tests and new patches, I realized there's more (bugs & patches for 1.4) there.

So, yeah. My first description was not updated property.
this is not simple backport of HBASE-19863. It's the backport of HBASE-19863 and a part of HBASE-17958 related to storeScanner SEEK/SKIP

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec1720Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1mvninstall483branch-1.3 passed
+1compile47branch-1.3 passed with JDK v1.8.0_222
+1compile49branch-1.3 passed with JDK v1.7.0_232
+1checkstyle112branch-1.3 passed
+1shadedjars201branch has no errors when building our shaded downstream artifacts.
+1javadoc41branch-1.3 passed with JDK v1.8.0_222
+1javadoc49branch-1.3 passed with JDK v1.7.0_232
0spotbugs209Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs205branch-1.3 passed
_ Patch Compile Tests _
+1mvninstall135the patch passed
+1compile46the patch passed with JDK v1.8.0_222
+1javac46the patch passed
+1compile53the patch passed with JDK v1.7.0_232
+1javac53the patch passed
+1checkstyle114hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1whitespace0The patch has no whitespace issues.
+1shadedjars215patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck672Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1javadoc33the patch passed with JDK v1.8.0_222
+1javadoc47the patch passed with JDK v1.7.0_232
+1findbugs210the patch passed
_ Other Tests _
-1unit8895hbase-server in the patch failed.
+1asflicense57The patch does not generate ASF License warnings.
13483
ReasonTests
Failed junit testshadoop.hbase.master.cleaner.TestSnapshotFromMaster
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
hadoop.hbase.replication.TestReplicationChangingPeerRegionservers
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/9/artifact/out/Dockerfile
GITHUB PR#484
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 2ca049f4c67a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revisionbranch-1.3 / 3351124
Default Java1.7.0_232
Multi-JDK versions/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/9/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/9/testReport/
Max. process+thread count3943 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/9/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec2213Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1mvninstall476branch-1.3 passed
+1compile53branch-1.3 passed
+1checkstyle128branch-1.3 passed
-1shadedjars16branch has 10 errors when building our shaded downstream artifacts.
+1javadoc44branch-1.3 passed
0spotbugs170Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs167branch-1.3 passed
_ Patch Compile Tests _
+1mvninstall139the patch passed
+1compile54the patch passed
+1javac54the patch passed
+1checkstyle122hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1whitespace0The patch has no whitespace issues.
-1shadedjars13patch has 10 errors when building our shaded downstream artifacts.
+1hadoopcheck712Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1javadoc39the patch passed
+1findbugs174the patch passed
_ Other Tests _
-1unit7889hbase-server in the patch failed.
+1asflicense23The patch does not generate ASF License warnings.
12369
ReasonTests
Failed junit testshadoop.hbase.TestPartialResultsFromClientSide
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/10/artifact/out/Dockerfile
GITHUB PR#484
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux bfee842652dd 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revisionbranch-1.3 / 2bb4a91
Default Java1.8.0_222
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/10/artifact/out/branch-shadedjars.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/10/artifact/out/patch-shadedjars.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/10/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/10/testReport/
Max. process+thread count4623 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/10/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec109Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1mvninstall460branch-1.3 passed
+1compile39branch-1.3 passed
+1checkstyle110branch-1.3 passed
-1shadedjars11branch has 10 errors when building our shaded downstream artifacts.
+1javadoc37branch-1.3 passed
0spotbugs140Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs138branch-1.3 passed
_ Patch Compile Tests _
+1mvninstall119the patch passed
+1compile39the patch passed
+1javac39the patch passed
+1checkstyle105hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1whitespace0The patch has no whitespace issues.
-1shadedjars10patch has 10 errors when building our shaded downstream artifacts.
+1hadoopcheck592Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1javadoc30the patch passed
+1findbugs144the patch passed
_ Other Tests _
-1unit7415hbase-server in the patch failed.
+1asflicense26The patch does not generate ASF License warnings.
9478
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestCompactSplitThread
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/11/artifact/out/Dockerfile
GITHUB PR#484
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 220bf1eff47d 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484@2/out/precommit/personality/provided.sh
git revisionbranch-1.3 / 102fbb5
Default Java1.8.0_222
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/11/artifact/out/branch-shadedjars.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/11/artifact/out/patch-shadedjars.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/11/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/11/testReport/
Max. process+thread count4496 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/11/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec78Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
-1mvninstall391root in branch-1.3 failed.
-1compile41hbase-server in branch-1.3 failed.
+1checkstyle108branch-1.3 passed
-1shadedjars12branch has 10 errors when building our shaded downstream artifacts.
+1javadoc39branch-1.3 passed
0spotbugs90Used deprecated FindBugs config; considering switching to SpotBugs.
-1findbugs38hbase-server in branch-1.3 failed.
_ Patch Compile Tests _
-1mvninstall71root in the patch failed.
-1compile40hbase-server in the patch failed.
-1javac40hbase-server in the patch failed.
+1checkstyle105hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1whitespace0The patch has no whitespace issues.
-1shadedjars10patch has 10 errors when building our shaded downstream artifacts.
-1hadoopcheck98The patch causes 18 errors with Hadoop v2.4.1.
-1hadoopcheck203The patch causes 18 errors with Hadoop v2.5.2.
-1hadoopcheck314The patch causes 18 errors with Hadoop v2.6.5.
-1hadoopcheck419The patch causes 18 errors with Hadoop v2.7.7.
+1javadoc30the patch passed
-1findbugs38hbase-server in the patch failed.
_ Other Tests _
-1unit39hbase-server in the patch failed.
+1asflicense13The patch does not generate ASF License warnings.
1546
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/Dockerfile
GITHUB PR#484
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 3f5ab43128fa 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revisionbranch-1.3 / ca0390c
Default Java1.8.0_222
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/branch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/branch-compile-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/branch-shadedjars.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/branch-findbugs-hbase-server.txt
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-compile-hbase-server.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-compile-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-javac-2.4.1.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-javac-2.5.2.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-javac-2.6.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-javac-2.7.7.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-findbugs-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/testReport/
Max. process+thread count77 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/console
versionsgit=1.9.1 maven=3.0.5
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…ilter could throw AssertionError (backport of HBASE-19863)
+ add a line at the end of file
@Reidddddd

Copy link
Copy Markdown
Contributor

LGTM.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec1968Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1mvninstall454branch-1.3 passed
+1compile41branch-1.3 passed with JDK v1.8.0_222
+1compile41branch-1.3 passed with JDK v1.7.0_232
+1checkstyle99branch-1.3 passed
+1shadedjars160branch has no errors when building our shaded downstream artifacts.
+1javadoc40branch-1.3 passed with JDK v1.8.0_222
+1javadoc43branch-1.3 passed with JDK v1.7.0_232
0spotbugs181Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs177branch-1.3 passed
_ Patch Compile Tests _
+1mvninstall112the patch passed
+1compile41the patch passed with JDK v1.8.0_222
+1javac41the patch passed
+1compile41the patch passed with JDK v1.7.0_232
+1javac41the patch passed
+1checkstyle90hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1whitespace0The patch has no whitespace issues.
+1shadedjars197patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck764Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1javadoc40the patch passed with JDK v1.8.0_222
+1javadoc42the patch passed with JDK v1.7.0_232
+1findbugs186the patch passed
_ Other Tests _
-1unit10107hbase-server in the patch failed.
+1asflicense24The patch does not generate ASF License warnings.
14772
ReasonTests
Failed junit testshadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
hadoop.hbase.regionserver.TestEncryptionKeyRotation
hadoop.hbase.regionserver.TestSplitTransactionOnCluster
hadoop.hbase.master.TestAssignmentManagerOnCluster
hadoop.hbase.client.TestFromClientSideWithCoprocessor
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/14/artifact/out/Dockerfile
GITHUB PR#484
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux e4a90bd4c2a3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revisionbranch-1.3 / 40cf771
Default Java1.7.0_232
Multi-JDK versions/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/14/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/14/testReport/
Max. process+thread count3932 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/14/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec1234Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1mvninstall456branch-1.3 passed
+1compile36branch-1.3 passed with JDK v1.8.0_222
+1compile40branch-1.3 passed with JDK v1.7.0_232
+1checkstyle91branch-1.3 passed
+1shadedjars153branch has no errors when building our shaded downstream artifacts.
+1javadoc36branch-1.3 passed with JDK v1.8.0_222
+1javadoc39branch-1.3 passed with JDK v1.7.0_232
0spotbugs167Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs164branch-1.3 passed
_ Patch Compile Tests _
+1mvninstall122the patch passed
+1compile35the patch passed with JDK v1.8.0_222
+1javac35the patch passed
+1compile42the patch passed with JDK v1.7.0_232
+1javac42the patch passed
+1checkstyle90hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1whitespace0The patch has no whitespace issues.
+1shadedjars146patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck636Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1javadoc26the patch passed with JDK v1.8.0_222
+1javadoc38the patch passed with JDK v1.7.0_232
+1findbugs162the patch passed
_ Other Tests _
+1unit7054hbase-server in the patch passed.
+1asflicense23The patch does not generate ASF License warnings.
10718
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/16/artifact/out/Dockerfile
GITHUB PR#484
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux d5e71ad519e1 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revisionbranch-1.3 / cd7bf70
Default Java1.7.0_232
Multi-JDK versions/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/16/testReport/
Max. process+thread count3807 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/16/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec48Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1mvninstall450branch-1.3 passed
+1compile43branch-1.3 passed
+1checkstyle110branch-1.3 passed
-1shadedjars12branch has 10 errors when building our shaded downstream artifacts.
+1javadoc40branch-1.3 passed
0spotbugs148Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs146branch-1.3 passed
_ Patch Compile Tests _
+1mvninstall113the patch passed
+1compile41the patch passed
+1javac41the patch passed
+1checkstyle104hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1whitespace0The patch has no whitespace issues.
-1shadedjars10patch has 10 errors when building our shaded downstream artifacts.
+1hadoopcheck586Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1javadoc31the patch passed
+1findbugs143the patch passed
_ Other Tests _
-1unit6651hbase-server in the patch failed.
+1asflicense28The patch does not generate ASF License warnings.
8644
ReasonTests
Failed junit testshadoop.hbase.trace.TestHTraceHooks
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/artifact/out/Dockerfile
GITHUB PR#484
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 2b6815fa53f6 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revisionbranch-1.3 / 6a0c26f
Default Java1.8.0_222
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/artifact/out/branch-shadedjars.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/artifact/out/patch-shadedjars.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/testReport/
Max. process+thread count4246 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Reidddddd
Reidddddd merged commit 957d968 into apache:branch-1.3Aug 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@eomiks@Apache-HBase@Reidddddd