Skip to content

HBASE-27444 Add tool commands list_enabled_tables and list_disabled_tables - #4849

Merged
Apache9 merged 3 commits into
apache:masterfrom
2005hithlj:HBASE-27444
Nov 5, 2022
Merged

HBASE-27444 Add tool commands list_enabled_tables and list_disabled_tables#4849
Apache9 merged 3 commits into
apache:masterfrom
2005hithlj:HBASE-27444

Conversation

@2005hithlj

@2005hithlj2005hithlj commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

@Apache-HBase

Apache-HBase commented Oct 26, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 2sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 1sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 21smaster passed
+1 💚compile4m 46smaster passed
+1 💚checkstyle1m 27smaster passed
+1 💚spotless0m 41sbranch has no errors when running spotless:check.
+1 💚spotbugs5m 18smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 12sthe patch passed
+1 💚compile4m 51sthe patch passed
+1 💚cc4m 51sthe patch passed
+1 💚javac4m 51sthe patch passed
+1 💚checkstyle1m 24sthe patch passed
-0 ⚠️rubocop0m 6sThe patch generated 6 new + 427 unchanged - 0 fixed = 433 total (was 427)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck7m 52sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚hbaseprotoc1m 55sthe patch passed
+1 💚spotless0m 40spatch has no errors when running spotless:check.
+1 💚spotbugs5m 45sthe patch passed
_ Other Tests _
+1 💚asflicense0m 46sThe patch does not generate ASF License warnings.
47m 28s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4849
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux ba05ac4858c7 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5e251c4
Default JavaTemurin-1.8.0_345-b01
rubocophttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.7.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 26, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 18smaster passed
+1 💚compile2m 2smaster passed
+1 💚shadedjars3m 47sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 25smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 9sthe patch passed
+1 💚compile2m 1sthe patch passed
+1 💚javac2m 1sthe patch passed
+1 💚shadedjars3m 47spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 22sthe patch passed
_ Other Tests _
+1 💚unit0m 30shbase-protocol-shaded in the patch passed.
+1 💚unit1m 13shbase-client in the patch passed.
-1 ❌unit219m 8shbase-server in the patch failed.
+1 💚unit8m 37shbase-thrift in the patch passed.
+1 💚unit7m 44shbase-shell in the patch passed.
260m 12s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4849
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3ee934004731 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5e251c4
Default JavaTemurin-1.8.0_345-b01
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/1/testReport/
Max. process+thread count2903 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 reviewed Oct 27, 2022
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to add a method to list enabled or disabled tables, just a flag to indicate enabled or disabled table? And also better add a method for listing table descriptors?

@2005hithlj2005hithlj reopened this Oct 28, 2022
@2005hithlj

2005hithlj commented Oct 28, 2022

Copy link
Copy Markdown
ContributorAuthor

Is it better to add a method to list enabled or disabled tables, just a flag to indicate enabled or disabled table? And also better add a method for listing table descriptors?

@Apache9 sir. Thanks for your review, I will have a new commit.

@2005hithlj2005hithlj changed the title HBASE-27444 Add a tool command list_disabled_tablesHBASE-27444 Add tool commands list_enabled_tables and list_disabled_tablesOct 31, 2022
@Apache-HBase

Apache-HBase commented Oct 31, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 19smaster passed
+1 💚compile4m 26smaster passed
+1 💚checkstyle1m 15smaster passed
+1 💚spotless0m 39sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 59smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 25sthe patch passed
+1 💚compile5m 1sthe patch passed
+1 💚cc5m 1sthe patch passed
+1 💚javac5m 1sthe patch passed
-0 ⚠️checkstyle0m 15shbase-client: The patch generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22)
-0 ⚠️rubocop0m 17sThe patch generated 9 new + 427 unchanged - 0 fixed = 436 total (was 427)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck8m 28sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚hbaseprotoc1m 46sthe patch passed
+1 💚spotless0m 37spatch has no errors when running spotless:check.
+1 💚spotbugs5m 39sthe patch passed
_ Other Tests _
+1 💚asflicense0m 35sThe patch does not generate ASF License warnings.
46m 47s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4849
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux ea4720d9ffbb 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dc4fa05
Default JavaTemurin-1.8.0_345-b01
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
rubocophttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.7.3 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 31, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 14smaster passed
+1 💚compile2m 22smaster passed
+1 💚shadedjars3m 51sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 36smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 43sthe patch passed
+1 💚compile2m 40sthe patch passed
+1 💚javac2m 40sthe patch passed
+1 💚shadedjars4m 1spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 36sthe patch passed
_ Other Tests _
+1 💚unit0m 38shbase-protocol-shaded in the patch passed.
+1 💚unit1m 31shbase-client in the patch passed.
+1 💚unit204m 14shbase-server in the patch passed.
+1 💚unit7m 4shbase-thrift in the patch passed.
+1 💚unit6m 53shbase-shell in the patch passed.
245m 10s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4849
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e68202ea112a 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dc4fa05
Default JavaEclipse Adoptium-11.0.16.1+1
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/2/testReport/
Max. process+thread count2715 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@2005hithlj

2005hithlj commented Nov 1, 2022

Copy link
Copy Markdown
ContributorAuthor

@Apache9 sir. Could you take a look? Thanks.

Apache9
Apache9 reviewed Nov 1, 2022
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No shell tests?

@2005hithlj

2005hithlj commented Nov 1, 2022

Copy link
Copy Markdown
ContributorAuthor

No shell tests?

@Apache9 sir, I have added shell tests.

@Apache-HBase

Apache-HBase commented Nov 1, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 19smaster passed
+1 💚compile4m 22smaster passed
+1 💚checkstyle1m 15smaster passed
+1 💚spotless0m 39sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 59smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall2m 7sthe patch passed
+1 💚compile4m 26sthe patch passed
+1 💚cc4m 26sthe patch passed
+1 💚javac4m 26sthe patch passed
-0 ⚠️checkstyle0m 12shbase-client: The patch generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22)
-0 ⚠️rubocop0m 10sThe patch generated 17 new + 431 unchanged - 0 fixed = 448 total (was 431)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck7m 58sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚hbaseprotoc1m 33sthe patch passed
+1 💚spotless0m 36spatch has no errors when running spotless:check.
+1 💚spotbugs5m 27sthe patch passed
_ Other Tests _
+1 💚asflicense0m 35sThe patch does not generate ASF License warnings.
47m 26s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4849
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux fb4e1d30a201 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3f17745
Default JavaTemurin-1.8.0_352-b08
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
rubocophttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count69 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 1, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 28sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall2m 28smaster passed
+1 💚compile2m 20smaster passed
+1 💚shadedjars3m 46sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 32smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 32sthe patch passed
+1 💚compile2m 21sthe patch passed
+1 💚javac2m 21sthe patch passed
+1 💚shadedjars3m 49spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 33sthe patch passed
_ Other Tests _
+1 💚unit0m 37shbase-protocol-shaded in the patch passed.
+1 💚unit1m 30shbase-client in the patch passed.
-1 ❌unit204m 39shbase-server in the patch failed.
+1 💚unit6m 58shbase-thrift in the patch passed.
-1 ❌unit7m 8shbase-shell in the patch failed.
249m 15s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4849
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b617b2f0efda 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3f17745
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/testReport/
Max. process+thread count3111 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 1, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 49sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall2m 16smaster passed
+1 💚compile2m 2smaster passed
+1 💚shadedjars3m 46sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 20smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 14sthe patch passed
+1 💚compile2m 4sthe patch passed
+1 💚javac2m 4sthe patch passed
+1 💚shadedjars3m 48spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 21sthe patch passed
_ Other Tests _
+1 💚unit0m 30shbase-protocol-shaded in the patch passed.
+1 💚unit1m 11shbase-client in the patch passed.
+1 💚unit216m 14shbase-server in the patch passed.
+1 💚unit8m 33shbase-thrift in the patch passed.
-1 ❌unit7m 43shbase-shell in the patch failed.
264m 45s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4849
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 5585032ab40a 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3f17745
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/testReport/
Max. process+thread count2278 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@2005hithlj

2005hithlj commented Nov 1, 2022

Copy link
Copy Markdown
ContributorAuthor

The failed UTs of hbase-server/hbase-shell seems to have nothing to do with my code modification.

@Apache9

Apache9 commented Nov 1, 2022

Copy link
Copy Markdown
Contributor

Please check the failure UT for hbase-shell?

@Apache-HBase

Apache-HBase commented Nov 2, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 19smaster passed
+1 💚compile4m 25smaster passed
+1 💚checkstyle1m 14smaster passed
+1 💚spotless0m 38sbranch has no errors when running spotless:check.
+1 💚spotbugs5m 3smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 4sthe patch passed
+1 💚compile4m 29sthe patch passed
+1 💚cc4m 29sthe patch passed
+1 💚javac4m 29sthe patch passed
-0 ⚠️checkstyle0m 12shbase-client: The patch generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22)
-0 ⚠️rubocop0m 10sThe patch generated 17 new + 431 unchanged - 0 fixed = 448 total (was 431)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck8m 0sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚hbaseprotoc1m 33sthe patch passed
+1 💚spotless0m 37spatch has no errors when running spotless:check.
+1 💚spotbugs5m 37sthe patch passed
_ Other Tests _
+1 💚asflicense0m 35sThe patch does not generate ASF License warnings.
44m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4849
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux 65e167dfbcae 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3f17745
Default JavaTemurin-1.8.0_352-b08
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
rubocophttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 2, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 23sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 32smaster passed
+1 💚compile2m 19smaster passed
+1 💚shadedjars3m 49sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 31smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 33sthe patch passed
+1 💚compile2m 21sthe patch passed
+1 💚javac2m 21sthe patch passed
+1 💚shadedjars3m 48spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 32sthe patch passed
_ Other Tests _
+1 💚unit0m 37shbase-protocol-shaded in the patch passed.
+1 💚unit1m 30shbase-client in the patch passed.
+1 💚unit203m 40shbase-server in the patch passed.
+1 💚unit7m 5shbase-thrift in the patch passed.
+1 💚unit6m 53shbase-shell in the patch passed.
246m 17s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4849
Optional Testsjavac javadoc unit shadedjars compile
unameLinux cc9f46b5a4a9 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3f17745
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/testReport/
Max. process+thread count3217 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 2, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 30sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 28smaster passed
+1 💚compile2m 7smaster passed
+1 💚shadedjars3m 50sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 21smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 8sthe patch passed
+1 💚compile2m 3sthe patch passed
+1 💚javac2m 3sthe patch passed
+1 💚shadedjars3m 46spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 20sthe patch passed
_ Other Tests _
+1 💚unit0m 30shbase-protocol-shaded in the patch passed.
+1 💚unit1m 12shbase-client in the patch passed.
+1 💚unit216m 28shbase-server in the patch passed.
+1 💚unit8m 33shbase-thrift in the patch passed.
+1 💚unit7m 46shbase-shell in the patch passed.
261m 7s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4849
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a71b28fbbcb4 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3f17745
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/testReport/
Max. process+thread count2632 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@2005hithlj

2005hithlj commented Nov 2, 2022

Copy link
Copy Markdown
ContributorAuthor

Please check the failure UT for hbase-shell?

@Apache9 sir.
I have modified the shell UT code, and the UTs are successfully executed in the new commit.

Apache9
Apache9 approved these changes Nov 5, 2022
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache9
Apache9 merged commit 186679f into apache:masterNov 5, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@2005hithlj@Apache-HBase@Apache9