Skip to content

HBASE-27167 s390x: Skip tests on unsupported compression libs - #4852

Merged
Apache9 merged 1 commit into
apache:masterfrom
linux-on-ibm-z:s390x-mvn-skipTests
Oct 28, 2022
Merged

HBASE-27167 s390x: Skip tests on unsupported compression libs#4852
Apache9 merged 1 commit into
apache:masterfrom
linux-on-ibm-z:s390x-mvn-skipTests

Conversation

@jonathan-albrecht-ibm

Copy link
Copy Markdown
Contributor

The brotli4j and aircompressor dependencies don't have s390x arch support yet. Even though aircompressor is pure java, it only supports little-endian right now.

This PR adds profiles to automatically set skipTests for hbase-compression-aircompressor and hbase-compression-brotli on s390x so builds can complete successfully.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 22smaster passed
+1 💚compile0m 26smaster passed
+1 💚shadedjars3m 50sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 15sthe patch passed
+1 💚compile0m 26sthe patch passed
+1 💚javac0m 26sthe patch passed
+1 💚shadedjars3m 47spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23sthe patch passed
_ Other Tests _
+1 💚unit0m 46shbase-compression-aircompressor in the patch passed.
+1 💚unit0m 36shbase-compression-brotli in the patch passed.
17m 19s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4852
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d7d88d9a5eca 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5e251c4
Default JavaTemurin-1.8.0_345-b01
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/testReport/
Max. process+thread count814 (vs. ulimit of 30000)
modulesC: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli U: hbase-compression
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 17sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 36smaster passed
+1 💚compile0m 24smaster passed
+1 💚shadedjars3m 55sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 21smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 25sthe patch passed
+1 💚compile0m 24sthe patch passed
+1 💚javac0m 24sthe patch passed
+1 💚shadedjars3m 53spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 19sthe patch passed
_ Other Tests _
+1 💚unit0m 50shbase-compression-aircompressor in the patch passed.
+1 💚unit0m 33shbase-compression-brotli in the patch passed.
20m 41s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4852
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9d27a9f3afb6 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5e251c4
Default JavaEclipse Adoptium-11.0.16.1+1
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/testReport/
Max. process+thread count582 (vs. ulimit of 30000)
modulesC: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli U: hbase-compression
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 44sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall2m 23smaster passed
+1 💚compile0m 30smaster passed
+1 💚spotless0m 38sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 5sthe patch passed
+1 💚compile0m 27sthe patch passed
+1 💚javac0m 27sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚hadoopcheck7m 51sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 35spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
21m 19s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4852
Optional Testsdupname asflicense javac hadoopcheck spotless xml compile
unameLinux 2a1385f1c57b 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5e251c4
Default JavaTemurin-1.8.0_345-b01
Max. process+thread count69 (vs. ulimit of 30000)
modulesC: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli U: hbase-compression
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4852/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
Contributor

Have you tried it locally on s390x to see whether it can skip the tests? I'm not sure whether the arch name is 's390x' or something else as I do not have a 390x machine...

Thanks.

@jonathan-albrecht-ibm

Copy link
Copy Markdown
ContributorAuthor

Yes, I've been testing locally on s390x VMs and the profile is getting activated properly. The maven docs say to see the enforcer plugin for the os values and on s390x mvn enforcer:display-info gives:

[INFO] OS Info: Arch: s390x Family: unix Name: linux Version: 5.15.0-52-generic

for example.

@Apache9
Apache9 merged commit d9713bf into apache:masterOct 28, 2022
Apache9 pushed a commit that referenced this pull request Oct 28, 2022
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit d9713bf)
Apache9 pushed a commit that referenced this pull request Oct 28, 2022
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit d9713bf)
@jonathan-albrecht-ibm

Copy link
Copy Markdown
ContributorAuthor

Thanks @Apache9 !

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathan-albrecht-ibm@Apache-HBase@Apache9