Uh oh!
There was an error while loading. Please reload this page.
HBASE-27167 s390x: Skip tests on unsupported compression libs - #4852
Merged
Conversation
Apache-HBase
commented
Oct 27, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 27, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 27, 2022
🎊 +1 overall
This message was automatically generated. |
Apache9
commented
Oct 27, 2022
Contributor
Have you tried it locally on s390x to see whether it can skip the tests? I'm not sure whether the arch name is 's390x' or something else as I do not have a 390x machine... Thanks. |
jonathan-albrecht-ibm
commented
Oct 27, 2022
ContributorAuthor
Yes, I've been testing locally on s390x VMs and the profile is getting activated properly. The maven docs say to see the enforcer plugin for the os values and on s390x for example. |
Apache9
approved these changes
Oct 28, 2022
Apache9 pushed a commit
that referenced
this pull request
Oct 28, 2022
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit d9713bf)
Apache9 pushed a commit
that referenced
this pull request
Oct 28, 2022
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit d9713bf)
jonathan-albrecht-ibm
commented
Oct 28, 2022
ContributorAuthor
Thanks @Apache9 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The brotli4j and aircompressor dependencies don't have s390x arch support yet. Even though aircompressor is pure java, it only supports little-endian right now.
This PR adds profiles to automatically set skipTests for
hbase-compression-aircompressorandhbase-compression-brotlion s390x so builds can complete successfully.