HBASE-26320 Implement a separate thread pool for the LogCleaner by petersomogyi · Pull Request #4895 · apache/hbase

petersomogyi · 2022-11-23T15:26:16Z

This avoids starvation when the archive directory is large and takes a long time to iterate through.

Signed-off-by: Duo Zhang zhangduo@apache.org
Signed-off-by: Anoop Sam John anoopsamjohn@apache.org
Signed-off-by: Pankaj pankajkumar@apache.org

Apache-HBase · 2022-11-23T17:43:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 16s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	2m 51s	branch-2.4 passed
+1 💚	compile	3m 17s	branch-2.4 passed
+1 💚	checkstyle	0m 44s	branch-2.4 passed
+1 💚	spotless	0m 52s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 45s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 10s	the patch passed
+1 💚	compile	3m 11s	the patch passed
+1 💚	javac	3m 11s	the patch passed
-0 ⚠️	checkstyle	0m 35s	hbase-server: The patch generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	18m 48s	Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.4.
+1 💚	spotless	0m 47s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 10s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		41m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4895
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 8b0b7af096dd 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `a3ac3c5`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-23T20:14:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	2m 12s	branch-2.4 passed
+1 💚	compile	0m 35s	branch-2.4 passed
+1 💚	shadedjars	3m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 0s	the patch passed
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
+1 💚	shadedjars	3m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	173m 1s	hbase-server in the patch passed.
		192m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4895
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ae2899c7a471 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `a3ac3c5`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/1/testReport/
Max. process+thread count	2451 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-23T20:27:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	3m 16s	branch-2.4 passed
+1 💚	compile	0m 54s	branch-2.4 passed
+1 💚	shadedjars	5m 27s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 8s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	5m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	the patch passed
		_ Other Tests _
+1 💚	unit	180m 59s	hbase-server in the patch passed.
		205m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4895
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3a792e9f6723 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `a3ac3c5`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/1/testReport/
Max. process+thread count	3037 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-24T13:53:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 47s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	2m 40s	branch-2.4 passed
+1 💚	compile	3m 3s	branch-2.4 passed
+1 💚	checkstyle	0m 44s	branch-2.4 passed
+1 💚	spotless	0m 55s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 48s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 53s	the patch passed
+1 💚	compile	2m 56s	the patch passed
+1 💚	javac	2m 56s	the patch passed
+1 💚	checkstyle	0m 46s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	18m 54s	Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.4.
+1 💚	spotless	0m 51s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 51s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		40m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4895
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux f07f0cfb2cc4 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `a3ac3c5`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-24T16:39:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 18s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	3m 5s	branch-2.4 passed
+1 💚	compile	0m 39s	branch-2.4 passed
+1 💚	shadedjars	5m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 31s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 54s	the patch passed
+1 💚	compile	0m 48s	the patch passed
+1 💚	javac	0m 48s	the patch passed
+1 💚	shadedjars	5m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	the patch passed
		_ Other Tests _
+1 💚	unit	181m 39s	hbase-server in the patch passed.
		207m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4895
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e8c103a78f0f 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `a3ac3c5`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/2/testReport/
Max. process+thread count	2837 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-24T16:40:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	2m 43s	branch-2.4 passed
+1 💚	compile	0m 39s	branch-2.4 passed
+1 💚	shadedjars	4m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 24s	the patch passed
+1 💚	compile	0m 41s	the patch passed
+1 💚	javac	0m 41s	the patch passed
+1 💚	shadedjars	4m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	184m 48s	hbase-server in the patch passed.
		207m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4895
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f5ad56762d35 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `a3ac3c5`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/2/testReport/
Max. process+thread count	2734 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-11-25T15:18:59Z

There are conflicts?

This avoids starvation when the archive directory is large and takes a long time to iterate through. Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Anoop Sam John <anoopsamjohn@apache.org> Signed-off-by: Pankaj <pankajkumar@apache.org>

petersomogyi · 2022-11-26T07:21:42Z

There are conflicts?

Thanks, I've rebased this commit.

Apache-HBase · 2022-11-26T08:03:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	2m 31s	branch-2.4 passed
+1 💚	compile	2m 20s	branch-2.4 passed
+1 💚	checkstyle	0m 36s	branch-2.4 passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 27s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	2m 13s	the patch passed
-0 ⚠️	javac	2m 13s	hbase-server generated 2 new + 193 unchanged - 2 fixed = 195 total (was 195)
+1 💚	checkstyle	0m 34s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	15m 32s	Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.4.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		33m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4895
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 20307b39f951 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `0a37292`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-26T10:39:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	2m 1s	branch-2.4 passed
+1 💚	compile	0m 35s	branch-2.4 passed
+1 💚	shadedjars	3m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	branch-2.4 passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	1m 54s	root in the patch failed.
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
+1 💚	shadedjars	3m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	170m 46s	hbase-server in the patch passed.
		189m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4895
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ca7e8bafff04 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `0a37292`
Default Java	Temurin-1.8.0_352-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/3/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/3/testReport/
Max. process+thread count	2221 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-26T10:43:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	2m 21s	branch-2.4 passed
+1 💚	compile	0m 38s	branch-2.4 passed
+1 💚	shadedjars	4m 33s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 16s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	shadedjars	4m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	172m 18s	hbase-server in the patch passed.
		193m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4895
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 635f1f515ed3 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `0a37292`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/3/testReport/
Max. process+thread count	3022 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-26T15:17:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 56s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	2m 56s	branch-2.4 passed
+1 💚	compile	2m 36s	branch-2.4 passed
+1 💚	checkstyle	0m 36s	branch-2.4 passed
+1 💚	spotless	0m 46s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 40s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	2m 29s	the patch passed
+1 💚	javac	2m 29s	the patch passed
+1 💚	checkstyle	0m 31s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 20s	Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.4.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 32s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		36m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4895
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux cc7e798824ae 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `0a37292`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-26T17:51:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	1m 54s	branch-2.4 passed
+1 💚	compile	0m 34s	branch-2.4 passed
+1 💚	shadedjars	3m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 57s	the patch passed
+1 💚	compile	0m 34s	the patch passed
+1 💚	javac	0m 34s	the patch passed
+1 💚	shadedjars	3m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 20s	the patch passed
		_ Other Tests _
-1 ❌	unit	171m 24s	hbase-server in the patch failed.
		190m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4895
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6af0b12c44f1 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `0a37292`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/4/testReport/
Max. process+thread count	2430 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-26T18:09:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 20s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	3m 9s	branch-2.4 passed
+1 💚	compile	0m 48s	branch-2.4 passed
+1 💚	shadedjars	5m 3s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 58s	the patch passed
+1 💚	compile	0m 51s	the patch passed
+1 💚	javac	0m 51s	the patch passed
+1 💚	shadedjars	5m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
-1 ❌	unit	183m 22s	hbase-server in the patch failed.
		208m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4895
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4fe45af4b3b0 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `0a37292`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/4/testReport/
Max. process+thread count	2881 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-27T10:56:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	2m 27s	branch-2.4 passed
+1 💚	compile	2m 16s	branch-2.4 passed
+1 💚	checkstyle	0m 34s	branch-2.4 passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 26s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 16s	the patch passed
+1 💚	compile	2m 13s	the patch passed
-0 ⚠️	javac	2m 13s	hbase-server generated 2 new + 193 unchanged - 2 fixed = 195 total (was 195)
+1 💚	checkstyle	0m 34s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	15m 19s	Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.4.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 37s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		33m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4895
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux f1cb62089929 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `0a37292`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-27T13:21:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 49s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	2m 17s	branch-2.4 passed
+1 💚	compile	0m 39s	branch-2.4 passed
+1 💚	shadedjars	4m 33s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 16s	the patch passed
+1 💚	compile	0m 38s	the patch passed
+1 💚	javac	0m 38s	the patch passed
+1 💚	shadedjars	4m 34s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	157m 38s	hbase-server in the patch passed.
		177m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4895
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 36adcc491d1a 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `0a37292`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/5/testReport/
Max. process+thread count	2955 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-27T13:32:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	2m 15s	branch-2.4 passed
+1 💚	compile	0m 35s	branch-2.4 passed
+1 💚	shadedjars	3m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 54s	the patch passed
+1 💚	compile	0m 36s	the patch passed
+1 💚	javac	0m 36s	the patch passed
+1 💚	shadedjars	3m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	170m 28s	hbase-server in the patch passed.
		189m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4895
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5c337c8eb077 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `0a37292`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/5/testReport/
Max. process+thread count	2219 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4895/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…he#4895) This avoids starvation when the archive directory is large and takes a long time to iterate through. Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Anoop Sam John <anoopsamjohn@apache.org> Signed-off-by: Pankaj <pankajkumar@apache.org> Co-authored-by: Xiaolin Ha <haxiaolin@apache.org> (cherry picked from commit f0c857a) Change-Id: Ia03944a7e0414406040fa6b75556e64a74e7bccf

petersomogyi requested a review from sunhelly November 23, 2022 15:26

petersomogyi requested review from Apache9 and wchevreuil November 25, 2022 14:34

sunhellyand others added 2 commits November 26, 2022 08:17

Checkstyle: make DirScanPool final
ee655c4

petersomogyi force-pushed the HBASE-26320-2.4 branch from 9950025 to ee655c4Compare November 26, 2022 07:18

Apache9 approved these changes Nov 27, 2022
View reviewed changes

petersomogyi merged commit f0c857a into apache:branch-2.4Nov 27, 2022

petersomogyi deleted the HBASE-26320-2.4 branch November 27, 2022 18:14

Uh oh!

Conversation

petersomogyi commented Nov 23, 2022

Uh oh!

Apache-HBase commented Nov 23, 2022

Uh oh!

Apache-HBase commented Nov 23, 2022

Uh oh!

Apache-HBase commented Nov 23, 2022

Uh oh!

Apache-HBase commented Nov 24, 2022

Uh oh!

Apache-HBase commented Nov 24, 2022

Uh oh!

Apache-HBase commented Nov 24, 2022

Uh oh!

Apache9 commented Nov 25, 2022

Uh oh!

petersomogyi commented Nov 26, 2022

Uh oh!

Apache-HBase commented Nov 26, 2022

Uh oh!

Apache-HBase commented Nov 26, 2022

Uh oh!

Apache-HBase commented Nov 26, 2022

Uh oh!

Apache-HBase commented Nov 26, 2022

Uh oh!

Apache-HBase commented Nov 26, 2022

Uh oh!

Apache-HBase commented Nov 26, 2022

Uh oh!

Apache-HBase commented Nov 27, 2022

Uh oh!

Apache-HBase commented Nov 27, 2022

Uh oh!

Apache-HBase commented Nov 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants