Skip to content

HBASE-27510 Should use 'org.apache.hbase.thirdparty.io.netty.tryRefle… - #4898

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-27510
Nov 29, 2022
Merged

HBASE-27510 Should use 'org.apache.hbase.thirdparty.io.netty.tryRefle…#4898
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-27510

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

…ctionSetAccessible'

@Apache9Apache9 self-assigned this Nov 28, 2022
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 59sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall2m 54smaster passed
+1 💚compile4m 43smaster passed
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 30sthe patch passed
+1 💚compile4m 40sthe patch passed
+1 💚javac4m 40sthe patch passed
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck8m 41sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 41spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
32m 2s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4898
Optional Testsdupname asflicense spotless shellcheck shelldocs javac hadoopcheck xml compile
unameLinux bd4c8805a675 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7fc4d99
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count73 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/console
versionsgit=2.34.1 maven=3.8.6 shellcheck=0.8.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@jojochuangjojochuang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good but is the removal of --illegal-access=permit and other JDK module export changes required?

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 22sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 39smaster passed
+1 💚compile2m 23smaster passed
+1 💚shadedjars4m 59sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 15smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 17sthe patch passed
+1 💚compile2m 13sthe patch passed
+1 💚javac2m 14sthe patch passed
+1 💚shadedjars4m 48spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 10sthe patch passed
_ Other Tests _
+1 💚unit286m 25sroot in the patch passed.
319m 29s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4898
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f37171c33df4 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7fc4d99
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/testReport/
Max. process+thread count4743 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 40smaster passed
+1 💚compile1m 37smaster passed
+1 💚shadedjars3m 47sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 25smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 8sthe patch passed
+1 💚compile1m 35sthe patch passed
+1 💚javac1m 35sthe patch passed
+1 💚shadedjars3m 44spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 24sthe patch passed
_ Other Tests _
+1 💚unit371m 58sroot in the patch passed.
397m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4898
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f4e419e7c898 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7fc4d99
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/testReport/
Max. process+thread count4697 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
ContributorAuthor

The change looks good but is the removal of --illegal-access=permit and other JDK module export changes required?

Java17 removes the support of --illegal-access support, so we have already removed this flag in pom when running UTs, in this PR I just align the flags in bin/hbase and pom.xml.

Thanks.

@Apache9
Apache9 merged commit 3ffc0b5 into apache:masterNov 29, 2022
Apache9 added a commit that referenced this pull request Nov 29, 2022
…ctionSetAccessible' (#4898)
Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit 3ffc0b5)
Apache9 added a commit that referenced this pull request Nov 29, 2022
…ctionSetAccessible' (#4898)
Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit 3ffc0b5)
stoty pushed a commit to stoty/hbase that referenced this pull request Dec 12, 2023
…ctionSetAccessible' (apache#4898)
Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit 3ffc0b5)
stoty pushed a commit to stoty/hbase that referenced this pull request Dec 12, 2023
…ctionSetAccessible' (apache#4898)
Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit 3ffc0b5)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@jojochuang