Skip to content

HBASE-27430 Should disable replication log cleaner when migrating rep… - #4901

Merged
Apache9 merged 2 commits into
apache:HBASE-27109/table_based_rqsfrom
Apache9:HBASE-27430
Dec 3, 2022
Merged

HBASE-27430 Should disable replication log cleaner when migrating rep…#4901
Apache9 merged 2 commits into
apache:HBASE-27109/table_based_rqsfrom
Apache9:HBASE-27430

Conversation

@Apache9

@Apache9Apache9 commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

…lication queue data

@Apache9Apache9 self-assigned this Nov 30, 2022
@Apache-HBase

Apache-HBase commented Nov 30, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 58sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-27109/table_based_rqs Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 2sHBASE-27109/table_based_rqs passed
+1 💚compile4m 55sHBASE-27109/table_based_rqs passed
+1 💚checkstyle1m 7sHBASE-27109/table_based_rqs passed
+1 💚spotless0m 59sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 38sHBASE-27109/table_based_rqs passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 45sthe patch passed
+1 💚compile4m 31sthe patch passed
+1 💚cc4m 31sthe patch passed
+1 💚javac4m 31sthe patch passed
-0 ⚠️checkstyle0m 46shbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 43sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚hbaseprotoc1m 46sthe patch passed
-1 ❌spotless1m 2spatch has 1 errors when running spotless:check, run spotless:apply to fix.
+1 💚spotbugs6m 56sthe patch passed
_ Other Tests _
+1 💚asflicense0m 31sThe patch does not generate ASF License warnings.
60m 24s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4901/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4901
Optional Testsdupname asflicense cc hbaseprotoc spotless prototool javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 35fbcfc751e4 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-27109/table_based_rqs / 9a4389a
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4901/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4901/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count80 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4901/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 1, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-27109/table_based_rqs Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 21sHBASE-27109/table_based_rqs passed
+1 💚compile3m 51sHBASE-27109/table_based_rqs passed
+1 💚checkstyle0m 43sHBASE-27109/table_based_rqs passed
+1 💚spotless0m 44sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 28sHBASE-27109/table_based_rqs passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall3m 17sthe patch passed
+1 💚compile3m 32sthe patch passed
+1 💚cc3m 32sthe patch passed
+1 💚javac3m 32sthe patch passed
+1 💚checkstyle0m 50sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 27sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚hbaseprotoc1m 12sthe patch passed
+1 💚spotless0m 46spatch has no errors when running spotless:check.
+1 💚spotbugs4m 40sthe patch passed
_ Other Tests _
+1 💚asflicense0m 17sThe patch does not generate ASF License warnings.
48m 27s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4901/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4901
Optional Testsdupname asflicense cc hbaseprotoc spotless prototool javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux e6245b5e86b7 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-27109/table_based_rqs / 9a4389a
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count81 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4901/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 1, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 46sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-27109/table_based_rqs Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall2m 8sHBASE-27109/table_based_rqs passed
+1 💚compile1m 4sHBASE-27109/table_based_rqs passed
+1 💚shadedjars4m 0sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 29sHBASE-27109/table_based_rqs passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 4sthe patch passed
+1 💚compile1m 0sthe patch passed
+1 💚javac1m 0sthe patch passed
+1 💚shadedjars4m 0spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 28sthe patch passed
_ Other Tests _
+1 💚unit0m 24shbase-protocol-shaded in the patch passed.
+1 💚unit213m 40shbase-server in the patch passed.
233m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4901/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4901
Optional Testsunit javac javadoc shadedjars compile
unameLinux 3ed652f9c166 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-27109/table_based_rqs / 9a4389a
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4901/2/testReport/
Max. process+thread count3045 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4901/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 1, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-27109/table_based_rqs Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall3m 5sHBASE-27109/table_based_rqs passed
+1 💚compile1m 33sHBASE-27109/table_based_rqs passed
+1 💚shadedjars5m 6sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 11sHBASE-27109/table_based_rqs passed
_ Patch Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for patch
+1 💚mvninstall3m 44sthe patch passed
+1 💚compile1m 43sthe patch passed
+1 💚javac1m 43sthe patch passed
+1 💚shadedjars4m 25spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36sthe patch passed
_ Other Tests _
+1 💚unit0m 41shbase-protocol-shaded in the patch passed.
-1 ❌unit284m 14shbase-server in the patch failed.
312m 49s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4901/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4901
Optional Testsunit javac javadoc shadedjars compile
unameLinux 7d86e8d72fc9 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-27109/table_based_rqs / 9a4389a
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4901/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4901/2/testReport/
Max. process+thread count2501 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4901/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@2005hithlj
2005hithlj self-requested a review December 2, 2022 16:00
2005hithlj
2005hithlj approved these changes Dec 2, 2022
View reviewed changes

@2005hithlj2005hithlj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Apache9
Apache9 merged commit 614e662 into apache:HBASE-27109/table_based_rqsDec 3, 2022
Apache9 added a commit that referenced this pull request Dec 3, 2022
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
da59154
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Jan 10, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
e4e3363
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Jan 18, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
ff31d25
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Jan 19, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
bf1f008
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Jan 31, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
069d1ca
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Feb 3, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
befa513
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Mar 6, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
6128eb4
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Mar 9, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
2e4e295
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Mar 13, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
9f95b0e
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Mar 15, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
c1d126d
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Mar 18, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
b59ec9b
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Apr 5, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
f55419a
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Apr 18, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
fb7eb04
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Apr 21, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
d7775aa
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Apr 23, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
552fb6b
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Apr 24, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
382c5ae
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Apr 25, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
2908349
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Apr 27, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
0e55062
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request Apr 28, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
d2295d2
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request May 1, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
ca48bb0
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request May 4, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
b9358ce
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request May 6, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
e47a833
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request May 8, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
894195f
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request May 13, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
9c5bfcf
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Apache9 added a commit that referenced this pull request May 15, 2023
@Apache9
HBASE-27430Should disable replication log cleaner when migrating rep…
7c74f9e
…lication queue data (#4901)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2005hithlj2005hithlj2005hithlj approved these changes

Assignees

@Apache9Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@2005hithlj