HBASE-27530 Fix comment syntax errors by LYCJeff · Pull Request #4910 · apache/hbase

LYCJeff · 2022-12-02T06:28:15Z

I am new to hbase and I'm trying to fix some comment sytax errors while reading the source code.

Apache-HBase · 2022-12-02T06:56:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 40s	master passed
+1 💚	compile	0m 24s	master passed
+1 💚	shadedjars	3m 57s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 22s	the patch passed
+1 💚	compile	0m 24s	the patch passed
+1 💚	javac	0m 24s	the patch passed
+1 💚	shadedjars	3m 56s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 20s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 50s	hbase-balancer in the patch passed.
+1 💚	unit	0m 57s	hbase-asyncfs in the patch passed.
		26m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4910
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4db163e65be2 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `320eca2`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/1/testReport/
Max. process+thread count	482 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-asyncfs U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-02T06:57:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 8s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 14s	master passed
+1 💚	compile	0m 29s	master passed
+1 💚	shadedjars	3m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 11s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	shadedjars	3m 47s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 38s	hbase-balancer in the patch passed.
+1 💚	unit	1m 24s	hbase-asyncfs in the patch passed.
		27m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4910
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3645354d5b31 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `320eca2`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/1/testReport/
Max. process+thread count	482 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-asyncfs U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-02T07:01:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	5m 51s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 42s	master passed
+1 💚	compile	0m 40s	master passed
+1 💚	checkstyle	0m 20s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 48s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 28s	the patch passed
+1 💚	compile	0m 38s	the patch passed
+1 💚	javac	0m 38s	the patch passed
-0 ⚠️	checkstyle	0m 8s	hbase-asyncfs: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 47s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
-1 ❌	spotless	0m 19s	patch has 26 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 1s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 20s	The patch does not generate ASF License warnings.
		31m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4910
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux f693f34a2a82 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `320eca2`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-asyncfs.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	76 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-asyncfs U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-08T10:46:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 39s	master passed
+1 💚	compile	0m 38s	master passed
+1 💚	checkstyle	0m 19s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 48s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 31s	the patch passed
+1 💚	compile	0m 38s	the patch passed
+1 💚	javac	0m 38s	the patch passed
+1 💚	checkstyle	0m 18s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 43s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
-1 ❌	spotless	0m 18s	patch has 26 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 2s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 18s	The patch does not generate ASF License warnings.
		26m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4910
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 573f65453387 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `febe511`
Default Java	Eclipse Adoptium-11.0.17+8
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-asyncfs U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-08T10:47:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 21s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 38s	master passed
+1 💚	compile	0m 25s	master passed
+1 💚	shadedjars	4m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 24s	the patch passed
+1 💚	compile	0m 26s	the patch passed
+1 💚	javac	0m 26s	the patch passed
+1 💚	shadedjars	3m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 53s	hbase-balancer in the patch passed.
+1 💚	unit	1m 0s	hbase-asyncfs in the patch passed.
		27m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4910
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1031f1b757a5 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `febe511`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/2/testReport/
Max. process+thread count	485 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-asyncfs U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-08T10:47:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 8s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 23s	master passed
+1 💚	compile	0m 25s	master passed
+1 💚	shadedjars	3m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 20s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 21s	the patch passed
+1 💚	compile	0m 24s	the patch passed
+1 💚	javac	0m 24s	the patch passed
+1 💚	shadedjars	3m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 18s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 39s	hbase-balancer in the patch passed.
+1 💚	unit	1m 23s	hbase-asyncfs in the patch passed.
		27m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4910
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 56a5daf2daf2 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `febe511`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/2/testReport/
Max. process+thread count	457 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-asyncfs U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-12-09T01:43:52Z

Thanks for putting up a PR!

HBase uses jira for tracking issues.

Do you have a jira account here?

https://issues.apache.org/jira/projects/HBASE

If not, please reply here in this format so I can acquire a jira account for you.

Preferred Jira Id:
Full Name:
E-Mail Address:

LYCJeff · 2022-12-09T02:03:50Z

Thanks for contacting me. I don't have a jira account yet. Preferred Jira Id: LYCJeff Full Name: Yuchen Liang E-Mail Address: ***@***.***

…

---Original--- From: "Duo ***@***.***> Date: Fri, Dec 9, 2022 09:44 AM To: ***@***.***>; Cc: ***@***.******@***.***>; Subject: Re: [apache/hbase] Fix comment syntax errors (PR #4910) Thanks for putting up a PR! HBase uses jira for tracking issues. Do you have a jira account here? https://issues.apache.org/jira/projects/HBASE If not, please reply here in this format so I can acquire a jira account for you. Preferred Jira Id: Full Name: E-Mail Address: — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

Apache9 · 2022-12-09T04:14:50Z

LYCJeff

I can not see the email address... It has been masked by '*'.

Apache9 · 2022-12-09T04:44:05Z

Oh, the jira id must be lower case...

Is 'lycjeff' OK for you?

Thanks.

LYCJeff · 2022-12-09T04:46:02Z

Oh, the jira id must be lower case...
Is 'lycjeff' OK for you?
Thanks.

No problem, Thanks!

Apache9 · 2022-12-09T04:56:09Z

Your jira account has been created.

You should have received an email about the jira account. Please finish the setup and create a jira issue under the HBase project about this change. I will add you to the contributor list and assign the issue to you.

Thanks~

LYCJeff · 2022-12-09T05:16:36Z

Your jira account has been created.
You should have received an email about the jira account. Please finish the setup and create a jira issue under the HBase project about this change. I will add you to the contributor list and assign the issue to you.
Thanks~

I'm wondering if I should close this PR, since it's not formal.

Apache9 · 2022-12-09T05:28:42Z

Just open a jira issue and then change the title of this PR to 'HBASE-XXXXX
Fix comment syntax errors'

LYCJeff · 2022-12-13T02:56:02Z

Just open a jira issue and then change the title of this PR to 'HBASE-XXXXX Fix comment syntax errors'

I have opened the issue according to what you said. Please help to check if there is any problem.
Thanks~

Apache-HBase · 2022-12-13T04:21:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 36s	master passed
+1 💚	compile	0m 12s	master passed
+1 💚	shadedjars	3m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 28s	the patch passed
+1 💚	compile	0m 12s	the patch passed
+1 💚	javac	0m 12s	the patch passed
+1 💚	shadedjars	3m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 0s	hbase-asyncfs in the patch passed.
		16m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4910
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1624caedae84 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `37c82a6`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/3/testReport/
Max. process+thread count	599 (vs. ulimit of 30000)
modules	C: hbase-asyncfs U: hbase-asyncfs
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-13T04:24:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 22s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 43s	master passed
+1 💚	compile	0m 15s	master passed
+1 💚	shadedjars	4m 36s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 41s	the patch passed
+1 💚	compile	0m 14s	the patch passed
+1 💚	javac	0m 14s	the patch passed
+1 💚	shadedjars	4m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 32s	hbase-asyncfs in the patch passed.
		19m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4910
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e66bf169d621 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `37c82a6`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/3/testReport/
Max. process+thread count	515 (vs. ulimit of 30000)
modules	C: hbase-asyncfs U: hbase-asyncfs
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-13T04:29:01Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 53s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 42s	master passed
+1 💚	compile	0m 19s	master passed
+1 💚	checkstyle	0m 10s	master passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	checkstyle	0m 9s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 52s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
-1 ❌	spotless	0m 20s	patch has 36 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	0m 29s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		23m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4910
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 111db650b177 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `37c82a6`
Default Java	Eclipse Adoptium-11.0.17+8
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/3/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-asyncfs U: hbase-asyncfs
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-12-13T16:01:17Z

Please run 'mvn spotless:apply' and push again?

Apache-HBase · 2022-12-14T02:35:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 26s	master passed
+1 💚	compile	0m 12s	master passed
+1 💚	shadedjars	3m 59s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 8s	the patch passed
+1 💚	compile	0m 11s	the patch passed
+1 💚	javac	0m 11s	the patch passed
+1 💚	shadedjars	3m 57s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 59s	hbase-asyncfs in the patch passed.
		15m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4910
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4a18dfd58e03 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8b4e134`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/4/testReport/
Max. process+thread count	473 (vs. ulimit of 30000)
modules	C: hbase-asyncfs U: hbase-asyncfs
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-14T02:39:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 53s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 28s	master passed
+1 💚	compile	0m 18s	master passed
+1 💚	shadedjars	4m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 50s	the patch passed
+1 💚	compile	0m 14s	the patch passed
+1 💚	javac	0m 14s	the patch passed
+1 💚	shadedjars	4m 25s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 8s	hbase-asyncfs in the patch passed.
		19m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4910
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 932ec23f80a3 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8b4e134`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/4/testReport/
Max. process+thread count	463 (vs. ulimit of 30000)
modules	C: hbase-asyncfs U: hbase-asyncfs
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-14T02:43:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 59s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 49s	master passed
+1 💚	compile	0m 19s	master passed
+1 💚	checkstyle	0m 10s	master passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	compile	0m 19s	the patch passed
+1 💚	javac	0m 19s	the patch passed
+1 💚	checkstyle	0m 8s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 44s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 31s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		23m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4910
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 8ff95bd5f977 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8b4e134`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-asyncfs U: hbase-asyncfs
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-14T03:09:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 2s	master passed
+1 💚	compile	0m 23s	master passed
+1 💚	shadedjars	3m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 18s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 4s	the patch passed
+1 💚	compile	0m 23s	the patch passed
+1 💚	javac	0m 23s	the patch passed
+1 💚	shadedjars	4m 0s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 18s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 50s	hbase-balancer in the patch passed.
+1 💚	unit	0m 55s	hbase-asyncfs in the patch passed.
		25m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4910
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cea53c83edf0 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8b4e134`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/5/testReport/
Max. process+thread count	461 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-asyncfs U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-14T03:10:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 59s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 30s	master passed
+1 💚	compile	0m 39s	master passed
+1 💚	checkstyle	0m 15s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 46s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 30s	the patch passed
+1 💚	compile	0m 38s	the patch passed
+1 💚	javac	0m 38s	the patch passed
+1 💚	checkstyle	0m 18s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 37s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 3s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 18s	The patch does not generate ASF License warnings.
		25m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4910
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux ecf599c2121e 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8b4e134`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-asyncfs U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-14T03:14:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 15s	master passed
+1 💚	compile	0m 34s	master passed
+1 💚	shadedjars	4m 26s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 4s	the patch passed
+1 💚	compile	0m 29s	the patch passed
+1 💚	javac	0m 29s	the patch passed
+1 💚	shadedjars	4m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 7s	hbase-balancer in the patch passed.
+1 💚	unit	1m 21s	hbase-asyncfs in the patch passed.
		30m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4910
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cef957d1dc4c 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8b4e134`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/5/testReport/
Max. process+thread count	520 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-asyncfs U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4910/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit f9518cc)

Signed-off-by: Duo Zhang <zhangduo@apache.org>

Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit f9518cc) (cherry picked from commit 9164ed4) Change-Id: Iab11555ef044cce3d37b57bdb43e95df5865956e

This comment was marked as off-topic.
Sign in to view

LYCJeff changed the title ~~Fix comment syntax errors~~[HBASE-27530]Fix comment syntax errorsDec 13, 2022

LYCJeff changed the title ~~[HBASE-27530]Fix comment syntax errors~~HBASE-27530 Fix comment syntax errorsDec 13, 2022

Fix comment syntax errors
560fb5b

LYCJeff force-pushed the dev branch from 74ec987 to 560fb5bCompare December 13, 2022 04:00

LYCJeff added 2 commits December 14, 2022 10:02

Fix spotless errors
995d74d

Fix comment syntax errors
d629cd1

Apache9 approved these changes Dec 14, 2022
View reviewed changes

Apache9 merged commit f9518cc into apache:masterDec 14, 2022

Apache9 pushed a commit that referenced this pull request Dec 14, 2022
HBASE-27530Fix comment syntax errors (#4910)
9164ed4
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit f9518cc)

Apache9 pushed a commit that referenced this pull request Dec 14, 2022
HBASE-27530Fix comment syntax errors (#4910)
2874c07
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit f9518cc)

Apache9 pushed a commit that referenced this pull request Dec 14, 2022
HBASE-27530Fix comment syntax errors (#4910)
1e53a34
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit f9518cc)

virajjasani pushed a commit to virajjasani/hbase that referenced this pull request Jan 5, 2023
HBASE-27530 Fix comment syntax errors (apache#4910)
b93e4b0
Signed-off-by: Duo Zhang <zhangduo@apache.org>

LYCJeff deleted the dev branch April 25, 2023 03:00

Uh oh!

Conversation

LYCJeff commented Dec 2, 2022

Uh oh!

Apache-HBase commented Dec 2, 2022

Uh oh!

Apache-HBase commented Dec 2, 2022

Uh oh!

Apache-HBase commented Dec 2, 2022

Uh oh!

Apache-HBase commented Dec 8, 2022

Uh oh!

Apache-HBase commented Dec 8, 2022

Uh oh!

Apache-HBase commented Dec 8, 2022

Uh oh!

Apache9 commented Dec 9, 2022

Uh oh!

LYCJeff commented Dec 9, 2022 via email

Uh oh!

Apache9 commented Dec 9, 2022

Uh oh!

This comment was marked as off-topic.

Apache9 commented Dec 9, 2022

Uh oh!

LYCJeff commented Dec 9, 2022

Uh oh!

Apache9 commented Dec 9, 2022

Uh oh!

LYCJeff commented Dec 9, 2022

Uh oh!

Apache9 commented Dec 9, 2022

Uh oh!

LYCJeff commented Dec 13, 2022

Uh oh!

Apache-HBase commented Dec 13, 2022

Uh oh!

Apache-HBase commented Dec 13, 2022

Uh oh!

Apache-HBase commented Dec 13, 2022

Uh oh!

Apache9 commented Dec 13, 2022

Uh oh!

Apache-HBase commented Dec 14, 2022

Uh oh!

Apache-HBase commented Dec 14, 2022

Uh oh!

Apache-HBase commented Dec 14, 2022

Uh oh!

Apache-HBase commented Dec 14, 2022

Uh oh!

Apache-HBase commented Dec 14, 2022

Uh oh!

Apache-HBase commented Dec 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants