Skip to content

HBASE-22833 MultiRowRangeFilter should provide a method for creating… - #493

Merged
openinx merged 5 commits into
apache:masterfrom
titsuki:HBASE-22833
Aug 16, 2019
Merged

HBASE-22833 MultiRowRangeFilter should provide a method for creating…#493
openinx merged 5 commits into
apache:masterfrom
titsuki:HBASE-22833

Conversation

@titsuki

@titsukititsuki commented Aug 14, 2019

Copy link
Copy Markdown
Contributor

… a filter which is functionally equivalent to multiple prefix filters

@titsuki
HBASE-22833: MultiRowRangeFilter should provide a method for creating…
5a7be2c
… a filter which is functionally equivalent to multiple prefix filters
@titsukititsuki changed the title HBASE-22833: MultiRowRangeFilter should provide a method for creating…HBASE-22833 MultiRowRangeFilter should provide a method for creating…Aug 14, 2019
@Apache-HBase

Apache-HBase commented Aug 14, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec38Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0mvndep35Maven dependency ordering for branch
+1mvninstall339master passed
+1compile82master passed
+1checkstyle110master passed
+1shadedjars292branch has no errors when building our shaded downstream artifacts.
+1javadoc63master passed
0spotbugs275Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs349master passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall311the patch passed
+1compile85the patch passed
+1javac85the patch passed
-1checkstyle29hbase-client: The patch generated 3 new + 15 unchanged - 1 fixed = 18 total (was 16)
-1checkstyle83hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1whitespace0The patch has no whitespace issues.
+1shadedjars291patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck989Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc56the patch passed
+1findbugs362the patch passed
_ Other Tests _
+1unit112hbase-client in the patch passed.
+1unit6740hbase-server in the patch passed.
+1asflicense59The patch does not generate ASF License warnings.
10823
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/2/artifact/out/Dockerfile
GITHUB PR#493
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux fa02af3a4b63 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-493/out/precommit/personality/provided.sh
git revisionmaster / 27ed2ac
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/2/artifact/out/diff-checkstyle-hbase-client.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/2/artifact/out/diff-checkstyle-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/2/testReport/
Max. process+thread count5186 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 14, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec91Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0mvndep34Maven dependency ordering for branch
+1mvninstall345master passed
+1compile87master passed
+1checkstyle120master passed
+1shadedjars323branch has no errors when building our shaded downstream artifacts.
+1javadoc64master passed
0spotbugs299Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs371master passed
_ Patch Compile Tests _
0mvndep20Maven dependency ordering for patch
+1mvninstall450the patch passed
+1compile99the patch passed
+1javac99the patch passed
-1checkstyle36hbase-client: The patch generated 3 new + 15 unchanged - 1 fixed = 18 total (was 16)
-1checkstyle93hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1whitespace0The patch has no whitespace issues.
+1shadedjars343patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1341Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc65the patch passed
+1findbugs382the patch passed
_ Other Tests _
+1unit101hbase-client in the patch passed.
+1unit10280hbase-server in the patch passed.
+1asflicense51The patch does not generate ASF License warnings.
15201
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/1/artifact/out/Dockerfile
GITHUB PR#493
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 54d6a91b4262 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-493/out/precommit/personality/provided.sh
git revisionmaster / 27ed2ac
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/1/artifact/out/diff-checkstyle-hbase-client.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/1/artifact/out/diff-checkstyle-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/1/testReport/
Max. process+thread count4660 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 14, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec73Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0mvndep41Maven dependency ordering for branch
+1mvninstall452master passed
+1compile108master passed
+1checkstyle141master passed
+1shadedjars378branch has no errors when building our shaded downstream artifacts.
+1javadoc72master passed
0spotbugs338Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs424master passed
_ Patch Compile Tests _
0mvndep21Maven dependency ordering for patch
+1mvninstall422the patch passed
+1compile106the patch passed
+1javac106the patch passed
-1checkstyle38hbase-client: The patch generated 3 new + 15 unchanged - 1 fixed = 18 total (was 16)
-1checkstyle100hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1whitespace0The patch has no whitespace issues.
+1shadedjars363patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1353Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc70the patch passed
+1findbugs432the patch passed
_ Other Tests _
+1unit134hbase-client in the patch passed.
+1unit13574hbase-server in the patch passed.
+1asflicense71The patch does not generate ASF License warnings.
18923
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/3/artifact/out/Dockerfile
GITHUB PR#493
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux e57425e80a85 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-493/out/precommit/personality/provided.sh
git revisionmaster / 53db390
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/3/artifact/out/diff-checkstyle-hbase-client.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/3/artifact/out/diff-checkstyle-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/3/testReport/
Max. process+thread count4452 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

openinx
openinx reviewed Aug 15, 2019
View reviewed changes

@openinxopeninx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, please address the comment, then I will +1. Thanks.

Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java
}

/**
* @param rowKeyPrefixes the array of byte array

@openinxopeninxAug 15, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a careful javadoc here, say why we need the public method ... because exposing an MultiRowRangeFilter constructor with rowKeyPrefixes looks very strange if no doc here.

@titsukititsukiAug 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I added explanation for this constructor.

Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java

private static List<RowRange> createRangeListFromRowKeyPrefixes(byte[][] rowKeyPrefixes) {
List<RowRange> list = new ArrayList<>();
for (byte[] rowKeyPrefix: rowKeyPrefixes) {

@openinxopeninxAug 15, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need some arguments check here ?

@titsukititsukiAug 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I added null check.

@Apache-HBase

Apache-HBase commented Aug 15, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec37Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0mvndep36Maven dependency ordering for branch
+1mvninstall309master passed
+1compile77master passed
+1checkstyle103master passed
+1shadedjars273branch has no errors when building our shaded downstream artifacts.
+1javadoc57master passed
0spotbugs247Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs311master passed
_ Patch Compile Tests _
0mvndep18Maven dependency ordering for patch
+1mvninstall296the patch passed
+1compile77the patch passed
+1javac77the patch passed
-1checkstyle32hbase-client: The patch generated 3 new + 15 unchanged - 1 fixed = 18 total (was 16)
-1checkstyle73hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1whitespace0The patch has no whitespace issues.
+1shadedjars270patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck921Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc54the patch passed
+1findbugs325the patch passed
_ Other Tests _
+1unit102hbase-client in the patch passed.
+1unit8922hbase-server in the patch passed.
+1asflicense43The patch does not generate ASF License warnings.
12726
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/4/artifact/out/Dockerfile
GITHUB PR#493
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 3724851e29a3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-493/out/precommit/personality/provided.sh
git revisionmaster / d9d5f69
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/4/artifact/out/diff-checkstyle-hbase-client.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/4/artifact/out/diff-checkstyle-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/4/testReport/
Max. process+thread count4806 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/4/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 15, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec81Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0mvndep70Maven dependency ordering for branch
+1mvninstall413master passed
+1compile100master passed
+1checkstyle140master passed
+1shadedjars357branch has no errors when building our shaded downstream artifacts.
+1javadoc69master passed
0spotbugs312Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs399master passed
_ Patch Compile Tests _
0mvndep17Maven dependency ordering for patch
+1mvninstall399the patch passed
+1compile99the patch passed
+1javac99the patch passed
-1checkstyle35hbase-client: The patch generated 3 new + 15 unchanged - 1 fixed = 18 total (was 16)
-1checkstyle101hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1whitespace0The patch has no whitespace issues.
+1shadedjars367patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1309Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc65the patch passed
+1findbugs404the patch passed
_ Other Tests _
+1unit117hbase-client in the patch passed.
-1unit17280hbase-server in the patch failed.
+1asflicense67The patch does not generate ASF License warnings.
22416
ReasonTests
Failed junit testshadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.client.TestFromClientSide
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/6/artifact/out/Dockerfile
GITHUB PR#493
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 1f9ad6adfabf 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-493/out/precommit/personality/provided.sh
git revisionmaster / 8ffc45a
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/6/artifact/out/diff-checkstyle-hbase-client.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/6/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/6/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/6/testReport/
Max. process+thread count4911 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/6/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 15, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec170Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0mvndep46Maven dependency ordering for branch
+1mvninstall455master passed
+1compile111master passed
+1checkstyle138master passed
+1shadedjars366branch has no errors when building our shaded downstream artifacts.
+1javadoc72master passed
0spotbugs296Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs379master passed
_ Patch Compile Tests _
0mvndep18Maven dependency ordering for patch
+1mvninstall457the patch passed
+1compile105the patch passed
+1javac105the patch passed
+1checkstyle37hbase-client: The patch generated 0 new + 13 unchanged - 3 fixed = 13 total (was 16)
+1checkstyle97The patch passed checkstyle in hbase-server
+1whitespace0The patch has no whitespace issues.
+1shadedjars351patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1355Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc73the patch passed
+1findbugs421the patch passed
_ Other Tests _
+1unit122hbase-client in the patch passed.
-1unit16107hbase-server in the patch failed.
+1asflicense47The patch does not generate ASF License warnings.
21507
ReasonTests
Failed junit testshadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.client.TestCloneSnapshotFromClientNormal
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/7/artifact/out/Dockerfile
GITHUB PR#493
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux ea03b0435c03 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-493/out/precommit/personality/provided.sh
git revisionmaster / 8ffc45a
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/7/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/7/testReport/
Max. process+thread count4955 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/7/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

openinx
openinx approved these changes Aug 16, 2019
View reviewed changes

@openinxopeninx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Let's get in.

@openinx

openinx commented Aug 16, 2019

Copy link
Copy Markdown
Member

The timeout snapshot related UT are irrelevant here.

@openinx
openinx merged commit 78f5d8e into apache:masterAug 16, 2019
asfgit pushed a commit that referenced this pull request Aug 16, 2019
@titsuki@openinx
HBASE-22833MultiRowRangeFilter should provide a method for creating… (…
bedab0d
…#493)
* HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
* Delete superfluous comments
* Add description for MultiRowRangeFilter constructor
* Add null check for rowKeyPrefixes
* Fix checkstyle
Signed-off-by: huzheng <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 16, 2019
@titsuki@openinx
HBASE-22833MultiRowRangeFilter should provide a method for creating… (…
6e273e8
…#493)
* HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
* Delete superfluous comments
* Add description for MultiRowRangeFilter constructor
* Add null check for rowKeyPrefixes
* Fix checkstyle
Signed-off-by: huzheng <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 16, 2019
@titsuki@openinx
HBASE-22833MultiRowRangeFilter should provide a method for creating… (…
f9646ef
…#493)
* HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
* Delete superfluous comments
* Add description for MultiRowRangeFilter constructor
* Add null check for rowKeyPrefixes
* Fix checkstyle
Signed-off-by: huzheng <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 16, 2019
@titsuki@openinx
HBASE-22833MultiRowRangeFilter should provide a method for creating… (…
dfe7e27
…#493)
* HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
* Delete superfluous comments
* Add description for MultiRowRangeFilter constructor
* Add null check for rowKeyPrefixes
* Fix checkstyle
Signed-off-by: huzheng <openinx@gmail.com>
@Apache-HBase

Apache-HBase commented Aug 16, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec97Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0mvndep34Maven dependency ordering for branch
+1mvninstall375master passed
+1compile85master passed
+1checkstyle126master passed
+1shadedjars308branch has no errors when building our shaded downstream artifacts.
+1javadoc68master passed
0spotbugs287Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs376master passed
_ Patch Compile Tests _
0mvndep17Maven dependency ordering for patch
+1mvninstall340the patch passed
+1compile89the patch passed
+1javac89the patch passed
+1checkstyle36hbase-client: The patch generated 0 new + 13 unchanged - 3 fixed = 13 total (was 16)
+1checkstyle90The patch passed checkstyle in hbase-server
+1whitespace0The patch has no whitespace issues.
+1shadedjars308patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1184Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc72the patch passed
+1findbugs458the patch passed
_ Other Tests _
+1unit118hbase-client in the patch passed.
-1unit15814hbase-server in the patch failed.
+1asflicense45The patch does not generate ASF License warnings.
20553
ReasonTests
Failed junit testshadoop.hbase.master.procedure.TestSCPWithReplicas
hadoop.hbase.master.assignment.TestOpenRegionProcedureHang
hadoop.hbase.util.TestFromClientSide3WoUnsafe
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/8/artifact/out/Dockerfile
GITHUB PR#493
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 2b55029992d0 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-493/out/precommit/personality/provided.sh
git revisionmaster / edf6f68
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/8/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/8/testReport/
Max. process+thread count4706 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/8/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

asfgit pushed a commit that referenced this pull request Aug 16, 2019
@titsuki@openinx
HBASE-22833MultiRowRangeFilter should provide a method for creating… (…
d2793f1
…#493)
* HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
* Delete superfluous comments
* Add description for MultiRowRangeFilter constructor
* Add null check for rowKeyPrefixes
* Fix checkstyle
Signed-off-by: huzheng <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 16, 2019
@titsuki@openinx
HBASE-22833MultiRowRangeFilter should provide a method for creating… (…
7021f7e
…#493)
* HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
* Delete superfluous comments
* Add description for MultiRowRangeFilter constructor
* Add null check for rowKeyPrefixes
* Fix checkstyle
Signed-off-by: huzheng <openinx@gmail.com>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@titsukihuzheng
HBASE-22833 MultiRowRangeFilter should provide a method for creating… (…
3651c8b
…apache#493)
* HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
* Delete superfluous comments
* Add description for MultiRowRangeFilter constructor
* Add null check for rowKeyPrefixes
* Fix checkstyle
Signed-off-by: huzheng <openinx@gmail.com>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@titsukiJenkins
HBASE-22833 MultiRowRangeFilter should provide a method for creating… (…
254169c
…apache#493)
* HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
* Delete superfluous comments
* Add description for MultiRowRangeFilter constructor
* Add null check for rowKeyPrefixes
* Fix checkstyle
Signed-off-by: huzheng <openinx@gmail.com>
(cherry picked from commit bedab0d)
Change-Id: I08b9252338009f3e2943cf15c109338a09634efa
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@openinxopeninxopeninx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@titsuki@Apache-HBase@openinx