Skip to content

HBASE-22380 break circle replication when doing bulkload - #494

Merged
wchevreuil merged 11 commits into
apache:branch-2from
wchevreuil:HBASE-22380
Sep 21, 2019
Merged

HBASE-22380 break circle replication when doing bulkload#494
wchevreuil merged 11 commits into
apache:branch-2from
wchevreuil:HBASE-22380

Conversation

@wchevreuil

Copy link
Copy Markdown
Contributor

Creating an initial PR on branch-2. Had done some manual tests within two single node cluster and it seems to work. Am gonna work on UTs tomorrow and update this PR.

@wchevreuil

Copy link
Copy Markdown
ContributorAuthor

Also need to work on some javadocs for modified interfaces.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec74Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
0mvndep27Maven dependency ordering for branch
+1mvninstall337branch-2 passed
+1compile120branch-2 passed
+1checkstyle148branch-2 passed
+1shadedjars272branch has no errors when building our shaded downstream artifacts.
+1javadoc73branch-2 passed
0spotbugs186Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs410branch-2 passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall319the patch passed
+1compile121the patch passed
+1cc121the patch passed
+1javac121the patch passed
-1checkstyle89hbase-server: The patch generated 2 new + 302 unchanged - 0 fixed = 304 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars270patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1066Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc134the patch passed
+1javadoc84the patch passed
-1findbugs238hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit45hbase-protocol-shaded in the patch passed.
+1unit213hbase-client in the patch passed.
-1unit1866hbase-server in the patch failed.
+1asflicense47The patch does not generate ASF License warnings.
6820
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
Failed junit testshadoop.hbase.regionserver.TestBulkLoad
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/1/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux c93e687ca2a1 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 3233f67
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/1/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/1/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/1/testReport/
Max. process+thread count683 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@openinx
openinx self-requested a review August 15, 2019 03:06
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec70Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
0mvndep13Maven dependency ordering for branch
+1mvninstall314branch-2 passed
+1compile110branch-2 passed
+1checkstyle123branch-2 passed
+1shadedjars238branch has no errors when building our shaded downstream artifacts.
+1javadoc67branch-2 passed
0spotbugs195Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs401branch-2 passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall292the patch passed
+1compile111the patch passed
+1cc111the patch passed
+1javac111the patch passed
-1checkstyle76hbase-server: The patch generated 2 new + 302 unchanged - 0 fixed = 304 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars246patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck908Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc110the patch passed
+1javadoc72the patch passed
-1findbugs212hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit38hbase-protocol-shaded in the patch passed.
+1unit198hbase-client in the patch passed.
-1unit1789hbase-server in the patch failed.
+1asflicense46The patch does not generate ASF License warnings.
6142
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
Failed junit testshadoop.hbase.regionserver.TestBulkLoad
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/2/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 5de229006b4a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 9aec8d8
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/2/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/2/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/2/testReport/
Max. process+thread count700 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec75Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
0mvndep16Maven dependency ordering for branch
+1mvninstall326branch-2 passed
+1compile123branch-2 passed
+1checkstyle126branch-2 passed
+1shadedjars259branch has no errors when building our shaded downstream artifacts.
+1javadoc74branch-2 passed
0spotbugs208Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs430branch-2 passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall306the patch passed
+1compile117the patch passed
+1cc117the patch passed
+1javac117the patch passed
-1checkstyle82hbase-server: The patch generated 2 new + 302 unchanged - 0 fixed = 304 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars256patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1016Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc110the patch passed
+1javadoc68the patch passed
-1findbugs212hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit43hbase-protocol-shaded in the patch passed.
+1unit214hbase-client in the patch passed.
-1unit1805hbase-server in the patch failed.
+1asflicense45The patch does not generate ASF License warnings.
6415
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
Failed junit testshadoop.hbase.regionserver.TestBulkLoad
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/3/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 6fe5db654f06 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 6f9db46
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/3/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/3/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/3/testReport/
Max. process+thread count696 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
0mvndep15Maven dependency ordering for branch
+1mvninstall321branch-2 passed
+1compile109branch-2 passed
+1checkstyle125branch-2 passed
+1shadedjars249branch has no errors when building our shaded downstream artifacts.
+1javadoc72branch-2 passed
0spotbugs179Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs393branch-2 passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall290the patch passed
+1compile109the patch passed
+1cc109the patch passed
+1javac109the patch passed
-1checkstyle76hbase-server: The patch generated 2 new + 302 unchanged - 0 fixed = 304 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars254patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck878Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc97the patch passed
+1javadoc63the patch passed
-1findbugs201hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit35hbase-protocol-shaded in the patch passed.
+1unit203hbase-client in the patch passed.
-1unit1739hbase-server in the patch failed.
+1asflicense38The patch does not generate ASF License warnings.
5978
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
Failed junit testshadoop.hbase.regionserver.TestBulkLoad
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/4/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 662667c355aa 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 76a68bd
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/4/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/4/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/4/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/4/testReport/
Max. process+thread count693 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/4/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec41Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
0mvndep14Maven dependency ordering for branch
+1mvninstall301branch-2 passed
+1compile104branch-2 passed
+1checkstyle117branch-2 passed
+1shadedjars248branch has no errors when building our shaded downstream artifacts.
+1javadoc68branch-2 passed
0spotbugs192Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs402branch-2 passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall287the patch passed
+1compile106the patch passed
+1cc106the patch passed
+1javac106the patch passed
-1checkstyle72hbase-server: The patch generated 2 new + 302 unchanged - 0 fixed = 304 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars240patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck879Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc101the patch passed
+1javadoc65the patch passed
-1findbugs208hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit34hbase-protocol-shaded in the patch passed.
+1unit203hbase-client in the patch passed.
-1unit1678hbase-server in the patch failed.
+1asflicense37The patch does not generate ASF License warnings.
5874
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
Failed junit testshadoop.hbase.regionserver.TestBulkLoad
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/5/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux fd793bca1f83 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 4b60eac
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/5/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/5/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/5/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/5/testReport/
Max. process+thread count701 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/5/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec158Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
0mvndep15Maven dependency ordering for branch
+1mvninstall452branch-2 passed
+1compile145branch-2 passed
+1checkstyle152branch-2 passed
+1shadedjars320branch has no errors when building our shaded downstream artifacts.
+1javadoc79branch-2 passed
0spotbugs260Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs531branch-2 passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall429the patch passed
+1compile142the patch passed
+1cc142the patch passed
+1javac142the patch passed
-1checkstyle111hbase-server: The patch generated 2 new + 302 unchanged - 0 fixed = 304 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars354patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1370Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc160the patch passed
+1javadoc106the patch passed
-1findbugs268hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit48hbase-protocol-shaded in the patch passed.
+1unit228hbase-client in the patch passed.
-1unit2350hbase-server in the patch failed.
+1asflicense181The patch does not generate ASF License warnings.
8675
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
Failed junit testshadoop.hbase.regionserver.TestBulkLoad
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/6/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 6d6ebd73ce0c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 3ff3938
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/6/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/6/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/6/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/6/testReport/
Max. process+thread count699 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/6/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec161Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
0mvndep40Maven dependency ordering for branch
+1mvninstall432branch-2 passed
+1compile137branch-2 passed
+1checkstyle144branch-2 passed
+1shadedjars310branch has no errors when building our shaded downstream artifacts.
+1javadoc75branch-2 passed
0spotbugs206Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs446branch-2 passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall365the patch passed
+1compile147the patch passed
+1cc147the patch passed
+1javac147the patch passed
-1checkstyle104hbase-server: The patch generated 2 new + 302 unchanged - 0 fixed = 304 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars297patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1125Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc132the patch passed
+1javadoc75the patch passed
-1findbugs252hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit46hbase-protocol-shaded in the patch passed.
+1unit210hbase-client in the patch passed.
-1unit1843hbase-server in the patch failed.
+1asflicense39The patch does not generate ASF License warnings.
7222
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
Failed junit testshadoop.hbase.regionserver.TestBulkLoad
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/7/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 9f914dca2f55 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 3ff3938
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/7/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/7/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/7/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/7/testReport/
Max. process+thread count679 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/7/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec53Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
0mvndep13Maven dependency ordering for branch
+1mvninstall353branch-2 passed
+1compile130branch-2 passed
+1checkstyle125branch-2 passed
+1shadedjars251branch has no errors when building our shaded downstream artifacts.
+1javadoc68branch-2 passed
0spotbugs194Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs422branch-2 passed
_ Patch Compile Tests _
0mvndep17Maven dependency ordering for patch
+1mvninstall305the patch passed
+1compile121the patch passed
+1cc121the patch passed
+1javac121the patch passed
-1checkstyle81hbase-server: The patch generated 2 new + 302 unchanged - 0 fixed = 304 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars250patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck886Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc104the patch passed
+1javadoc65the patch passed
-1findbugs187hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit34hbase-protocol-shaded in the patch passed.
+1unit205hbase-client in the patch passed.
-1unit1656hbase-server in the patch failed.
+1asflicense37The patch does not generate ASF License warnings.
6031
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
Failed junit testshadoop.hbase.regionserver.TestBulkLoad
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/8/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 653a8388f116 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 43603ec
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/8/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/8/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/8/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/8/testReport/
Max. process+thread count705 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/8/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec37Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
0mvndep12Maven dependency ordering for branch
+1mvninstall307branch-2 passed
+1compile105branch-2 passed
+1checkstyle116branch-2 passed
+1shadedjars245branch has no errors when building our shaded downstream artifacts.
+1javadoc67branch-2 passed
0spotbugs198Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs406branch-2 passed
_ Patch Compile Tests _
0mvndep13Maven dependency ordering for patch
+1mvninstall277the patch passed
+1compile105the patch passed
+1cc105the patch passed
+1javac105the patch passed
-1checkstyle74hbase-server: The patch generated 2 new + 302 unchanged - 0 fixed = 304 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars236patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck875Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc100the patch passed
+1javadoc64the patch passed
-1findbugs204hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit34hbase-protocol-shaded in the patch passed.
+1unit195hbase-client in the patch passed.
-1unit1682hbase-server in the patch failed.
+1asflicense37The patch does not generate ASF License warnings.
5847
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
Failed junit testshadoop.hbase.regionserver.TestBulkLoad
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/9/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux ad7b39032e13 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / f9e20a6
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/9/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/9/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/9/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/9/testReport/
Max. process+thread count698 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/9/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec66Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
0mvndep17Maven dependency ordering for branch
+1mvninstall439branch-2 passed
+1compile140branch-2 passed
+1checkstyle160branch-2 passed
+1shadedjars335branch has no errors when building our shaded downstream artifacts.
+1javadoc88branch-2 passed
0spotbugs232Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs503branch-2 passed
_ Patch Compile Tests _
0mvndep19Maven dependency ordering for patch
+1mvninstall368the patch passed
+1compile144the patch passed
+1cc144the patch passed
+1javac144the patch passed
-1checkstyle98hbase-server: The patch generated 2 new + 302 unchanged - 0 fixed = 304 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars330patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1173Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc133the patch passed
+1javadoc86the patch passed
-1findbugs259hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit47hbase-protocol-shaded in the patch passed.
+1unit237hbase-client in the patch passed.
-1unit2026hbase-server in the patch failed.
+1asflicense47The patch does not generate ASF License warnings.
7576
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
Failed junit testshadoop.hbase.regionserver.TestBulkLoad
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/10/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 0d737c8f5317 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 8cbe20c
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/10/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/10/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/10/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/10/testReport/
Max. process+thread count696 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/10/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@wchevreuil

Copy link
Copy Markdown
ContributorAuthor

Fixed failed UTs. Added IT to validate the bulk replication loop condition.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec45Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti1Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
0mvndep13Maven dependency ordering for branch
+1mvninstall315branch-2 passed
+1compile111branch-2 passed
+1checkstyle125branch-2 passed
+1shadedjars251branch has no errors when building our shaded downstream artifacts.
+1javadoc69branch-2 passed
0spotbugs194Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs404branch-2 passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall294the patch passed
+1compile110the patch passed
+1cc110the patch passed
+1javac110the patch passed
-1checkstyle76hbase-server: The patch generated 4 new + 302 unchanged - 0 fixed = 306 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars254patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck909Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc106the patch passed
+1javadoc65the patch passed
-1findbugs206hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit35hbase-protocol-shaded in the patch passed.
+1unit204hbase-client in the patch passed.
+1unit7668hbase-server in the patch passed.
+1asflicense53The patch does not generate ASF License warnings.
12021
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/11/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux d205345b4ae5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 8cbe20c
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/11/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/11/artifact/out/new-findbugs-hbase-server.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/11/testReport/
Max. process+thread count4504 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/11/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec49Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
0mvndep17Maven dependency ordering for branch
+1mvninstall345branch-2 passed
+1compile119branch-2 passed
+1checkstyle128branch-2 passed
+1shadedjars255branch has no errors when building our shaded downstream artifacts.
+1javadoc68branch-2 passed
0spotbugs206Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs438branch-2 passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall332the patch passed
+1compile123the patch passed
+1cc123the patch passed
+1javac123the patch passed
-1checkstyle83hbase-server: The patch generated 4 new + 302 unchanged - 0 fixed = 306 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars276patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck980Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc112the patch passed
+1javadoc66the patch passed
-1findbugs192hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit42hbase-protocol-shaded in the patch passed.
+1unit200hbase-client in the patch passed.
+1unit7921hbase-server in the patch passed.
+1asflicense57The patch does not generate ASF License warnings.
12545
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/12/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 961410b955e3 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / c295fd7
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/12/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/12/artifact/out/new-findbugs-hbase-server.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/12/testReport/
Max. process+thread count4921 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/12/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec56Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
0mvndep16Maven dependency ordering for branch
+1mvninstall347branch-2 passed
+1compile110branch-2 passed
+1checkstyle123branch-2 passed
+1shadedjars250branch has no errors when building our shaded downstream artifacts.
+1javadoc69branch-2 passed
0spotbugs207Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs429branch-2 passed
_ Patch Compile Tests _
0mvndep17Maven dependency ordering for patch
+1mvninstall292the patch passed
+1compile110the patch passed
+1cc110the patch passed
+1javac110the patch passed
-1checkstyle79hbase-server: The patch generated 1 new + 302 unchanged - 0 fixed = 303 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars275patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1020Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc100the patch passed
+1javadoc63the patch passed
-1findbugs209hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit36hbase-protocol-shaded in the patch passed.
+1unit212hbase-client in the patch passed.
-1unit13020hbase-server in the patch failed.
+1asflicense66The patch does not generate ASF License warnings.
17587
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/13/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 7a88b9d02740 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / c295fd7
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/13/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/13/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/13/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/13/testReport/
Max. process+thread count4448 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/13/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@openinx

Copy link
Copy Markdown
Member

OK, we have added the UT... Will take a look

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec52Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
0mvndep12Maven dependency ordering for branch
+1mvninstall299branch-2 passed
+1compile109branch-2 passed
+1checkstyle119branch-2 passed
+1shadedjars240branch has no errors when building our shaded downstream artifacts.
+1javadoc64branch-2 passed
0spotbugs199Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs407branch-2 passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall277the patch passed
+1compile107the patch passed
+1cc107the patch passed
+1javac107the patch passed
-1checkstyle74hbase-server: The patch generated 1 new + 302 unchanged - 0 fixed = 303 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars235patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck870Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc103the patch passed
+1javadoc68the patch passed
-1findbugs177hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit35hbase-protocol-shaded in the patch passed.
+1unit199hbase-client in the patch passed.
+1unit8095hbase-server in the patch passed.
+1asflicense61The patch does not generate ASF License warnings.
12299
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/14/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 402c9b821bce 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 29ed415
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/14/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/14/artifact/out/new-findbugs-hbase-server.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/14/testReport/
Max. process+thread count4653 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/14/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

HFileReplicator hFileReplicator =
new HFileReplicator(this.provider.getConf(this.conf, replicationClusterId),
if(bulkLoadsPerClusters != null) {
for (String clusterId : bulkLoadsPerClusters.keySet()) {

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the reported findbugs issue: We do need to iterate over the keySet, as we do need the clusterId further to forward it to HFileReplicator call.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec41Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
0mvndep13Maven dependency ordering for branch
+1mvninstall306branch-2 passed
+1compile108branch-2 passed
+1checkstyle121branch-2 passed
+1shadedjars243branch has no errors when building our shaded downstream artifacts.
+1javadoc66branch-2 passed
0spotbugs195Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs418branch-2 passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall282the patch passed
+1compile106the patch passed
+1cc106the patch passed
+1javac106the patch passed
-1checkstyle71hbase-server: The patch generated 1 new + 302 unchanged - 0 fixed = 303 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars242patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck874Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc100the patch passed
+1javadoc64the patch passed
-1findbugs204hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit34hbase-protocol-shaded in the patch passed.
+1unit201hbase-client in the patch passed.
+1unit7729hbase-server in the patch passed.
+1asflicense61The patch does not generate ASF License warnings.
11954
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/15/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux fab6be06dd0b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / b7c7b4a
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/15/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/15/artifact/out/new-findbugs-hbase-server.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/15/testReport/
Max. process+thread count4533 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/15/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec41Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
0mvndep13Maven dependency ordering for branch
+1mvninstall312branch-2 passed
+1compile108branch-2 passed
+1checkstyle119branch-2 passed
+1shadedjars242branch has no errors when building our shaded downstream artifacts.
+1javadoc66branch-2 passed
0spotbugs171Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs381branch-2 passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall285the patch passed
+1compile111the patch passed
+1cc111the patch passed
+1javac111the patch passed
-1checkstyle76hbase-server: The patch generated 1 new + 302 unchanged - 0 fixed = 303 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars243patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck888Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc98the patch passed
+1javadoc69the patch passed
-1findbugs201hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit34hbase-protocol-shaded in the patch passed.
+1unit195hbase-client in the patch passed.
+1unit8115hbase-server in the patch passed.
+1asflicense68The patch does not generate ASF License warnings.
12338
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/16/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 3fd897ac8b62 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / e9874a6
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/16/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/16/artifact/out/new-findbugs-hbase-server.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/16/testReport/
Max. process+thread count4662 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/16/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec98Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
0mvndep14Maven dependency ordering for branch
+1mvninstall349branch-2 passed
+1compile125branch-2 passed
+1checkstyle144branch-2 passed
+1shadedjars273branch has no errors when building our shaded downstream artifacts.
+1javadoc73branch-2 passed
0spotbugs211Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs440branch-2 passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall330the patch passed
+1compile132the patch passed
+1cc132the patch passed
+1javac132the patch passed
-1checkstyle92hbase-server: The patch generated 1 new + 302 unchanged - 0 fixed = 303 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars278patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1018Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc112the patch passed
+1javadoc70the patch passed
-1findbugs231hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit43hbase-protocol-shaded in the patch passed.
+1unit230hbase-client in the patch passed.
+1unit13293hbase-server in the patch passed.
+1asflicense70The patch does not generate ASF License warnings.
18186
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/17/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 22d0a627fd4c 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 22814f8
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/17/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/17/artifact/out/new-findbugs-hbase-server.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/17/testReport/
Max. process+thread count4215 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/17/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec74Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
0mvndep14Maven dependency ordering for branch
+1mvninstall330branch-2 passed
+1compile105branch-2 passed
+1checkstyle123branch-2 passed
+1shadedjars256branch has no errors when building our shaded downstream artifacts.
+1javadoc68branch-2 passed
0spotbugs196Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs415branch-2 passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall300the patch passed
+1compile110the patch passed
+1cc110the patch passed
+1javac110the patch passed
-1checkstyle81hbase-server: The patch generated 1 new + 302 unchanged - 0 fixed = 303 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars255patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck950Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc101the patch passed
+1javadoc65the patch passed
-1findbugs212hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit36hbase-protocol-shaded in the patch passed.
+1unit205hbase-client in the patch passed.
-1unit17761hbase-server in the patch failed.
+1asflicense85The patch does not generate ASF License warnings.
22261
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257]
Failed junit testshadoop.hbase.master.procedure.TestSCPWithReplicas
hadoop.hbase.TestRegionRebalancing
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
hadoop.hbase.client.TestAsyncReplicationAdminApiWithClusters
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/18/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 0c627d572448 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 9d178cf
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/18/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/18/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/18/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/18/testReport/
Max. process+thread count4675 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/18/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec75Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
0mvndep16Maven dependency ordering for branch
+1mvninstall319branch-2 passed
+1compile119branch-2 passed
+1checkstyle126branch-2 passed
+1shadedjars258branch has no errors when building our shaded downstream artifacts.
+1javadoc73branch-2 passed
0spotbugs194Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs402branch-2 passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall299the patch passed
+1compile116the patch passed
+1cc116the patch passed
+1javac116the patch passed
-1checkstyle75hbase-server: The patch generated 1 new + 302 unchanged - 0 fixed = 303 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars282patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck952Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc113the patch passed
+1javadoc67the patch passed
-1findbugs215hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit35hbase-protocol-shaded in the patch passed.
+1unit204hbase-client in the patch passed.
-1unit16454hbase-server in the patch failed.
+1asflicense100The patch does not generate ASF License warnings.
21022
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257]
Failed junit testshadoop.hbase.master.procedure.TestSCPWithReplicas
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/19/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 8b4b921cc7f3 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 6bc78d3
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/19/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/19/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/19/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/19/testReport/
Max. process+thread count4423 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/19/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec42Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
0mvndep27Maven dependency ordering for branch
+1mvninstall305branch-2 passed
+1compile106branch-2 passed
+1checkstyle122branch-2 passed
+1shadedjars250branch has no errors when building our shaded downstream artifacts.
+1javadoc68branch-2 passed
0spotbugs186Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs400branch-2 passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall281the patch passed
+1compile106the patch passed
+1cc106the patch passed
+1javac106the patch passed
-1checkstyle77hbase-server: The patch generated 1 new + 302 unchanged - 0 fixed = 303 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars246patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck881Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc101the patch passed
+1javadoc65the patch passed
-1findbugs194hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit33hbase-protocol-shaded in the patch passed.
+1unit197hbase-client in the patch passed.
-1unit8096hbase-server in the patch failed.
+1asflicense65The patch does not generate ASF License warnings.
12333
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/20/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux d04a9ce6c55e 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / e28a7c2
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/20/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/20/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/20/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/20/testReport/
Max. process+thread count4436 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/20/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
0mvndep14Maven dependency ordering for branch
+1mvninstall322branch-2 passed
+1compile116branch-2 passed
+1checkstyle127branch-2 passed
+1shadedjars258branch has no errors when building our shaded downstream artifacts.
+1javadoc71branch-2 passed
0spotbugs204Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs423branch-2 passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall304the patch passed
+1compile133the patch passed
+1cc133the patch passed
+1javac133the patch passed
-1checkstyle89hbase-server: The patch generated 1 new + 302 unchanged - 0 fixed = 303 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars278patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1042Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc107the patch passed
+1javadoc77the patch passed
-1findbugs204hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit41hbase-protocol-shaded in the patch passed.
+1unit210hbase-client in the patch passed.
-1unit8118hbase-server in the patch failed.
+1asflicense80The patch does not generate ASF License warnings.
12829
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/21/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux ce92e92f387e 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / e28a7c2
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/21/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/21/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/21/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/21/testReport/
Max. process+thread count4410 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/21/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
0mvndep12Maven dependency ordering for branch
+1mvninstall320branch-2 passed
+1compile115branch-2 passed
+1checkstyle121branch-2 passed
+1shadedjars253branch has no errors when building our shaded downstream artifacts.
+1javadoc70branch-2 passed
0spotbugs206Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs433branch-2 passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall302the patch passed
+1compile118the patch passed
+1cc118the patch passed
+1javac118the patch passed
-1checkstyle81hbase-server: The patch generated 1 new + 302 unchanged - 0 fixed = 303 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars258patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck940Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc118the patch passed
+1javadoc73the patch passed
-1findbugs219hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit40hbase-protocol-shaded in the patch passed.
+1unit211hbase-client in the patch passed.
+1unit8359hbase-server in the patch passed.
+1asflicense59The patch does not generate ASF License warnings.
12911
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/22/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 2cd12dfb0e87 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 53522f3
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/22/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/22/artifact/out/new-findbugs-hbase-server.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/22/testReport/
Max. process+thread count4364 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/22/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec86Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
0mvndep14Maven dependency ordering for branch
+1mvninstall351branch-2 passed
+1compile124branch-2 passed
+1checkstyle150branch-2 passed
+1shadedjars278branch has no errors when building our shaded downstream artifacts.
+1javadoc75branch-2 passed
0spotbugs233Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs464branch-2 passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall340the patch passed
+1compile146the patch passed
+1cc146the patch passed
+1javac146the patch passed
-1checkstyle100hbase-server: The patch generated 1 new + 302 unchanged - 0 fixed = 303 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars288patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1041Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc118the patch passed
+1javadoc74the patch passed
-1findbugs251hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit47hbase-protocol-shaded in the patch passed.
+1unit227hbase-client in the patch passed.
-1unit16421hbase-server in the patch failed.
+1asflicense71The patch does not generate ASF License warnings.
21480
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257]
Failed junit testshadoop.hbase.master.assignment.TestMergeTableRegionsProcedure
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/35/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 3267cf6d0876 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / a18be19
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/35/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/35/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/35/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/35/testReport/
Max. process+thread count4667 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/35/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…you can replace a few request.getClusterId() calls.'
…er2.
This is enough to fail the test, since we do bulk load on cluster1,
cluster1 replicates to cluster2, who in turn replicates to cluster3.
As we only track the originator id (cluster1), we won't have the infinite loop
between cluster1 and cluster2, but cluster2 and cluster3 will keep replicating
between each other indefinitely.
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
0mvndep14Maven dependency ordering for branch
+1mvninstall355branch-2 passed
+1compile124branch-2 passed
+1checkstyle150branch-2 passed
+1shadedjars282branch has no errors when building our shaded downstream artifacts.
+1javadoc75branch-2 passed
0spotbugs205Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs436branch-2 passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall321the patch passed
+1compile136the patch passed
+1cc136the patch passed
+1javac136the patch passed
-1checkstyle98hbase-server: The patch generated 1 new + 302 unchanged - 0 fixed = 303 total (was 302)
+1whitespace0The patch has no whitespace issues.
+1shadedjars294patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1013Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc116the patch passed
+1javadoc73the patch passed
-1findbugs231hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit41hbase-protocol-shaded in the patch passed.
+1unit207hbase-client in the patch passed.
+1unit9420hbase-server in the patch passed.
+1asflicense66The patch does not generate ASF License warnings.
14252
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/36/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 1aaa71aac532 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 9b9f055
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/36/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/36/artifact/out/new-findbugs-hbase-server.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/36/testReport/
Max. process+thread count4367 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/36/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…we can track all clusters
that had already processed a given bulk load request. Needed to change also WAL proto for
bulk load event, as well as additional classes logic to now handle a list of ids, instead of a single one.
Also replaced these sleeps by a CountDownLatch being updated by
a _postBulkLoadHFile_ CP method in this test, to help prevent
potential flakyness, as we can set a huge timeout in the latch.await,
without worryig too much with penalysing fast runs.
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec38Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0mvndep13Maven dependency ordering for branch
+1mvninstall350branch-2 passed
+1compile130branch-2 passed
+1checkstyle152branch-2 passed
+1shadedjars283branch has no errors when building our shaded downstream artifacts.
+1javadoc74branch-2 passed
0spotbugs223Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs465branch-2 passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall328the patch passed
+1compile127the patch passed
+1cc127the patch passed
+1javac127the patch passed
-1checkstyle97hbase-server: The patch generated 3 new + 300 unchanged - 0 fixed = 303 total (was 300)
+1whitespace0The patch has no whitespace issues.
+1shadedjars279patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1070Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc133the patch passed
+1javadoc81the patch passed
-1findbugs269hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit49hbase-protocol-shaded in the patch passed.
+1unit240hbase-client in the patch passed.
-1unit9448hbase-server in the patch failed.
+1asflicense68The patch does not generate ASF License warnings.
14584
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257]
Failed junit testshadoop.hbase.regionserver.TestBulkLoadReplication
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/37/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 6cac864672d6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 84b4a61
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/37/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/37/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/37/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/37/testReport/
Max. process+thread count4563 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/37/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec127Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0mvndep19Maven dependency ordering for branch
+1mvninstall384branch-2 passed
+1compile128branch-2 passed
+1checkstyle141branch-2 passed
+1shadedjars256branch has no errors when building our shaded downstream artifacts.
+1javadoc71branch-2 passed
0spotbugs213Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs433branch-2 passed
_ Patch Compile Tests _
0mvndep17Maven dependency ordering for patch
+1mvninstall310the patch passed
+1compile114the patch passed
+1cc114the patch passed
+1javac114the patch passed
-1checkstyle39hbase-client: The patch generated 1 new + 314 unchanged - 0 fixed = 315 total (was 314)
-1checkstyle84hbase-server: The patch generated 3 new + 300 unchanged - 0 fixed = 303 total (was 300)
+1whitespace0The patch has no whitespace issues.
+1shadedjars262patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck997Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc112the patch passed
+1javadoc74the patch passed
-1findbugs201hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit37hbase-protocol-shaded in the patch passed.
+1unit196hbase-client in the patch passed.
-1unit16905hbase-server in the patch failed.
+1asflicense74The patch does not generate ASF License warnings.
21686
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
Failed junit testshadoop.hbase.regionserver.TestSplitTransactionOnCluster
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/38/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux f6e784ec7309 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 84b4a61
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/38/artifact/out/diff-checkstyle-hbase-client.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/38/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/38/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/38/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/38/testReport/
Max. process+thread count4676 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/38/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec40Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0mvndep13Maven dependency ordering for branch
+1mvninstall351branch-2 passed
+1compile126branch-2 passed
+1checkstyle145branch-2 passed
+1shadedjars278branch has no errors when building our shaded downstream artifacts.
+1javadoc72branch-2 passed
0spotbugs183Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs413branch-2 passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall323the patch passed
+1compile135the patch passed
+1cc135the patch passed
+1javac135the patch passed
+1checkstyle148the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars281patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1008Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc127the patch passed
+1javadoc81the patch passed
-1findbugs217hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit40hbase-protocol-shaded in the patch passed.
+1unit209hbase-client in the patch passed.
+1unit9098hbase-server in the patch passed.
+1asflicense66The patch does not generate ASF License warnings.
13907
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/39/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 825fd4215235 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 84b4a61
Default Java1.8.0_181
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/39/artifact/out/new-findbugs-hbase-server.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/39/testReport/
Max. process+thread count4461 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/39/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec43Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti1Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0mvndep16Maven dependency ordering for branch
+1mvninstall354branch-2 passed
+1compile141branch-2 passed
+1checkstyle158branch-2 passed
+1shadedjars324branch has no errors when building our shaded downstream artifacts.
+1javadoc84branch-2 passed
0spotbugs206Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs474branch-2 passed
_ Patch Compile Tests _
0mvndep18Maven dependency ordering for patch
+1mvninstall376the patch passed
+1compile142the patch passed
+1cc142the patch passed
+1javac142the patch passed
+1checkstyle158the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars316patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1116Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc133the patch passed
+1javadoc84the patch passed
-1findbugs247hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit46hbase-protocol-shaded in the patch passed.
+1unit226hbase-client in the patch passed.
+1unit9547hbase-server in the patch passed.
+1asflicense84The patch does not generate ASF License warnings.
14883
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/40/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 2b0e2c11d02b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 6ece958
Default Java1.8.0_181
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/40/artifact/out/new-findbugs-hbase-server.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/40/testReport/
Max. process+thread count4196 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/40/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec44Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0mvndep14Maven dependency ordering for branch
+1mvninstall331branch-2 passed
+1compile123branch-2 passed
+1checkstyle145branch-2 passed
+1shadedjars261branch has no errors when building our shaded downstream artifacts.
+1javadoc75branch-2 passed
0spotbugs183Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs421branch-2 passed
_ Patch Compile Tests _
0mvndep17Maven dependency ordering for patch
+1mvninstall302the patch passed
+1compile126the patch passed
+1cc126the patch passed
+1javac126the patch passed
+1checkstyle139the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars257patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1149Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc133the patch passed
+1javadoc80the patch passed
-1findbugs257hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit51hbase-protocol-shaded in the patch passed.
+1unit225hbase-client in the patch passed.
-1unit10015hbase-server in the patch failed.
+1asflicense83The patch does not generate ASF License warnings.
15014
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/41/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 1401e96a9823 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 4a4208f
Default Java1.8.0_181
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/41/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/41/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/41/testReport/
Max. process+thread count4653 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/41/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec37Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0mvndep15Maven dependency ordering for branch
+1mvninstall339branch-2 passed
+1compile124branch-2 passed
+1checkstyle146branch-2 passed
+1shadedjars277branch has no errors when building our shaded downstream artifacts.
+1javadoc74branch-2 passed
0spotbugs216Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs451branch-2 passed
_ Patch Compile Tests _
0mvndep17Maven dependency ordering for patch
+1mvninstall328the patch passed
+1compile121the patch passed
+1cc121the patch passed
+1javac121the patch passed
+1checkstyle146the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars272patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1036Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc122the patch passed
+1javadoc78the patch passed
-1findbugs251hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit46hbase-protocol-shaded in the patch passed.
+1unit219hbase-client in the patch passed.
-1unit10482hbase-server in the patch failed.
+1asflicense72The patch does not generate ASF License warnings.
15385
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
Failed junit testshadoop.hbase.client.TestMobSnapshotCloneIndependence
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/42/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux a1ac18d0eaa5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / f088dd5
Default Java1.8.0_181
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/42/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/42/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/42/testReport/
Max. process+thread count4456 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/42/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec44Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0mvndep14Maven dependency ordering for branch
+1mvninstall349branch-2 passed
+1compile132branch-2 passed
+1checkstyle141branch-2 passed
+1shadedjars249branch has no errors when building our shaded downstream artifacts.
+1javadoc76branch-2 passed
0spotbugs204Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs417branch-2 passed
_ Patch Compile Tests _
0mvndep18Maven dependency ordering for patch
+1mvninstall286the patch passed
+1compile119the patch passed
+1cc119the patch passed
+1javac119the patch passed
+1checkstyle143the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars251patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck904Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc112the patch passed
+1javadoc74the patch passed
-1findbugs196hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit39hbase-protocol-shaded in the patch passed.
+1unit209hbase-client in the patch passed.
+1unit9052hbase-server in the patch passed.
+1asflicense95The patch does not generate ASF License warnings.
13562
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/43/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux 11bc8fed4cd1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 576e688
Default Java1.8.0_181
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/43/artifact/out/new-findbugs-hbase-server.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/43/testReport/
Max. process+thread count4324 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/43/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec147Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0mvndep38Maven dependency ordering for branch
+1mvninstall479branch-2 passed
+1compile163branch-2 passed
+1checkstyle174branch-2 passed
+1shadedjars347branch has no errors when building our shaded downstream artifacts.
+1javadoc100branch-2 passed
0spotbugs237Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs528branch-2 passed
_ Patch Compile Tests _
0mvndep19Maven dependency ordering for patch
+1mvninstall451the patch passed
+1compile154the patch passed
+1cc154the patch passed
+1javac154the patch passed
+1checkstyle165the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars322patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1387Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc145the patch passed
+1javadoc84the patch passed
-1findbugs259hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit50hbase-protocol-shaded in the patch passed.
+1unit224hbase-client in the patch passed.
-1unit16642hbase-server in the patch failed.
+1asflicense94The patch does not generate ASF License warnings.
22822
ReasonTests
FindBugsmodule:hbase-server
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256]
Failed junit testshadoop.hbase.client.TestAdmin
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
SubsystemReport/Notes
DockerClient=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/44/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
unameLinux d960c47cd7c1 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 41fddd4
Default Java1.8.0_181
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/44/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/44/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/44/testReport/
Max. process+thread count4729 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/44/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@busbey

Copy link
Copy Markdown
Contributor

Please either make the findbugs correction or annotate things to ack the complaint.

@wchevreuil

Copy link
Copy Markdown
ContributorAuthor

On the reported findbugs issue: We do need to iterate over the keySet, as we do need the clusterId further to forward it to HFileReplicator call. What do you mean by annotate it @busbey ? Commenting on that line?

@nkalmarnkalmar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had one question, not sure if String vs UUID was intentional or not. (See my comment)
Otherwise looks good!

HFileReplicator hFileReplicator =
new HFileReplicator(this.provider.getConf(this.conf, replicationClusterId),
if(bulkLoadsPerClusters != null) {
for (List<String> clusterIds : bulkLoadsPerClusters.keySet()) {

@nkalmarnkalmarSep 11, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason String is used for clusterId?
I see UUID used elsewhere in this class.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That came up as well on the separate PR I created for master branch. Pasting my explanation made there:

HRegionServer already keeps a String clusterId (not UUID), which I'm using to check against the incoming bulk load request. Converting the request List to List when clusterId is already represented as String didn't seem to give much gain here. Maybe we should raise a separate jira to convert all existing String representations of cluster id into UUID, and including this one as part of this work?

We agreed with that suggestion to open a separate jira to address replacing existing String clusterId to UUID.

@busbey

Copy link
Copy Markdown
Contributor

On the reported findbugs issue: We do need to iterate over the keySet, as we do need the clusterId further to forward it to HFileReplicator call. What do you mean by annotate it @busbey ? Commenting on that line?

You can annotate the implementation so that findbugs doesn't report an error. I think the lowest level you can do it for is the method.

In this case though, I believe the complaint from findbugs is that we should be using entrySet instead of both keySet and then getValue with the key.

@wchevreuil

wchevreuil commented Sep 17, 2019

Copy link
Copy Markdown
ContributorAuthor

In this case though, I believe the complaint from findbugs is that we should be using entrySet instead of both keySet and then getValue with the key.

Thanks for the tip, @busbey! Had gone with that on the last commit.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec2m 35sDocker mode activated.
_ Prechecks _
💚dupname0m 1sNo case conflicting files found.
💙prototool0m 0sprototool was not available.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
💙mvndep0m 18sMaven dependency ordering for branch
💚mvninstall8m 9sbranch-2 passed
💚compile2m 37sbranch-2 passed
💚checkstyle2m 54sbranch-2 passed
💚shadedjars5m 45sbranch has no errors when building our shaded downstream artifacts.
💚javadoc1m 35sbranch-2 passed
💙spotbugs4m 6sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs8m 51sbranch-2 passed
_ Patch Compile Tests _
💙mvndep0m 16sMaven dependency ordering for patch
💚mvninstall7m 6sthe patch passed
💚compile2m 42sthe patch passed
💚cc2m 42sthe patch passed
💚javac2m 42sthe patch passed
💔checkstyle1m 49shbase-server: The patch generated 1 new + 300 unchanged - 0 fixed = 301 total (was 300)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars5m 43spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck23m 7sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚hbaseprotoc2m 32sthe patch passed
💚javadoc1m 40sthe patch passed
💚findbugs9m 29sthe patch passed
_ Other Tests _
💚unit0m 47shbase-protocol-shaded in the patch passed.
💚unit2m 41shbase-client in the patch passed.
💔unit279m 32shbase-server in the patch failed.
💚asflicense1m 15sThe patch does not generate ASF License warnings.
381m 49s
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestHRegionWithInMemoryFlush
SubsystemReport/Notes
DockerClient=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/47/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux bcb90a6f9458 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / faed3e4
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/47/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/47/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/47/testReport/
Max. process+thread count3944 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/47/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec1m 18sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💙prototool0m 0sprototool was not available.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
💙mvndep0m 27sMaven dependency ordering for branch
💚mvninstall5m 50sbranch-2 passed
💚compile2m 1sbranch-2 passed
💚checkstyle2m 28sbranch-2 passed
💚shadedjars4m 33sbranch has no errors when building our shaded downstream artifacts.
💚javadoc1m 11sbranch-2 passed
💙spotbugs3m 28sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs7m 14sbranch-2 passed
_ Patch Compile Tests _
💙mvndep0m 14sMaven dependency ordering for patch
💚mvninstall5m 17sthe patch passed
💚compile2m 2sthe patch passed
💚cc2m 2sthe patch passed
💚javac2m 2sthe patch passed
💚checkstyle2m 27sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 33spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck16m 49sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚hbaseprotoc1m 52sthe patch passed
💚javadoc1m 10sthe patch passed
💚findbugs7m 33sthe patch passed
_ Other Tests _
💚unit0m 41shbase-protocol-shaded in the patch passed.
💚unit2m 19shbase-client in the patch passed.
💔unit292m 42shbase-server in the patch failed.
💚asflicense1m 13sThe patch does not generate ASF License warnings.
370m 27s
ReasonTests
Failed junit testshadoop.hbase.client.TestFromClientSideWithCoprocessor
hadoop.hbase.master.TestSplitWALManager
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
SubsystemReport/Notes
DockerClient=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/48/artifact/out/Dockerfile
GITHUB PR#494
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 7a7e21d26b94 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
git revisionbranch-2 / 37d49aa
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/48/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/48/testReport/
Max. process+thread count4896 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/48/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@nkalmarnkalmar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @wchevreuil , LGTM!

@wchevreuil
wchevreuil merged commit 38c8bd3 into apache:branch-2Sep 21, 2019
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Norbert Kalmar <nkalmar@cloudera.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@wchevreuil@Apache-HBase@openinx@busbey@saintstack@apurtell@nkalmar