Skip to content

HBASE-27485 HBaseTestingUtility minicluster requires log4j2 - #4941

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-27485
Jan 4, 2023
Merged

HBASE-27485 HBaseTestingUtility minicluster requires log4j2#4941
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-27485

Conversation

@Apache9

@Apache9Apache9 commented Dec 29, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@Apache9Apache9 self-assigned this Dec 29, 2022
@Apache9

Apache9 commented Dec 29, 2022

Copy link
Copy Markdown
ContributorAuthor

@ndimiduk I just removed the setLogLevel call in HBTU, and then added some configurations in log4j2.properties to set the log level. I think for downstreamer users, since they could use different logging framework, it is their duty to change the log level if they want.

Thanks.

@Apache-HBase

Apache-HBase commented Dec 29, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 57smaster passed
+1 💚compile2m 58smaster passed
+1 💚checkstyle0m 49smaster passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
+1 💚spotbugs2m 8smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 34sthe patch passed
+1 💚compile2m 56sthe patch passed
+1 💚javac2m 56sthe patch passed
+1 💚checkstyle0m 43sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck9m 45sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 43spatch has no errors when running spotless:check.
+1 💚spotbugs2m 32sthe patch passed
_ Other Tests _
+1 💚asflicense0m 22sThe patch does not generate ASF License warnings.
36m 49s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4941/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4941
Optional Testsdupname asflicense spotless javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux d6b8e6ad9f03 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7ef63b6
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count80 (vs. ulimit of 30000)
modulesC: hbase-logging hbase-server hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4941/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 29, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 23smaster passed
+1 💚compile0m 55smaster passed
+1 💚shadedjars4m 4sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 40smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 4sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚shadedjars4m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sthe patch passed
_ Other Tests _
+1 💚unit0m 8shbase-logging in the patch passed.
+1 💚unit208m 6shbase-server in the patch passed.
+1 💚unit2m 16shbase-testing-util in the patch passed.
231m 56s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4941/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4941
Optional Testsunit javac javadoc shadedjars compile
unameLinux ffd0d9261b96 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7ef63b6
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4941/1/testReport/
Max. process+thread count2641 (vs. ulimit of 30000)
modulesC: hbase-logging hbase-server hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4941/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 29, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 54sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 48smaster passed
+1 💚compile1m 11smaster passed
+1 💚shadedjars3m 47sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 52smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 31sthe patch passed
+1 💚compile1m 10sthe patch passed
+1 💚javac1m 10sthe patch passed
+1 💚shadedjars3m 45spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 50sthe patch passed
_ Other Tests _
+1 💚unit0m 11shbase-logging in the patch passed.
+1 💚unit215m 18shbase-server in the patch passed.
+1 💚unit2m 14shbase-testing-util in the patch passed.
240m 31s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4941/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4941
Optional Testsunit javac javadoc shadedjars compile
unameLinux 2be03a2d6a17 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7ef63b6
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4941/1/testReport/
Max. process+thread count2792 (vs. ulimit of 30000)
modulesC: hbase-logging hbase-server hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4941/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit 3f1087f into apache:masterJan 4, 2023
Apache9 added a commit that referenced this pull request Jan 4, 2023
@Apache9
HBASE-27485HBaseTestingUtility minicluster requires log4j2 (#4941)
49735cd
Signed-off-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
Reviewed-by: SiCheng-Zheng <643463623@qq.com>
(cherry picked from commit 3f1087f)
Apache9 added a commit that referenced this pull request Jan 4, 2023
@Apache9
HBASE-27485HBaseTestingUtility minicluster requires log4j2 (#4941)
2fdefdc
Signed-off-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
Reviewed-by: SiCheng-Zheng <643463623@qq.com>
(cherry picked from commit 3f1087f)
virajjasani pushed a commit to virajjasani/hbase that referenced this pull request Jan 5, 2023
@Apache9@virajjasani
HBASE-27485 HBaseTestingUtility minicluster requires log4j2 (apache#4941
997e350
)
Signed-off-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
Reviewed-by: SiCheng-Zheng <643463623@qq.com>
@ndimiduk

ndimiduk commented Jan 6, 2023

Copy link
Copy Markdown
Member

Thanks guys.

bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Apr 19, 2023
@Apache9@bbeaudreault
HubSpot Backport: HBASE-27485 HBaseTestingUtility minicluster require…
2ca2974
…s log4j2 (apache#4941)
Signed-off-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
Reviewed-by: SiCheng-Zheng <643463623@qq.com>
(cherry picked from commit 3f1087f)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrajeshbabuchrajeshbabuchrajeshbabu approved these changes
@ndimidukndimidukAwaiting requested review from ndimiduk
+1 more reviewer
@SiCheng-ZhengSiCheng-ZhengSiCheng-Zheng approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Apache9Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Apache9@Apache-HBase@ndimiduk@chrajeshbabu@SiCheng-Zheng