Skip to content

HBASE-21467 Fix flaky test TestCoprocessorClassLoader.testCleanupOldJars - #100

Merged
saintstack merged 1 commit into
apache:masterfrom
OrDTesters:fix-flaky-testCleanupOldJars
Apr 23, 2019
Merged

HBASE-21467 Fix flaky test TestCoprocessorClassLoader.testCleanupOldJars#100
saintstack merged 1 commit into
apache:masterfrom
OrDTesters:fix-flaky-testCleanupOldJars

Conversation

@OrDTesters

Copy link
Copy Markdown
Contributor

TestCoprocessorClassLoader.testCleanupOldJars fails when run by itself.

This can be fixed by calling CoprocessorClassLoader.getClassLoader, which initializes the jar file needed by testCleanupOldJars.

Link to issue: HBASE-21467

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec278Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1mvninstall319master passed
+1compile25master passed
+1checkstyle29master passed
+1shadedjars332branch has no errors when building our shaded downstream artifacts.
+1findbugs51master passed
+1javadoc25master passed
_ Patch Compile Tests _
+1mvninstall315the patch passed
+1compile25the patch passed
+1javac25the patch passed
+1checkstyle28the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars334patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck654Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs59the patch passed
+1javadoc23the patch passed
_ Other Tests _
+1unit188hbase-common in the patch passed.
+1asflicense14The patch does not generate ASF License warnings.
2763
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-100/1/artifact/out/Dockerfile
GITHUB PR#100
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux a38276c593df 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 11547b7
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-100/1/testReport/
Max. process+thread count290 (vs. ulimit of 10000)
modulesC: hbase-common U: hbase-common
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-100/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec21Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1mvninstall254master passed
+1compile21master passed
+1checkstyle21master passed
+1shadedjars262branch has no errors when building our shaded downstream artifacts.
+1findbugs42master passed
+1javadoc19master passed
_ Patch Compile Tests _
+1mvninstall270the patch passed
+1compile23the patch passed
+1javac23the patch passed
+1checkstyle24the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars281patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck534Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs50the patch passed
+1javadoc19the patch passed
_ Other Tests _
+1unit156hbase-common in the patch passed.
+1asflicense10The patch does not generate ASF License warnings.
2064
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-100/2/artifact/out/Dockerfile
GITHUB PR#100
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux a9816267dd7e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / f30d6c9
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-100/2/testReport/
Max. process+thread count358 (vs. ulimit of 10000)
modulesC: hbase-common U: hbase-common
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-100/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@saintstack
saintstack merged commit 1584d24 into apache:masterApr 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@OrDTesters@Apache-HBase@toyokazu03102478@saintstack