Uh oh!
There was an error while loading. Please reload this page.
[HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. - #499
Conversation
Apache-HBase
commented
Aug 15, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 16, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 16, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 16, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 16, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 16, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 17, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 17, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 17, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 17, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 18, 2019
🎊 +1 overall
This message was automatically generated. |
| } | ||
| } | ||
| if (peerClusterId == null) { |
There was a problem hiding this comment.
I think here we just need to add the same check like above?
if (!this.isSourceActive()) {
return;
}
There was a problem hiding this comment.
Actually this makes more sense. Thanks for the idea.
| } | ||
| for (NavigableSet<String> walsByGroup : walsById.get(peerId).values()) { | ||
| walsByGroup.forEach(wal -> src.enqueueLog(new Path(this.logDir, wal))); | ||
| if (walsById.get(peerId) != null) { |
There was a problem hiding this comment.
And is this possible? In the addSource method, we will always put a Map into the walsByGroup for the corresponding peerId. Notice that the code for branch-2 have been changed a lot from branch-1 so...
Apache-HBase
commented
Aug 18, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 18, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 19, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 19, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 20, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 20, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 20, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 21, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 21, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 21, 2019
💔 -1 overall
This message was automatically generated. |
@apurtell This is the patch for master branch. please review.
Cherry-picking master commit applies cleanly to branch-2.