Uh oh!
There was an error while loading. Please reload this page.
HBASE-22870 reflection fails to access a private nested class - #503
Merged
Conversation
Reidddddd
commented
Aug 17, 2019
Contributor
Did you raise a related JIRA ticket? If not, please raise one first, it is easy for history tracking. |
satanson
commented
Aug 17, 2019
ContributorAuthor
hbase-2.1.5 will be deployed in our product environment, now, interface compablity, integration test and fault exercises are being performed, so more and more bugs will be exposed. I want to contribute bugfix, how can I do? It there a guide doc for new comer? |
Reidddddd
commented
Aug 17, 2019
Contributor
HBASE-22870, is it yours? Please update the description in JIRA too. |
satanson
commented
Aug 17, 2019
ContributorAuthor
@Reidddddd |
Reidddddd
requested changes
Aug 17, 2019
| * Force to terminate region server when abort timeout. | ||
| */ | ||
| private static class SystemExitWhenAbortTimeout extends TimerTask { | ||
| public static class SystemExitWhenAbortTimeout extends TimerTask { |
Contributor
There was a problem hiding this comment.
It is reasonable to keep it private since it is an inner task which should not be seen outside service.
I suggest usinggetDeclaredConstructor().setAccessible(true).newInstance() to bypass it.
ContributorAuthor
There was a problem hiding this comment.
ok, good suggest, setAccessible return void, so should write like this
Constructor<? extends TimerTask> timerTaskCtor =
Class.forName(conf.get(ABORT_TIMEOUT_TASK, SystemExitWhenAbortTimeout.class.getName()))
.asSubclass(TimerTask.class).getDeclaredConstructor();
timerTaskCtor.setAccessible(true);
abortTimeoutTask = timerTaskCtor.newInstance();
Reidddddd
commented
Aug 17, 2019
Contributor
Let's wait some time to see if any other comment. I'll will commit it tomorrow if no further comment. |
Apache-HBase
commented
Aug 17, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 17, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 17, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 17, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 17, 2019
💔 -1 overall
This message was automatically generated. |
satanson
commented
Aug 17, 2019
ContributorAuthor
commit |
Apache-HBase
commented
Aug 17, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 18, 2019
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HMaster crashes at org/apache/hadoop/hbase/regionserver/HRegionServer.java:1044
A private static nested class can not be instantiated via reflection.
code snippet
log in product environtment