HBASE-27652 Client-side lock contention around Configuration when using read replica regions

[ndimiduk]

No description provided.

[ndimiduk]

Posting up a PR vs. branch-2. I didn't find RpcRetryingCallerFactory on master. I guess the master patch will look quite different.

[ndimiduk]

Avoid calling this method as much as is reasonable.

The HRegionServer call site is particularly insidious. It is called from the HRegionServer constructor and looks like this,

rpcRetryingCallerFactory = RpcRetryingCallerFactory.instantiate(this.conf,
clusterConnection == null ? null : clusterConnection.getConnectionMetrics());

I think that clusterConnection is always null here, because clusterConnection is instantiated in protected synchronized void setupClusterConnection(), which, as far as I can tell, is only called from public void run().

[Apache9]

Posting up a PR vs. branch-2. I didn't find RpcRetryingCallerFactory on master. I guess the master patch will look quite different.

On master the whole sync client is built upon async client, so the retrying caller related classes are all removed.

[Apache9]

Most code are just boiler plate as we add a parameter for the constructor.

Only one concern is about changing RpcRetryingCallerFactory to IA.LimitedPrivate, as I do not think we want users to customize it, otherwise we should have introduced an interface. I think the configuration is just for tests, just like we can also set the implementation class of HMaster and HRegionServer, but we not expect users to do this.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 0s	branch-2 passed
+1 💚	compile	3m 40s	branch-2 passed
+1 💚	checkstyle	1m 0s	branch-2 passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 50s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 0s	the patch passed
+1 💚	compile	3m 43s	the patch passed
+1 💚	javac	3m 43s	the patch passed
+1 💚	checkstyle	0m 57s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	20m 8s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚	spotless	0m 45s	patch has no errors when running spotless:check.
+1 💚	spotbugs	3m 22s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 23s	The patch does not generate ASF License warnings.
		48m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5036/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5036
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux af466fe53727 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / b5dcd48
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server hbase-endpoint U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5036/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 40s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 36s	branch-2 passed
+1 💚	compile	1m 39s	branch-2 passed
+1 💚	shadedjars	5m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 59s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 10s	the patch passed
+1 💚	compile	1m 39s	the patch passed
+1 💚	javac	1m 39s	the patch passed
+1 💚	shadedjars	5m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 13s	hbase-client in the patch passed.
+1 💚	unit	198m 1s	hbase-server in the patch passed.
+1 💚	unit	2m 27s	hbase-endpoint in the patch passed.
		242m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5036/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5036
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e338f2f2e8b9 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / b5dcd48
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5036/5/testReport/
Max. process+thread count	2818 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server hbase-endpoint U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5036/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 20s	branch-2 passed
+1 💚	compile	1m 53s	branch-2 passed
+1 💚	shadedjars	6m 26s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 10s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 35s	the patch passed
+1 💚	compile	1m 44s	the patch passed
+1 💚	javac	1m 44s	the patch passed
+1 💚	shadedjars	6m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 8s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 19s	hbase-client in the patch passed.
-1 ❌	unit	238m 3s	hbase-server in the patch failed.
+1 💚	unit	3m 14s	hbase-endpoint in the patch passed.
		283m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5036/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5036
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0e0fd983582c 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / b5dcd48
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5036/5/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5036/5/testReport/
Max. process+thread count	2112 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server hbase-endpoint U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5036/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.