should closing flag be set false in HRegion.java by zhengxle · Pull Request #105 · apache/hbase

zhengxle · 2018-12-13T09:38:48Z

refer: HBASE-21593

HorizonNet · 2019-04-07T15:34:43Z

@zhengxle Could you please update the commit message to include the Jira ticket ID? See the appropriate documentation for more details.

Apache-HBase · 2019-04-07T23:11:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	238	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	256	master passed
+1	compile	52	master passed
+1	checkstyle	71	master passed
+1	shadedjars	257	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	148	master passed
+1	javadoc	33	master passed
		_ Patch Compile Tests _
+1	mvninstall	257	the patch passed
+1	compile	55	the patch passed
+1	javac	55	the patch passed
+1	checkstyle	72	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	269	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	502	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	145	the patch passed
+1	javadoc	31	the patch passed
		_ Other Tests _
-1	unit	15641	hbase-server in the patch failed.
+1	asflicense	26	The patch does not generate ASF License warnings.
		18118

Reason	Tests
Failed junit tests	hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.master.TestAssignmentManagerMetrics
	hadoop.hbase.client.TestAdmin1
	hadoop.hbase.client.TestFromClientSideWithCoprocessor
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.master.TestSplitWALManager

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-105/1/artifact/out/Dockerfile
GITHUB PR	#105
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux babe299e61b0 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `11547b7`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-105/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-105/1/testReport/
Max. process+thread count	4850 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-105/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-04-21T00:46:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	47	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	1	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	270	master passed
+1	compile	56	master passed
+1	checkstyle	80	master passed
+1	shadedjars	282	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	252	master passed
+1	javadoc	36	master passed
		_ Patch Compile Tests _
+1	mvninstall	261	the patch passed
+1	compile	54	the patch passed
+1	javac	54	the patch passed
+1	checkstyle	77	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	282	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	548	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	250	the patch passed
+1	javadoc	34	the patch passed
		_ Other Tests _
+1	unit	12146	hbase-server in the patch passed.
+1	asflicense	27	The patch does not generate ASF License warnings.
		14768

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-105/2/artifact/out/Dockerfile
GITHUB PR	#105
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 790757bd8737 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `f30d6c9`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-105/2/testReport/
Max. process+thread count	4181 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-105/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

saintstack

Perhaps I should close out this PR since it has been around a while unaddressed.

saintstack · 2019-06-06T23:46:50Z

 LOG.info("Closed " + this);
 return result;
 } finally {
+ this.closing.set(false);


Not sure how this addresses problem in the issue and what the benefit is here?

saintstack · 2019-06-09T21:26:10Z

Closed old PR that has gone months w/o update.

Update HRegion.java
d684436
refer: HBASE-21593

zhengxle changed the title ~~Update HRegion.java~~should closing flag be set false in HRegion.javaDec 13, 2018

saintstack requested changes Jun 6, 2019
View reviewed changes

saintstack closed this Jun 9, 2019

wchevreuil mentioned this pull request Oct 23, 2019
HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule #677
Merged

This was referenced May 11, 2023
HBASE-27859:HMaster.getCompactionState can happen NPE when region state is closed #5232
Merged
HBASE-27860: Fix build error against Hadoop 3.3.5 #5233
Merged
HBASE-27863 Add hadoop 3.3.5 check in our personality script #5236
Merged

This was referenced May 28, 2023
HBASE-27890 Expose a getter on Connection/AsyncConnection for getting… #5257
Closed
HBASE-27820: HBase is not starting due to Jersey library conflicts wi… #5261
Merged
HBASE-27894 create-release is broken by recent gitbox changes #5262
Merged

Navigation Menu

Uh oh!

should closing flag be set false in HRegion.java - #105

should closing flag be set false in HRegion.java#105
zhengxle wants to merge 1 commit into
apache:masterfrom
zhengxle:patch-1

zhengxle commented Dec 13, 2018

Uh oh!

HorizonNet commented Apr 7, 2019

Uh oh!

Apache-HBase commented Apr 7, 2019

Uh oh!

Apache-HBase commented Apr 21, 2019

Uh oh!

saintstack left a comment

Uh oh!

saintstackJun 6, 2019

Uh oh!

saintstack commented Jun 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

zhengxle commented Dec 13, 2018

Uh oh!

HorizonNet commented Apr 7, 2019

Uh oh!

Apache-HBase commented Apr 7, 2019

Uh oh!

Apache-HBase commented Apr 21, 2019

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

saintstackJun 6, 2019

Choose a reason for hiding this comment

Uh oh!

saintstack commented Jun 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants