Skip to content

HBASE-27649 WALPlayer does not properly dedupe overridden cell versions - #5047

Merged
bbeaudreault merged 8 commits into
apache:masterfrom
HubSpot:HBASE-27649
Feb 25, 2023
Merged

HBASE-27649 WALPlayer does not properly dedupe overridden cell versions#5047
bbeaudreault merged 8 commits into
apache:masterfrom
HubSpot:HBASE-27649

Conversation

@bbeaudreault

@bbeaudreaultbbeaudreault commented Feb 21, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This seems simple enough from a compatibility perspective. I'm adding a new io.serializations, but it should not matter for HFileOutputFormat2 whose output is actually written by StoreFileWriter. It'll only be used in the intermediate output, so is safe to change between deploys.

I chose to create a new ExtendedCellSerialization because it seemed the cleanest way to encapsulate, since others may have used CellSerialization in other contexts. The alternative would be to make CellSerialization implement Configurable, and use that to inject some new configuration which defaults to false. It felt better to skip needing to add a new configuration.

EDIT: I decided to wrap this in a conditional so its exposed to WALPlayer only for now. I realized that someone could have a job which reads Cells from some other sequence file they had created. A job configured by HFileOutputFormat2 would fail to read those if ExtendedCellSerialization were added. So adding to just WALPlayer preserves compatibility, since that job is end-to-end.

@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

Apache-HBase commented Feb 21, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall5m 15smaster passed
+1 💚compile1m 3smaster passed
+1 💚checkstyle0m 23smaster passed
+1 💚spotless0m 47sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 5smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall4m 37sthe patch passed
+1 💚compile1m 12sthe patch passed
+1 💚javac1m 12sthe patch passed
+1 💚checkstyle0m 24sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚hadoopcheck18m 51sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless1m 2spatch has no errors when running spotless:check.
+1 💚spotbugs1m 34sthe patch passed
_ Other Tests _
+1 💚asflicense0m 17sThe patch does not generate ASF License warnings.
48m 25s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5047
Optional Testsdupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle
unameLinux 0a5c4a1c6df5 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 22dbb7a
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/3/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 21, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 43sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for branch
+1 💚mvninstall4m 25smaster passed
+1 💚compile0m 39smaster passed
+1 💚shadedjars6m 1sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 29smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 57sthe patch passed
+1 💚compile0m 38sthe patch passed
+1 💚javac0m 38sthe patch passed
+1 💚shadedjars5m 20spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24sthe patch passed
_ Other Tests _
-1 ❌unit16m 4shbase-mapreduce in the patch failed.
+1 💚unit10m 34shbase-backup in the patch passed.
50m 52s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5047
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f221260b3642 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 22dbb7a
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/3/testReport/
Max. process+thread count3426 (vs. ulimit of 30000)
modulesC: hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 22, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 43sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall5m 27smaster passed
+1 💚compile0m 43smaster passed
+1 💚shadedjars5m 26sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 27smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall4m 53sthe patch passed
+1 💚compile0m 44sthe patch passed
+1 💚javac0m 44sthe patch passed
+1 💚shadedjars5m 53spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 27sthe patch passed
_ Other Tests _
-1 ❌unit22m 39shbase-mapreduce in the patch failed.
+1 💚unit14m 20shbase-backup in the patch passed.
64m 10s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5047
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8f1555c0583a 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 22dbb7a
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/3/testReport/
Max. process+thread count3071 (vs. ulimit of 30000)
modulesC: hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 22, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall5m 30smaster passed
+1 💚compile1m 2smaster passed
+1 💚checkstyle0m 25smaster passed
+1 💚spotless0m 46sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 4smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall4m 46sthe patch passed
+1 💚compile1m 14sthe patch passed
+1 💚javac1m 14sthe patch passed
+1 💚checkstyle0m 24sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚hadoopcheck19m 10sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 57spatch has no errors when running spotless:check.
+1 💚spotbugs1m 36sthe patch passed
_ Other Tests _
+1 💚asflicense0m 23sThe patch does not generate ASF License warnings.
48m 58s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5047
Optional Testsdupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle
unameLinux b88fb45ebc76 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 22dbb7a
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/4/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 22, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 45sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for branch
+1 💚mvninstall4m 24smaster passed
+1 💚compile0m 41smaster passed
+1 💚shadedjars5m 53sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 33smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 6sthe patch passed
+1 💚compile0m 38sthe patch passed
+1 💚javac0m 38sthe patch passed
+1 💚shadedjars5m 23spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24sthe patch passed
_ Other Tests _
+1 💚unit15m 58shbase-mapreduce in the patch passed.
+1 💚unit10m 38shbase-backup in the patch passed.
51m 14s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5047
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 74eae465b343 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 22dbb7a
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/4/testReport/
Max. process+thread count3400 (vs. ulimit of 30000)
modulesC: hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 22, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 40sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall5m 35smaster passed
+1 💚compile0m 55smaster passed
+1 💚shadedjars7m 9sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 41smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 32sthe patch passed
+1 💚compile0m 48sthe patch passed
+1 💚javac0m 48sthe patch passed
+1 💚shadedjars5m 46spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 28sthe patch passed
_ Other Tests _
+1 💚unit20m 16shbase-mapreduce in the patch passed.
+1 💚unit13m 32shbase-backup in the patch passed.
63m 17s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5047
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 47867a4cccba 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 22dbb7a
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/4/testReport/
Max. process+thread count3045 (vs. ulimit of 30000)
modulesC: hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 approved these changes Feb 25, 2023
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits. Overall LGTM.

Comment threadhbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestWALPlayer.java Outdated
final byte[] row = Bytes.toBytes("row");
Table table = TEST_UTIL.createTable(tableName, family);

long now = System.currentTimeMillis();

@Apache9Apache9Feb 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use EnvironmentEdgeManager.currentTime if possible

Comment threadhbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestWALPlayer.java Outdated
table = TEST_UTIL.truncateTable(tableName);
g = new Get(row);
result = table.get(g);
assertTrue("expected row to be empty after truncate but got " + result, result.isEmpty());

@Apache9Apache9Feb 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use assertThat and Matchers.empty?

@Apache-HBase

Apache-HBase commented Feb 25, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 24sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 0smaster passed
+1 💚compile0m 28smaster passed
+1 💚shadedjars4m 35sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 22smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 49sthe patch passed
+1 💚compile0m 27sthe patch passed
+1 💚javac0m 27sthe patch passed
+1 💚shadedjars4m 32spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 20sthe patch passed
_ Other Tests _
+1 💚unit13m 25shbase-mapreduce in the patch passed.
+1 💚unit9m 52shbase-backup in the patch passed.
42m 5s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5047
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 788cbb7235d0 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 36bb0d1
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/5/testReport/
Max. process+thread count3374 (vs. ulimit of 30000)
modulesC: hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/5/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 25, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall4m 21smaster passed
+1 💚compile0m 58smaster passed
+1 💚checkstyle0m 21smaster passed
+1 💚spotless0m 51sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 0smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall4m 27sthe patch passed
+1 💚compile1m 3sthe patch passed
+1 💚javac1m 3sthe patch passed
-0 ⚠️checkstyle0m 10shbase-backup: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck16m 20sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 48spatch has no errors when running spotless:check.
-1 ❌spotbugs0m 45shbase-backup generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
42m 35s
ReasonTests
FindBugsmodule:hbase-backup
Exception is caught when Exception is not thrown in org.apache.hadoop.hbase.backup.impl.IncrementalTableBackupClient.execute() At IncrementalTableBackupClient.java:is not thrown in org.apache.hadoop.hbase.backup.impl.IncrementalTableBackupClient.execute() At IncrementalTableBackupClient.java:[line 334]
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5047
Optional Testsdupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle
unameLinux b9b9a606002c 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 36bb0d1
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-backup.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/5/artifact/yetus-general-check/output/new-spotbugs-hbase-backup.html
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/5/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 25, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 7sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall3m 22smaster passed
+1 💚compile0m 37smaster passed
+1 💚shadedjars4m 28sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 28smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 26sthe patch passed
+1 💚compile0m 36sthe patch passed
+1 💚javac0m 36sthe patch passed
+1 💚shadedjars4m 26spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25sthe patch passed
_ Other Tests _
+1 💚unit14m 7shbase-mapreduce in the patch passed.
+1 💚unit11m 5shbase-backup in the patch passed.
46m 5s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5047
Optional Testsjavac javadoc unit shadedjars compile
unameLinux fc2345b4aa5c 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 36bb0d1
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/5/testReport/
Max. process+thread count3376 (vs. ulimit of 30000)
modulesC: hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5047/5/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault

bbeaudreault commented Feb 25, 2023

Copy link
Copy Markdown
ContributorAuthor

checkstyle/spotbugs are in hbase-backups module, which i haven't changed here. Will be handling that in a separate issue. Otherwise pre-commit passing so going to merge. Thanks!

@bbeaudreault
bbeaudreault merged commit 82c7dbd into apache:masterFeb 25, 2023
@bbeaudreault
bbeaudreault deleted the HBASE-27649 branch February 25, 2023 17:10
@bbeaudreault

bbeaudreault commented Feb 25, 2023

Copy link
Copy Markdown
ContributorAuthor

Ugh, somehow some temp code got in here in hbase-backup. Going to revert

bbeaudreault added a commit that referenced this pull request Feb 25, 2023
@bbeaudreault
Revert "HBASE-27649WALPlayer does not properly dedupe overridden cel…
7a80e71
…l versions (#5047)"
This reverts commit 82c7dbd.
@bbeaudreaultbbeaudreault mentioned this pull request Feb 25, 2023
Merged
bbeaudreault added a commit that referenced this pull request Feb 25, 2023
@bbeaudreault
Revert "HBASE-27649WALPlayer does not properly dedupe overridden cel…
6b672cc
…l versions (#5047)" (#5057)
This reverts commit 82c7dbd.
@bbeaudreaultbbeaudreault mentioned this pull request Feb 25, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bbeaudreault@Apache-HBase@Apache9