Skip to content

HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) - #505

Merged
Apache9 merged 3 commits into
apache:masterfrom
virajjasani:HBASE-22863-master
Aug 21, 2019
Merged

HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)#505
Apache9 merged 3 commits into
apache:masterfrom
virajjasani:HBASE-22863-master

Conversation

@virajjasani

@virajjasanivirajjasani commented Aug 17, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Partly forwardport from HBASE-22728 to master and branch-2

@Apache-HBase

Apache-HBase commented Aug 17, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec37Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep34Maven dependency ordering for branch
+1mvninstall340master passed
+1compile423master passed
+1shadedjars295branch has no errors when building our shaded downstream artifacts.
+1javadoc284master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall319the patch passed
+1compile425the patch passed
+1javac425the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml21The patch has no ill-formed XML file.
+1shadedjars295patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1021Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc285the patch passed
_ Other Tests _
+1unit175hbase-common in the patch passed.
+1unit34hbase-hadoop2-compat in the patch passed.
+1unit46hbase-zookeeper in the patch passed.
+1unit68hbase-http in the patch passed.
+1unit203hbase-procedure in the patch passed.
+1unit8789hbase-server in the patch passed.
+1unit1005hbase-mapreduce in the patch passed.
+1unit55hbase-testing-util in the patch passed.
+1unit223hbase-thrift in the patch passed.
+1unit435hbase-shell in the patch passed.
+1unit234hbase-endpoint in the patch passed.
+1unit856hbase-backup in the patch passed.
+1unit68hbase-it in the patch passed.
+1unit288hbase-rest in the patch passed.
+1unit117hbase-examples in the patch passed.
+1unit38hbase-external-blockcache in the patch passed.
+1unit39hbase-shaded-testing-util in the patch passed.
+1asflicense481The patch does not generate ASF License warnings.
17489
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/1/artifact/out/Dockerfile
GITHUB PR#505
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux 06fed7d11782 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh
git revisionmaster / 43a0ec8
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/1/testReport/
Max. process+thread count5192 (vs. ulimit of 10000)
modulesC: hbase-common hbase-hadoop2-compat hbase-zookeeper hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@virajjasanivirajjasani changed the title HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependenciesHBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)Aug 17, 2019
@Apache-HBase

Apache-HBase commented Aug 17, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec33Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep33Maven dependency ordering for branch
+1mvninstall337master passed
+1compile423master passed
+1shadedjars294branch has no errors when building our shaded downstream artifacts.
+1javadoc284master passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall323the patch passed
+1compile424the patch passed
+1javac424the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml21The patch has no ill-formed XML file.
+1shadedjars297patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1009Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc286the patch passed
_ Other Tests _
+1unit174hbase-common in the patch passed.
+1unit34hbase-hadoop2-compat in the patch passed.
+1unit46hbase-zookeeper in the patch passed.
+1unit67hbase-http in the patch passed.
+1unit207hbase-procedure in the patch passed.
+1unit9023hbase-server in the patch passed.
+1unit1087hbase-mapreduce in the patch passed.
+1unit55hbase-testing-util in the patch passed.
+1unit231hbase-thrift in the patch passed.
+1unit432hbase-shell in the patch passed.
+1unit236hbase-endpoint in the patch passed.
+1unit859hbase-backup in the patch passed.
+1unit65hbase-it in the patch passed.
+1unit294hbase-rest in the patch passed.
+1unit116hbase-examples in the patch passed.
+1unit36hbase-external-blockcache in the patch passed.
+1unit40hbase-shaded-testing-util in the patch passed.
+1asflicense463The patch does not generate ASF License warnings.
17787
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/2/artifact/out/Dockerfile
GITHUB PR#505
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux f66a2e3a1ce4 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh
git revisionmaster / 7903f55
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/2/testReport/
Max. process+thread count5137 (vs. ulimit of 10000)
modulesC: hbase-common hbase-hadoop2-compat hbase-zookeeper hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 17, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec40Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep37Maven dependency ordering for branch
+1mvninstall352master passed
+1compile431master passed
+1shadedjars288branch has no errors when building our shaded downstream artifacts.
+1javadoc303master passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall327the patch passed
+1compile458the patch passed
+1javac458the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml20The patch has no ill-formed XML file.
+1shadedjars296patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck992Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc286the patch passed
_ Other Tests _
+1unit173hbase-common in the patch passed.
+1unit33hbase-hadoop2-compat in the patch passed.
+1unit48hbase-zookeeper in the patch passed.
+1unit63hbase-http in the patch passed.
+1unit216hbase-procedure in the patch passed.
+1unit8202hbase-server in the patch passed.
+1unit994hbase-mapreduce in the patch passed.
+1unit55hbase-testing-util in the patch passed.
+1unit221hbase-thrift in the patch passed.
+1unit434hbase-shell in the patch passed.
+1unit228hbase-endpoint in the patch passed.
+1unit888hbase-backup in the patch passed.
+1unit66hbase-it in the patch passed.
+1unit281hbase-rest in the patch passed.
+1unit106hbase-examples in the patch passed.
+1unit35hbase-external-blockcache in the patch passed.
+1unit39hbase-shaded-testing-util in the patch passed.
+1asflicense489The patch does not generate ASF License warnings.
16936
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/4/artifact/out/Dockerfile
GITHUB PR#505
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux 6db552f95121 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh
git revisionmaster / 836f269
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/4/testReport/
Max. process+thread count5410 (vs. ulimit of 10000)
modulesC: hbase-common hbase-hadoop2-compat hbase-zookeeper hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/4/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 requested changes Aug 18, 2019
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to just exclude these transitive dependencies? At least hadoop adds them as dependencies...

Comment threadhbase-zookeeper/pom.xml Outdated
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
<exclusions>

@Apache9Apache9Aug 18, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add these exclusions in the parent pom? No?

@virajjasanivirajjasaniAug 18, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, that doesn't work

@virajjasanivirajjasaniAug 18, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you mean just exclude from parent pom and we don't need to exclude from individual modules right? Sure let me do that for jackson-jaxrs and jackson-xc since they are common across all modules

@Apache9Apache9Aug 18, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's what I mean, excluding in the parent pom so the sub modules just inherit the exclusions automatically. But I'm not a maven expert so please confirm whether it actually works...

@virajjasanivirajjasaniAug 18, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Apache9 this doesn't work as expected. For instance, if downstream app has hbase-client dependency and if we have just excluded from parent pom, downstream would still get vulnerable Jackson1 dependencies from hbase-client. In fact, the same is done for branch-1: 4b34d24 (removal in individual modules so that downstreamer won't pull in from HBase)

@Apache9Apache9Aug 18, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for now but this is a bit strange. At least the downstreamer need to find the version from parent pom, then why it just ignores the exclusions?

@Apache9Apache9Aug 18, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what I mean is to exclude them in the dependencyManagement section in the parent pom, not in dependency section(and I wonder whether we have this section in the parent pom...)

Could you please try again?

@virajjasanivirajjasaniAug 18, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct @Apache9
It works...Thanks. Just committed the changes

@virajjasanivirajjasaniAug 20, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have committed all the necessary and suggested changes.

@virajjasani

virajjasani commented Aug 18, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Is it safe to just exclude these transitive dependencies? At least hadoop adds them as dependencies...

@Apache9 Since we have moved to Jackson2, we can safely exclude these dependencies. At some places, we require jackson-mapper-asl:1.9.13(CVE exposed) at test scope to run tests like HBaseTestUtility.startMiniCluster(). But definitely not required at compile scope as we would expose these to downstreamers otherwise. This is partly forwardport from HBASE-22728 to master and branch-2.

@Apache9

Apache9 commented Aug 18, 2019

Copy link
Copy Markdown
Contributor

So we need to add the jackson dependency explicitly as a test dependency in our own pom as we exclude them from the hadoop-common?

@virajjasani

virajjasani commented Aug 18, 2019

Copy link
Copy Markdown
ContributorAuthor

So we need to add the jackson dependency explicitly as a test dependency in our own pom as we exclude them from the hadoop-common?

Correct. Just did it here: https://github.com/apache/hbase/pull/505/files#diff-659d55cb388d174df96d2c372cfc982fR138

@Apache9

Apache9 commented Aug 18, 2019

Copy link
Copy Markdown
Contributor

So what about our own UTs? How do we include the jackson1 dependencies for hbase-server test module for example?

@virajjasani

virajjasani commented Aug 18, 2019

Copy link
Copy Markdown
ContributorAuthor

That is already included from hadoop-minicluster only, but at test scop:

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-server ---
[INFO] org.apache.hbase:hbase-server:jar:3.0.0-SNAPSHOT
[INFO] +- org.apache.hbase:hbase-http:test-jar:tests:3.0.0-SNAPSHOT:test
[INFO] | \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test
[INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test
[INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test

@virajjasani

virajjasani commented Aug 18, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Let me provide the full dependency tree for Jackson1 with this patch:

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-http ---
[INFO] org.apache.hbase:hbase-http:jar:3.0.0-SNAPSHOT
[INFO] +- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test
[INFO] | +- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] | | \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test
[INFO] | \- org.apache.hadoop:hadoop-yarn-server-tests:test-jar:tests:2.8.5:test
[INFO] | \- org.apache.hadoop:hadoop-yarn-common:jar:2.8.5:test
[INFO] | +- org.codehaus.jackson:jackson-jaxrs:jar:1.9.13:test
[INFO] | \- org.codehaus.jackson:jackson-xc:jar:1.9.13:test
[INFO] \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-server ---
[INFO] org.apache.hbase:hbase-server:jar:3.0.0-SNAPSHOT
[INFO] +- org.apache.hbase:hbase-http:test-jar:tests:3.0.0-SNAPSHOT:test
[INFO] | \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test
[INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test
[INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test
[INFO] 
[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-mapreduce ---
[INFO] org.apache.hbase:hbase-mapreduce:jar:3.0.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test
[INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test
[INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-testing-util ---
[INFO] org.apache.hbase:hbase-testing-util:jar:3.0.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:compile
[INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test
[INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-thrift ---
[INFO] org.apache.hbase:hbase-thrift:jar:3.0.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test
[INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test
[INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-rsgroup ---
[INFO] org.apache.hbase:hbase-rsgroup:jar:3.0.0-SNAPSHOT
[INFO] \- org.apache.hbase:hbase-testing-util:jar:3.0.0-SNAPSHOT:test
[INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test
[INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test
[INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-shell ---
[INFO] org.apache.hbase:hbase-shell:jar:3.0.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test
[INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test
[INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-endpoint ---
[INFO] org.apache.hbase:hbase-endpoint:jar:3.0.0-SNAPSHOT
[INFO] +- org.apache.hbase:hbase-http:test-jar:tests:3.0.0-SNAPSHOT:test
[INFO] | \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test
[INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test
[INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-backup ---
[INFO] org.apache.hbase:hbase-backup:jar:3.0.0-SNAPSHOT
[INFO] \- org.apache.hbase:hbase-testing-util:jar:3.0.0-SNAPSHOT:test
[INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test
[INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test
[INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-it ---
[INFO] org.apache.hbase:hbase-it:jar:3.0.0-SNAPSHOT
[INFO] \- org.apache.hbase:hbase-testing-util:jar:3.0.0-SNAPSHOT:test
[INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test
[INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test
[INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-rest ---
[INFO] org.apache.hbase:hbase-rest:jar:3.0.0-SNAPSHOT
[INFO] +- org.apache.hbase:hbase-testing-util:jar:3.0.0-SNAPSHOT:test
[INFO] | \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test
[INFO] | \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] | \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test
[INFO] +- org.apache.hbase:hbase-http:test-jar:tests:3.0.0-SNAPSHOT:test
[INFO] | \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test
[INFO] +- com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:jar:2.9.9:compile
[INFO] | +- com.fasterxml.jackson.jaxrs:jackson-jaxrs-base:jar:2.9.9:compile
[INFO] | \- com.fasterxml.jackson.module:jackson-module-jaxb-annotations:jar:2.9.9:compile
[INFO] +- com.fasterxml.jackson.core:jackson-annotations:jar:2.9.9:compile
[INFO] +- com.fasterxml.jackson.core:jackson-core:jar:2.9.9:compile
[INFO] \- com.fasterxml.jackson.core:jackson-databind:jar:2.9.9.2:compile

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-examples ---
[INFO] org.apache.hbase:hbase-examples:jar:3.0.0-SNAPSHOT
[INFO] +- org.apache.hbase:hbase-testing-util:jar:3.0.0-SNAPSHOT:test
[INFO] | \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test
[INFO] | \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] | +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test
[INFO] | \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test
[INFO] \- org.apache.hbase:hbase-rest:jar:3.0.0-SNAPSHOT:compile
[INFO] +- com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:jar:2.9.9:compile
[INFO] | +- com.fasterxml.jackson.jaxrs:jackson-jaxrs-base:jar:2.9.9:compile
[INFO] | \- com.fasterxml.jackson.module:jackson-module-jaxb-annotations:jar:2.9.9:compile
[INFO] +- com.fasterxml.jackson.core:jackson-annotations:jar:2.9.9:compile
[INFO] +- com.fasterxml.jackson.core:jackson-core:jar:2.9.9:compile
[INFO] \- com.fasterxml.jackson.core:jackson-databind:jar:2.9.9.2:compile

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-shaded-client-byo-hadoop ---
[INFO] org.apache.hbase:hbase-shaded-client-byo-hadoop:jar:3.0.0-SNAPSHOT
[INFO] +- org.codehaus.jackson:jackson-jaxrs:jar:1.9.13:provided
[INFO] \- org.codehaus.jackson:jackson-xc:jar:1.9.13:provided

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-shaded-mapreduce ---
[INFO] org.apache.hbase:hbase-shaded-mapreduce:jar:3.0.0-SNAPSHOT
[INFO] +- org.codehaus.jackson:jackson-jaxrs:jar:1.9.13:provided
[INFO] \- org.codehaus.jackson:jackson-xc:jar:1.9.13:provided

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-assembly ---
[INFO] org.apache.hbase:hbase-assembly:pom:3.0.0-SNAPSHOT
[INFO] +- org.apache.hbase:hbase-rest:jar:3.0.0-SNAPSHOT:compile
[INFO] | +- com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:jar:2.9.9:compile
[INFO] | | +- com.fasterxml.jackson.jaxrs:jackson-jaxrs-base:jar:2.9.9:compile
[INFO] | | \- com.fasterxml.jackson.module:jackson-module-jaxb-annotations:jar:2.9.9:compile
[INFO] | +- com.fasterxml.jackson.core:jackson-annotations:jar:2.9.9:compile
[INFO] | +- com.fasterxml.jackson.core:jackson-core:jar:2.9.9:compile
[INFO] | \- com.fasterxml.jackson.core:jackson-databind:jar:2.9.9.2:compile
[INFO] +- org.apache.hbase:hbase-testing-util:jar:3.0.0-SNAPSHOT:test
[INFO] | \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test
[INFO] | \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] | \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test
[INFO] \- org.apache.hbase:hbase-http:jar:3.0.0-SNAPSHOT:compile
[INFO] \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-shaded-testing-util ---
[INFO] org.apache.hbase:hbase-shaded-testing-util:jar:3.0.0-SNAPSHOT
[INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test
[INFO] \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-client-project ---
[INFO] org.apache.hbase:hbase-client-project:jar:3.0.0-SNAPSHOT
[INFO] \- org.apache.hbase:hbase-testing-util:jar:3.0.0-SNAPSHOT:test
[INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test
[INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test
[INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-shaded-client-project ---
[INFO] org.apache.hbase:hbase-shaded-client-project:jar:3.0.0-SNAPSHOT
[INFO] \- org.apache.hbase:hbase-testing-util:jar:3.0.0-SNAPSHOT:test
[INFO] \- org.apache.hadoop:hadoop-minicluster:jar:2.8.5:test
[INFO] \- org.apache.hadoop:hadoop-common:test-jar:tests:2.8.5:test
[INFO] +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test
[INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test

[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ hbase-shaded-testing-util-tester ---
[INFO] org.apache.hbase:hbase-shaded-testing-util-tester:jar:3.0.0-SNAPSHOT
[INFO] \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test
[INFO] \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test

@Apache9 Please let me know how this looks.

@Apache-HBase

Apache-HBase commented Aug 18, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec40Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep35Maven dependency ordering for branch
+1mvninstall355master passed
+1compile444master passed
+1shadedjars298branch has no errors when building our shaded downstream artifacts.
+1javadoc294master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall321the patch passed
+1compile451the patch passed
+1javac451the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml22The patch has no ill-formed XML file.
+1shadedjars299patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1030Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc294the patch passed
_ Other Tests _
+1unit177hbase-common in the patch passed.
+1unit34hbase-hadoop2-compat in the patch passed.
+1unit46hbase-zookeeper in the patch passed.
+1unit69hbase-http in the patch passed.
+1unit211hbase-procedure in the patch passed.
+1unit8847hbase-server in the patch passed.
+1unit1004hbase-mapreduce in the patch passed.
+1unit55hbase-testing-util in the patch passed.
+1unit235hbase-thrift in the patch passed.
+1unit436hbase-shell in the patch passed.
+1unit246hbase-endpoint in the patch passed.
+1unit995hbase-backup in the patch passed.
+1unit70hbase-it in the patch passed.
+1unit315hbase-rest in the patch passed.
+1unit137hbase-examples in the patch passed.
+1unit36hbase-external-blockcache in the patch passed.
+1unit39hbase-shaded-testing-util in the patch passed.
+1asflicense479The patch does not generate ASF License warnings.
17874
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/5/artifact/out/Dockerfile
GITHUB PR#505
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux 4984864994e0 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh
git revisionmaster / 7697d48
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/5/testReport/
Max. process+thread count5260 (vs. ulimit of 10000)
modulesC: hbase-common hbase-hadoop2-compat hbase-zookeeper hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/5/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 approved these changes Aug 18, 2019
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Let's try it.

@Apache-HBase

Apache-HBase commented Aug 18, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec42Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep66Maven dependency ordering for branch
+1mvninstall337master passed
+1compile186master passed
+1shadedjars287branch has no errors when building our shaded downstream artifacts.
+1javadoc261master passed
_ Patch Compile Tests _
0mvndep13Maven dependency ordering for patch
+1mvninstall311the patch passed
+1compile195the patch passed
+1javac195the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml9The patch has no ill-formed XML file.
+1shadedjars289patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1030Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc254the patch passed
_ Other Tests _
-1unit11480root in the patch failed.
+1asflicense169The patch does not generate ASF License warnings.
15354
ReasonTests
Failed junit testshadoop.hbase.snapshot.TestMobExportSnapshot
hbase.shaded.TestShadedHBaseTestingUtility
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/6/artifact/out/Dockerfile
GITHUB PR#505
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux d7ee38b18cd6 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh
git revisionmaster / 7697d48
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/6/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/6/testReport/
Max. process+thread count5471 (vs. ulimit of 10000)
modulesC: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/6/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 18, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep33Maven dependency ordering for branch
+1mvninstall341master passed
+1compile209master passed
+1shadedjars302branch has no errors when building our shaded downstream artifacts.
+1javadoc271master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall337the patch passed
+1compile191the patch passed
+1javac191the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml8The patch has no ill-formed XML file.
+1shadedjars305patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1045Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc253the patch passed
_ Other Tests _
-1unit13944root in the patch failed.
+1asflicense188The patch does not generate ASF License warnings.
17909
ReasonTests
Failed junit testshbase.shaded.TestShadedHBaseTestingUtility
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/7/artifact/out/Dockerfile
GITHUB PR#505
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux 4d704ff9d7b3 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh
git revisionmaster / 7697d48
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/7/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/7/testReport/
Max. process+thread count5164 (vs. ulimit of 10000)
modulesC: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/7/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 19, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec71Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep35Maven dependency ordering for branch
+1mvninstall316master passed
+1compile172master passed
+1shadedjars277branch has no errors when building our shaded downstream artifacts.
+1javadoc265master passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall333the patch passed
+1compile177the patch passed
+1javac177the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml10The patch has no ill-formed XML file.
+1shadedjars273patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck971Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc260the patch passed
_ Other Tests _
-1unit16821root in the patch failed.
+1asflicense171The patch does not generate ASF License warnings.
20611
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestHRegion
hadoop.hbase.client.TestFromClientSide3
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/8/artifact/out/Dockerfile
GITHUB PR#505
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux ddc2209b7e07 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh
git revisionmaster / 7697d48
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/8/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/8/testReport/
Max. process+thread count5195 (vs. ulimit of 10000)
modulesC: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/8/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 19, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec99Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep36Maven dependency ordering for branch
+1mvninstall352master passed
+1compile202master passed
+1shadedjars309branch has no errors when building our shaded downstream artifacts.
+1javadoc276master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall333the patch passed
+1compile202the patch passed
+1javac202the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml9The patch has no ill-formed XML file.
+1shadedjars306patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1062Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc270the patch passed
_ Other Tests _
-1unit14947root in the patch failed.
+1asflicense152The patch does not generate ASF License warnings.
19023
ReasonTests
Failed junit testshadoop.hbase.util.TestFromClientSide3WoUnsafe
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/10/artifact/out/Dockerfile
GITHUB PR#505
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux 6a248cd0b89c 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh
git revisionmaster / 46abaef
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/10/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/10/testReport/
Max. process+thread count4668 (vs. ulimit of 10000)
modulesC: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/10/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 19, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec37Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep35Maven dependency ordering for branch
+1mvninstall310master passed
+1compile181master passed
+1shadedjars279branch has no errors when building our shaded downstream artifacts.
+1javadoc262master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall303the patch passed
+1compile187the patch passed
+1javac187the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml10The patch has no ill-formed XML file.
+1shadedjars275patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck941Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc265the patch passed
_ Other Tests _
-1unit10010root in the patch failed.
+1asflicense164The patch does not generate ASF License warnings.
13696
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestHRegion
hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/11/artifact/out/Dockerfile
GITHUB PR#505
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux a879d01eba97 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh
git revisionmaster / 8e488ce
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/11/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/11/testReport/
Max. process+thread count4694 (vs. ulimit of 10000)
modulesC: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/11/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 20, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec44Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep36Maven dependency ordering for branch
+1mvninstall363master passed
+1compile186master passed
+1shadedjars266branch has no errors when building our shaded downstream artifacts.
+1javadoc266master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall312the patch passed
+1compile190the patch passed
+1javac190the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml9The patch has no ill-formed XML file.
+1shadedjars283patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck962Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc258the patch passed
_ Other Tests _
-1unit9340root in the patch failed.
+1asflicense157The patch does not generate ASF License warnings.
13117
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestHRegion
hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/12/artifact/out/Dockerfile
GITHUB PR#505
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux 992dcfe98120 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh
git revisionmaster / 6738280
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/12/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/12/testReport/
Max. process+thread count4741 (vs. ulimit of 10000)
modulesC: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/12/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Reidddddd
Reidddddd approved these changes Aug 20, 2019
View reviewed changes

@ReiddddddReidddddd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache-HBase

Apache-HBase commented Aug 20, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec78Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep42Maven dependency ordering for branch
+1mvninstall439master passed
+1compile243master passed
+1shadedjars371branch has no errors when building our shaded downstream artifacts.
+1javadoc321master passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall409the patch passed
+1compile233the patch passed
+1javac233the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml14The patch has no ill-formed XML file.
+1shadedjars377patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1250Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc307the patch passed
_ Other Tests _
-1unit19171root in the patch failed.
+1asflicense182The patch does not generate ASF License warnings.
23983
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestHRegion
hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush
hadoop.hbase.tool.TestSecureBulkLoadHFiles
hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
hadoop.hbase.tool.TestBulkLoadHFiles
hadoop.hbase.client.TestAsyncTableBatch
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestFromClientSide3
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/13/artifact/out/Dockerfile
GITHUB PR#505
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux 23c254d1b86e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh
git revisionmaster / a59f7d4
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/13/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/13/testReport/
Max. process+thread count4933 (vs. ulimit of 10000)
modulesC: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/13/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 20, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec43Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep35Maven dependency ordering for branch
+1mvninstall339master passed
+1compile192master passed
+1shadedjars296branch has no errors when building our shaded downstream artifacts.
+1javadoc272master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall332the patch passed
+1compile203the patch passed
+1javac203the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml9The patch has no ill-formed XML file.
+1shadedjars318patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1030Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc278the patch passed
_ Other Tests _
+1unit15339root in the patch passed.
+1asflicense198The patch does not generate ASF License warnings.
19328
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/14/artifact/out/Dockerfile
GITHUB PR#505
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux 2416fffba854 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh
git revisionmaster / ab28f9d
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/14/testReport/
Max. process+thread count5273 (vs. ulimit of 10000)
modulesC: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/14/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@virajjasani

virajjasani commented Aug 21, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review @Apache9@Reidddddd
We have +1 overall from QA also.

For branch-2, I have attached patch(HBASE-22863.branch-2.000.patch) on the JIRA. With that patch, dependency tree for branch-2 comes exactly similar to what I updated on this PR for master.

@Apache-HBase

Apache-HBase commented Aug 21, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec100Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep65Maven dependency ordering for branch
+1mvninstall321master passed
+1compile176master passed
+1shadedjars273branch has no errors when building our shaded downstream artifacts.
+1javadoc262master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall308the patch passed
+1compile179the patch passed
+1javac179the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml11The patch has no ill-formed XML file.
+1shadedjars274patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck975Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc264the patch passed
_ Other Tests _
-1unit9934root in the patch failed.
+1asflicense184The patch does not generate ASF License warnings.
13749
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/15/artifact/out/Dockerfile
GITHUB PR#505
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux 218be9e0fa2f 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh
git revisionmaster / 66ad42c
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/15/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/15/testReport/
Max. process+thread count4608 (vs. ulimit of 10000)
modulesC: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/15/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@virajjasani

virajjasani commented Aug 21, 2019

Copy link
Copy Markdown
ContributorAuthor

@Apache9@Reidddddd
Could you please help me merge this? Patch for branch-2 is also available with QA results in JIRA.
Thanks

@Apache-HBase

Apache-HBase commented Aug 21, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec233Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep34Maven dependency ordering for branch
+1mvninstall347master passed
+1compile202master passed
+1shadedjars306branch has no errors when building our shaded downstream artifacts.
+1javadoc288master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall341the patch passed
+1compile213the patch passed
+1javac213the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml12The patch has no ill-formed XML file.
+1shadedjars312patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1051Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc288the patch passed
_ Other Tests _
-1unit14585root in the patch failed.
+1asflicense174The patch does not generate ASF License warnings.
18843
ReasonTests
Failed junit testshadoop.hbase.master.TestMasterShutdown
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/16/artifact/out/Dockerfile
GITHUB PR#505
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux f510008edd57 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh
git revisionmaster / 7af5b30
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/16/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/16/testReport/
Max. process+thread count4598 (vs. ulimit of 10000)
modulesC: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/16/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit b8857ec into apache:masterAug 21, 2019
asfgit pushed a commit that referenced this pull request Aug 21, 2019
@virajjasani@Apache9
HBASE-22863Cleanup transitive Jackson1 vulnerable dependencies(forwa…
e28a7c2
…rd-port HBASE-22728) (#505)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
asfgit pushed a commit that referenced this pull request Aug 21, 2019
@virajjasani@Apache9
HBASE-22863Cleanup transitive Jackson1 vulnerable dependencies(forwa…
84d092c
…rd-port HBASE-22728) (#505)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
asfgit pushed a commit that referenced this pull request Aug 21, 2019
@virajjasani@Apache9
HBASE-22863Cleanup transitive Jackson1 vulnerable dependencies(forwa…
538088f
…rd-port HBASE-22728) (#505)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
@Apache-HBase

Apache-HBase commented Aug 21, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec122Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep46Maven dependency ordering for branch
+1mvninstall395master passed
+1compile229master passed
+1shadedjars341branch has no errors when building our shaded downstream artifacts.
+1javadoc308master passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall415the patch passed
+1compile220the patch passed
+1javac220the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml10The patch has no ill-formed XML file.
+1shadedjars340patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1085Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc289the patch passed
_ Other Tests _
-1unit15572root in the patch failed.
+1asflicense238The patch does not generate ASF License warnings.
20096
ReasonTests
Failed junit testshadoop.hbase.client.TestMobSnapshotCloneIndependence
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/17/artifact/out/Dockerfile
GITHUB PR#505
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux b3f728cc823c 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh
git revisionmaster / 1b50404
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/17/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/17/testReport/
Max. process+thread count5002 (vs. ulimit of 10000)
modulesC: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/17/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@virajjasani@Apache9
HBASE-22863 Cleanup transitive Jackson1 vulnerable dependencies(forwa…
a2a84e0
…rd-port HBASE-22728) (apache#505)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@virajjasaniJenkins
HBASE-22863 Cleanup transitive Jackson1 vulnerable dependencies(forwa…
392a2b2
…rd-port HBASE-22728) (apache#505)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
(cherry picked from commit 84d092c)
Change-Id: Ib0da7f02001acead63190b80c27413cb2e6a93c5
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes
@ReiddddddReiddddddReidddddd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@virajjasani@Apache-HBase@Apache9@Reidddddd