Skip to content

Backport "HBASE-23102: Improper Usage of Map putIfAbsent (#828)" to branch-2.5 - #5062

Merged
ndimiduk merged 1 commit into
apache:branch-2.5from
ndimiduk:23102-improper-use-of-map-putifabsent-branch-2.5
Mar 1, 2023
Merged

Backport "HBASE-23102: Improper Usage of Map putIfAbsent (#828)" to branch-2.5#5062
ndimiduk merged 1 commit into
apache:branch-2.5from
ndimiduk:23102-improper-use-of-map-putifabsent-branch-2.5

Conversation

@ndimiduk

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Co-authored-by: belugabehr <12578579+belugabehr@users.noreply.github.com>
@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Feb 27, 2023
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 11sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 55sbranch-2.5 passed
+1 💚compile3m 45sbranch-2.5 passed
+1 💚checkstyle1m 0sbranch-2.5 passed
+1 💚spotless0m 49sbranch has no errors when running spotless:check.
+1 💚spotbugs2m 41sbranch-2.5 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 3sthe patch passed
+1 💚compile3m 32sthe patch passed
+1 💚javac3m 32sthe patch passed
+1 💚checkstyle0m 10sThe patch passed checkstyle in hbase-procedure
+1 💚checkstyle0m 38shbase-server: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)
+1 💚checkstyle0m 8sThe patch passed checkstyle in hbase-rsgroup
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck20m 26sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚spotless0m 41spatch has no errors when running spotless:check.
+1 💚spotbugs3m 10sthe patch passed
_ Other Tests _
+1 💚asflicense0m 26sThe patch does not generate ASF License warnings.
49m 20s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5062
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux bed4a1f50ba2 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / c29355e
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-procedure hbase-server hbase-rsgroup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall5m 22sbranch-2.5 passed
+1 💚compile1m 28sbranch-2.5 passed
+1 💚shadedjars5m 21sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 20sbranch-2.5 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
+1 💚mvninstall5m 40sthe patch passed
+1 💚compile2m 5sthe patch passed
+1 💚javac2m 5sthe patch passed
+1 💚shadedjars6m 32spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 3sthe patch passed
_ Other Tests _
+1 💚unit1m 40shbase-procedure in the patch passed.
-1 ❌unit255m 51shbase-server in the patch failed.
+1 💚unit4m 43shbase-rsgroup in the patch passed.
298m 5s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5062
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7204cd13ce2d 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / c29355e
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/testReport/
Max. process+thread count2429 (vs. ulimit of 30000)
modulesC: hbase-procedure hbase-server hbase-rsgroup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 0sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall4m 23sbranch-2.5 passed
+1 💚compile1m 18sbranch-2.5 passed
+1 💚shadedjars6m 23sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 17sbranch-2.5 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 48sthe patch passed
+1 💚compile1m 32sthe patch passed
+1 💚javac1m 32sthe patch passed
+1 💚shadedjars6m 14spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 1sthe patch passed
_ Other Tests _
+1 💚unit1m 56shbase-procedure in the patch passed.
-1 ❌unit261m 58shbase-server in the patch failed.
+1 💚unit6m 47shbase-rsgroup in the patch passed.
303m 47s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5062
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a581e6bceefd 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / c29355e
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/testReport/
Max. process+thread count2653 (vs. ulimit of 30000)
modulesC: hbase-procedure hbase-server hbase-rsgroup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

TestRegionRebalancing, TestMobCompactionWithDefaults, and TestSplitRegionWhileRSCrash all pass for me locally.

@ndimiduk
ndimiduk merged commit a5d0f26 into apache:branch-2.5Mar 1, 2023
@ndimiduk
ndimiduk deleted the 23102-improper-use-of-map-putifabsent-branch-2.5 branch March 1, 2023 13:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ndimiduk@Apache-HBase