Skip to content

HBASE-27672 Read RPC threads may BLOCKED at the Configuration.get whe… - #5075

Merged
sunhelly merged 1 commit into
apache:masterfrom
sunhelly:HBASE-27672
Mar 6, 2023
Merged

HBASE-27672 Read RPC threads may BLOCKED at the Configuration.get whe…#5075
sunhelly merged 1 commit into
apache:masterfrom
sunhelly:HBASE-27672

Conversation

@sunhelly

@sunhellysunhelly commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

…n using java compression

@Apache-HBase

Apache-HBase commented Mar 3, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 23sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 46smaster passed
+1 💚compile1m 11smaster passed
+1 💚shadedjars4m 53sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 1smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 36sthe patch passed
+1 💚compile1m 11sthe patch passed
+1 💚javac1m 11sthe patch passed
+1 💚shadedjars4m 53spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 0sthe patch passed
_ Other Tests _
+1 💚unit0m 57shbase-compression-aircompressor in the patch passed.
+1 💚unit0m 36shbase-compression-brotli in the patch passed.
+1 💚unit0m 30shbase-compression-lz4 in the patch passed.
+1 💚unit0m 29shbase-compression-snappy in the patch passed.
+1 💚unit1m 2shbase-compression-xz in the patch passed.
+1 💚unit4m 8shbase-compression-zstd in the patch passed.
31m 40s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5075
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ee26f1f379d5 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d2b0074
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/testReport/
Max. process+thread count699 (vs. ulimit of 30000)
modulesC: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: hbase-compression
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 3, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 59sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for branch
+1 💚mvninstall2m 55smaster passed
+1 💚compile1m 19smaster passed
+1 💚shadedjars4m 20sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 8smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 48sthe patch passed
+1 💚compile1m 19sthe patch passed
+1 💚javac1m 19sthe patch passed
+1 💚shadedjars4m 17spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 6sthe patch passed
_ Other Tests _
+1 💚unit0m 47shbase-compression-aircompressor in the patch passed.
+1 💚unit0m 36shbase-compression-brotli in the patch passed.
+1 💚unit0m 29shbase-compression-lz4 in the patch passed.
+1 💚unit0m 28shbase-compression-snappy in the patch passed.
+1 💚unit0m 54shbase-compression-xz in the patch passed.
+1 💚unit7m 28shbase-compression-zstd in the patch passed.
33m 10s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5075
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e527c6251ce2 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d2b0074
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/testReport/
Max. process+thread count832 (vs. ulimit of 30000)
modulesC: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: hbase-compression
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 3, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 25sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 51smaster passed
+1 💚compile1m 25smaster passed
+1 💚checkstyle0m 38smaster passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 45smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 32sthe patch passed
+1 💚compile1m 25sthe patch passed
+1 💚javac1m 25sthe patch passed
+1 💚checkstyle0m 36sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck14m 15sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 42spatch has no errors when running spotless:check.
+1 💚spotbugs2m 31sthe patch passed
_ Other Tests _
+1 💚asflicense0m 43sThe patch does not generate ASF License warnings.
42m 19s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5075
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux a0fc014ebe0d 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d2b0074
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: hbase-compression
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5075/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault
bbeaudreault approved these changes Mar 3, 2023
View reviewed changes

@bbeaudreaultbbeaudreault left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, we should avoid Configuration.get in any hot codepaths. Thanks for cleaning this up.

@sunhelly
sunhelly merged commit 3eedc09 into apache:masterMar 6, 2023
sunhelly added a commit to sunhelly/hbase that referenced this pull request Mar 6, 2023
@sunhelly
HBASE-27672 Read RPC threads may BLOCKED at the Configuration.get whe…
6c69fc3
…n using java compression (apache#5075)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
sunhelly added a commit to sunhelly/hbase that referenced this pull request Mar 6, 2023
@sunhelly
HBASE-27672 Read RPC threads may BLOCKED at the Configuration.get whe…
bc31a30
…n using java compression (apache#5075)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
This was referenced Mar 6, 2023
Merged
Merged
sunhelly added a commit that referenced this pull request Mar 6, 2023
@sunhelly
HBASE-27672Read RPC threads may BLOCKED at the Configuration.get whe…
505a901
…n using java compression (#5075) (#5083)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
sunhelly added a commit that referenced this pull request Mar 6, 2023
@sunhelly
HBASE-27672Read RPC threads may BLOCKED at the Configuration.get whe…
6d463f7
…n using java compression (#5075) (#5084)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
charlesconnell pushed a commit to HubSpot/hbase that referenced this pull request Feb 7, 2024
@sunhelly@charlesconnell
Hubspot backport: HBASE-27672 Read RPC threads may BLOCKED at the Con…
2483e3b
…figuration.get when using java compression (apache#5075) (apache#5084)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
charlesconnell added a commit to HubSpot/hbase that referenced this pull request Feb 7, 2024
@charlesconnell@sunhelly
Hubspot backport: HBASE-27672 Read RPC threads may BLOCKED at the Con…
73223be
…figuration.get when using java compression (apache#5075) (apache#5084) (#76)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Co-authored-by: Xiaolin Ha <haxiaolin@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbeaudreaultbbeaudreaultbbeaudreault approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sunhelly@Apache-HBase@bbeaudreault