Skip to content

Backport "HBASE-27250 MasterRpcService#setRegionStateInMeta does not support replica region encodedNames or region names" to branch-2 - #5079

Merged
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:27250-masterrpcservices-setregionstateinmeta-support-replica-regions-branch-2
Mar 6, 2023
Merged

Backport "HBASE-27250 MasterRpcService#setRegionStateInMeta does not support replica region encodedNames or region names" to branch-2#5079
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:27250-masterrpcservices-setregionstateinmeta-support-replica-regions-branch-2

Conversation

@ndimiduk

@ndimidukndimiduk commented Mar 3, 2023

Copy link
Copy Markdown
Member

Backport touches more files because branch-2 doesn't have the MetaTableAccessor and CatalogFamilyFormat changes from master.

@huaxiangsunHuaxiang Sun@ndimiduk
HBASE-27250 MasterRpcService#setRegionStateInMeta does not support re…
05d55af
…plica region encodedNames or region names
- Added sanity check to make sure input region encoded name or region name is valid
- Assignment improvements pertaining to read replica regions
- make several MetaTableAccessor methods more precise in their handling of replica regions
- hbck2 setRegionStateInMeta and HBCKServerCrashProcedure handle read replicas
- separate AM helper methods -- loading RegionInfo from cache vs. refreshing cache from meta
- AM helper method support loading RegionInfo from cache via either region name and encoded region
name (both caches are maintained, and under lock)
- consolidate, extend tests to cover read replica regions
Co-authored-by: Huaxiang Sun <huaxiangsun@apache.com>
Co-authored-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Mar 3, 2023
@Apache-HBase

Apache-HBase commented Mar 3, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall5m 35sbranch-2 passed
+1 💚compile4m 32sbranch-2 passed
+1 💚checkstyle1m 21sbranch-2 passed
+1 💚spotless1m 6sbranch has no errors when running spotless:check.
+1 💚spotbugs3m 25sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall5m 4sthe patch passed
+1 💚compile4m 51sthe patch passed
+1 💚javac4m 51sthe patch passed
+1 💚checkstyle1m 17sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck27m 26sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚spotless1m 4spatch has no errors when running spotless:check.
+1 💚spotbugs3m 54sthe patch passed
_ Other Tests _
+1 💚asflicense0m 28sThe patch does not generate ASF License warnings.
64m 29s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5079/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5079
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 212a07b49bd0 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6bc84de
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count84 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5079/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 3, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 2sbranch-2 passed
+1 💚compile0m 53sbranch-2 passed
+1 💚shadedjars4m 28sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 40sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚shadedjars4m 31spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 39sthe patch passed
_ Other Tests _
+1 💚unit2m 42shbase-client in the patch passed.
+1 💚unit197m 16shbase-server in the patch passed.
223m 26s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5079/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5079
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 84a8db166535 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6bc84de
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5079/1/testReport/
Max. process+thread count2558 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5079/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 3, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall4m 47sbranch-2 passed
+1 💚compile1m 18sbranch-2 passed
+1 💚shadedjars5m 49sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 54sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 22sthe patch passed
+1 💚compile1m 20sthe patch passed
+1 💚javac1m 20sthe patch passed
+1 💚shadedjars5m 57spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 43sthe patch passed
_ Other Tests _
+1 💚unit3m 29shbase-client in the patch passed.
+1 💚unit223m 37shbase-server in the patch passed.
258m 20s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5079/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5079
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 0e9d59b71941 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6bc84de
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5079/1/testReport/
Max. process+thread count2759 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5079/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault
bbeaudreault approved these changes Mar 3, 2023
View reviewed changes

@bbeaudreaultbbeaudreault left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not part of the original jira, so feel free to wait for one of them if you want. but this lgtm :)

@ndimiduk

ndimiduk commented Mar 3, 2023

Copy link
Copy Markdown
MemberAuthor

Hah thanks. I don't usually look for a review on backports, unless it's complex or significantly different from master. I put up the PR for build-bot approval.

@ndimiduk
ndimiduk merged commit 9a69a69 into apache:branch-2Mar 6, 2023
@ndimiduk
ndimiduk deleted the 27250-masterrpcservices-setregionstateinmeta-support-replica-regions-branch-2 branch March 6, 2023 10:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbeaudreaultbbeaudreaultbbeaudreault approved these changes

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ndimiduk@Apache-HBase@bbeaudreault@huaxiangsun