Skip to content

HBASE-22879 user_permission command failed to show global permission - #511

Merged
mymeiyi merged 1 commit into
apache:masterfrom
mymeiyi:user-permission
Aug 21, 2019
Merged

HBASE-22879 user_permission command failed to show global permission#511
mymeiyi merged 1 commit into
apache:masterfrom
mymeiyi:user-permission

Conversation

@mymeiyi

@mymeiyimymeiyi commented Aug 19, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Apache-HBase commented Aug 19, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec129Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall377master passed
+1compile25master passed
+1checkstyle14master passed
+1shadedjars278branch has no errors when building our shaded downstream artifacts.
+1javadoc17master passed
0spotbugs297Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs0master passed
_ Patch Compile Tests _
+1mvninstall345the patch passed
+1compile23the patch passed
+1javac23the patch passed
+1checkstyle12the patch passed
-1rubocop35The patch generated 22 new + 67 unchanged - 3 fixed = 89 total (was 70)
+1whitespace0The patch has no whitespace issues.
+1shadedjars271patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1072Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc11the patch passed
+1findbugs0the patch passed
_ Other Tests _
+1unit597hbase-shell in the patch passed.
+1asflicense11The patch does not generate ASF License warnings.
3761
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/1/artifact/out/Dockerfile
GITHUB PR#511
Optional Testsdupname asflicense javac javadoc unit rubocop spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 1923f91b0bc3 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-511/out/precommit/personality/provided.sh
git revisionmaster / 7697d48
Default Java1.8.0_181
rubocophttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/1/artifact/out/diff-patch-rubocop.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/1/testReport/
Max. process+thread count2552 (vs. ulimit of 10000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 19, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec61Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall335master passed
+1compile23master passed
+1checkstyle12master passed
+1shadedjars277branch has no errors when building our shaded downstream artifacts.
+1javadoc13master passed
0spotbugs292Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs0master passed
_ Patch Compile Tests _
+1mvninstall341the patch passed
+1compile23the patch passed
+1javac23the patch passed
+1checkstyle10the patch passed
-1rubocop7The patch generated 3 new + 67 unchanged - 3 fixed = 70 total (was 70)
+1whitespace0The patch has no whitespace issues.
+1shadedjars298patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck953Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc13the patch passed
+1findbugs0the patch passed
_ Other Tests _
+1unit570hbase-shell in the patch passed.
+1asflicense14The patch does not generate ASF License warnings.
3320
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/3/artifact/out/Dockerfile
GITHUB PR#511
Optional Testsdupname asflicense javac javadoc unit rubocop spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux b7d8194c3f49 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-511/out/precommit/personality/provided.sh
git revisionmaster / 46abaef
Default Java1.8.0_181
rubocophttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/3/artifact/out/diff-patch-rubocop.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/3/testReport/
Max. process+thread count2577 (vs. ulimit of 10000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 19, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec92Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall367master passed
+1compile23master passed
+1checkstyle12master passed
+1shadedjars309branch has no errors when building our shaded downstream artifacts.
+1javadoc16master passed
0spotbugs327Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs0master passed
_ Patch Compile Tests _
+1mvninstall348the patch passed
+1compile29the patch passed
+1javac29the patch passed
+1checkstyle13the patch passed
-1rubocop7The patch generated 3 new + 67 unchanged - 3 fixed = 70 total (was 70)
+1whitespace0The patch has no whitespace issues.
+1shadedjars314patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1051Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc12the patch passed
+1findbugs0the patch passed
_ Other Tests _
+1unit502hbase-shell in the patch passed.
+1asflicense12The patch does not generate ASF License warnings.
3526
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/4/artifact/out/Dockerfile
GITHUB PR#511
Optional Testsdupname asflicense javac javadoc unit rubocop spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 2cc6e8921eed 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-511/out/precommit/personality/provided.sh
git revisionmaster / 8e488ce
Default Java1.8.0_181
rubocophttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/4/artifact/out/diff-patch-rubocop.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/4/testReport/
Max. process+thread count2517 (vs. ulimit of 10000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/4/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 19, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec83Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall418master passed
+1compile23master passed
+1checkstyle12master passed
+1shadedjars297branch has no errors when building our shaded downstream artifacts.
+1javadoc13master passed
0spotbugs312Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs0master passed
_ Patch Compile Tests _
+1mvninstall309the patch passed
+1compile23the patch passed
+1javac23the patch passed
+1checkstyle10the patch passed
-1rubocop25The patch generated 3 new + 67 unchanged - 3 fixed = 70 total (was 70)
+1whitespace0The patch has no whitespace issues.
+1shadedjars287patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck974Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc13the patch passed
+1findbugs0the patch passed
_ Other Tests _
+1unit615hbase-shell in the patch passed.
+1asflicense13The patch does not generate ASF License warnings.
3511
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/5/artifact/out/Dockerfile
GITHUB PR#511
Optional Testsdupname asflicense javac javadoc unit rubocop spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 53d5983804fb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-511/out/precommit/personality/provided.sh
git revisionmaster / 6738280
Default Java1.8.0_181
rubocophttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/5/artifact/out/diff-patch-rubocop.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/5/testReport/
Max. process+thread count2523 (vs. ulimit of 10000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/5/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 20, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec66Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall319master passed
+1compile21master passed
+1checkstyle10master passed
+1shadedjars271branch has no errors when building our shaded downstream artifacts.
+1javadoc13master passed
0spotbugs285Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs0master passed
_ Patch Compile Tests _
+1mvninstall303the patch passed
+1compile22the patch passed
+1javac22the patch passed
+1checkstyle10the patch passed
-1rubocop5The patch generated 3 new + 67 unchanged - 3 fixed = 70 total (was 70)
+1whitespace1The patch has no whitespace issues.
+1shadedjars280patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck945Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc12the patch passed
+1findbugs0the patch passed
_ Other Tests _
+1unit603hbase-shell in the patch passed.
+1asflicense11The patch does not generate ASF License warnings.
3260
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/6/artifact/out/Dockerfile
GITHUB PR#511
Optional Testsdupname asflicense javac javadoc unit rubocop spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 6fe1fa90ea8a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-511/out/precommit/personality/provided.sh
git revisionmaster / a59f7d4
Default Java1.8.0_181
rubocophttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/6/artifact/out/diff-patch-rubocop.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/6/testReport/
Max. process+thread count2526 (vs. ulimit of 10000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/6/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Reidddddd
Reidddddd requested changes Aug 20, 2019
View reviewed changes
Comment threadhbase-shell/src/test/java/org/apache/hadoop/hbase/client/TestShell.java
public void testRunShellTests() throws IOException {
System.setProperty("shell.test.exclude", "replication_admin_test.rb,rsgroup_shell_test.rb," +
"admin_test.rb,table_test.rb,quotas_test.rb");
"admin_test.rb,table_test.rb,quotas_test.rb,admin2_test.rb");

@ReiddddddReiddddddAug 20, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the story of admin2_test.rb, why is it related to this fix?

@mymeiyimymeiyiAug 20, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not related to this fix. But admin2_test.rb is already tested in TestAdminShell2, TestShell can skip it rather than test it twice?

Reidddddd
Reidddddd approved these changes Aug 20, 2019
View reviewed changes

@ReiddddddReidddddd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache-HBase

Apache-HBase commented Aug 20, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec61Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall372master passed
+1compile24master passed
+1checkstyle11master passed
+1shadedjars301branch has no errors when building our shaded downstream artifacts.
+1javadoc15master passed
0spotbugs319Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs0master passed
_ Patch Compile Tests _
+1mvninstall336the patch passed
+1compile22the patch passed
+1javac22the patch passed
+1checkstyle10the patch passed
-1rubocop6The patch generated 3 new + 67 unchanged - 3 fixed = 70 total (was 70)
+1whitespace0The patch has no whitespace issues.
+1shadedjars276patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck943Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc33the patch passed
+1findbugs0the patch passed
_ Other Tests _
+1unit745hbase-shell in the patch passed.
+1asflicense17The patch does not generate ASF License warnings.
3613
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/7/artifact/out/Dockerfile
GITHUB PR#511
Optional Testsdupname asflicense javac javadoc unit rubocop spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 90009fb56837 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-511/out/precommit/personality/provided.sh
git revisionmaster / ab28f9d
Default Java1.8.0_181
rubocophttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/7/artifact/out/diff-patch-rubocop.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/7/testReport/
Max. process+thread count2528 (vs. ulimit of 10000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/7/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@mymeiyi
mymeiyi merged commit 66ad42c into apache:masterAug 21, 2019
mymeiyi added a commit that referenced this pull request Aug 21, 2019
@mymeiyimeiyi
HBASE-22879user_permission command failed to show global permission (#…
947f6d4
…511)
mymeiyi added a commit that referenced this pull request Aug 21, 2019
@mymeiyimeiyi
HBASE-22879user_permission command failed to show global permission (#…
9d178cf
…511)
@mymeiyi
mymeiyi deleted the user-permission branch September 4, 2019 06:47
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@mymeiyi@Apache9
HBASE-22879 user_permission command failed to show global permission (a…
63159cc
…pache#511)
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@mymeiyiJenkins
HBASE-22879 user_permission command failed to show global permission (a…
57aa791
…pache#511)
(cherry picked from commit 947f6d4)
Change-Id: If5de4d376b78a7a13ac26321a464dc91ae12f9de
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ReiddddddReiddddddReidddddd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mymeiyi@Apache-HBase@Reidddddd