Uh oh!
There was an error while loading. Please reload this page.
HBASE-27720 TestClusterRestartFailover is flakey due to metrics assertion - #5110
Conversation
Apache-HBase
commented
Mar 15, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 15, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 15, 2023
💔 -1 overall
This message was automatically generated. |
| .getServerNode(SERVER_FOR_TEST); | ||
| assertNull("serverNode should be deleted after SCP finished", serverNode); | ||
| // this test has been flakey. When it is rerun by surefire, the underlying minicluster isn't |
There was a problem hiding this comment.
Can not reset the metrics system in the AfterClass method or BeforeClass method?
There was a problem hiding this comment.
Posted a new patch that (I think) will reset the master metrics each time the mini cluster is started.
Apache9
commented
Mar 16, 2023
https://issues.apache.org/jira/browse/HBASE-14166 Seems added in this issue. |
9e49b1f to
e82f925CompareApache-HBase
commented
Mar 31, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 31, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 31, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 3, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 3, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 3, 2023
🎊 +1 overall
This message was automatically generated. |
…tion (apache#5110) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit f36587c) (cherry picked from commit 34e05b7) Change-Id: Ide31e7d4473061e223752c213c6836f5a53a1979
This test has been flakey. When it is rerun by surefire, the underlying minicluster isn't completely cleaned. specifically, the metics system isn't reset. The result is an otherwise successful re-run is failed because there's 8 or 12 SCPcounts instead of the 4 that a single run of the test would otherwise produce. Thus, assert of a multiple of 4.