Skip to content

Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2 - #5126

Merged
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:27651-hbase-daemon-sigs-branch-2
Mar 20, 2023
Merged

Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2#5126
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:27651-hbase-daemon-sigs-branch-2

Conversation

@ndimiduk

Copy link
Copy Markdown
Member

Introduce separate traps for SIGHUP vs. the rest. Treat SIGINT, SIGKILL, and EXIT identically, as before. Use the signal name without SIG prefix for increased portability, as per the POSIX man page for trap.

SIGTERM handler will now honor HBASE_STOP_TIMEOUT as described in the file header.

…and SIGTERM
Introduce separate `trap`s for SIGHUP vs. the rest. Treat `SIGINT`, `SIGKILL`, and `EXIT` identically, as before. Use the signal name without `SIG` prefix for increased portability, as per the POSIX man page for `trap`.
`SIGTERM` handler will now honor `HBASE_STOP_TIMEOUT` as described in the file header.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Mar 20, 2023
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 7sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
2m 27s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5126/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5126
Optional Tests
unameLinux 8445614c4e9e 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 873f898
Max. process+thread count29 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5126/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
1m 45s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5126/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5126
Optional Tests
unameLinux 98371ab557ac 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 873f898
Max. process+thread count38 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5126/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 59sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚spotless0m 53sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚shellcheck0m 0sThe patch generated 0 new + 126 unchanged - 12 fixed = 126 total (was 138)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚spotless0m 37spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
4m 1s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5126/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5126
Optional Testsdupname asflicense spotless shellcheck shelldocs
unameLinux 69f9c24f65e9 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 873f898
Max. process+thread count45 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5126/1/console
versionsgit=2.34.1 maven=3.8.6 shellcheck=0.8.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit e7a958a into apache:branch-2Mar 20, 2023
@ndimiduk
ndimiduk deleted the 27651-hbase-daemon-sigs-branch-2 branch March 20, 2023 14:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ndimiduk@Apache-HBase