Skip to content

HBASE-27741 Fall back to protoc osx-x86_64 on Apple Silicon - #5132

Merged
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:27741-apple-silicon-protoc-x86
Mar 22, 2023
Merged

HBASE-27741 Fall back to protoc osx-x86_64 on Apple Silicon#5132
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:27741-apple-silicon-protoc-x86

Conversation

@ndimiduk

Copy link
Copy Markdown
Member

Old protobuf-2.5 doesn't know about Apple Silicon. Fall back to the x86 binary and hope that rosetta continues to work.

https://cwiki.apache.org/confluence/display/HADOOP/Develop+on+Apple+Silicon+%28M1%29+macOS

Old protobuf-2.5 doesn't know about Apple Silicon. Fall back to the x86 binary and hope that
rosetta continues to work.
https://cwiki.apache.org/confluence/display/HADOOP/Develop+on+Apple+Silicon+%28M1%29+macOS
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 1sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 53sbranch-2 passed
+1 💚compile0m 9sbranch-2 passed
+1 💚shadedjars4m 12sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 11sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 41sthe patch passed
+1 💚compile0m 10sthe patch passed
+1 💚javac0m 10sthe patch passed
+1 💚shadedjars4m 8spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 10sthe patch passed
_ Other Tests _
+1 💚unit0m 9shbase-build-configuration in the patch passed.
16m 59s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5132/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5132
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9b9e9c8f66bb 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a10cbf8
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5132/1/testReport/
Max. process+thread count71 (vs. ulimit of 30000)
modulesC: hbase-build-configuration U: hbase-build-configuration
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5132/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 44sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall5m 31sbranch-2 passed
+1 💚compile0m 11sbranch-2 passed
+1 💚shadedjars5m 52sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 13sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 32sthe patch passed
+1 💚compile0m 10sthe patch passed
+1 💚javac0m 10sthe patch passed
+1 💚shadedjars4m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 9sthe patch passed
_ Other Tests _
+1 💚unit0m 10shbase-build-configuration in the patch passed.
23m 29s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5132/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5132
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8edd46fae972 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a10cbf8
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5132/1/testReport/
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-build-configuration U: hbase-build-configuration
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5132/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall4m 6sbranch-2 passed
+1 💚compile0m 7sbranch-2 passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 32sthe patch passed
+1 💚compile0m 8sthe patch passed
+1 💚javac0m 8sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck19m 38sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚spotless0m 40spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 9sThe patch does not generate ASF License warnings.
31m 23s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5132/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5132
Optional Testsdupname asflicense javac hadoopcheck spotless xml compile
unameLinux dbd869544fe6 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 29dfd00
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count80 (vs. ulimit of 30000)
modulesC: hbase-build-configuration U: hbase-build-configuration
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5132/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@petersomogyipetersomogyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@ndimiduk
ndimiduk merged commit 29ca26a into apache:branch-2Mar 22, 2023
@ndimiduk
ndimiduk deleted the 27741-apple-silicon-protoc-x86 branch March 22, 2023 13:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@petersomogyi