Skip to content

HBASE-27536: Include more request information in slowlog for Scans - #5166

Merged
bbeaudreault merged 5 commits into
apache:branch-2from
HubSpot:rmattingly/branch-2/HBASE-27536
Apr 16, 2023
Merged

HBASE-27536: Include more request information in slowlog for Scans#5166
bbeaudreault merged 5 commits into
apache:branch-2from
HubSpot:rmattingly/branch-2/HBASE-27536

Conversation

@rmdmattingly

@rmdmattinglyrmdmattingly commented Apr 8, 2023

Copy link
Copy Markdown
Contributor

PR to master: #5155, solves HBASE-27536

Currently slow logs only includes a barebones text format of the underlying protobuf Message fields. Gets and Puts are relatively straightforward from a query cost perspective, but the configuration of Scans can have very significant performance implications.

With that in mind, we think it would be valuable to include the JSON representation of a given Scan to the slow log that it may produce.

@Apache-HBase

Apache-HBase commented Apr 8, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 55sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 38sbranch-2 passed
+1 💚compile2m 0sbranch-2 passed
+1 💚shadedjars4m 36sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 12sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
-1 ❌mvninstall0m 40sroot in the patch failed.
-1 ❌compile0m 8shbase-protocol-shaded in the patch failed.
-1 ❌compile0m 18shbase-client in the patch failed.
-1 ❌compile0m 31shbase-server in the patch failed.
-0 ⚠️javac0m 8shbase-protocol-shaded in the patch failed.
-0 ⚠️javac0m 18shbase-client in the patch failed.
-0 ⚠️javac0m 31shbase-server in the patch failed.
-1 ❌shadedjars1m 28spatch has 51 errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 9shbase-protocol-shaded in the patch failed.
_ Other Tests _
-1 ❌unit0m 9shbase-protocol-shaded in the patch failed.
+1 💚unit2m 14shbase-common in the patch passed.
-1 ❌unit0m 19shbase-client in the patch failed.
-1 ❌unit0m 31shbase-server in the patch failed.
22m 33s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5166
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 61d6d51e4a0e 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a67a8f7
Default JavaEclipse Adoptium-11.0.17+8
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-protocol-shaded.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-protocol-shaded.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjarshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-protocol-shaded.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-protocol-shaded.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/testReport/
Max. process+thread count243 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 8, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 56sbranch-2 passed
+1 💚compile4m 7sbranch-2 passed
+1 💚checkstyle1m 9sbranch-2 passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 37sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
-1 ❌mvninstall0m 36sroot in the patch failed.
-1 ❌compile0m 6shbase-protocol-shaded in the patch failed.
-1 ❌compile0m 15shbase-client in the patch failed.
-1 ❌compile0m 26shbase-server in the patch failed.
-0 ⚠️cc0m 6shbase-protocol-shaded in the patch failed.
-0 ⚠️cc0m 15shbase-client in the patch failed.
-0 ⚠️cc0m 26shbase-server in the patch failed.
-0 ⚠️javac0m 6shbase-protocol-shaded in the patch failed.
-0 ⚠️javac0m 15shbase-client in the patch failed.
-0 ⚠️javac0m 26shbase-server in the patch failed.
+1 💚checkstyle1m 4sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌hadoopcheck0m 8sThe patch causes 51 errors with Hadoop v2.10.2.
-1 ❌hadoopcheck0m 17sThe patch causes 51 errors with Hadoop v3.2.4.
-1 ❌hadoopcheck0m 26sThe patch causes 51 errors with Hadoop v3.3.4.
-1 ❌hbaseprotoc0m 6shbase-protocol-shaded in the patch failed.
-1 ❌hbaseprotoc0m 15shbase-client in the patch failed.
-1 ❌hbaseprotoc0m 26shbase-server in the patch failed.
+1 💚spotless0m 40spatch has no errors when running spotless:check.
-1 ❌spotbugs0m 6shbase-protocol-shaded in the patch failed.
-1 ❌spotbugs0m 13shbase-client in the patch failed.
-1 ❌spotbugs0m 22shbase-server in the patch failed.
_ Other Tests _
+1 💚asflicense0m 26sThe patch does not generate ASF License warnings.
24m 22s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5166
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
unameLinux 5dabd6124247 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a67a8f7
Default JavaEclipse Adoptium-11.0.17+8
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-protocol-shaded.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
cchttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-protocol-shaded.txt
cchttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
cchttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-protocol-shaded.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-javac-2.10.2.txt
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-javac-3.2.4.txt
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-javac-3.3.4.txt
hbaseprotochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-protocol-shaded.txt
hbaseprotochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-client.txt
hbaseprotochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-protocol-shaded.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-client.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 8, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 52sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for branch
+1 💚mvninstall4m 8sbranch-2 passed
+1 💚compile2m 3sbranch-2 passed
+1 💚shadedjars5m 19sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 3sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
-1 ❌mvninstall0m 40sroot in the patch failed.
-1 ❌compile0m 7shbase-protocol-shaded in the patch failed.
-1 ❌compile0m 17shbase-client in the patch failed.
-1 ❌compile0m 36shbase-server in the patch failed.
-0 ⚠️javac0m 7shbase-protocol-shaded in the patch failed.
-0 ⚠️javac0m 17shbase-client in the patch failed.
-0 ⚠️javac0m 36shbase-server in the patch failed.
-1 ❌shadedjars2m 1spatch has 51 errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 10shbase-protocol-shaded in the patch failed.
_ Other Tests _
-1 ❌unit0m 9shbase-protocol-shaded in the patch failed.
+1 💚unit3m 1shbase-common in the patch passed.
-1 ❌unit0m 27shbase-client in the patch failed.
-1 ❌unit0m 35shbase-server in the patch failed.
26m 14s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5166
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c0add2382427 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a67a8f7
Default JavaTemurin-1.8.0_352-b08
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-protocol-shaded.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-client.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-protocol-shaded.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-client.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-server.txt
shadedjarshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-hbase-protocol-shaded.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-protocol-shaded.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-client.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/testReport/
Max. process+thread count246 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@rmdmattingly
rmdmattinglyforce-pushed the rmattingly/branch-2/HBASE-27536 branch from a66f623 to 982cfcdCompareApril 10, 2023 16:16
@Apache-HBase

Apache-HBase commented Apr 10, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 25sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 41sbranch-2 passed
+1 💚compile4m 13sbranch-2 passed
+1 💚checkstyle1m 17sbranch-2 passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 42sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 24sthe patch passed
+1 💚compile4m 15sthe patch passed
+1 💚cc4m 15sthe patch passed
-0 ⚠️javac0m 44shbase-client generated 1 new + 107 unchanged - 1 fixed = 108 total (was 108)
+1 💚checkstyle1m 17sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck17m 44sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚hbaseprotoc1m 43sthe patch passed
+1 💚spotless0m 41spatch has no errors when running spotless:check.
+1 💚spotbugs5m 14sthe patch passed
_ Other Tests _
+1 💚asflicense0m 39sThe patch does not generate ASF License warnings.
52m 46s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5166
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
unameLinux f054ff2d7669 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a67a8f7
Default JavaEclipse Adoptium-11.0.17+8
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 10, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 58sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 20sbranch-2 passed
+1 💚compile2m 1sbranch-2 passed
+1 💚shadedjars4m 34sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 10sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 22sthe patch passed
+1 💚compile2m 7sthe patch passed
+1 💚javac2m 7sthe patch passed
+1 💚shadedjars4m 34spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 12sthe patch passed
_ Other Tests _
+1 💚unit0m 34shbase-protocol-shaded in the patch passed.
+1 💚unit2m 13shbase-common in the patch passed.
+1 💚unit8m 9shbase-client in the patch passed.
+1 💚unit214m 26shbase-server in the patch passed.
254m 34s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5166
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9bdeb71c3753 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a67a8f7
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/testReport/
Max. process+thread count2287 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 10, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 42sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 52sbranch-2 passed
+1 💚compile1m 44sbranch-2 passed
+1 💚shadedjars4m 13sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 5sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 44sthe patch passed
+1 💚compile1m 43sthe patch passed
+1 💚javac1m 43sthe patch passed
+1 💚shadedjars4m 8spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 5sthe patch passed
_ Other Tests _
+1 💚unit0m 27shbase-protocol-shaded in the patch passed.
+1 💚unit2m 0shbase-common in the patch passed.
+1 💚unit7m 56shbase-client in the patch passed.
-1 ❌unit221m 23shbase-server in the patch failed.
263m 23s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5166
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 50ff19988abf 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a67a8f7
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/testReport/
Max. process+thread count2233 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 10, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 52sbranch-2 passed
+1 💚compile4m 16sbranch-2 passed
+1 💚checkstyle1m 10sbranch-2 passed
+1 💚spotless0m 44sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 39sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 31sthe patch passed
+1 💚compile4m 13sthe patch passed
+1 💚cc4m 13sthe patch passed
+1 💚javac4m 13sthe patch passed
+1 💚checkstyle1m 7sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck19m 36sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚hbaseprotoc1m 39sthe patch passed
+1 💚spotless0m 40spatch has no errors when running spotless:check.
+1 💚spotbugs5m 8sthe patch passed
_ Other Tests _
+1 💚asflicense0m 31sThe patch does not generate ASF License warnings.
54m 39s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5166
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
unameLinux 43f306f2d6d6 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 0848936
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count84 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 11, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 0sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 22sbranch-2 passed
+1 💚compile2m 1sbranch-2 passed
+1 💚shadedjars4m 34sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 10sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 25sthe patch passed
+1 💚compile2m 2sthe patch passed
+1 💚javac2m 2sthe patch passed
+1 💚shadedjars4m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 5sthe patch passed
_ Other Tests _
+1 💚unit0m 35shbase-protocol-shaded in the patch passed.
+1 💚unit2m 11shbase-common in the patch passed.
+1 💚unit8m 5shbase-client in the patch passed.
+1 💚unit213m 51shbase-server in the patch passed.
253m 48s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5166
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a8beea3de350 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 0848936
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/testReport/
Max. process+thread count2265 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 11, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 12sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 38sbranch-2 passed
+1 💚compile1m 43sbranch-2 passed
+1 💚shadedjars4m 14sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 5sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 39sthe patch passed
+1 💚compile1m 44sthe patch passed
+1 💚javac1m 44sthe patch passed
+1 💚shadedjars4m 11spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 4sthe patch passed
_ Other Tests _
+1 💚unit0m 28shbase-protocol-shaded in the patch passed.
+1 💚unit1m 59shbase-common in the patch passed.
+1 💚unit7m 49shbase-client in the patch passed.
-1 ❌unit220m 24shbase-server in the patch failed.
256m 58s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5166
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a3a53ca65193 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 0848936
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/testReport/
Max. process+thread count2170 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasanivirajjasani changed the title "HBASE-27536: add Scan to slow log payload" to branch-2HBASE-27536: add Scan to slow log payloadApr 12, 2023
@virajjasanivirajjasani added the backport This PR is a back port of some issue or issues already committed to master label Apr 12, 2023
@virajjasanivirajjasani changed the title HBASE-27536: add Scan to slow log payloadHBASE-27536: Include more request information in slowlog for ScansApr 12, 2023
@bbeaudreault
bbeaudreault merged commit 1ae057b into apache:branch-2Apr 16, 2023
@bbeaudreault
bbeaudreault deleted the rmattingly/branch-2/HBASE-27536 branch April 16, 2023 14:11
rmdmattingly added a commit to HubSpot/hbase that referenced this pull request Apr 18, 2023
@rmdmattinglyRay Mattingly
HBASE-27536: Include more request information in slowlog for Scans (a…
60cb5c4
…pache#5166)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
@rmdmattinglyrmdmattingly mentioned this pull request Apr 18, 2023
Merged
rmdmattingly added a commit to HubSpot/hbase that referenced this pull request Apr 18, 2023
@rmdmattingly
HBASE-27536: Include more request information in slowlog for Scans (a…
bbb3324
…pache#5166) (#51)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rmdmattingly@Apache-HBase@bbeaudreault@virajjasani