Skip to content

HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot (addendum - use the old config key) - #517

Merged
openinx merged 1 commit into
apache:masterfrom
openinx:HBASE-22810
Aug 22, 2019
Merged

HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot (addendum - use the old config key)#517
openinx merged 1 commit into
apache:masterfrom
openinx:HBASE-22810

Conversation

@openinx

@openinxopeninx commented Aug 21, 2019

Copy link
Copy Markdown
Member

No description provided.

@openinx
HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/rest…
289e9ed
…oring snapshot (addendum - use the old config key)
Apache9
Apache9 approved these changes Aug 21, 2019
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 if pre commit is fine.

@ankitsinghal

ankitsinghal commented Aug 21, 2019

Copy link
Copy Markdown
Contributor

👍

@Apache-HBase

Apache-HBase commented Aug 21, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec37Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0mvndep35Maven dependency ordering for branch
+1mvninstall316master passed
+1compile78master passed
+1checkstyle101master passed
+1shadedjars279branch has no errors when building our shaded downstream artifacts.
+1javadoc54master passed
0spotbugs256Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs300master passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall321the patch passed
+1compile81the patch passed
+1javac81the patch passed
+1checkstyle23The patch passed checkstyle in hbase-common
+1checkstyle76hbase-server: The patch generated 0 new + 123 unchanged - 1 fixed = 123 total (was 124)
+1whitespace0The patch has no whitespace issues.
+1shadedjars282patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1002Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc52the patch passed
+1findbugs300the patch passed
_ Other Tests _
+1unit172hbase-common in the patch passed.
+1unit8371hbase-server in the patch passed.
+1asflicense48The patch does not generate ASF License warnings.
12348
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-517/2/artifact/out/Dockerfile
GITHUB PR#517
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 71a09ebeb520 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-517/out/precommit/personality/provided.sh
git revisionmaster / b8857ec
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-517/2/testReport/
Max. process+thread count4634 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-517/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 21, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec32Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0mvndep33Maven dependency ordering for branch
+1mvninstall345master passed
+1compile97master passed
+1checkstyle134master passed
+1shadedjars310branch has no errors when building our shaded downstream artifacts.
+1javadoc59master passed
0spotbugs279Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs331master passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall336the patch passed
+1compile84the patch passed
+1javac84the patch passed
+1checkstyle28The patch passed checkstyle in hbase-common
+1checkstyle94hbase-server: The patch generated 0 new + 123 unchanged - 1 fixed = 123 total (was 124)
+1whitespace0The patch has no whitespace issues.
+1shadedjars308patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1169Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc69the patch passed
+1findbugs416the patch passed
_ Other Tests _
+1unit205hbase-common in the patch passed.
-1unit10249hbase-server in the patch failed.
+1asflicense50The patch does not generate ASF License warnings.
14884
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-517/3/artifact/out/Dockerfile
GITHUB PR#517
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 06d22b1932ff 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-517/out/precommit/personality/provided.sh
git revisionmaster / b8857ec
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-517/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-517/3/testReport/
Max. process+thread count4874 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-517/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 21, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec102Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0mvndep38Maven dependency ordering for branch
+1mvninstall379master passed
+1compile86master passed
+1checkstyle120master passed
+1shadedjars305branch has no errors when building our shaded downstream artifacts.
+1javadoc64master passed
0spotbugs304Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs376master passed
_ Patch Compile Tests _
0mvndep17Maven dependency ordering for patch
+1mvninstall465the patch passed
+1compile196the patch passed
+1javac196the patch passed
+1checkstyle74The patch passed checkstyle in hbase-common
+1checkstyle171hbase-server: The patch generated 0 new + 123 unchanged - 1 fixed = 123 total (was 124)
+1whitespace0The patch has no whitespace issues.
+1shadedjars496patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1708Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc172the patch passed
+1findbugs650the patch passed
_ Other Tests _
+1unit182hbase-common in the patch passed.
-1unit17194hbase-server in the patch failed.
+1asflicense73The patch does not generate ASF License warnings.
23535
ReasonTests
Failed junit testshadoop.hbase.client.TestFromClientSideWithCoprocessor
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
SubsystemReport/Notes
DockerClient=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-517/1/artifact/out/Dockerfile
GITHUB PR#517
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 837ca6db7b3f 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-517/out/precommit/personality/provided.sh
git revisionmaster / 61a3a9f
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-517/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-517/1/testReport/
Max. process+thread count4681 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-517/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@openinx
openinx merged commit 84ee378 into apache:masterAug 22, 2019
asfgit pushed a commit that referenced this pull request Aug 22, 2019
@openinx
HBASE-22810Initialize an separate ThreadPoolExecutor for taking/rest…
cb0727d
…oring snapshot (addendum - use the old config key) (#517)
asfgit pushed a commit that referenced this pull request Aug 22, 2019
@openinx
HBASE-22810Initialize an separate ThreadPoolExecutor for taking/rest…
d26f006
…oring snapshot (addendum - use the old config key) (#517)
asfgit pushed a commit that referenced this pull request Aug 22, 2019
@openinx
HBASE-22810Initialize an separate ThreadPoolExecutor for taking/rest…
53522f3
…oring snapshot (addendum - use the old config key) (#517)
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@openinx@Apache9
HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/rest…
354ebaf
…oring snapshot (addendum - use the old config key) (apache#517)
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@openinxJenkins
HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/rest…
b67d777
…oring snapshot (addendum - use the old config key) (apache#517)
(cherry picked from commit cb0727d)
Change-Id: Ibad2ae833873f9c71ea9fe570bf4a3fa66822ed4
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes
@saintstacksaintstackAwaiting requested review from saintstack

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openinx@ankitsinghal@Apache-HBase@Apache9