Skip to content

HBASE-27791 Upgrade vega and its related js libraries - #5173

Merged
ndimiduk merged 1 commit into
apache:masterfrom
NihalJain:HBASE-27791
Apr 17, 2023
Merged

HBASE-27791 Upgrade vega and its related js libraries#5173
ndimiduk merged 1 commit into
apache:masterfrom
NihalJain:HBASE-27791

Conversation

@NihalJain

Copy link
Copy Markdown
Contributor

No description provided.

@NihalJain

NihalJain commented Apr 12, 2023

Copy link
Copy Markdown
ContributorAuthor

Built HBase assembly tarball locally. Started HBase in hbase.cluster.distributed=false mode. Ran PE tool on 2 tables with 100K rows. Opened Master web UI and verified the visualisations are as expected.
Screenshot 2023-04-12 at 5 47 05 PM

NOTE: Above image is edited to hide IP with thick line

Also clicked on the various options available for the visualisation, like save SVG, PNG etc. and ensured all the 5 options work as expected.

Also verified http://localhost:16010/static/js/ has expected JS files:
Screenshot 2023-04-12 at 5 46 51 PM

The attached JS files are downloaded from below CDN:

FYI @ndimiduk, please review!

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗jshint0m 0sjshint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 31smaster passed
+1 💚spotless0m 40sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall3m 10sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚spotless0m 36spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 17sThe patch does not generate ASF License warnings.
10m 35s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5173
Optional Testsdupname asflicense javac spotless jshint
unameLinux fc6db542b2d6 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e4b4cef
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall5m 5smaster passed
+1 💚javadoc2m 43smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 8sMaven dependency ordering for patch
+1 💚mvninstall3m 52sthe patch passed
+1 💚javadoc3m 14sthe patch passed
_ Other Tests _
-1 ❌unit290m 29sroot in the patch failed.
312m 12s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5173
Optional Testsjavac javadoc unit
unameLinux bc19aa43f191 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e4b4cef
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/testReport/
Max. process+thread count2724 (vs. ulimit of 30000)
modulesC: hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 25sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 2smaster passed
+1 💚javadoc1m 42smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 45sthe patch passed
+1 💚javadoc1m 40sthe patch passed
_ Other Tests _
+1 💚unit388m 46sroot in the patch passed.
404m 58s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5173
Optional Testsjavac javadoc unit
unameLinux ff8e9545264a 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e4b4cef
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/testReport/
Max. process+thread count4805 (vs. ulimit of 30000)
modulesC: hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@chrajeshbabuchrajeshbabu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ndimidukndimiduk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @NihalJain .

One follow-up question: do you have a suggestion as to how HBase build could pull in these javascript dependencies automatically? I think it would be better for everyone if these were not managed by hand.

@ndimiduk
ndimiduk merged commit 24c471a into apache:masterApr 17, 2023
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Apr 17, 2023
Signed-off-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Apr 17, 2023
Signed-off-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
ndimiduk pushed a commit that referenced this pull request Apr 18, 2023
Signed-off-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
ndimiduk pushed a commit that referenced this pull request Apr 18, 2023
Signed-off-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
@NihalJain

NihalJain commented Apr 18, 2023

Copy link
Copy Markdown
ContributorAuthor

Looks good to me @NihalJain .

One follow-up question: do you have a suggestion as to how HBase build could pull in these javascript dependencies automatically? I think it would be better for everyone if these were not managed by hand.

Created https://issues.apache.org/jira/browse/HBASE-27802 to discuss same

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@NihalJain@Apache-HBase@ndimiduk@chrajeshbabu