Skip to content

HBASE-27274 Re-enable the disabled tests when implementing HBASE-27212 - #5178

Merged
Apache9 merged 1 commit into
apache:HBASE-27109/table_based_rqsfrom
2005hithlj:HBASE-27274
Apr 18, 2023
Merged

HBASE-27274 Re-enable the disabled tests when implementing HBASE-27212#5178
Apache9 merged 1 commit into
apache:HBASE-27109/table_based_rqsfrom
2005hithlj:HBASE-27274

Conversation

@2005hithlj

Copy link
Copy Markdown
Contributor

@2005hithlj
2005hithlj requested a review from Apache9April 13, 2023 15:00
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-27109/table_based_rqs Compile Tests _
+1 💚mvninstall3m 54sHBASE-27109/table_based_rqs passed
+1 💚compile2m 32sHBASE-27109/table_based_rqs passed
+1 💚checkstyle0m 35sHBASE-27109/table_based_rqs passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 29sHBASE-27109/table_based_rqs passed
_ Patch Compile Tests _
+1 💚mvninstall3m 32sthe patch passed
+1 💚compile2m 31sthe patch passed
+1 💚javac2m 31sthe patch passed
+1 💚checkstyle0m 34sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 52sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 40spatch has no errors when running spotless:check.
+1 💚spotbugs1m 34sthe patch passed
_ Other Tests _
+1 💚asflicense0m 9sThe patch does not generate ASF License warnings.
40m 46s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5178
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux fc7a07503cb9 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-27109/table_based_rqs / 2ea9c59
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
Contributor

Let's wait for the pre commit result.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 54sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-27109/table_based_rqs Compile Tests _
+1 💚mvninstall3m 44sHBASE-27109/table_based_rqs passed
+1 💚compile0m 45sHBASE-27109/table_based_rqs passed
+1 💚shadedjars4m 27sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 27sHBASE-27109/table_based_rqs passed
_ Patch Compile Tests _
+1 💚mvninstall3m 27sthe patch passed
+1 💚compile0m 49sthe patch passed
+1 💚javac0m 49sthe patch passed
+1 💚shadedjars4m 24spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 26sthe patch passed
_ Other Tests _
-1 ❌unit230m 23shbase-server in the patch failed.
254m 18s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5178
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c3ed4bfcb5ef 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-27109/table_based_rqs / 2ea9c59
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/testReport/
Max. process+thread count2679 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 28sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-27109/table_based_rqs Compile Tests _
+1 💚mvninstall4m 46sHBASE-27109/table_based_rqs passed
+1 💚compile1m 8sHBASE-27109/table_based_rqs passed
+1 💚shadedjars6m 16sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37sHBASE-27109/table_based_rqs passed
_ Patch Compile Tests _
+1 💚mvninstall4m 28sthe patch passed
+1 💚compile1m 0sthe patch passed
+1 💚javac1m 0sthe patch passed
+1 💚shadedjars6m 42spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 31sthe patch passed
_ Other Tests _
-1 ❌unit263m 47shbase-server in the patch failed.
295m 42s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5178
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 821ba2606fbc 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-27109/table_based_rqs / 2ea9c59
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/testReport/
Max. process+thread count2684 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@2005hithlj

Copy link
Copy Markdown
ContributorAuthor

There are some failed UTs, but I found that they are not related to TestHBaseFsckReplication.

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's dig on the replication related test failures later.

@2005hithlj

Copy link
Copy Markdown
ContributorAuthor

In my local environment, TestReplicationValueCompressedWAL will still fail, but TestReplicationDroppedTables will succeed.

@Apache9

Copy link
Copy Markdown
Contributor

In my local environment, TestReplicationValueCompressedWAL will still fail, but TestReplicationDroppedTables will succeed.

Oh, you can reproduce the failure of TestReplicationValueCompressedWAL locally? It has been flaky for a long time but it is really hard to reproduce the failure locally so no big progress on the fixing...
If you can reproduce it locally, could you please try to find out the root cause?

Thanks.

@Apache9
Apache9 merged commit 042c1e7 into apache:HBASE-27109/table_based_rqsApr 18, 2023
@2005hithlj

Copy link
Copy Markdown
ContributorAuthor

In my local environment, TestReplicationValueCompressedWAL will still fail, but TestReplicationDroppedTables will succeed.

Oh, you can reproduce the failure of TestReplicationValueCompressedWAL locally? It has been flaky for a long time but it is really hard to reproduce the failure locally so no big progress on the fixing... If you can reproduce it locally, could you please try to find out the root cause?

Thanks.

OK, I will try to find out.

Apache9 pushed a commit that referenced this pull request Apr 18, 2023
Apache9 pushed a commit that referenced this pull request Apr 21, 2023
Apache9 pushed a commit that referenced this pull request Apr 23, 2023
Apache9 pushed a commit that referenced this pull request Apr 24, 2023
Apache9 pushed a commit that referenced this pull request Apr 25, 2023
Apache9 pushed a commit that referenced this pull request Apr 27, 2023
Apache9 pushed a commit that referenced this pull request Apr 28, 2023
Apache9 pushed a commit that referenced this pull request May 1, 2023
Apache9 pushed a commit that referenced this pull request May 4, 2023
Apache9 pushed a commit that referenced this pull request May 6, 2023
Apache9 pushed a commit that referenced this pull request May 8, 2023
Apache9 pushed a commit that referenced this pull request May 13, 2023
Apache9 pushed a commit that referenced this pull request May 14, 2023
Apache9 pushed a commit that referenced this pull request May 15, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@2005hithlj@Apache-HBase@Apache9