Skip to content

HBASE-27728 Implement a tool to migrate replication peer data between… - #5179

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-27728
Apr 17, 2023
Merged

HBASE-27728 Implement a tool to migrate replication peer data between…#5179
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-27728

Conversation

@Apache9

@Apache9Apache9 commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

… different storage implementation

@Apache9Apache9 self-assigned this Apr 13, 2023
@Apache9
Apache9 requested a review from 2005hithljApril 13, 2023 15:54
@Apache-HBase

Apache-HBase commented Apr 13, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 39smaster passed
+1 💚compile1m 15smaster passed
+1 💚checkstyle0m 29smaster passed
+1 💚spotless0m 40sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 23smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall3m 14sthe patch passed
+1 💚compile1m 14sthe patch passed
+1 💚javac1m 14sthe patch passed
-0 ⚠️checkstyle0m 13shbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck12m 56sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 40spatch has no errors when running spotless:check.
+1 💚spotbugs1m 45sthe patch passed
_ Other Tests _
+1 💚asflicense0m 22sThe patch does not generate ASF License warnings.
37m 5s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5179
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml
unameLinux b26929185804 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a711059
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count81 (vs. ulimit of 30000)
modulesC: hbase-client hbase-replication hbase-mapreduce U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 13, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 0sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for branch
+1 💚mvninstall3m 26smaster passed
+1 💚compile0m 51smaster passed
+1 💚shadedjars4m 27sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 44smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 19sthe patch passed
+1 💚compile0m 51sthe patch passed
+1 💚javac0m 51sthe patch passed
+1 💚shadedjars4m 26spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 44sthe patch passed
_ Other Tests _
+1 💚unit1m 18shbase-client in the patch passed.
+1 💚unit0m 34shbase-replication in the patch passed.
+1 💚unit13m 56shbase-mapreduce in the patch passed.
37m 49s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5179
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9fe672878999 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a711059
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/testReport/
Max. process+thread count2738 (vs. ulimit of 30000)
modulesC: hbase-client hbase-replication hbase-mapreduce U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 13, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 25smaster passed
+1 💚compile1m 5smaster passed
+1 💚shadedjars6m 1sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 44smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 3sthe patch passed
+1 💚compile0m 49sthe patch passed
+1 💚javac0m 49sthe patch passed
+1 💚shadedjars4m 46spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35sthe patch passed
_ Other Tests _
+1 💚unit1m 14shbase-client in the patch passed.
+1 💚unit0m 28shbase-replication in the patch passed.
+1 💚unit13m 56shbase-mapreduce in the patch passed.
40m 59s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5179
Optional Testsjavac javadoc unit shadedjars compile
unameLinux bfd7e6258207 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a711059
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/testReport/
Max. process+thread count2688 (vs. ulimit of 30000)
modulesC: hbase-client hbase-replication hbase-mapreduce U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

2005hithlj
2005hithlj reviewed Apr 14, 2023
View reviewed changes
Comment threadhbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Driver.java Outdated
wchevreuil
wchevreuil reviewed Apr 14, 2023
View reviewed changes
Comment thread...lication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerMigrationTool.java
Comment thread...lication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerMigrationTool.java
Comment thread...lication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerMigrationTool.java Outdated
@Apache-HBase

Apache-HBase commented Apr 14, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 50sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 1sShelldocs was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall5m 30smaster passed
+1 💚compile6m 45smaster passed
+1 💚checkstyle1m 38smaster passed
+1 💚spotless0m 59sbranch has no errors when running spotless:check.
+1 💚spotbugs11m 57smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 32sthe patch passed
+1 💚compile5m 29sthe patch passed
+1 💚javac5m 29sthe patch passed
-0 ⚠️checkstyle1m 8sroot: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚shellcheck0m 2sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck12m 52sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 38spatch has no errors when running spotless:check.
+1 💚spotbugs7m 50sthe patch passed
_ Other Tests _
+1 💚asflicense0m 24sThe patch does not generate ASF License warnings.
69m 37s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5179
Optional Testsdupname asflicense spotless shellcheck shelldocs javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
unameLinux 85c619455819 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 856fa14
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt
Max. process+thread count176 (vs. ulimit of 30000)
modulesC: hbase-client hbase-replication . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/2/console
versionsgit=2.34.1 maven=3.8.6 shellcheck=0.8.0 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Apr 17, 2023

Copy link
Copy Markdown
ContributorAuthor

Any other concerns? @2005hithlj@wchevreuil

Thanks.

@2005hithlj

2005hithlj commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

LGTM

@Apache-HBase

Apache-HBase commented Apr 17, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 40sMaven dependency ordering for branch
+1 💚mvninstall5m 44smaster passed
+1 💚compile6m 2smaster passed
+1 💚checkstyle1m 38smaster passed
+1 💚spotless1m 1sbranch has no errors when running spotless:check.
+1 💚spotbugs11m 2smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall5m 4sthe patch passed
+1 💚compile8m 5sthe patch passed
+1 💚javac8m 5sthe patch passed
+1 💚checkstyle1m 30sthe patch passed
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚hadoopcheck20m 16sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless1m 7spatch has no errors when running spotless:check.
+1 💚spotbugs12m 53sthe patch passed
_ Other Tests _
+1 💚asflicense0m 31sThe patch does not generate ASF License warnings.
88m 24s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5179
Optional Testsdupname asflicense spotless shellcheck shelldocs javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
unameLinux 0449032dfafd 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2b098b0
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count176 (vs. ulimit of 30000)
modulesC: hbase-client hbase-replication . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/console
versionsgit=2.34.1 maven=3.8.6 shellcheck=0.8.0 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 17, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 3sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 25smaster passed
+1 💚compile1m 51smaster passed
+1 💚shadedjars4m 24sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 21smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 22sthe patch passed
+1 💚compile1m 50sthe patch passed
+1 💚javac1m 50sthe patch passed
+1 💚shadedjars4m 20spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 18sthe patch passed
_ Other Tests _
+1 💚unit274m 20sroot in the patch passed.
307m 34s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5179
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c459b7324373 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2b098b0
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/testReport/
Max. process+thread count4610 (vs. ulimit of 30000)
modulesC: hbase-client hbase-replication . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 17, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall4m 45smaster passed
+1 💚compile2m 11smaster passed
+1 💚shadedjars5m 47sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 9smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall4m 19sthe patch passed
+1 💚compile2m 16sthe patch passed
+1 💚javac2m 16sthe patch passed
+1 💚shadedjars6m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 41sthe patch passed
_ Other Tests _
-1 ❌unit361m 13sroot in the patch failed.
398m 25s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5179
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 66f4a3e62123 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2b098b0
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/testReport/
Max. process+thread count2191 (vs. ulimit of 30000)
modulesC: hbase-client hbase-replication . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit 31c4aea into apache:masterApr 17, 2023
Apache9 added a commit that referenced this pull request Apr 17, 2023
@Apache9
HBASE-27728Implement a tool to migrate replication peer data between…
04a4ac5
… different storage implementation (#5179)
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
(cherry picked from commit 31c4aea)
Conflicts:
hbase-client/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationPeerConfig.java
hbase-replication/src/test/java/org/apache/hadoop/hbase/replication/ReplicationPeerStorageTestBase.java
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2005hithlj2005hithlj2005hithlj approved these changes
@wchevreuilwchevreuilwchevreuil approved these changes

Assignees

@Apache9Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Apache9@Apache-HBase@2005hithlj@wchevreuil