Skip to content

Backport "HBASE-27762 Include EventType and ProcedureV2 pid in logging via MDC (#5145)" to branch-2 - #5185

Merged
ndimiduk merged 2 commits into
apache:branch-2from
ndimiduk:27762-eventtype-pid-mdc-branch-2
May 1, 2023
Merged

Backport "HBASE-27762 Include EventType and ProcedureV2 pid in logging via MDC (#5145)" to branch-2#5185
ndimiduk merged 2 commits into
apache:branch-2from
ndimiduk:27762-eventtype-pid-mdc-branch-2

Conversation

@ndimiduk

@ndimidukndimiduk commented Apr 17, 2023

Copy link
Copy Markdown
Member

No description provided.

@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Apr 17, 2023
@Apache-HBase

Apache-HBase commented Apr 17, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 46sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall5m 2sbranch-2 passed
+1 💚compile6m 11sbranch-2 passed
+1 💚checkstyle1m 21sbranch-2 passed
+1 💚spotless0m 53sbranch has no errors when running spotless:check.
+1 💚spotbugs11m 13sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 35sthe patch passed
+1 💚compile5m 57sthe patch passed
+1 💚javac5m 57sthe patch passed
+1 💚checkstyle1m 22sthe patch passed
+1 💚whitespace0m 1sThe patch has no whitespace issues.
+1 💚hadoopcheck23m 11sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚spotless0m 47spatch has no errors when running spotless:check.
+1 💚spotbugs11m 15sthe patch passed
_ Other Tests _
+1 💚asflicense0m 29sThe patch does not generate ASF License warnings.
76m 2s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5185
Optional Testsdupname asflicense spotless javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 82fb9b326030 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 1ae057b
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count180 (vs. ulimit of 30000)
modulesC: hbase-logging hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 17, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 50sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 41sbranch-2 passed
+1 💚compile2m 8sbranch-2 passed
+1 💚shadedjars6m 2sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 1sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 28sthe patch passed
+1 💚compile1m 59sthe patch passed
+1 💚javac1m 59sthe patch passed
+1 💚shadedjars5m 59spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 53sthe patch passed
_ Other Tests _
-1 ❌unit268m 27sroot in the patch failed.
306m 50s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5185
Optional Testsunit javac javadoc shadedjars compile
unameLinux aa4a50a84ce0 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 1ae057b
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/1/testReport/
Max. process+thread count4890 (vs. ulimit of 30000)
modulesC: hbase-logging hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 17, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 42sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 49sbranch-2 passed
+1 💚compile1m 32sbranch-2 passed
+1 💚shadedjars4m 8sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 2sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 39sthe patch passed
+1 💚compile1m 32sthe patch passed
+1 💚javac1m 32sthe patch passed
+1 💚shadedjars4m 10spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 3sthe patch passed
_ Other Tests _
-1 ❌unit341m 50sroot in the patch failed.
370m 32s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5185
Optional Testsunit javac javadoc shadedjars compile
unameLinux 6af86e3ad749 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 1ae057b
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/1/testReport/
Max. process+thread count2486 (vs. ulimit of 30000)
modulesC: hbase-logging hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
HBASE-27762 Include EventType and ProcedureV2 pid in logging via MDC (a…
0956b6d
…pache#5145)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@ndimiduk
HBASE-27762 Include EventType and ProcedureV2 pid in logging via MDC …
3724731
…(addendum)
Make use of `%notEmpty` pattern with MDC logging. Will function as expected once we upgrade to
Log4J 2.21.0+.
@ndimiduk
ndimidukforce-pushed the 27762-eventtype-pid-mdc-branch-2 branch from 8816173 to 3724731CompareApril 28, 2023 09:58
@Apache-HBase

Apache-HBase commented Apr 28, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 47sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 13sbranch-2 passed
-1 ❌compile2m 45sroot in branch-2 failed.
+1 💚checkstyle1m 21sbranch-2 passed
+1 💚spotless0m 50sbranch has no errors when running spotless:check.
+1 💚spotbugs11m 9sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 35sthe patch passed
-1 ❌compile2m 45sroot in the patch failed.
-0 ⚠️javac2m 45sroot in the patch failed.
+1 💚checkstyle1m 18sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck22m 24sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚spotless0m 54spatch has no errors when running spotless:check.
+1 💚spotbugs11m 23sthe patch passed
_ Other Tests _
+1 💚asflicense0m 29sThe patch does not generate ASF License warnings.
67m 30s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5185
Optional Testsdupname asflicense spotless javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 80f4f0b2c4d3 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 0fb5053
Default JavaEclipse Adoptium-11.0.17+8
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/2/artifact/yetus-general-check/output/branch-compile-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/2/artifact/yetus-general-check/output/patch-compile-root.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/2/artifact/yetus-general-check/output/patch-compile-root.txt
Max. process+thread count180 (vs. ulimit of 30000)
modulesC: hbase-logging hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 28, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 24sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 35sbranch-2 passed
+1 💚compile1m 54sbranch-2 passed
+1 💚shadedjars4m 39sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 32sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 21sthe patch passed
+1 💚compile1m 51sthe patch passed
+1 💚javac1m 51sthe patch passed
+1 💚shadedjars4m 34spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 31sthe patch passed
_ Other Tests _
-1 ❌unit286m 30sroot in the patch failed.
320m 45s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5185
Optional Testsunit javac javadoc shadedjars compile
unameLinux 687d786f1726 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 0fb5053
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/2/testReport/
Max. process+thread count5259 (vs. ulimit of 30000)
modulesC: hbase-logging hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 28, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 1sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 51sbranch-2 passed
+1 💚compile1m 36sbranch-2 passed
+1 💚shadedjars5m 25sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 40sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall3m 8sthe patch passed
+1 💚compile1m 57sthe patch passed
+1 💚javac1m 57sthe patch passed
+1 💚shadedjars5m 25spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 14sthe patch passed
_ Other Tests _
+1 💚unit399m 49sroot in the patch passed.
433m 20s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5185
Optional Testsunit javac javadoc shadedjars compile
unameLinux 2837e64e168d 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 0fb5053
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/2/testReport/
Max. process+thread count4614 (vs. ulimit of 30000)
modulesC: hbase-logging hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5185/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit b776c12 into apache:branch-2May 1, 2023
@ndimiduk
ndimiduk deleted the 27762-eventtype-pid-mdc-branch-2 branch May 1, 2023 15:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndimiduk@Apache-HBase