Uh oh!
There was an error while loading. Please reload this page.
HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s - #5192
Conversation
Apache-HBase
commented
Apr 19, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 19, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 19, 2023
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
left a comment
There was a problem hiding this comment.
Nice and easy. Can you actually just add a quick test?
bbeaudreault
left a comment
There was a problem hiding this comment.
Nice, thanks! Looks good. Will merge once I have time after pre commit comes back green.
Apache-HBase
commented
Apr 19, 2023
Apache-HBase
commented
Apr 19, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 19, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 19, 2023
🎊 +1 overall
This message was automatically generated. |
rmdmattingly
commented
Apr 20, 2023
Thank you! I think those first failures are because I force pushed a change |
| private static String stringFromMillis(long millis) { | ||
| if (millis >= 1000) { | ||
| return StringUtils.formatTime(millis); |
There was a problem hiding this comment.
Actually, I realize this will continue to be misleading for values greater than 1s. For example 1.9s is almost double what would be shown by formatTime. It matters less for values in the 10s of seconds or higher, but I think it will be very common to have values mostly in the single digit seconds.
We could copy the impl of formatTime here and add ms, or use the existing formatTime and append a ms part, or look for a different "humanize" method/library (as long as it's already a dep)
Apache-HBase
commented
Apr 20, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 20, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 20, 2023
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
commented
Apr 21, 2023
@rmdmattingly can you fix the javac warnings? |
Apache-HBase
commented
Apr 21, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 21, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 21, 2023
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
commented
Apr 22, 2023
i dont have time to handle merging right now, but will try to do it in the next couple days. thanks! |
rmdmattingly
commented
Apr 26, 2023
@bbeaudreault while working on https://issues.apache.org/jira/browse/HBASE-27798 I realized that there's an extra change that I want to make here. These changes would break Though notably, |
| if (i == 1) { | ||
| time += Math.round(Float.parseFloat(m.group(1)) * 1000); // sec | ||
| time += Math.round(Float.parseFloat(m.group(2))); // ms | ||
| } | ||
| if (i == 2) { | ||
| time += Math.round(Float.parseFloat(m.group(1)) * 60 * 1000); // mins | ||
| time += Math.round(Float.parseFloat(m.group(2)) * 1000); // sec | ||
| time += Math.round(Float.parseFloat(m.group(3))); // ms | ||
| } | ||
| if (i == 3) { | ||
| time += Math.round(Float.parseFloat(m.group(1)) * 60 * 60 * 1000); // hrs | ||
| time += Math.round(Float.parseFloat(m.group(2)) * 60 * 1000); // mins | ||
| time += Math.round(Float.parseFloat(m.group(3)) * 1000); // sec | ||
| time += Math.round(Float.parseFloat(m.group(4))); // ms | ||
| } |
There was a problem hiding this comment.
admittedly we could clean this up a bit via some sort of loop, but I think the initial implementation suffered from trying to be a little too clever and this both works and is straightforward imo
| HBaseClassTestRule.forClass(TestRpcThrottlingException.class); | ||
| @Test | ||
| public void itHandlesSecWaitIntervalMessage() { |
There was a problem hiding this comment.
We should also test that it still works for the old format. We need to make sure it doesn't break if someone deploys the updated client side with old servers or vice versa.
Apache-HBase
commented
Apr 26, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 26, 2023
🎊 +1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
Apr 26, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 26, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 26, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 26, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 26, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 26, 2023
🎊 +1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
May 2, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 2, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 2, 2023
🎊 +1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
May 3, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 3, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 3, 2023
🎊 +1 overall
This message was automatically generated. |
…ng between 0-1s (#5192) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…ng between 0-1s (#5192) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…ng between 0-1s (#5192) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…ng between 0-1s (apache#5192) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…ng between 0-1s (apache#5192) (#52) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…ng between 0-1s (apache#5192) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> (cherry picked from commit 05de158) Change-Id: Ic2755a64fa017d56a77e42355266af5b615d0f40
StringUtils#formatTimewill round down millis which can produce misleading error messages on RpcThrottlingExceptions with wait intervals between 0 and 1 second. This PR simply adds support expressing sub-second wait intervals@bbeaudreault