Skip to content

HBASE-27762 Include EventType and ProcedureV2 pid in logging via MDC (addendum) - #5200

Merged
ndimiduk merged 1 commit into
apache:masterfrom
ndimiduk:27762-mdc-logging-adendum
Apr 24, 2023
Merged

HBASE-27762 Include EventType and ProcedureV2 pid in logging via MDC (addendum)#5200
ndimiduk merged 1 commit into
apache:masterfrom
ndimiduk:27762-mdc-logging-adendum

Conversation

@ndimiduk

Copy link
Copy Markdown
Member

Make use of %notEmpty pattern with MDC logging. Will function as expected once we upgrade to Log4J 2.21.0+.

@ndimiduk
ndimiduk requested a review from Apache9April 24, 2023 12:10
@ndimidukndimiduk changed the title HBASE-27762 Include EventType and ProcedureV2 pid in logging via MDC (adendum)HBASE-27762 Include EventType and ProcedureV2 pid in logging via MDC (addendum)Apr 24, 2023
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 22sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚spotless0m 39sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 4sMaven dependency ordering for patch
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚spotless0m 35spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
3m 25s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5200
Optional Testsdupname asflicense spotless
unameLinux 210d345c93c1 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 95f83cb
Max. process+thread count43 (vs. ulimit of 30000)
modulesC: . hbase-logging U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…(addendum)
Make use of `%notEmpty` pattern with MDC logging. Will function as expected once we upgrade to
Log4J 2.21.0+.
@ndimiduk
ndimidukforce-pushed the 27762-mdc-logging-adendum branch from 14e0762 to 5d5c1b6CompareApril 24, 2023 12:24

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried with log4j 2.20.1-SNAPSHOT, at least it worked when running UTs without the proper MDC properties.

+1. Let's keep an eye on the new release for log4j2.

@ndimiduk
ndimiduk merged commit 2216414 into apache:masterApr 24, 2023
@ndimiduk
ndimiduk deleted the 27762-mdc-logging-adendum branch April 24, 2023 15:55
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 50sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall3m 32smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 18sthe patch passed
_ Other Tests _
+1 💚unit266m 53sroot in the patch passed.
281m 9s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5200
Optional Testsunit
unameLinux b6df4b8ef593 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 95f83cb
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/testReport/
Max. process+thread count4601 (vs. ulimit of 30000)
modulesC: hbase-logging . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 24sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 3smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 45sthe patch passed
_ Other Tests _
+1 💚unit399m 43sroot in the patch passed.
412m 51s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5200
Optional Testsunit
unameLinux 40a2c4a07f9d 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 95f83cb
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/testReport/
Max. process+thread count5093 (vs. ulimit of 30000)
modulesC: hbase-logging . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@Apache9