Uh oh!
There was an error while loading. Please reload this page.
HBASE-27793 Make HBCK be able to report unknown servers - #5229
Conversation
validated the patch against real cluster. with the patch unknown servers reported. |
Apache-HBase
commented
May 11, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 11, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 11, 2023
🎊 +1 overall
This message was automatically generated. |
Apache9
commented
May 12, 2023
I think we'd better make the title like The current title seems like it is incorrect to report unknown servers as inconsistencies... |
chrajeshbabu
commented
May 15, 2023
Thanks for review @Apache9. Changed the title as suggested. |
Apache-HBase
commented
May 15, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 15, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 15, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 17, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 17, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 17, 2023
🎊 +1 overall
This message was automatically generated. |
| unknownServers.stream().forEach(serverName -> { | ||
| errors.reportError(ERROR_CODE.UNKNOWN_SERVER, | ||
| "Found unknown server, " | ||
| + " some of the regions hold by this server may not get assigned. " |
There was a problem hiding this comment.
nit: hold -> held.
also we could remove an extra space between "server, some"
Apache9
commented
May 20, 2023
Add better correct the comments which pointed out by @NihalJain above before merging. Thanks. |
Apache-HBase
commented
May 20, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 20, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 20, 2023
🎊 +1 overall
This message was automatically generated. |
Apache9
commented
May 24, 2023
@chrajeshbabu Any updates here? |
chrajeshbabu
commented
May 24, 2023
@Apache9 going to commit it today. Thanks. |
Co-authored-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
Co-authored-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
No description provided.