Uh oh!
There was an error while loading. Please reload this page.
HBASE-22880 Move the DirScanPool out and do not use static field - #527
Merged
Conversation
| // Start log cleaner thread | ||
| int cleanerInterval = conf.getInt("hbase.master.cleaner.interval", 600 * 1000); | ||
| this.logCleaner = new LogCleaner(cleanerInterval, this, conf, | ||
| getMasterFileSystem().getOldLogDir().getFileSystem(conf), getMasterFileSystem().getOldLogDir(), cleanerPool); |
| params.put(MASTER, this); | ||
| this.hfileCleaner = new HFileCleaner(cleanerInterval, this, conf, getMasterFileSystem() | ||
| .getFileSystem(), archiveDir, params); | ||
| .getFileSystem(), archiveDir, cleanerPool, params); |
Contributor
There was a problem hiding this comment.
nit, usually don't start with '.'
| FileSystem fs, Path oldFileDir, String confKey) { | ||
| this(name, sleepPeriod, s, conf, fs, oldFileDir, confKey, null); | ||
| FileSystem fs, Path oldFileDir, String confKey, DirScanPool pool) { | ||
| this(name, sleepPeriod, s, conf, fs, oldFileDir, confKey,pool, null); |
| @Override | ||
| public synchronized void onConfigurationChange(Configuration conf) { | ||
| int newSize = CleanerChore.calculatePoolSize( | ||
| conf.get(CleanerChore.CHORE_POOL_SIZE, CleanerChore.DEFAULT_CHORE_POOL_SIZE)); |
Reidddddd
requested changes
Aug 23, 2019
Reidddddd
left a comment
Contributor
There was a problem hiding this comment.
There're numbers of style problem, please fix. BTW, all the indents in DirScanPool.java is wrong. Indents should be two.
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.hbase.classification.InterfaceAudience; | ||
| import org.apache.hadoop.hbase.conf.ConfigurationObserver; | ||
| import org.slf4j.Logger; |
Contributor
There was a problem hiding this comment.
In branch-1, we use package org.apache.commons.logging
| * Checks if pool can be updated. If so, mark for update later. | ||
| * @param conf configuration | ||
| */ | ||
| @Override public synchronized void onConfigurationChange(Configuration conf) { |
| import java.util.ArrayList; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
| import java.util.*; |
Reidddddd
requested changes
Aug 23, 2019
Reidddddd
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall, left few comments.
Apache-HBase
commented
Aug 23, 2019
💔 -1 overall
This message was automatically generated. |
| /** | ||
| * The thread pool used for scan directories | ||
| */ | ||
| @InterfaceAudience.Private public class DirScanPool implements ConfigurationObserver { |
Contributor
There was a problem hiding this comment.
A new line after @InterfaceAudience.Private
| public static void tearDown() { | ||
| POOL.shutdownNow(); | ||
| } | ||
Contributor
There was a problem hiding this comment.
nit, just keep one empty line.
Reidddddd
approved these changes
Aug 23, 2019
Reidddddd
left a comment
Contributor
There was a problem hiding this comment.
+1, let's wait QA results.
Apache-HBase
commented
Aug 23, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 23, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 23, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 23, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 23, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 23, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 23, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 24, 2019
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-22880