Skip to content

Revert "HBASE-27892 Report memstore on-heap and off-heap size as jmx metrics (#5308)" - #5311

Merged
petersomogyi merged 1 commit into
apache:branch-2.4from
petersomogyi:revert-HBASE-27892
Jun 27, 2023
Merged

Revert "HBASE-27892 Report memstore on-heap and off-heap size as jmx metrics (#5308)"#5311
petersomogyi merged 1 commit into
apache:branch-2.4from
petersomogyi:revert-HBASE-27892

Conversation

@petersomogyi

Copy link
Copy Markdown
Contributor

This reverts commit 7c49300.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 49sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.4 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
-1 ❌mvninstall1m 10sroot in branch-2.4 failed.
-1 ❌compile0m 14shbase-hadoop2-compat in branch-2.4 failed.
-1 ❌compile0m 10shbase-server in branch-2.4 failed.
-0 ⚠️checkstyle0m 4sThe patch fails to run checkstyle in hbase-server
+1 💚spotless0m 54sbranch has no errors when running spotless:check.
-1 ❌spotbugs0m 13shbase-hadoop2-compat in branch-2.4 failed.
-1 ❌spotbugs0m 6shbase-server in branch-2.4 failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 59sthe patch passed
+1 💚compile3m 19sthe patch passed
-0 ⚠️javac0m 19shbase-hadoop2-compat generated 47 new + 0 unchanged - 4 fixed = 47 total (was 4)
-0 ⚠️javac2m 46shbase-server generated 195 new + 0 unchanged - 0 fixed = 195 total (was 0)
+1 💚checkstyle0m 58sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck19m 51sPatch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.5.
+1 💚spotless1m 7spatch has no errors when running spotless:check.
+1 💚spotbugs3m 17sthe patch passed
_ Other Tests _
+1 💚asflicense0m 25sThe patch does not generate ASF License warnings.
39m 4s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5311
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux e6cf1c4b44ef 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / 7c49300
Default JavaEclipse Adoptium-11.0.17+8
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/branch-compile-hbase-hadoop2-compat.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/branch-compile-hbase-server.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/buildtool-branch-checkstyle-hbase-server.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-hadoop2-compat.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-hadoop2-compat.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@petersomogyi
petersomogyi merged commit c0df943 into apache:branch-2.4Jun 27, 2023
@petersomogyi
petersomogyi deleted the revert-HBASE-27892 branch June 27, 2023 15:45
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
-1 ❌mvninstall0m 49sroot in branch-2.4 failed.
-1 ❌compile0m 9shbase-hadoop2-compat in branch-2.4 failed.
-1 ❌compile0m 9shbase-server in branch-2.4 failed.
-1 ❌shadedjars1m 36sbranch has 20 errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 6shbase-server in branch-2.4 failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 6sMaven dependency ordering for patch
+1 💚mvninstall1m 50sthe patch passed
+1 💚compile0m 50sthe patch passed
+1 💚javac0m 8shbase-hadoop-compat in the patch passed.
+1 💚javac0m 10shbase-hadoop2-compat generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
+1 💚javac0m 32shbase-server in the patch passed.
+1 💚shadedjars3m 55spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 20shbase-server generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0)
_ Other Tests _
+1 💚unit0m 23shbase-hadoop-compat in the patch passed.
+1 💚unit0m 20shbase-hadoop2-compat in the patch passed.
+1 💚unit125m 19shbase-server in the patch passed.
141m 8s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5311
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7a1e9e1c8ab1 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / 7c49300
Default JavaTemurin-1.8.0_352-b08
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk8-hadoop2-check/output/branch-compile-hbase-hadoop2-compat.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk8-hadoop2-check/output/branch-compile-hbase-server.txt
shadedjarshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk8-hadoop2-check/output/branch-shadedjars.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk8-hadoop2-check/output/branch-javadoc-hbase-server.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/testReport/
Max. process+thread count3634 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 51sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
-1 ❌mvninstall1m 14sroot in branch-2.4 failed.
-1 ❌compile0m 11shbase-hadoop2-compat in branch-2.4 failed.
-1 ❌compile0m 10shbase-server in branch-2.4 failed.
-1 ❌shadedjars2m 9sbranch has 20 errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 6shbase-server in branch-2.4 failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall3m 0sthe patch passed
+1 💚compile1m 16sthe patch passed
+1 💚javac0m 13shbase-hadoop-compat in the patch passed.
+1 💚javac0m 13shbase-hadoop2-compat generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
+1 💚javac0m 50shbase-server in the patch passed.
+1 💚shadedjars5m 2spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 29shbase-server generated 79 new + 0 unchanged - 0 fixed = 79 total (was 0)
_ Other Tests _
+1 💚unit0m 29shbase-hadoop-compat in the patch passed.
+1 💚unit0m 27shbase-hadoop2-compat in the patch passed.
+1 💚unit142m 47shbase-server in the patch passed.
163m 28s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5311
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c436b3009e97 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / 7c49300
Default JavaEclipse Adoptium-11.0.17+8
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-hbase-hadoop2-compat.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-hbase-server.txt
shadedjarshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/testReport/
Max. process+thread count3859 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
…metrics (apache#5308)" (apache#5311)
This reverts commit 7c49300.
(cherry picked from commit c0df943)
Change-Id: I6e6aafda6ef5781761cf0bb5a3461b3060f6b94b
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@petersomogyi@Apache-HBase@virajjasani