Skip to content

HBASE-27968 add JvmPauseMonitor in hbase-client - #5319

Open
frostruan wants to merge 4 commits into
apache:masterfrom
frostruan:HBASE-27968
Open

HBASE-27968 add JvmPauseMonitor in hbase-client#5319
frostruan wants to merge 4 commits into
apache:masterfrom
frostruan:HBASE-27968

Conversation

@frostruan

@frostruanfrostruan commented Jul 9, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Apache-HBase commented Jul 9, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 11sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 44smaster passed
+1 💚compile2m 57smaster passed
+1 💚checkstyle0m 45smaster passed
+1 💚spotless0m 40sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 59smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 30sthe patch passed
+1 💚compile2m 55sthe patch passed
+1 💚javac2m 55sthe patch passed
-0 ⚠️checkstyle0m 12shbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚checkstyle0m 32shbase-server: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck9m 14sPatch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚spotless0m 39spatch has no errors when running spotless:check.
+1 💚spotbugs2m 15sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
36m 14s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5319
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 445363fe780f 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b2e2abe
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 9, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 2smaster passed
+1 💚compile1m 2smaster passed
+1 💚shadedjars5m 12sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 42sthe patch passed
+1 💚compile1m 3sthe patch passed
+1 💚javac1m 3sthe patch passed
+1 💚shadedjars5m 10spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37sthe patch passed
_ Other Tests _
+1 💚unit1m 32shbase-client in the patch passed.
+1 💚unit212m 18shbase-server in the patch passed.
238m 33s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5319
Optional Testsjavac javadoc unit shadedjars compile
unameLinux de1dde7c5233 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b2e2abe
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/testReport/
Max. process+thread count4709 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 9, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall2m 22smaster passed
+1 💚compile0m 59smaster passed
+1 💚shadedjars4m 31sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 40smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 15sthe patch passed
+1 💚compile0m 58sthe patch passed
+1 💚javac0m 58sthe patch passed
+1 💚shadedjars4m 31spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 39sthe patch passed
_ Other Tests _
+1 💚unit1m 15shbase-client in the patch passed.
+1 💚unit225m 21shbase-server in the patch passed.
249m 28s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5319
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ac88396757ae 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b2e2abe
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/testReport/
Max. process+thread count4200 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil reviewed Jul 10, 2023
View reviewed changes

@wchevreuilwchevreuil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add it for ConnectionImplementation?

Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
private final String metricsScope;
private final Optional<MetricsConnection> metrics;

private JvmPauseMonitor pauseMonitor;

@wchevreuilwchevreuilJul 10, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a singleton, instead? In the case of applications opening or pooling multiple connections, we don't need a separate JvmPauseMonitor per connection, just a single one for the whole application.

@frostruanfrostruanJul 10, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea ! But if so, we may need to consider adding a reference count to pauseMonitor. Only when all connections that refer to it are no longer active, we can stop it . Or we can keep it all the time , even all the connections are closed ?

@wchevreuilwchevreuilJul 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we don't need to stop it when connection is closed, it may be useful to have it running for as long the client application runs.

@frostruan

frostruan commented Jul 10, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review @wchevreuil

Sorry, I didn't find the ConnectionImplementation class in the master branch. If you mean the synchronous connection, then I think the synchronous connection is implemented based on asynchronous connection, so maybe only for asynchronous connection is enough ?

@Apache-HBase

Apache-HBase commented Jul 10, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 24sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 48smaster passed
+1 💚compile4m 17smaster passed
+1 💚checkstyle1m 46smaster passed
+1 💚spotless0m 53sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 12smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 41sthe patch passed
+1 💚compile3m 54sthe patch passed
+1 💚javac3m 54sthe patch passed
-0 ⚠️checkstyle0m 13shbase-client: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚checkstyle0m 32shbase-server: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5)
+1 💚checkstyle0m 29sThe patch passed checkstyle in hbase-thrift
+1 💚checkstyle0m 8sThe patch passed checkstyle in hbase-rest
+1 💚whitespace0m 1sThe patch has no whitespace issues.
+1 💚hadoopcheck9m 26sPatch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚spotless0m 39spatch has no errors when running spotless:check.
-1 ❌spotbugs0m 47shbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚asflicense0m 29sThe patch does not generate ASF License warnings.
43m 31s
ReasonTests
FindBugsmodule:hbase-client
Public static org.apache.hadoop.hbase.util.JvmPauseMonitor.getInstance(Configuration, JvmPauseMonitorSource) may expose internal representation by returning JvmPauseMonitor.INSTANCE At JvmPauseMonitor.java:expose internal representation by returning JvmPauseMonitor.INSTANCE At JvmPauseMonitor.java:[line 86]
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5319
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 17c11f8c1de1 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b2e2abe
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/artifact/yetus-general-check/output/new-spotbugs-hbase-client.html
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 10, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 3smaster passed
+1 💚compile1m 38smaster passed
+1 💚shadedjars5m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 18smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 44sthe patch passed
+1 💚compile1m 38sthe patch passed
+1 💚javac1m 38sthe patch passed
+1 💚shadedjars5m 8spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 16sthe patch passed
_ Other Tests _
+1 💚unit1m 31shbase-client in the patch passed.
+1 💚unit214m 43shbase-server in the patch passed.
+1 💚unit5m 4shbase-thrift in the patch passed.
+1 💚unit3m 48shbase-rest in the patch passed.
252m 25s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5319
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4320aa914a04 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b2e2abe
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/testReport/
Max. process+thread count4676 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 10, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 7sMaven dependency ordering for branch
+1 💚mvninstall2m 20smaster passed
+1 💚compile1m 35smaster passed
+1 💚shadedjars4m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 14smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 15sthe patch passed
+1 💚compile1m 35sthe patch passed
+1 💚javac1m 35sthe patch passed
+1 💚shadedjars4m 33spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 13sthe patch passed
_ Other Tests _
+1 💚unit1m 15shbase-client in the patch passed.
+1 💚unit224m 17shbase-server in the patch passed.
+1 💚unit5m 15shbase-thrift in the patch passed.
+1 💚unit3m 32shbase-rest in the patch passed.
259m 37s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5319
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 10841dec31ff 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b2e2abe
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/testReport/
Max. process+thread count4121 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 11, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 24sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall2m 29smaster passed
+1 💚compile3m 55smaster passed
+1 💚checkstyle1m 23smaster passed
+1 💚spotless0m 39sbranch has no errors when running spotless:check.
+1 💚spotbugs3m 18smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 31sthe patch passed
+1 💚compile3m 56sthe patch passed
+1 💚javac3m 56sthe patch passed
+1 💚checkstyle0m 13sThe patch passed checkstyle in hbase-client
+1 💚checkstyle0m 33shbase-server: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5)
+1 💚checkstyle0m 29sThe patch passed checkstyle in hbase-thrift
+1 💚checkstyle0m 7sThe patch passed checkstyle in hbase-rest
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck9m 20sPatch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚spotless0m 38spatch has no errors when running spotless:check.
-1 ❌spotbugs0m 48shbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚asflicense0m 28sThe patch does not generate ASF License warnings.
41m 19s
ReasonTests
FindBugsmodule:hbase-client
Public static org.apache.hadoop.hbase.util.JvmPauseMonitor.getInstance(Configuration, JvmPauseMonitorSource) may expose internal representation by returning JvmPauseMonitor.INSTANCE At JvmPauseMonitor.java:expose internal representation by returning JvmPauseMonitor.INSTANCE At JvmPauseMonitor.java:[line 86]
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5319
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 4cc3dac8c225 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1d704a7
Default JavaEclipse Adoptium-11.0.17+8
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/artifact/yetus-general-check/output/new-spotbugs-hbase-client.html
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 11, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 41smaster passed
+1 💚compile1m 44smaster passed
+1 💚shadedjars5m 19sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 23smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 35sthe patch passed
+1 💚compile1m 55sthe patch passed
+1 💚javac1m 55sthe patch passed
+1 💚shadedjars5m 8spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 15sthe patch passed
_ Other Tests _
+1 💚unit1m 22shbase-client in the patch passed.
-1 ❌unit245m 5shbase-server in the patch failed.
+1 💚unit5m 13shbase-thrift in the patch passed.
+1 💚unit3m 29shbase-rest in the patch passed.
283m 40s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5319
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4307b81b297e 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1d704a7
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/testReport/
Max. process+thread count4130 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 11, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall3m 16smaster passed
+1 💚compile2m 3smaster passed
+1 💚shadedjars6m 0sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 28smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 29sthe patch passed
+1 💚compile2m 5sthe patch passed
+1 💚javac2m 5sthe patch passed
+1 💚shadedjars6m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 37sthe patch passed
_ Other Tests _
+1 💚unit1m 49shbase-client in the patch passed.
-1 ❌unit253m 2shbase-server in the patch failed.
+1 💚unit5m 33shbase-thrift in the patch passed.
+1 💚unit3m 48shbase-rest in the patch passed.
296m 24s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5319
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b67891896a02 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1d704a7
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/testReport/
Max. process+thread count4681 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 12, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 24sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall2m 35smaster passed
+1 💚compile3m 55smaster passed
+1 💚checkstyle1m 24smaster passed
+1 💚spotless0m 39sbranch has no errors when running spotless:check.
+1 💚spotbugs3m 15smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 29sthe patch passed
+1 💚compile3m 56sthe patch passed
+1 💚javac3m 56sthe patch passed
+1 💚checkstyle0m 13sThe patch passed checkstyle in hbase-client
+1 💚checkstyle0m 33shbase-server: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5)
+1 💚checkstyle0m 29sThe patch passed checkstyle in hbase-thrift
+1 💚checkstyle0m 8sThe patch passed checkstyle in hbase-rest
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck9m 13sPatch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
+1 💚spotbugs4m 41sthe patch passed
_ Other Tests _
+1 💚asflicense0m 28sThe patch does not generate ASF License warnings.
42m 40s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5319
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 6a016f6b7d33 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1d704a7
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count80 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 12, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 27sMaven dependency ordering for branch
+1 💚mvninstall2m 58smaster passed
+1 💚compile1m 37smaster passed
+1 💚shadedjars5m 8sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 16smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 45sthe patch passed
+1 💚compile1m 38sthe patch passed
+1 💚javac1m 38sthe patch passed
+1 💚shadedjars5m 7spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 17sthe patch passed
_ Other Tests _
+1 💚unit1m 32shbase-client in the patch passed.
+1 💚unit239m 49shbase-server in the patch passed.
+1 💚unit6m 6shbase-thrift in the patch passed.
+1 💚unit4m 28shbase-rest in the patch passed.
279m 33s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5319
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3bc1273dae6c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1d704a7
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/testReport/
Max. process+thread count4698 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 12, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 49smaster passed
+1 💚compile1m 58smaster passed
+1 💚shadedjars5m 4sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 27smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 0sthe patch passed
+1 💚compile1m 58sthe patch passed
+1 💚javac1m 58sthe patch passed
+1 💚shadedjars5m 33spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 26sthe patch passed
_ Other Tests _
+1 💚unit1m 32shbase-client in the patch passed.
-1 ❌unit262m 54shbase-server in the patch failed.
+1 💚unit5m 30shbase-thrift in the patch passed.
+1 💚unit5m 13shbase-rest in the patch passed.
304m 28s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5319
Optional Testsjavac javadoc unit shadedjars compile
unameLinux fe8b8247fe0c 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1d704a7
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/testReport/
Max. process+thread count4115 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5319/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 reviewed Jul 13, 2023
View reviewed changes
Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/util/JvmPauseMonitor.java
private JvmPauseMonitorSource metricsSource;
private final JvmPauseMonitorSource metricsSource;

public static synchronized JvmPauseMonitor getInstance(Configuration conf) {

@Apache9Apache9Jul 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change it to singleton? What if we pass different Configuration here?

@frostruanfrostruanJul 13, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two reasons.

@wchevreuil mentioned that our user may open multiple connections, however only one pause monitor is enough for a process. More details please see here

@Apache9Apache9Aug 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we only want one JvmPauseMonitor in process, then we should not bind it to a connection? Just add a utility method to enable jvm pause monitor is enough?

@frostruanfrostruanAug 14, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Let me try to fix this. Thanks Duo ! @Apache9

@wchevreuil

wchevreuil commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

Thanks for the review @wchevreuil

Sorry, I didn't find the ConnectionImplementation class in the master branch. If you mean the synchronous connection, then I think the synchronous connection is implemented based on asynchronous connection, so maybe only for asynchronous connection is enough ?

Yeah, you are right. My bad, I was looking at older branches. LGTM, assuming the UT failures are unrelated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 left review comments
@wchevreuilwchevreuilwchevreuil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@frostruan@Apache-HBase@wchevreuil@Apache9