Skip to content

HBASE-27966 HBase Master/RS JVM metrics populated incorrectly - #5364

Merged
NihalJain merged 1 commit into
apache:branch-2from
NihalJain:HBASE-27966_branch-2
Aug 29, 2023
Merged

HBASE-27966 HBase Master/RS JVM metrics populated incorrectly#5364
NihalJain merged 1 commit into
apache:branch-2from
NihalJain:HBASE-27966_branch-2

Conversation

@NihalJain

Copy link
Copy Markdown
Contributor

Backports #5323

@NihalJainNihalJain added the backport This PR is a back port of some issue or issues already committed to master label Aug 21, 2023
@NihalJain

NihalJain commented Aug 21, 2023

Copy link
Copy Markdown
ContributorAuthor

When trying to cherry-pick from master and apply patch locally in branch-2 and build: there was a compilation error as HBaseTestingUtil in master, does not exist and is called HBaseTestingUtility in branch-2.

Just curious, what is the practice followed by other committers for backports, when we have a reference of this class HBaseTestingUtil in a PR raised on master.

  • Do we raise a backport JIRA and merge, the way I have done here?
  • Or, Do we cherry-pick commit from master, resolve the issue locally and push to branch-2 directly?

CC: @Apache9, @bbeaudreault, @Reidddddd

@bbeaudreault

Copy link
Copy Markdown
Contributor

For this particular issue, I usually just edit locally after cherry picking, and commit with the fix applied. It's pretty annoying, I wonder if we can come up with a better way to make this a non-issue

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall2m 48sbranch-2 passed
+1 💚compile2m 23sbranch-2 passed
+1 💚checkstyle0m 36sbranch-2 passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 28sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 36sthe patch passed
+1 💚compile2m 23sthe patch passed
+1 💚javac2m 23sthe patch passed
+1 💚checkstyle0m 35sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 8sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.
+1 💚spotless0m 41spatch has no errors when running spotless:check.
+1 💚spotbugs1m 34sthe patch passed
_ Other Tests _
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
31m 29s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5364
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 7a428ba94043 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / fbd258f
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 31sbranch-2 passed
+1 💚compile0m 35sbranch-2 passed
+1 💚shadedjars4m 42sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 9sthe patch passed
+1 💚compile0m 37sthe patch passed
+1 💚javac0m 37sthe patch passed
+1 💚shadedjars4m 44spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 21sthe patch passed
_ Other Tests _
+1 💚unit210m 55shbase-server in the patch passed.
231m 49s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5364
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f6b0ee8b75ed 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / fbd258f
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/testReport/
Max. process+thread count4545 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 51sbranch-2 passed
+1 💚compile0m 48sbranch-2 passed
+1 💚shadedjars4m 49sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 28sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 38sthe patch passed
+1 💚compile0m 47sthe patch passed
+1 💚javac0m 47sthe patch passed
+1 💚shadedjars4m 49spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 26sthe patch passed
_ Other Tests _
+1 💚unit216m 49shbase-server in the patch passed.
239m 35s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5364
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 01f551e5abb6 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / fbd258f
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/testReport/
Max. process+thread count4477 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5364/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain

Copy link
Copy Markdown
ContributorAuthor

For this particular issue, I usually just edit locally after cherry picking, and commit with the fix applied.

Thank you @bbeaudreault for clarifying.

@NihalJain

Copy link
Copy Markdown
ContributorAuthor

Code has already been reviewed as part of #5323. Will merge this tonight, if no concerns.

@NihalJain
NihalJain merged commit 2713a3c into apache:branch-2Aug 29, 2023
NihalJain added a commit that referenced this pull request Aug 29, 2023
…#5364)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
(cherry picked from commit 2713a3c)
bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Dec 13, 2023
…ncorrectly (apache#5323) (apache#5364)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@NihalJain@bbeaudreault@Apache-HBase