HBASE-27966 HBase Master/RS JVM metrics populated incorrectly by NihalJain · Pull Request #5323 · apache/hbase

NihalJain · 2023-07-14T13:56:13Z

No description provided.

Apache-HBase · 2023-07-14T14:31:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 51s	master passed
+1 💚	compile	2m 24s	master passed
+1 💚	checkstyle	0m 31s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	compile	2m 22s	the patch passed
+1 💚	javac	2m 22s	the patch passed
+1 💚	checkstyle	0m 32s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 15s	Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 28s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		31m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5323
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux feb1402b05f0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3353381`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-07-14T18:09:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 35s	master passed
+1 💚	compile	0m 36s	master passed
+1 💚	shadedjars	4m 59s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 2s	the patch passed
+1 💚	compile	0m 44s	the patch passed
+1 💚	javac	0m 44s	the patch passed
+1 💚	shadedjars	5m 35s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	226m 19s	hbase-server in the patch passed.
		249m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5323
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 716bd5019fee 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3353381`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/1/testReport/
Max. process+thread count	4601 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-07-14T18:34:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 32s	master passed
+1 💚	compile	1m 4s	master passed
+1 💚	shadedjars	5m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 31s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 52s	the patch passed
+1 💚	compile	0m 57s	the patch passed
+1 💚	javac	0m 57s	the patch passed
+1 💚	shadedjars	5m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	the patch passed
		_ Other Tests _
+1 💚	unit	248m 11s	hbase-server in the patch passed.
		273m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5323
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9fd9aaed9c03 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3353381`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/1/testReport/
Max. process+thread count	4207 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2023-07-15T18:44:31Z

Hi @apurtell could you please help review this?

bbeaudreault

One comment ~~, but how does this fix the issue~~?

Edit: I just saw the description in the jira. It might warrant a small comment in the javadoc for getInstance that we want to lazy initialize so that correct process name is in place?

bbeaudreault · 2023-07-19T07:25:41Z

 @InterfaceAudience.Private
 public class MetricsIO {

+ private static MetricsIO instance;


This probably should be volatile. Below in your new method, you should do synchronization if it's null so it only gets instantiated once. Example: https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClientConfigHelper.java#L87

This probably should be volatile. Below in your new method, you should do synchronization if it's null so it only gets instantiated once. Example: https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClientConfigHelper.java#L87
Update the logic as per suggestion.

NihalJain · 2023-07-21T07:11:13Z

Edit: I just saw the description in the jira. It might warrant a small comment in the javadoc for getInstance that we want to lazy initialize so that correct process name is in place?

Done, please review.

Apache-HBase · 2023-07-21T07:43:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 2s	master passed
+1 💚	compile	2m 36s	master passed
+1 💚	checkstyle	0m 36s	master passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 33s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 40s	the patch passed
+1 💚	compile	2m 38s	the patch passed
+1 💚	javac	2m 38s	the patch passed
+1 💚	checkstyle	0m 33s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 47s	Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 35s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		32m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5323
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux acc1def37420 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c92e6f`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-07-21T11:10:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 36s	master passed
+1 💚	compile	0m 37s	master passed
+1 💚	shadedjars	4m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 18s	the patch passed
+1 💚	compile	0m 37s	the patch passed
+1 💚	javac	0m 37s	the patch passed
+1 💚	shadedjars	4m 56s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	218m 45s	hbase-server in the patch passed.
		239m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5323
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 526ca1a7894d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c92e6f`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/2/testReport/
Max. process+thread count	4463 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-07-21T11:24:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 36s	master passed
+1 💚	compile	0m 46s	master passed
+1 💚	shadedjars	4m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 42s	the patch passed
+1 💚	compile	0m 46s	the patch passed
+1 💚	javac	0m 46s	the patch passed
+1 💚	shadedjars	4m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	232m 42s	hbase-server in the patch passed.
		254m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5323
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 07a2bb4744b4 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c92e6f`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/2/testReport/
Max. process+thread count	4210 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Reidddddd · 2023-08-02T07:07:11Z

 private final MetricsIOWrapper wrapper;

- public MetricsIO(MetricsIOWrapper wrapper) {
+ // visible for testing only


could use the annotation @VisibleForTesting?

I initially thought to add same but checked code and found this is banned now. See
hbase/pom.xml
Line 2535 in f6c5dbe
<bannedImport>org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting</bannedImport>
So added a comment "visible for testing only" as done at other places in code base. See https://github.com/search?q=repo%3Aapache%2Fhbase+%22visible+for+testing%22&type=code

Could use RestrictedApi to restrict the place where we can call this method. It will cause a compilation error if called from other places in the error prone check.

Done with commit 0a7b561 and updated PR.

Reidddddd · 2023-08-02T07:14:40Z


- public MetricsIO(MetricsIOWrapper wrapper) {
+ // visible for testing only
+ MetricsIO(MetricsIOWrapper wrapper) {


weird here, here is implementing a singleton, but there is still a public constructor...
is it used somewhere? if not, could we just delete it.

Yes it is being used in a test case, hence had to keep it and changed scope from public

Reidddddd

lgtm

NihalJain · 2023-08-10T15:40:26Z

Thank you for the reviews @bbeaudreault and @Reidddddd.
Also @bbeaudreault please let me know if the revised PR is as per your review comment and can be merged.

bbeaudreault

Sorry this fell off my radar. LGTM!

Apache9 · 2023-08-13T10:44:43Z

After checking the code, I think we should change the implementation for DefaultMetricsSystemInitializer?

It should be called when we create HMaster or HRegionServer, not in BaseSourceImpl?

Have you read the commit history about why we just add a call in the Constructor of BaseSourceImpl? It looks strange to initialize JvmMetrics with a metrics name instead of the actual process name.

Thanks.

NihalJain · 2023-08-16T11:02:14Z

After checking the code, I think we should change the implementation for DefaultMetricsSystemInitializer?
It should be called when we create HMaster or HRegionServer, not in BaseSourceImpl?
Have you read the commit history about why we just add a call in the Constructor of BaseSourceImpl? It looks strange to initialize JvmMetrics with a metrics name instead of the actual process name.
Thanks.

Hi @Apache9 thanks for your input. I had put up an RCA at https://issues.apache.org/jira/browse/HBASE-27966?focusedCommentId=17741087&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17741087.

One of the proposed solution was to do following (let's call this approach 1) :

Explicitly initialize JvmMetrics when Master/RS starts up as one of the first step.

But based on discussion went ahead with a simpler fix, i.e. approach 2, which was as follow:

Use lazy initialization to delay static field initialization so that HFile.checkHFileVersion(this.conf); does not invoke the metric io initialization

and hence I did not try to see the details of how to fix using approach 1.

Could we work on approach 1 with another ticket after taking this as a stop-gap? Or do you want me to switch to approach 1 and revert the code changes done here? Please let me know how we should move ahead.

I will work on following review comment:

Could use RestrictedApi to restrict the place where we can call this method. It will cause a compilation error if called from other places in the error prone check.

based on what we decide here

Apache9 · 2023-08-16T11:13:57Z

I think we should finally go with approach 1 but I'm also OK for having a quick fix. So if you have already tested the patch on your deployment and it does work, I'm OK with merging the current PR first. But let's open an issue for approach 1 first so we will not forget to do it.

Thanks.

NihalJain · 2023-08-16T11:27:33Z

@Apache9 Thanks for the quick response.

So if you have already tested the patch on your deployment and it does work, I'm OK with merging the current PR first.

Yes this has been tested E2E in our deployment along with the dependent component i.e. ambari.

But let's open an issue for approach 1 first so we will not forget to do it.

Sure let me create a JIRA for the same for follow up work.

Also will update this PR with the review comments' fix as another commit here.

NihalJain · 2023-08-16T11:32:53Z

Created https://issues.apache.org/jira/browse/HBASE-28026 for follow up work

NihalJain · 2023-08-16T12:20:59Z

Addressed review comment and updated PR with commit 0a7b561

Apache-HBase · 2023-08-16T13:02:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 38s	master passed
+1 💚	compile	2m 47s	master passed
+1 💚	checkstyle	0m 43s	master passed
+1 💚	spotless	0m 54s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 42s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 8s	the patch passed
-1 ❌	compile	1m 11s	hbase-server in the patch failed.
-0 ⚠️	javac	1m 11s	hbase-server in the patch failed.
+1 💚	checkstyle	0m 38s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 51s	Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚	spotless	0m 54s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 3s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		37m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5323
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux f36e49a33c26 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2fb2ae1`
Default Java	Eclipse Adoptium-11.0.17+8
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…hadoop.hbase.io.MetricsIO#MetricsIO(org.apache.hadoop.hbase.io.MetricsIOWrapper)

NihalJain · 2023-08-16T14:13:15Z

Over-wrote last commit to also take care of adding the file MetricIO.java itself into list of restricted paths, which was missed earlier. See diff. (My bad, used @RestrictedApi for the 1st time..)

Apache-HBase · 2023-08-16T16:36:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 17s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 29s	master passed
+1 💚	compile	0m 41s	master passed
+1 💚	shadedjars	4m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	0m 40s	the patch passed
+1 💚	javac	0m 40s	the patch passed
+1 💚	shadedjars	4m 30s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	226m 50s	hbase-server in the patch passed.
		250m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5323
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cdf114dc6148 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2fb2ae1`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/3/testReport/
Max. process+thread count	4279 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-08-16T17:17:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 11s	master passed
+1 💚	compile	0m 55s	master passed
+1 💚	shadedjars	5m 30s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 32s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 17s	the patch passed
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
+1 💚	shadedjars	5m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 31s	the patch passed
		_ Other Tests _
+1 💚	unit	266m 19s	hbase-server in the patch passed.
		291m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5323
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 73bef42f24dd 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2fb2ae1`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/3/testReport/
Max. process+thread count	4347 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-08-16T17:49:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 12s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 50s	master passed
+1 💚	compile	2m 28s	master passed
+1 💚	checkstyle	0m 37s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 29s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	2m 24s	the patch passed
+1 💚	javac	2m 24s	the patch passed
+1 💚	checkstyle	0m 33s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 53s	Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 37s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		30m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5323
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 32fe9bd03bd2 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2fb2ae1`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-08-16T21:24:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 20s	master passed
+1 💚	compile	0m 40s	master passed
+1 💚	shadedjars	4m 30s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 15s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	shadedjars	4m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	225m 56s	hbase-server in the patch passed.
		246m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5323
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4d17e48d61da 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2fb2ae1`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/4/testReport/
Max. process+thread count	4323 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-08-16T21:27:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 24s	master passed
+1 💚	compile	0m 58s	master passed
+1 💚	shadedjars	5m 28s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 33s	the patch passed
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
+1 💚	shadedjars	5m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	223m 23s	hbase-server in the patch passed.
		249m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5323
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux dc89d12f5bec 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2fb2ae1`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/4/testReport/
Max. process+thread count	4997 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5323/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…#5323)

…#5364) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Reid Chan <reidchan@apache.org>

…#5364) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Reid Chan <reidchan@apache.org> (cherry picked from commit 2713a3c)

…ncorrectly (apache#5323) (apache#5364) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Reid Chan <reidchan@apache.org>

Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Reid Chan <reidchan@apache.org>

HBASE-27966 HBase Master/RS JVM metrics populated incorrectly
4a0b03b

NihalJain requested a review from apurtell July 15, 2023 17:26

bbeaudreault reviewed Jul 19, 2023
View reviewed changes

Change to lazy initialization with double check locking
f4ec899

NihalJain requested a review from bbeaudreault July 21, 2023 07:13

Reidddddd reviewed Aug 2, 2023
View reviewed changes

Reidddddd approved these changes Aug 2, 2023
View reviewed changes

bbeaudreault approved these changes Aug 10, 2023
View reviewed changes

Apache9 approved these changes Aug 16, 2023
View reviewed changes

Use RestrictedApi to restrict the place where we can call org.apache.…
fa5446d
…hadoop.hbase.io.MetricsIO#MetricsIO(org.apache.hadoop.hbase.io.MetricsIOWrapper)

NihalJain force-pushed the HBASE-27966 branch from 0a7b561 to fa5446dCompare August 16, 2023 13:59

NihalJain merged commit d309e99 into apache:masterAug 21, 2023

NihalJain added a commit to NihalJain/hbase that referenced this pull request Aug 21, 2023
HBASE-27966 HBase Master/RS JVM metrics populated incorrectly (apache…
57a33b1
…#5323)

NihalJain mentioned this pull request Aug 21, 2023
HBASE-27966 HBase Master/RS JVM metrics populated incorrectly #5364
Merged

Uh oh!

Conversation

NihalJain commented Jul 14, 2023

Uh oh!

Apache-HBase commented Jul 14, 2023

Uh oh!

Apache-HBase commented Jul 14, 2023

Uh oh!

Apache-HBase commented Jul 14, 2023

Uh oh!

NihalJain commented Jul 15, 2023

Uh oh!

bbeaudreault left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bbeaudreaultJul 19, 2023

Choose a reason for hiding this comment

Uh oh!

NihalJainJul 21, 2023

Choose a reason for hiding this comment

Uh oh!

NihalJain commented Jul 21, 2023

Uh oh!

Apache-HBase commented Jul 21, 2023

Uh oh!

Apache-HBase commented Jul 21, 2023

Uh oh!

Apache-HBase commented Jul 21, 2023

Uh oh!

ReiddddddAug 2, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NihalJainAug 2, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache9Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

NihalJainAug 16, 2023

Choose a reason for hiding this comment

Uh oh!

ReiddddddAug 2, 2023

Choose a reason for hiding this comment

Uh oh!

NihalJainAug 2, 2023

Choose a reason for hiding this comment

Uh oh!

Reidddddd left a comment

Choose a reason for hiding this comment

Uh oh!

NihalJain commented Aug 10, 2023

Uh oh!

bbeaudreault left a comment

Choose a reason for hiding this comment

Uh oh!

Apache9 commented Aug 13, 2023

Uh oh!

NihalJain commented Aug 16, 2023

Uh oh!

Apache9 commented Aug 16, 2023

Uh oh!

NihalJain commented Aug 16, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NihalJain commented Aug 16, 2023

Uh oh!

NihalJain commented Aug 16, 2023

Uh oh!

Apache-HBase commented Aug 16, 2023

Uh oh!

NihalJain commented Aug 16, 2023

Uh oh!

Apache-HBase commented Aug 16, 2023

Uh oh!

Apache-HBase commented Aug 16, 2023

Uh oh!

Apache-HBase commented Aug 16, 2023

bbeaudreault left a comment •
edited
Loading

ReiddddddAug 2, 2023•
edited
Loading

NihalJainAug 2, 2023•
edited
Loading

NihalJain commented Aug 16, 2023•
edited
Loading