Uh oh!
There was an error while loading. Please reload this page.
HBASE-28105 NPE in QuotaCache if Table is dropped from cluster - #5426
Conversation
Apache-HBase
commented
Sep 21, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 21, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 21, 2023
💔 -1 overall
This message was automatically generated. |
bbeaudreault
left a comment
There was a problem hiding this comment.
I think we should probably remove the tableName from the tableMachineQuotaFactors in this case. Nothing else seems to cause entries to be removed from that map, and it may have outdated factors that mess with the user quotas.
Uh oh!
There was an error while loading. Please reload this page.
Are you referring to If so, I think the outdated tableName might be removed the next time when the cache gets updated in this function. Not sure whether we still need to remove it explicitly in |
bbeaudreault
commented
Sep 22, 2023
No, this method is populating a map called |
hanke580
commented
Sep 22, 2023
Make sense. I have updated the commit to remove the dropped tableName from tableMachineQuotaFactors. Is there any other place you suggest me to modify? |
Apache-HBase
commented
Sep 22, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 23, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 23, 2023
💔 -1 overall
This message was automatically generated. |
bbeaudreault
left a comment
There was a problem hiding this comment.
@hanke580 It looks good but can you run mvn spotless:apply to fix formatting?
@bbeaudreault Certainly! I have fixed the format problem. |
Apache-HBase
commented
Sep 23, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 23, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 23, 2023
💔 -1 overall
This message was automatically generated. |
bbeaudreault
left a comment
There was a problem hiding this comment.
Unit test failure is unrelated. LGTM, thanks for the contribution!
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…rom cluster (apache#5426) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…e#5426) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
https://issues.apache.org/jira/browse/HBASE-28105
Avoid NPE by making sure the table exists in the latest metadata.