Skip to content

HBASE-22231 Removed unused and '*' import - #180

Merged
HorizonNet merged 1 commit into
apache:branch-2.0from
ultratendency:HBASE-22231-branch-2.0
Apr 24, 2019
Merged

HBASE-22231 Removed unused and '*' import#180
HorizonNet merged 1 commit into
apache:branch-2.0from
ultratendency:HBASE-22231-branch-2.0

Conversation

@HorizonNet

Copy link
Copy Markdown
Contributor

Targeted for branch-2.0.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec38Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 81 new or modified test files.
_ branch-2.0 Compile Tests _
0mvndep10Maven dependency ordering for branch
+1mvninstall227branch-2.0 passed
+1compile278branch-2.0 passed
+1checkstyle292branch-2.0 passed
+1shadedjars320branch has no errors when building our shaded downstream artifacts.
+1findbugs508branch-2.0 passed
+1javadoc198branch-2.0 passed
_ Patch Compile Tests _
0mvndep17Maven dependency ordering for patch
+1mvninstall226the patch passed
+1compile274the patch passed
+1javac274the patch passed
+1checkstyle28hbase-common: The patch generated 0 new + 11 unchanged - 3 fixed = 11 total (was 14)
-1checkstyle43hbase-client: The patch generated 2 new + 209 unchanged - 19 fixed = 211 total (was 228)
+1checkstyle15hbase-zookeeper: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1checkstyle15hbase-replication: The patch generated 0 new + 9 unchanged - 1 fixed = 9 total (was 10)
+1checkstyle18hbase-procedure: The patch generated 0 new + 1 unchanged - 7 fixed = 1 total (was 8)
-1checkstyle94hbase-server: The patch generated 4 new + 500 unchanged - 124 fixed = 504 total (was 624)
+1checkstyle25hbase-mapreduce: The patch generated 0 new + 97 unchanged - 12 fixed = 97 total (was 109)
-1checkstyle28hbase-it: The patch generated 1 new + 90 unchanged - 7 fixed = 91 total (was 97)
+1checkstyle21hbase-rest: The patch generated 0 new + 15 unchanged - 3 fixed = 15 total (was 18)
+1whitespace0The patch has no whitespace issues.
+1shadedjars317patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck678Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
+1findbugs591the patch passed
+1javadoc200the patch passed
_ Other Tests _
+1unit186hbase-common in the patch passed.
+1unit215hbase-client in the patch passed.
+1unit57hbase-zookeeper in the patch passed.
+1unit20hbase-replication in the patch passed.
+1unit237hbase-procedure in the patch passed.
-1unit12147hbase-server in the patch failed.
+1unit1397hbase-mapreduce in the patch passed.
+1unit86hbase-it in the patch passed.
+1unit485hbase-rest in the patch passed.
+1asflicense278The patch does not generate ASF License warnings.
19810
ReasonTests
Failed junit testshadoop.hbase.util.TestFromClientSide3WoUnsafe
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/1/artifact/out/Dockerfile
GITHUB PR#180
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux ba2abe091073 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionbranch-2.0 / 49a27e1
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.0-RC3
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/1/artifact/out/diff-checkstyle-hbase-client.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/1/artifact/out/diff-checkstyle-hbase-server.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/1/artifact/out/diff-checkstyle-hbase-it.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/1/testReport/
Max. process+thread count5182 (vs. ulimit of 10000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-procedure hbase-server hbase-mapreduce hbase-it hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec51Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 81 new or modified test files.
_ branch-2.0 Compile Tests _
0mvndep8Maven dependency ordering for branch
+1mvninstall170branch-2.0 passed
+1compile207branch-2.0 passed
+1checkstyle215branch-2.0 passed
+1shadedjars247branch has no errors when building our shaded downstream artifacts.
+1findbugs395branch-2.0 passed
+1javadoc164branch-2.0 passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall165the patch passed
+1compile226the patch passed
+1javac226the patch passed
+1checkstyle23hbase-common: The patch generated 0 new + 11 unchanged - 3 fixed = 11 total (was 14)
+1checkstyle33hbase-client: The patch generated 0 new + 208 unchanged - 20 fixed = 208 total (was 228)
+1checkstyle14hbase-zookeeper: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1checkstyle11hbase-replication: The patch generated 0 new + 9 unchanged - 1 fixed = 9 total (was 10)
+1checkstyle15hbase-procedure: The patch generated 0 new + 1 unchanged - 7 fixed = 1 total (was 8)
+1checkstyle72hbase-server: The patch generated 0 new + 497 unchanged - 127 fixed = 497 total (was 624)
+1checkstyle18hbase-mapreduce: The patch generated 0 new + 97 unchanged - 12 fixed = 97 total (was 109)
+1checkstyle24hbase-it: The patch generated 0 new + 88 unchanged - 9 fixed = 88 total (was 97)
+1checkstyle16hbase-rest: The patch generated 0 new + 15 unchanged - 3 fixed = 15 total (was 18)
+1whitespace0The patch has no whitespace issues.
+1shadedjars245patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck509Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
+1findbugs456the patch passed
+1javadoc157the patch passed
_ Other Tests _
+1unit154hbase-common in the patch passed.
+1unit186hbase-client in the patch passed.
+1unit45hbase-zookeeper in the patch passed.
+1unit15hbase-replication in the patch passed.
+1unit205hbase-procedure in the patch passed.
-1unit12104hbase-server in the patch failed.
+1unit1239hbase-mapreduce in the patch passed.
+1unit72hbase-it in the patch passed.
+1unit396hbase-rest in the patch passed.
+1asflicense230The patch does not generate ASF License warnings.
18308
ReasonTests
Failed junit testshadoop.hbase.client.TestAdmin1
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/2/artifact/out/Dockerfile
GITHUB PR#180
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 445276d772d3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionbranch-2.0 / 49a27e1
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.0-RC3
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/2/testReport/
Max. process+thread count5346 (vs. ulimit of 10000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-procedure hbase-server hbase-mapreduce hbase-it hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving conditional on build test passing. These cleanup is great.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec57Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 81 new or modified test files.
_ branch-2.0 Compile Tests _
0mvndep15Maven dependency ordering for branch
+1mvninstall236branch-2.0 passed
+1compile282branch-2.0 passed
+1checkstyle292branch-2.0 passed
+1shadedjars322branch has no errors when building our shaded downstream artifacts.
+1findbugs514branch-2.0 passed
+1javadoc199branch-2.0 passed
_ Patch Compile Tests _
0mvndep17Maven dependency ordering for patch
+1mvninstall215the patch passed
+1compile275the patch passed
+1javac275the patch passed
+1checkstyle28hbase-common: The patch generated 0 new + 11 unchanged - 3 fixed = 11 total (was 14)
+1checkstyle44hbase-client: The patch generated 0 new + 208 unchanged - 20 fixed = 208 total (was 228)
+1checkstyle16hbase-zookeeper: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1checkstyle15hbase-replication: The patch generated 0 new + 9 unchanged - 1 fixed = 9 total (was 10)
+1checkstyle19hbase-procedure: The patch generated 0 new + 1 unchanged - 7 fixed = 1 total (was 8)
+1checkstyle95hbase-server: The patch generated 0 new + 497 unchanged - 127 fixed = 497 total (was 624)
+1checkstyle25hbase-mapreduce: The patch generated 0 new + 97 unchanged - 12 fixed = 97 total (was 109)
+1checkstyle27hbase-it: The patch generated 0 new + 88 unchanged - 9 fixed = 88 total (was 97)
+1checkstyle21hbase-rest: The patch generated 0 new + 15 unchanged - 3 fixed = 15 total (was 18)
+1whitespace0The patch has no whitespace issues.
+1shadedjars316patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck690Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
+1findbugs597the patch passed
+1javadoc199the patch passed
_ Other Tests _
+1unit188hbase-common in the patch passed.
+1unit225hbase-client in the patch passed.
+1unit55hbase-zookeeper in the patch passed.
+1unit19hbase-replication in the patch passed.
+1unit236hbase-procedure in the patch passed.
+1unit11324hbase-server in the patch passed.
+1unit1379hbase-mapreduce in the patch passed.
+1unit86hbase-it in the patch passed.
+1unit479hbase-rest in the patch passed.
+1asflicense285The patch does not generate ASF License warnings.
19026
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/4/artifact/out/Dockerfile
GITHUB PR#180
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 5b031bb5c861 4.4.0-145-generic #171-Ubuntu SMP Tue Mar 26 12:43:40 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionbranch-2.0 / c3f9264
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.0-RC3
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/4/testReport/
Max. process+thread count4878 (vs. ulimit of 10000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-procedure hbase-server hbase-mapreduce hbase-it hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/4/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet
HorizonNet merged commit ecb0fd0 into apache:branch-2.0Apr 24, 2019
@HorizonNet
HorizonNet deleted the HBASE-22231-branch-2.0 branch April 24, 2019 16:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@HorizonNet@Apache-HBase@saintstack